File: omni-area-check-for-n_messages-greater-zero-to-avoid.patch

package info (click to toggle)
endeavour 43.0-5
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 4,384 kB
  • sloc: ansic: 23,899; xml: 134; makefile: 6
file content (25 lines) | stat: -rw-r--r-- 916 bytes parent folder | download 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
 
From: Philipp Unger <philipp.unger.1988@gmail.com>
Date: Mon, 25 Nov 2024 22:27:45 +0100
Subject: [PATCH] omni-area: check for n_messages greater zero to avoid divide
 by zero

fixes #496

Forwarded: https://gitlab.gnome.org/World/Endeavour/-/issues/496
---
 src/gui/gtd-omni-area.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gui/gtd-omni-area.c b/src/gui/gtd-omni-area.c
index 828f36c..007061b 100644
--- a/src/gui/gtd-omni-area.c
+++ b/src/gui/gtd-omni-area.c
@@ -78,7 +78,7 @@ switch_message_cb (gpointer user_data)
   n_messages = g_queue_get_length (self->messages);
   gtk_stack_set_visible_child_name (self->main_stack, n_messages > 0 ? "messages" : "placeholder");
 
-  next_message_index = (self->current + 1) % n_messages;
+  next_message_index = n_messages > 0 ? (self->current + 1) % n_messages : 0;
   show_message (self, next_message_index);
 
   return G_SOURCE_CONTINUE;