1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
|
Using the same expressions as both arguments to the following binary expressions
is usually a mistake:
* `a && a`, `a || a`, `a & a`, or `a | a` is equivalent to `a`
* `a <= a`, `a >= a`, or `a == a` is always `true`
* `a < a`, `a > a`, `a != a`, or `a ^ a` is always `false`
* `a / a` is always `1`
* `a % a` or `a - a` is always `0`
If the expression has side-effects, consider refactoring one of the expressions
with side effects into a local. For example, prefer this:
```java
// check twice, just to be sure
boolean isTrue = foo.isTrue();
if (isTrue && foo.isTrue()) {
// ...
}
```
to this:
```java
if (foo.isTrue() && foo.isTrue()) {
// ...
}
```
|
