File: LeakingForkedAndroidBundle.md

package info (click to toggle)
error-prone-java 2.18.0-1
  • links: PTS, VCS
  • area: main
  • in suites: bookworm, forky, sid, trixie
  • size: 23,204 kB
  • sloc: java: 222,992; xml: 1,319; sh: 25; makefile: 7
file content (30 lines) | stat: -rw-r--r-- 905 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
> When passing a mutable instance into a method which makes a deep copy of the
> instance, it results in discrepancies between the forked instances. It is
> prone to errors if one expects the state change on the original instance to be
> reflected on the method with its forked instance.

```java
Location location = new Location("gps");
Bundle bundle = new Bundle();
bundle.putFloat("someFloat", 12.3f);
location.setExtras(bundle);

// Now add more things to the bundle, but it won't modify the internal
// representation stored by Location.
bundle.putInt("someInt", 7);
```

```java
private static Bundle getLocationExtras(Location location) {
  Bundle bundle = location.getExtras();
  if (bundle != null) {
    return bundle;
  }
  bundle = new Bundle();
  location.setExtras(bundle);

  // Now leaks the bundle which is subject to modification in its
  // method of invocation.
  return bundle;
}
```