File: BinderIdentityRestoredDangerously.md

package info (click to toggle)
error-prone-java 2.18.0-1
  • links: PTS, VCS
  • area: main
  • in suites: bookworm, forky, sid, trixie
  • size: 23,204 kB
  • sloc: java: 222,992; xml: 1,319; sh: 25; makefile: 7
file content (13 lines) | stat: -rw-r--r-- 662 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
Binder is Android's inter-process communication mechanism. Each call to
`Binder.clearCallingIdentity()` should be followed by
`Binder.restoreCallingIdentity()` in a finally block. Otherwise the wrong Binder
identity may be used by subsequent code.

For example: `java long token = Binder.clearCallingIdentity(); // Issue a Binder
call (may throw an Exception). someBinderInterface.makeCall();
Binder.restoreCallingIdentity(token);`

The above code should be rewritten as: `java long token =
Binder.clearCallingIdentity(); try { // Issue a Binder call (may throw an
Exception). someBinderInterface.makeCall(); } finally {
Binder.restoreCallingIdentity(token); }`