File: 02_data_book_respond_get_changes_missing_array_add.patch

package info (click to toggle)
evolution-data-server 2.30.3-2%2Bsqueeze1
  • links: PTS, VCS
  • area: main
  • in suites: squeeze
  • size: 45,704 kB
  • ctags: 26,968
  • sloc: ansic: 223,692; sh: 10,413; makefile: 2,646; xml: 386; perl: 204; python: 30
file content (35 lines) | stat: -rw-r--r-- 1,202 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
From 15ad5dc232f493afef212a8217e82eedd0fe6e64 Mon Sep 17 00:00:00 2001
From: Chris Frey <cdfrey@foursquare.net>
Date: Thu, 22 Sep 2011 23:07:29 -0400
Subject: [PATCH] Fixed libedata-book's e_data_book_respond_get_changes(): missing array add

When building the get_changes DBUS response, the code forgot to add the
values to the response array, resulting in get_changes calls that never
returned any data.

This fixes Ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/658459

and Debian bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641898
---
 addressbook/libedata-book/e-data-book.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/addressbook/libedata-book/e-data-book.c b/addressbook/libedata-book/e-data-book.c
index 7794e8b..d7a2a80 100644
--- a/addressbook/libedata-book/e-data-book.c
+++ b/addressbook/libedata-book/e-data-book.c
@@ -620,6 +620,10 @@ e_data_book_respond_get_changes (EDataBook *book, guint32 opid, EDataBookStatus
 			/* Now change->vcard is owned by the GValue */
 
 			g_free (change);
+
+			/* append vals to array */
+			g_ptr_array_add(array, vals);
+
 			changes = g_list_remove (changes, change);
 		}
 
-- 
1.7.2.3