File: larger_read_buffer.patch

package info (click to toggle)

firefox 143.0.3-1

links: PTS, VCS
area: main
in suites: sid
size: 4,617,328 kB
sloc: cpp: 7,478,492; javascript: 6,417,157; ansic: 3,720,058; python: 1,396,372; xml: 627,523; asm: 438,677; java: 186,156; sh: 63,477; makefile: 19,171; objc: 13,059; perl: 12,983; yacc: 4,583; cs: 3,846; pascal: 3,405; lex: 1,720; ruby: 1,003; exp: 762; php: 436; lisp: 258; awk: 247; sql: 66; sed: 53; csh: 10

file content (30 lines) | stat: -rw-r--r-- 1,072 bytes

parent folder | download | duplicates (12)

From 92f174669fc86642d4a8baf4b8d1305dc593eb2c Mon Sep 17 00:00:00 2001
From: Greg Stoll <gstoll@mozilla.com>
Date: Wed, 26 Feb 2025 08:04:10 -0600
Subject: [PATCH] Bug 1948884 - increase Content Analysis client buffer size
 r=#dlp-reviewers!

It's a bit unclear to me why this helps, since the logic seems to
indicate that ReadNextMessageFromPipe() will resize the buffer as
needed. But on my machine this makes a ~100 file upload work
consistently, where it would freeze sometimes before this change. And
it seems harmless.

diff --git a/browser/src/client_win.cc b/browser/src/client_win.cc
index 039946d131398..aaa17d0e051a9 100644
--- a/browser/src/client_win.cc
+++ b/browser/src/client_win.cc
@@ -17,7 +17,9 @@
 namespace content_analysis {
 namespace sdk {
 
-const DWORD kBufferSize = 4096;
+// Increased to a larger size to help with issues with analyzing a lot of
+// files at once - see bug 1948884.
+const DWORD kBufferSize = 65536;
 
 // Use the same default timeout value (50ms) as CreateNamedPipeA(), expressed
 // in 100ns intervals.
-- 
2.47.1.windows.2