1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
|
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include <memory>
#include <ostream>
#include <string>
#include <string_view>
#include <type_traits>
#include <vector>
#include "gtest/gtest.h"
#include "mozilla/CmdLineAndEnvUtils.h"
// Insulate these test-classes from the outside world.
//
// (In particular, distinguish this `CommandLine` from the one in ipc/chromium.
// The compiler has no issues here, but the MSVC debugger gets somewhat
// confused.)
namespace testzilla {
// Auxiliary class to simplify the declaration of test-cases for
// EnsureCommandlineSafe.
class CommandLine {
const size_t size;
std::vector<std::string> _data_8;
std::vector<std::wstring> _data_16;
// _should_ be const all the way through, but...
char const** argv_8;
wchar_t const** argv_16;
public:
inline int argc() const { return (int)(unsigned int)(size); }
template <typename CharT>
CharT const** argv() const;
CommandLine(CommandLine const&) = delete;
CommandLine(CommandLine&& that) = delete;
template <typename Container>
explicit CommandLine(Container const& container)
: size{std::size(container) + 1}, // plus one for argv[0]
argv_8(new const char*[size + 1]), // plus one again for argv[argc]
argv_16(new const wchar_t*[size + 1]) {
_data_8.reserve(size + 1);
_data_16.reserve(size + 1);
size_t pos = 0;
const auto append = [&](const char* val) {
size_t const len = ::strlen(val);
_data_8.emplace_back(val, val + len);
_data_16.emplace_back(val, val + len);
argv_8[pos] = _data_8.back().data();
argv_16[pos] = _data_16.back().data();
++pos;
};
append("GECKOAPP.COM"); // argv[0] may be anything
for (const char* item : container) {
append(item);
}
assert(pos == size);
// C99 §5.1.2.2.1 states "argv[argc] shall be a null pointer", and
// `CheckArg` implicitly relies on this.
argv_8[pos] = nullptr;
argv_16[pos] = nullptr;
}
// debug output
friend std::ostream& operator<<(std::ostream& o, CommandLine const& cl) {
for (const auto& item : cl._data_8) {
o << '"';
for (const char c : item) {
if (c == '"') {
o << "\\\"";
} else {
o << c;
}
}
o << "\", ";
}
return o;
}
};
template <>
char const** CommandLine::argv<char>() const {
return argv_8;
}
template <>
wchar_t const** CommandLine::argv<wchar_t>() const {
return argv_16;
}
enum TestCaseState : bool {
FAIL = false,
PASS = true,
};
constexpr TestCaseState operator!(TestCaseState s) {
return TestCaseState(!bool(s));
}
#ifdef XP_WIN
constexpr static const TestCaseState WIN_ONLY = PASS;
#else
constexpr static const TestCaseState WIN_ONLY = FAIL;
#endif
using NarrowTestCase = std::pair<const char*, const char*>;
constexpr std::pair<TestCaseState, NarrowTestCase> kStrMatches8[] = {
{PASS, {"", ""}},
{PASS, {"i", "i"}},
{PASS, {"i", "I"}},
{FAIL, {"", "i"}},
{FAIL, {"i", ""}},
{FAIL, {"i", "j"}},
{PASS, {"mozilla", "mozilla"}},
{PASS, {"mozilla", "Mozilla"}},
{PASS, {"mozilla", "MOZILLA"}},
{PASS, {"mozilla", "mOZILLA"}},
{PASS, {"mozilla", "mOZIlLa"}},
{PASS, {"mozilla", "MoZiLlA"}},
{FAIL, {"mozilla", ""}},
{FAIL, {"mozilla", "mozill"}},
{FAIL, {"mozilla", "mozillo"}},
{FAIL, {"mozilla", "mozillam"}},
{FAIL, {"mozilla", "mozilla-"}},
{FAIL, {"mozilla", "-mozilla"}},
{FAIL, {"-mozilla", "mozilla"}},
// numbers are permissible
{PASS, {"m0zi11a", "m0zi11a"}},
{PASS, {"m0zi11a", "M0ZI11A"}},
{PASS, {"m0zi11a", "m0Zi11A"}},
{FAIL, {"mozilla", "m0zi11a"}},
{FAIL, {"m0zi11a", "mozilla"}},
// capital letters are not accepted in the left comparand
{FAIL, {"I", "i"}},
{FAIL, {"I", "i"}},
{FAIL, {"Mozilla", "mozilla"}},
{FAIL, {"Mozilla", "Mozilla"}},
// punctuation other than `-` is rejected
{FAIL, {"*", "*"}},
{FAIL, {"*", "word"}},
{FAIL, {".", "."}},
{FAIL, {".", "a"}},
{FAIL, {"_", "_"}},
// spaces are rejected
{FAIL, {" ", " "}},
{FAIL, {"two words", "two words"}},
// non-ASCII characters are rejected
//
// (the contents of this test case may differ depending on the source and
// execution character sets, but the result should always be failure)
{FAIL, {"à", "a"}},
{FAIL, {"a", "à"}},
{FAIL, {"à", "à"}},
};
#ifdef XP_WIN
using WideTestCase = std::pair<const char*, const wchar_t*>;
std::pair<TestCaseState, WideTestCase> kStrMatches16[] = {
// (Turkish 'İ' may lowercase to 'i' in some locales, but
// we explicitly prevent that from being relevant)
{FAIL, {"i", L"İ"}},
{FAIL, {"mozilla", L"ṁozilla"}},
};
#endif
constexpr const char* kRequiredArgs[] = {"aleph", "beth"};
MOZ_RUNINIT std::pair<TestCaseState,
std::vector<const char*>> const kCommandLines[] = {
// the basic admissible forms
{PASS, {"-osint", "-aleph", "http://www.example.com/"}},
{PASS, {"-osint", "-beth", "http://www.example.com/"}},
// GNU-style double-dashes are also allowed
{PASS, {"--osint", "-aleph", "http://www.example.com/"}},
{PASS, {"--osint", "-beth", "http://www.example.com/"}},
{PASS, {"--osint", "--aleph", "http://www.example.com/"}},
{PASS, {"--osint", "--beth", "http://www.example.com/"}},
// on Windows, slashes are also permitted
{WIN_ONLY, {"-osint", "/aleph", "http://www.example.com/"}},
{WIN_ONLY, {"--osint", "/aleph", "http://www.example.com/"}},
// - These should pass on Windows because they're well-formed.
// - These should pass elsewhere because the first parameter is
// just a local filesystem path, not an option.
{PASS, {"/osint", "/aleph", "http://www.example.com/"}},
{PASS, {"/osint", "-aleph", "http://www.example.com/"}},
{PASS, {"/osint", "--aleph", "http://www.example.com/"}},
// the required argument's argument may not itself be a flag
{FAIL, {"-osint", "-aleph", "-anything"}},
{FAIL, {"-osint", "-aleph", "--anything"}},
// - On Windows systems this is a switch and should be rejected.
// - On non-Windows systems this is potentially a valid local path.
{!WIN_ONLY, {"-osint", "-aleph", "/anything"}},
// wrong order
{FAIL, {"-osint", "http://www.example.com/", "-aleph"}},
{FAIL, {"-aleph", "-osint", "http://www.example.com/"}},
{FAIL, {"-aleph", "http://www.example.com/", "-osint"}},
{FAIL, {"http://www.example.com/", "-osint", "-aleph"}},
{FAIL, {"http://www.example.com/", "-aleph", "-osint"}},
// missing arguments
{FAIL, {"-osint", "http://www.example.com/"}},
{FAIL, {"-osint", "-aleph"}},
{FAIL, {"-osint"}},
// improper arguments
{FAIL, {"-osint", "-other-argument", "http://www.example.com/"}},
{FAIL, {"-osint", "", "http://www.example.com/"}},
// additional arguments
{FAIL, {"-osint", "-aleph", "http://www.example.com/", "-other-argument"}},
{FAIL, {"-osint", "-other-argument", "-aleph", "http://www.example.com/"}},
{FAIL, {"-osint", "-aleph", "-other-argument", "http://www.example.com/"}},
{FAIL, {"-osint", "-aleph", "http://www.example.com/", "-a", "-b"}},
{FAIL, {"-osint", "-aleph", "-a", "http://www.example.com/", "-b"}},
{FAIL, {"-osint", "-a", "-aleph", "http://www.example.com/", "-b"}},
// multiply-occurring otherwise-licit arguments
{FAIL, {"-osint", "-aleph", "-beth", "http://www.example.com/"}},
{FAIL, {"-osint", "-aleph", "-aleph", "http://www.example.com/"}},
// if -osint is not supplied, anything goes
{PASS, {}},
{PASS, {"http://www.example.com"}},
{PASS, {"-aleph", "http://www.example.com/"}},
{PASS, {"-beth", "http://www.example.com/"}},
{PASS, {"-aleph", "http://www.example.com/", "-other-argument"}},
{PASS, {"-aleph", "-aleph", "http://www.example.com/"}},
};
constexpr static char const* const kOptionalArgs[] = {"mozilla", "allizom"};
// Additional test cases for optional parameters.
//
// Test cases marked PASS should pass iff the above optional parameters are
// permitted. (Test cases marked FAIL should fail regardless, and are only
// grouped here for convenience and semantic coherence.)
MOZ_RUNINIT std::pair<TestCaseState, std::vector<const char*>>
kCommandLinesOpt[] = {
// one permitted optional argument
{PASS, {"-osint", "-mozilla", "-aleph", "http://www.example.com/"}},
{PASS, {"-osint", "-allizom", "-aleph", "http://www.example.com/"}},
// multiple permitted optional arguments
{PASS,
{"-osint", "-mozilla", "-allizom", "-aleph",
"http://www.example.com/"}},
{PASS,
{"-osint", "-allizom", "-mozilla", "-aleph",
"http://www.example.com/"}},
// optional arguments in the wrong place
{FAIL, {"-mozilla", "-osint", "-aleph", "http://www.example.com/"}},
{FAIL, {"-osint", "-aleph", "-mozilla", "http://www.example.com/"}},
{FAIL, {"-osint", "-aleph", "http://www.example.com/", "-mozilla"}},
// optional arguments in both right and wrong places
{FAIL,
{"-mozilla", "-osint", "-allizom", "-aleph",
"http://www.example.com/"}},
{FAIL,
{"-osint", "-allizom", "-aleph", "-mozilla",
"http://www.example.com/"}},
{FAIL,
{"-osint", "-allizom", "-aleph", "http://www.example.com/",
"-mozilla"}},
};
enum WithOptionalState : bool {
NoOptionalArgs = false,
WithOptionalArgs = true,
};
template <typename CharT>
bool TestCommandLineImpl(CommandLine const& cl,
WithOptionalState withOptional) {
int argc = cl.argc();
// EnsureCommandlineSafe's signature isn't const-correct here for annoying
// reasons, but it is indeed non-mutating.
CharT** argv = const_cast<CharT**>(cl.argv<CharT>());
if (withOptional) {
return mozilla::internal::EnsureCommandlineSafeImpl(
argc, argv, kRequiredArgs, kOptionalArgs);
}
return mozilla::internal::EnsureCommandlineSafeImpl(argc, argv,
kRequiredArgs);
}
// Test that `args` produces `expectation`. On Windows, test against both
// wide-character and narrow-character implementations.
void TestCommandLine(TestCaseState expectation, CommandLine const& cl,
WithOptionalState withOptional) {
EXPECT_EQ(TestCommandLineImpl<char>(cl, withOptional), expectation)
<< "cl is: " << cl << "\n"
<< "withOptional is: " << bool(withOptional);
#ifdef XP_WIN
EXPECT_EQ(TestCommandLineImpl<wchar_t>(cl, withOptional), expectation)
<< "cl is: " << cl << "\n"
<< "withOptional is: " << bool(withOptional);
#endif
}
} // namespace testzilla
/***********************
* Test cases
*/
TEST(CmdLineAndEnvUtils, strimatch)
{
using namespace testzilla;
using mozilla::strimatch;
for (auto const& [result, data] : kStrMatches8) {
auto const& [left, right] = data;
auto match = strimatch(left, right);
EXPECT_EQ(match, result) << '<' << left << "> !~ <" << right << '>';
#ifdef XP_WIN
wchar_t right_wide[200];
::mbstowcs(right_wide, right, 200);
auto match_wide = strimatch(left, right_wide);
EXPECT_EQ(match_wide, result) << '<' << left << "> !~ L<" << right << '>';
#endif
}
#ifdef XP_WIN
for (auto const& [result, data] : kStrMatches16) {
auto const& [left, right] = data;
EXPECT_EQ(strimatch(left, right), result)
<< '<' << left << "> !~ L<" << right << '>';
}
#endif
}
TEST(CmdLineAndEnvUtils, ArgStartsWith)
{
using mozilla::ArgStartsWith;
// Should match and point to '='
auto match = ArgStartsWith("flag=value", "flag");
ASSERT_TRUE(match);
// Should match and point to '\0' for exact match
auto match2 = ArgStartsWith("flag", "flag");
ASSERT_TRUE(match2);
// Should not match
auto match3 = ArgStartsWith("flog=value", "flag");
EXPECT_FALSE(match3);
}
TEST(CmdLineAndEnvUtils, flagValue)
{
using mozilla::ARG_BAD;
using mozilla::ARG_FOUND;
using mozilla::ARG_NONE;
using mozilla::CheckArg;
int argc;
const char* argv1[] = {"prog", "--flag=value", nullptr};
argc = 2;
const char* param = nullptr;
EXPECT_EQ(CheckArg(argc, const_cast<char**>(argv1), "flag", ¶m),
ARG_FOUND);
ASSERT_TRUE(param);
EXPECT_STREQ(param, "value");
const char* argv2[] = {"prog", "-flag=foo", nullptr};
argc = 2;
param = nullptr;
EXPECT_EQ(CheckArg(argc, const_cast<char**>(argv2), "flag", ¶m),
ARG_FOUND);
ASSERT_TRUE(param);
EXPECT_STREQ(param, "foo");
// Should still work for --flag value
const char* argv3[] = {"prog", "--flag", "bar", nullptr};
argc = 3;
param = nullptr;
EXPECT_EQ(CheckArg(argc, const_cast<char**>(argv3), "flag", ¶m),
ARG_FOUND);
ASSERT_TRUE(param);
EXPECT_STREQ(param, "bar");
// Should not match for --flog=value
const char* argv4[] = {"prog", "--flog=value", nullptr};
argc = 2;
param = nullptr;
EXPECT_EQ(CheckArg(argc, const_cast<char**>(argv4), "flag", ¶m),
ARG_NONE);
const char* argv5[] = {"prog", "-flag=foo", nullptr};
argc = 2;
EXPECT_EQ(CheckArg(argc, const_cast<char**>(argv5), "flag", nullptr),
ARG_BAD);
}
TEST(CmdLineAndEnvUtils, ensureSafe)
{
using namespace testzilla;
for (auto const& [result, data] : kCommandLines) {
CommandLine const cl(data);
TestCommandLine(result, cl, NoOptionalArgs);
}
for (auto const& [_unused, data] : kCommandLinesOpt) {
MOZ_UNUSED(_unused); // silence gcc
CommandLine const cl(data);
TestCommandLine(FAIL, cl, NoOptionalArgs);
}
}
TEST(CmdLineAndEnvUtils, ensureSafeWithOptional)
{
using namespace testzilla;
for (auto const& [result, data] : kCommandLines) {
CommandLine const cl(data);
TestCommandLine(result, cl, WithOptionalArgs);
}
for (auto const& [result, data] : kCommandLinesOpt) {
CommandLine const cl(data);
TestCommandLine(result, cl, WithOptionalArgs);
}
}
|