File: larger_read_buffer.patch

package info (click to toggle)
firefox 147.0.2-1
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 4,683,484 kB
  • sloc: cpp: 7,607,246; javascript: 6,533,185; ansic: 3,775,227; python: 1,415,393; xml: 634,561; asm: 438,951; java: 186,241; sh: 62,752; makefile: 18,079; objc: 13,092; perl: 12,808; yacc: 4,583; cs: 3,846; pascal: 3,448; lex: 1,720; ruby: 1,003; php: 436; lisp: 258; awk: 247; sql: 66; sed: 54; csh: 10; exp: 6
file content (30 lines) | stat: -rw-r--r-- 1,072 bytes parent folder | download | duplicates (13) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
 
From 92f174669fc86642d4a8baf4b8d1305dc593eb2c Mon Sep 17 00:00:00 2001
From: Greg Stoll <gstoll@mozilla.com>
Date: Wed, 26 Feb 2025 08:04:10 -0600
Subject: [PATCH] Bug 1948884 - increase Content Analysis client buffer size
 r=#dlp-reviewers!

It's a bit unclear to me why this helps, since the logic seems to
indicate that ReadNextMessageFromPipe() will resize the buffer as
needed. But on my machine this makes a ~100 file upload work
consistently, where it would freeze sometimes before this change. And
it seems harmless.

diff --git a/browser/src/client_win.cc b/browser/src/client_win.cc
index 039946d131398..aaa17d0e051a9 100644
--- a/browser/src/client_win.cc
+++ b/browser/src/client_win.cc
@@ -17,7 +17,9 @@
 namespace content_analysis {
 namespace sdk {
 
-const DWORD kBufferSize = 4096;
+// Increased to a larger size to help with issues with analyzing a lot of
+// files at once - see bug 1948884.
+const DWORD kBufferSize = 65536;
 
 // Use the same default timeout value (50ms) as CreateNamedPipeA(), expressed
 // in 100ns intervals.
-- 
2.47.1.windows.2