1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720
|
"""
test_changeable
~~~~~~~~~~~~~~~
Changeable tests
:copyright: (c) 2019-2025 by J. Christopher Wagner (jwag).
:license: MIT, see LICENSE for more details.
"""
import base64
import pytest
from flask import Flask
import markupsafe
from flask_security import PasswordUtil, UserMixin, password_changed, user_authenticated
from flask_security.forms import _default_field_labels
from flask_security.utils import localize_callback
from tests.test_utils import (
authenticate,
check_location,
check_xlation,
get_form_input_value,
get_session,
hash_password,
init_app_with_options,
json_authenticate,
logout,
)
pytestmark = pytest.mark.changeable()
def test_changeable_flag(app, clients, get_message):
tcl = clients
recorded = []
@password_changed.connect_via(app)
def on_password_changed(app, user):
assert isinstance(app, Flask)
assert isinstance(user, UserMixin)
recorded.append(user)
authenticate(tcl)
# Test change view
response = tcl.get("/change", follow_redirects=True)
assert b"Change Password" in response.data
# Test wrong original password
response = tcl.post(
"/change",
data={
"password": "notpassword",
"new_password": "newpassword",
"new_password_confirm": "newpassword",
},
follow_redirects=True,
)
assert get_message("INVALID_PASSWORD") in response.data
# Test mismatch
response = tcl.post(
"/change",
data={
"password": "password",
"new_password": "newpassword",
"new_password_confirm": "notnewpassword",
},
follow_redirects=True,
)
assert get_message("RETYPE_PASSWORD_MISMATCH") in response.data
# Test missing password
response = tcl.post(
"/change",
data={"password": " ", "new_password": "", "new_password_confirm": ""},
follow_redirects=True,
)
assert get_message("PASSWORD_NOT_PROVIDED") in response.data
response = tcl.post(
"/change",
data={
"password": " ",
"new_password": "awesome password",
"new_password_confirm": "awesome password",
},
follow_redirects=True,
)
assert get_message("PASSWORD_NOT_PROVIDED") in response.data
# Test bad password
response = tcl.post(
"/change",
data={"password": "password", "new_password": "a", "new_password_confirm": "a"},
follow_redirects=True,
)
assert get_message("PASSWORD_INVALID_LENGTH", length=8) in response.data
# Test same as previous
response = tcl.post(
"/change",
data={
"password": "password",
"new_password": "password",
"new_password_confirm": "password",
},
follow_redirects=True,
)
assert get_message("PASSWORD_IS_THE_SAME") in response.data
# Test successful submit sends email notification
response = tcl.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
outbox = app.mail.outbox
assert get_message("PASSWORD_CHANGE") in response.data
assert b"Home Page" in response.data
assert len(recorded) == 1
assert len(outbox) == 1
assert "Your password has been changed" in outbox[0].body
# Test leading & trailing whitespace not stripped
response = tcl.post(
"/change",
data={
"password": "new strong password",
"new_password": " new strong password ",
"new_password_confirm": " new strong password ",
},
follow_redirects=True,
)
assert get_message("PASSWORD_CHANGE") in response.data
# Test JSON
data = (
'{"password": " new strong password ", '
'"new_password": "new stronger password2", '
'"new_password_confirm": "new stronger password2"}'
)
response = tcl.post(
"/change", data=data, headers={"Content-Type": "application/json"}
)
assert response.status_code == 200
assert response.headers["Content-Type"] == "application/json"
# Test JSON errors
data = '{"password": "newpassword"}'
response = tcl.post(
"/change", data=data, headers={"Content-Type": "application/json"}
)
assert response.status_code == 400
assert response.json["response"]["field_errors"]["new_password"] == [
"Password not provided"
]
def test_change_invalidates_session(app, client):
# Make sure that if we change our password - prior sessions are invalidated.
# changing password effectively re-logs in user - verify the signal
auths = []
@user_authenticated.connect_via(app)
def authned(myapp, user, **extra_args):
auths.append((user.email, extra_args["authn_via"]))
# No remember cookie since that also be reset and auto-login.
data = dict(email="matt@lp.com", password="password", remember="")
response = client.post("/login", data=data)
sess = get_session(response)
cur_user_id = sess.get("_user_id", sess.get("user_id"))
response = client.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
# First auth was the initial login above - second should be from /change
assert auths[1][0] == "matt@lp.com"
assert "change" in auths[1][1]
# Should have received a new session cookie - so should still be logged in
response = client.get("/profile", follow_redirects=True)
assert b"Profile Page" in response.data
# Now use old session - shouldn't work.
with client.session_transaction() as oldsess:
oldsess["_user_id"] = cur_user_id
oldsess["user_id"] = cur_user_id
# try to access protected endpoint - shouldn't work
response = client.get("/profile")
assert response.status_code == 302
assert response.location == "/login?next=/profile"
def test_change_updates_remember(app, client):
# Test that on change password - remember cookie updated
authenticate(client)
response = client.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
# Should have received a new session cookie - so should still be logged in
response = client.get("/profile", follow_redirects=True)
assert b"Profile Page" in response.data
assert client.get_cookie("remember_token")
client.delete_cookie("session")
response = client.get("/profile", follow_redirects=True)
assert b"Profile Page" in response.data
def test_change_invalidates_auth_token(app, client):
# if change password, by default that should invalidate auth tokens
response = json_authenticate(client)
token = response.json["response"]["user"]["authentication_token"]
headers = {"Authentication-Token": token}
# make sure can access restricted page
response = client.get("/token", headers=headers)
assert b"Token Authentication" in response.data
response = client.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
assert response.status_code == 200
# authtoken should now be invalid
response = client.get("/token", headers=headers)
assert response.status_code == 302
assert response.location == "/login?next=/token"
def test_auth_uniquifier(app):
pytest.importorskip("sqlalchemy")
pytest.importorskip("flask_sqlalchemy")
# If add fs_token_uniquifier to user model - change password shouldn't invalidate
# auth tokens.
from sqlalchemy import Column, String
from flask_sqlalchemy import SQLAlchemy
from flask_security.models import fsqla_v2 as fsqla
from flask_security import Security, SQLAlchemyUserDatastore
app.config["SQLALCHEMY_DATABASE_URI"] = "sqlite:///:memory:"
db = SQLAlchemy(app)
fsqla.FsModels.set_db_info(db)
class Role(db.Model, fsqla.FsRoleMixin):
pass
class User(db.Model, fsqla.FsUserMixin):
fs_token_uniquifier = Column(String(64), unique=True, nullable=False)
with app.app_context():
db.create_all()
ds = SQLAlchemyUserDatastore(db, User, Role)
app.security = Security(app, datastore=ds)
with app.app_context():
ds.create_user(
email="matt@lp.com",
password=hash_password("password"),
)
ds.commit()
client = app.test_client()
# standard login with auth token
response = json_authenticate(client)
token = response.json["response"]["user"]["authentication_token"]
headers = {"Authentication-Token": token}
# make sure can access restricted page
response = client.get("/token", headers=headers)
assert b"Token Authentication" in response.data
# change password
response = client.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
assert response.status_code == 200
# authtoken should still be valid
response = client.get("/token", headers=headers)
assert response.status_code == 200
with app.app_context():
db.engine.dispose()
@pytest.mark.app_settings(babel_default_locale="fr_FR")
@pytest.mark.babel()
def test_xlation(app, client, get_message_local):
# Test form and email translation
assert check_xlation(app, "fr_FR"), "You must run python setup.py compile_catalog"
authenticate(client)
response = client.get("/change", follow_redirects=True)
with app.test_request_context():
# Check header
assert (
f'<h1>{localize_callback("Change Password")}</h1>'.encode() in response.data
)
submit = localize_callback(_default_field_labels["change_password"])
assert f'value="{submit}"'.encode() in response.data
response = client.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
outbox = app.mail.outbox
with app.test_request_context():
assert get_message_local("PASSWORD_CHANGE").encode("utf-8") in response.data
assert b"Home Page" in response.data
assert len(outbox) == 1
assert (
localize_callback(
app.config["SECURITY_EMAIL_SUBJECT_PASSWORD_CHANGE_NOTICE"]
)
in outbox[0].subject
)
assert (
str(markupsafe.escape(localize_callback("Your password has been changed.")))
in outbox[0].alternatives[0][0]
)
assert localize_callback("Your password has been changed") in outbox[0].body
@pytest.mark.settings(change_url="/custom_change")
def test_custom_change_url(client):
authenticate(client)
response = client.get("/custom_change")
assert response.status_code == 200
@pytest.mark.settings(change_password_template="custom_security/change_password.html")
def test_custom_change_template(client):
authenticate(client)
response = client.get("/change")
assert b"CUSTOM CHANGE PASSWORD" in response.data
@pytest.mark.settings(send_password_change_email=False)
def test_disable_change_emails(app, client):
client.post(
"/change",
data={
"password": "password",
"new_password": "newpassword",
"new_password_confirm": "newpassword",
},
follow_redirects=True,
)
assert not app.mail.outbox
@pytest.mark.settings(post_change_view="/profile")
def test_custom_post_change_view(client):
authenticate(client)
response = client.post(
"/change",
data={
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
},
follow_redirects=True,
)
assert b"Profile Page" in response.data
def test_token_change(app, client_nc):
# Verify can change password using token auth only
login_response = json_authenticate(client_nc)
token = login_response.json["response"]["user"]["authentication_token"]
data = dict(
password="password",
new_password="new strong password",
new_password_confirm="new strong password",
)
response = client_nc.post(
"/change?include_auth_token=1",
json=data,
headers={"Content-Type": "application/json", "Authentication-Token": token},
)
assert response.status_code == 200
assert "authentication_token" in response.json["response"]["user"]
@pytest.mark.settings(api_enabled_methods=["basic"])
def test_basic_change(app, client_nc, get_message):
# Verify can change password using basic auth
data = dict(
password="password",
new_password="new strong password",
new_password_confirm="new strong password",
)
response = client_nc.post("/change", data=data)
assert get_message("UNAUTHENTICATED") in response.data
assert "WWW-Authenticate" in response.headers
response = client_nc.post(
"/change",
data=data,
headers={
"Authorization": "Basic %s"
% base64.b64encode(b"matt@lp.com:password").decode("utf-8")
},
follow_redirects=True,
)
assert response.status_code == 200
# No session so no flashing
assert b"Home Page" in response.data
def __test_easy_password(client):
authenticate(client)
data = (
'{"password": "password", '
'"new_password": "mattmatt2", '
'"new_password_confirm": "mattmatt2"}'
)
response = client.post(
"/change", data=data, headers={"Content-Type": "application/json"}
)
assert response.headers["Content-Type"] == "application/json"
return response
@pytest.mark.settings(password_complexity_checker="zxcvbn")
def test_easy_password(app, client):
response = __test_easy_password(client)
assert response.status_code == 400
# Response from zxcvbn
assert "Repeats like" in response.json["response"]["errors"][0]
@pytest.mark.settings(password_complexity_checker="zxcvbn", zxcvbn_minimum_score=0)
def test_easy_password_ok(app, client):
response = __test_easy_password(client)
assert response.status_code == 200
def test_my_validator(app, sqlalchemy_datastore):
class MyPwUtil(PasswordUtil):
def validate(self, password, is_register, **kwargs):
user = kwargs["user"]
# This is setup in createusers for matt.
assert user.security_number == 123456
return ["Are you crazy?"], password
init_app_with_options(
app, sqlalchemy_datastore, **{"security_args": {"password_util_cls": MyPwUtil}}
)
client = app.test_client()
authenticate(client)
data = (
'{"password": "password", '
'"new_password": "mattmatt2", '
'"new_password_confirm": "mattmatt2"}'
)
response = client.post(
"/change", data=data, headers={"Content-Type": "application/json"}
)
assert response.headers["Content-Type"] == "application/json"
assert response.status_code == 400
assert "Are you crazy" in response.json["response"]["errors"][0]
@pytest.mark.settings(password_length_min=12)
def test_override_length(app, client, get_message):
authenticate(client)
response = client.post(
"/change",
data={
"password": "password",
"new_password": "01234567890",
"new_password_confirm": "01234567890",
},
follow_redirects=True,
)
assert get_message("PASSWORD_INVALID_LENGTH", length=12) in response.data
def test_unicode_length(app, client, get_message):
# From NIST and OWASP - each unicode code point should count as a character.
authenticate(client)
# Emoji's are 4 bytes in utf-8
data = dict(
password="password",
new_password="\N{CYCLONE}\N{SUNRISE}\N{FOGGY}"
"\N{VOLCANO}\N{CRESCENT MOON}\N{MILKY WAY}"
"\N{FOG}\N{THERMOMETER}\N{ROSE}",
new_password_confirm="\N{CYCLONE}\N{SUNRISE}\N{FOGGY}"
"\N{VOLCANO}\N{CRESCENT MOON}\N{MILKY WAY}"
"\N{FOG}\N{THERMOMETER}\N{ROSE}",
)
response = client.post(
"/change", json=data, headers={"Content-Type": "application/json"}
)
assert response.headers["Content-Type"] == "application/json"
assert response.status_code == 200
def test_unicode_invalid_length(app, client, get_message):
# From NIST and OWASP - each unicode code point should count as a character.
authenticate(client)
# Emoji's are 4 bytes in utf-8
data = dict(
password="password",
new_password="\N{CYCLONE}\N{CYCLONE}\N{FOGGY}\N{FOGGY}",
new_password_confirm="\N{CYCLONE}\N{CYCLONE}\N{FOGGY}\N{FOGGY}",
)
response = client.post(
"/change", json=data, headers={"Content-Type": "application/json"}
)
assert response.headers["Content-Type"] == "application/json"
assert response.status_code == 400
assert get_message("PASSWORD_INVALID_LENGTH", length=8) in response.data
def test_pwd_normalize(app, client):
"""Verify that can log in with both original and normalized pwd"""
authenticate(client)
data = dict(
password="password",
new_password="new strong password\N{ROMAN NUMERAL ONE}",
new_password_confirm="new strong password\N{ROMAN NUMERAL ONE}",
)
response = client.post(
"/change",
json=data,
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
logout(client)
# use original typed-in pwd
response = client.post(
"/login",
json=dict(
email="matt@lp.com", password="new strong password\N{ROMAN NUMERAL ONE}"
),
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
logout(client)
# try with normalized password
response = client.post(
"/login",
json=dict(
email="matt@lp.com",
password="new strong password\N{LATIN CAPITAL LETTER I}",
),
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
# Verify can change password using original password
data = dict(
password="new strong password\N{ROMAN NUMERAL ONE}",
new_password="new strong password\N{ROMAN NUMERAL TWO}",
new_password_confirm="new strong password\N{ROMAN NUMERAL TWO}",
)
response = client.post(
"/change",
json=data,
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
@pytest.mark.settings(password_normalize_form=None)
def test_pwd_no_normalize(app, client):
"""Verify that can log in with original but not normalized if have
disabled normalization
"""
authenticate(client)
data = dict(
password="password",
new_password="new strong password\N{ROMAN NUMERAL ONE}",
new_password_confirm="new strong password\N{ROMAN NUMERAL ONE}",
)
response = client.post(
"/change",
json=data,
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
logout(client)
# try with normalized password - should fail
response = client.post(
"/login",
json=dict(
email="matt@lp.com",
password="new strong password\N{LATIN CAPITAL LETTER I}",
),
headers={"Content-Type": "application/json"},
)
assert response.status_code == 400
# use original typed-in pwd
response = client.post(
"/login",
json=dict(
email="matt@lp.com", password="new strong password\N{ROMAN NUMERAL ONE}"
),
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
# Verify can change password using original password
data = dict(
password="new strong password\N{ROMAN NUMERAL ONE}",
new_password="new strong password\N{ROMAN NUMERAL TWO}",
new_password_confirm="new strong password\N{ROMAN NUMERAL TWO}",
)
response = client.post(
"/change",
json=data,
headers={"Content-Type": "application/json"},
)
assert response.status_code == 200
@pytest.mark.csrf(ignore_unauth=True)
@pytest.mark.settings(post_change_view="/post_change_view")
def test_csrf(app, client):
# enable CSRF, make sure template shows CSRF errors.
authenticate(client)
data = {
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
}
response = client.post("/change", data=data)
assert b"The CSRF token is missing" in response.data
# Note that we get a CSRF token EVEN for errors - this seems odd
# but can't find anything that says its a security issue
csrf_token = get_form_input_value(response, "csrf_token")
data["csrf_token"] = csrf_token
response = client.post("/change", data=data)
assert check_location(app, response.location, "/post_change_view")
@pytest.mark.csrf(ignore_unauth=True, csrfprotect=True)
def test_csrf_json(app, client):
# This tests the handle_csrf code path - especially the JSON code path
# that should return a JSON response!
authenticate(client)
data = {
"password": "password",
"new_password": "new strong password",
"new_password_confirm": "new strong password",
}
response = client.post("/change", json=data)
assert response.status_code == 400
assert response.json["response"]["errors"][0] == "The CSRF token is missing."
# check form path also
response = client.post("/change", data=data)
assert response.status_code == 400
assert b"The CSRF token is missing." in response.data
response = client.get("/change", content_type="application/json")
csrf_token = response.json["response"]["csrf_token"]
response = client.post("/change", json=data, headers={"X-CSRF-Token": csrf_token})
assert response.status_code == 200
|