1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
;;; test-typescript.el --- Flycheck Specs: Ruby -*- lexical-binding: t; -*-
;; Copyright (C) 2017 Flycheck contributors
;; Copyright (C) 2016 Sebastian Wiesner and Flycheck contributors
;; Author: Saša Jovanić <sasa@simplify.ba>
;; This file is not part of GNU Emacs.
;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; This program is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with this program. If not, see <http://www.gnu.org/licenses/>.
;;; Commentary:
;; Specs for Ruby support.
;;; Code:
(require 'flycheck-buttercup)
(require 'test-helpers)
(describe "Language Ruby"
(describe "The Reek error parser"
(let ((json "[{\"context\":\"ApplicationController#validate_type\",
\"lines\":[15,15,16],
\"message\":\"calls 'params['data']' 3 times\",
\"smell_type\":\"DuplicateMethodCall\",
\"source\":\"app/controllers/application_controller.rb\",
\"name\":\"params['data']\",
\"count\":3,
\"wiki_link\":\"https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md\"},
{\"context\":\"ApplicationController#pagination_meta\",
\"lines\":[52],
\"message\":\"doesn't depend on instance state (maybe move it to another class?)\",
\"smell_type\":\"UtilityFunction\",
\"source\":\"app/controllers/application_controller.rb\",
\"wiki_link\":\"https://github.com/troessner/reek/blob/master/docs/Utility-Function.md\"}]"))
(it "parses Reek JSON output"
(expect (flycheck-parse-reek json 'checker 'buffer)
:to-be-equal-flycheck-errors
(list
(flycheck-error-new-at 15 nil 'warning
"ApplicationController#validate_type calls 'params['data']' 3 times"
:id "DuplicateMethodCall"
:checker 'checker
:buffer 'buffer
:filename "app/controllers/application_controller.rb")
(flycheck-error-new-at 16 nil 'warning
"ApplicationController#validate_type calls 'params['data']' 3 times"
:id "DuplicateMethodCall"
:checker 'checker
:buffer 'buffer
:filename "app/controllers/application_controller.rb")
(flycheck-error-new-at 52 nil 'warning
"ApplicationController#pagination_meta doesn't depend on instance state (maybe move it to another class?)"
:id "UtilityFunction"
:checker 'checker
:buffer 'buffer
:filename "app/controllers/application_controller.rb"))))))
(describe "Checker tests"
(flycheck-buttercup-def-checker-test ruby-rubocop ruby syntax-error
(flycheck-buttercup-should-syntax-check
"language/ruby/syntax-error.rb" 'ruby-mode
'(5 7 error "unexpected token tCONSTANT (Using Ruby 2.4 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)"
:id "Lint/Syntax"
:checker ruby-rubocop)
'(5 24 error "unterminated string meets end of file (Using Ruby 2.4 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)"
:id "Lint/Syntax"
:checker ruby-rubocop)))
(flycheck-buttercup-def-checker-test ruby-standard ruby syntax-error
(let ((flycheck-disabled-checkers '(ruby-rubocop)))
(flycheck-buttercup-should-syntax-check
"language/ruby/syntax-error.rb" 'ruby-mode
'(5 7 error "unexpected token tCONSTANT (Using Ruby 2.4 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)"
:id "Lint/Syntax"
:checker ruby-standard)
'(5 24 error "unterminated string meets end of file (Using Ruby 2.4 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)"
:id "Lint/Syntax"
:checker ruby-standard))))
(flycheck-buttercup-def-checker-test ruby ruby syntax-error
(let ((flycheck-disabled-checkers '(ruby-rubocop ruby-reek)))
(flycheck-buttercup-should-syntax-check
"language/ruby/syntax-error.rb" 'ruby-mode
'(4 nil warning "assigned but unused variable - days" :checker ruby)
'(5 nil error "syntax error, unexpected constant, expecting end-of-input"
:checker ruby))))
(flycheck-buttercup-def-checker-test (ruby-rubocop ruby-reek) ruby warnings
(flycheck-buttercup-should-syntax-check
"language/ruby/warnings.rb" 'ruby-mode
'(1 1 info "Missing frozen string literal comment."
:id "[Correctable] Style/FrozenStringLiteralComment" :checker ruby-rubocop)
'(3 nil warning "Person assumes too much for instance variable '@name'"
:id "InstanceVariableAssumption" :checker ruby-reek)
'(3 1 info "Missing top-level class documentation comment."
:id "Style/Documentation" :checker ruby-rubocop)
'(5 5 warning "Useless assignment to variable - `arr`."
:id "Lint/UselessAssignment" :checker ruby-rubocop)
'(5 11 info "Use `%i` or `%I` for an array of symbols."
:id "[Correctable] Style/SymbolArray" :checker ruby-rubocop)
'(6 10 info "Prefer single-quoted strings when you don't need string interpolation or special symbols."
:id "[Correctable] Style/StringLiterals" :checker ruby-rubocop)
'(10 5 info "Use a guard clause (`return unless true`) instead of wrapping the code inside a conditional expression."
:id "Style/GuardClause":checker ruby-rubocop)
'(10 5 info "Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`."
:id "[Correctable] Style/IfUnlessModifier" :checker ruby-rubocop)
'(10 8 warning "Literal `true` appeared as a condition."
:id "Lint/LiteralAsCondition" :checker ruby-rubocop)
'(10 13 info "Do not use `then` for multi-line `if`."
:id "[Correctable] Style/MultilineIfThen" :checker ruby-rubocop)
'(11 7 info "Redundant `return` detected."
:id "[Correctable] Style/RedundantReturn" :checker ruby-rubocop)))
(flycheck-buttercup-def-checker-test ruby-reek ruby warnings
(let ((flycheck-disabled-checkers '(ruby-rubocop)))
(flycheck-buttercup-should-syntax-check
"language/ruby/warnings.rb" 'ruby-mode
'(3 nil warning "Person assumes too much for instance variable '@name'"
:id "InstanceVariableAssumption" :checker ruby-reek))))
(flycheck-buttercup-def-checker-test ruby ruby warnings
(let ((flycheck-disabled-checkers '(ruby-rubocop ruby-reek)))
(flycheck-buttercup-should-syntax-check
"language/ruby/warnings.rb" 'ruby-mode
'(5 nil warning "assigned but unused variable - arr" :checker ruby)
'(16 nil warning "possibly useless use of == in void context"
:checker ruby))))
))
;;; test-ruby.el ends here
|
