1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
|
# SPDX-License-Identifier: AGPL-3.0-or-later
"""
Test scheduling of backups.
"""
import json
from datetime import datetime, timedelta
from unittest.mock import MagicMock, call, patch
import pytest
import plinth.modules.backups.repository as repository_module
from plinth.app import App
from ..components import BackupRestore
from ..schedule import Schedule
class AppTest(App):
"""Sample App for testing."""
app_id = 'test-app'
def _get_backup_component(name):
"""Return a BackupRestore component."""
return BackupRestore(name)
def _get_test_app(name):
"""Return an App."""
app = AppTest()
app.app_id = name
app._all_apps[name] = app
app.add(BackupRestore(name + '-component'))
return app
def test_init_default_values():
"""Test initialization of schedule with default values."""
schedule = Schedule('test-uuid')
assert schedule.repository_uuid == 'test-uuid'
assert not schedule.enabled
assert schedule.daily_to_keep == 5
assert schedule.weekly_to_keep == 3
assert schedule.monthly_to_keep == 3
assert schedule.run_at_hour == 2
assert schedule.unselected_apps == []
def test_init():
"""Test initialization with explicit values."""
schedule = Schedule('test-uuid', enabled=True, daily_to_keep=1,
weekly_to_keep=2, monthly_to_keep=5, run_at_hour=0,
unselected_apps=['test-app1', 'test-app2'])
assert schedule.repository_uuid == 'test-uuid'
assert schedule.enabled
assert schedule.daily_to_keep == 1
assert schedule.weekly_to_keep == 2
assert schedule.monthly_to_keep == 5
assert schedule.run_at_hour == 0
assert schedule.unselected_apps == ['test-app1', 'test-app2']
def test_get_storage_format():
"""Test that storage format is properly returned."""
schedule = Schedule('test-uuid', enabled=True, daily_to_keep=1,
weekly_to_keep=2, monthly_to_keep=5, run_at_hour=23,
unselected_apps=['test-app1', 'test-app2'])
assert schedule.get_storage_format() == {
'enabled': True,
'daily_to_keep': 1,
'weekly_to_keep': 2,
'monthly_to_keep': 5,
'run_at_hour': 23,
'unselected_apps': ['test-app1', 'test-app2'],
}
def _get_archives_from_test_data(data):
"""Return a list of archives from test data."""
archives = []
for index, item in enumerate(data):
archive_time = item['time']
if isinstance(archive_time, str):
archive_time = datetime.strptime(archive_time,
'%Y-%m-%d %H:%M:%S+0000')
comment = json.dumps({'type': 'scheduled', 'periods': item['periods']})
archive = {
'comment': comment,
'start': archive_time,
'name': f'archive-{index}'
}
archives.append(archive)
return archives
# - First item is the arguments to send construct Schedule()
# - Second item is the list of previous backups in the system.
# - Third item is the return value of datetime.datetime.now().
# - Fourth item is the list of periods for which backups must be triggered.
# - Fifth item is the list of expected archives to be deleted after backup.
cases = [
# Schedule is disabled
[
[False, 10, 10, 10, 0],
[],
datetime(2021, 1, 1),
[],
[],
],
# No past backups
[
[True, 10, 10, 10, 0],
[],
datetime(2021, 1, 1),
['daily', 'weekly', 'monthly'],
[],
],
# Daily backup taken recently
[
[True, 10, 10, 10, 0],
[{
'periods': ['daily'],
'time': datetime(2021, 1, 1) - timedelta(seconds=600)
}],
datetime(2021, 1, 1),
[],
[],
],
# Weekly backup taken recently
[
[True, 10, 10, 10, 0],
[{
'periods': ['weekly'],
'time': datetime(2021, 1, 1) - timedelta(seconds=600)
}],
datetime(2021, 1, 1),
[],
[],
],
# Monthly backup taken recently
[
[True, 10, 10, 10, 0],
[{
'periods': ['monthly'],
'time': datetime(2021, 1, 1) - timedelta(seconds=600)
}],
datetime(2021, 1, 1),
[],
[],
],
# Backup taken not so recently
[
[True, 10, 10, 10, 0],
[{
'periods': ['daily'],
'time': datetime(2021, 1, 1) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 1),
['daily', 'weekly', 'monthly'],
[],
],
# Too long since a daily backup, not scheduled time
[
[True, 10, 10, 10, 2],
[{
'periods': ['daily'],
'time': datetime(2021, 1, 1) - timedelta(days=1, seconds=3601)
}],
datetime(2021, 1, 1),
['daily', 'weekly', 'monthly'],
[],
],
# No too long since a daily backup, not scheduled time
[
[True, 10, 10, 10, 2],
[{
'periods': ['daily'],
'time': datetime(2021, 1, 1) - timedelta(days=1, seconds=3600)
}],
datetime(2021, 1, 1),
['weekly', 'monthly'],
[],
],
# Too long since a weekly backup, not scheduled time
[
[True, 10, 10, 10, 2],
[{
'periods': ['weekly'],
'time': datetime(2021, 1, 1) - timedelta(days=7, seconds=3601)
}],
datetime(2021, 1, 1),
['daily', 'weekly', 'monthly'],
[],
],
# No too long since a daily backup, not scheduled time
[
[True, 10, 10, 10, 2],
[{
'periods': ['weekly'],
'time': datetime(2021, 1, 1) - timedelta(days=7, seconds=3600)
}],
datetime(2021, 1, 1),
['daily', 'monthly'],
[],
],
# Too long since a monthly backup, not scheduled time, year rounding
[
[True, 10, 10, 10, 2],
[{
'periods': ['monthly'],
'time': datetime(2020, 12, 1)
}],
datetime(2021, 1, 1, 1, 0, 1),
['daily', 'weekly', 'monthly'],
[],
],
# No too long since a monthly backup, not scheduled time, year rounding
[
[True, 10, 10, 10, 2],
[{
'periods': ['monthly'],
'time': datetime(2020, 12, 1)
}],
datetime(2021, 1, 1, 1),
['daily', 'weekly'],
[],
],
# Too long since a monthly backup, not scheduled time, no year rounding
[
[True, 10, 10, 10, 2],
[{
'periods': ['monthly'],
'time': datetime(2020, 11, 1)
}],
datetime(2020, 12, 1, 1, 0, 1),
['daily', 'weekly', 'monthly'],
[],
],
# No too long since a monthly backup, not scheduled time, no year rounding
[
[True, 10, 10, 10, 2],
[{
'periods': ['monthly'],
'time': datetime(2020, 11, 1)
}],
datetime(2020, 12, 1, 1),
['daily', 'weekly'],
[],
],
# Time for daily backup
[
[True, 10, 10, 10, 0],
[{
'periods': ['daily', 'weekly', 'monthly'],
'time': datetime(2021, 1, 2) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 2),
['daily'],
[],
],
# Time for daily backup, different scheduled time
[
[True, 10, 10, 10, 11],
[{
'periods': ['daily', 'weekly', 'monthly'],
'time': datetime(2021, 1, 2, 11) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 2, 11),
['daily'],
[],
],
# Time for daily/weekly backup, 2021-01-03 is a Sunday
[
[True, 10, 10, 10, 0],
[{
'periods': ['daily', 'weekly', 'monthly'],
'time': datetime(2021, 1, 3) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 3),
['daily', 'weekly'],
[],
],
# Time for daily/monthly backup
[
[True, 10, 10, 10, 0],
[{
'periods': ['daily', 'weekly', 'monthly'],
'time': datetime(2021, 1, 1) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 1),
['daily', 'monthly'],
[],
],
# Daily backups disabled by setting the no. of backups to keep to 0
[
[True, 0, 10, 10, 0],
[],
datetime(2021, 1, 1),
['weekly', 'monthly'],
[],
],
# Weekly backups disabled by setting the no. of backups to keep to 0
[
[True, 10, 0, 10, 0],
[],
datetime(2021, 1, 1),
['daily', 'monthly'],
[],
],
# Monthly backups disabled by setting the no. of backups to keep to 0
[
[True, 10, 10, 0, 0],
[],
datetime(2021, 1, 1),
['daily', 'weekly'],
[],
],
# Not scheduled, not too long since last, no backup necessary
[
[True, 10, 10, 10, 0],
[{
'periods': ['daily', 'weekly', 'monthly'],
'time': datetime(2021, 1, 2, 1) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 2, 1),
[],
[],
],
# Cleanup daily backups
[
[True, 2, 10, 10, 0],
[{
'periods': ['daily'],
'time': datetime(2021, 1, 3, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily'],
'time': datetime(2021, 1, 2, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily'],
'time': datetime(2021, 1, 1, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily'],
'time': datetime(2021, 1, 1, 0) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 4, 1),
['daily', 'weekly', 'monthly'],
['archive-2', 'archive-3'],
],
# Cleanup weekly backups
[
[True, 10, 2, 10, 0],
[{
'periods': ['weekly'],
'time': datetime(2021, 1, 3, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['weekly'],
'time': datetime(2021, 1, 2, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['weekly'],
'time': datetime(2021, 1, 1, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['weekly'],
'time': datetime(2021, 1, 1, 0) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 4, 1),
['daily', 'monthly'],
['archive-2', 'archive-3'],
],
# Cleanup monthly backups
[
[True, 10, 10, 2, 0],
[{
'periods': ['monthly'],
'time': datetime(2021, 1, 3, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['monthly'],
'time': datetime(2021, 1, 2, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['monthly'],
'time': datetime(2021, 1, 1, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['monthly'],
'time': datetime(2021, 1, 1, 0) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 4, 1),
['daily', 'weekly'],
['archive-2', 'archive-3'],
],
# Cleanup daily backups, but keep due to them being weekly/monthly too
[
[True, 2, 1, 10, 0],
[{
'periods': ['daily'],
'time': datetime(2021, 1, 6, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily'],
'time': datetime(2021, 1, 5, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily', 'weekly'],
'time': datetime(2021, 1, 4, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily', 'weekly'],
'time': datetime(2021, 1, 3, 1) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily', 'monthly'],
'time': datetime(2021, 1, 2, 0) - timedelta(seconds=3 * 3600)
}, {
'periods': ['daily'],
'time': datetime(2021, 1, 1, 0) - timedelta(seconds=3 * 3600)
}],
datetime(2021, 1, 7, 1),
['daily'],
['archive-3', 'archive-5'],
],
]
@pytest.mark.parametrize(
'schedule_params,archives_data,test_now,run_periods,cleanups', cases)
@patch('plinth.app.App.get_setup_state')
@patch('plinth.modules.backups.repository.get_instance')
def test_run_schedule(get_instance, get_setup_state, schedule_params,
archives_data, test_now, run_periods, cleanups):
"""Test that backups are run at expected time."""
get_setup_state.return_value = App.SetupState.UP_TO_DATE
repository = MagicMock()
repository.list_archives.side_effect = \
lambda: _get_archives_from_test_data(archives_data)
get_instance.return_value = repository
repository.generate_archive_name = lambda: \
repository_module.BaseBorgRepository.generate_archive_name(None)
with patch('plinth.modules.backups.schedule.datetime') as mock_datetime, \
patch('plinth.modules.backups.repository.datetime') \
as repo_datetime, patch('plinth.app.App.list') as app_list:
app_list.return_value = [
_get_test_app('test-app1'),
_get_test_app('test-app2'),
_get_test_app('test-app3')
]
repo_datetime.datetime.now.return_value = test_now
mock_datetime.now.return_value = test_now
mock_datetime.strptime = datetime.strptime
mock_datetime.min = datetime.min
mock_datetime.side_effect = lambda *args, **kwargs: datetime(
*args, **kwargs)
schedule = Schedule('test_uuid', schedule_params[0],
schedule_params[1], schedule_params[2],
schedule_params[3], schedule_params[4],
['test-app2'])
schedule.run_schedule()
if not run_periods:
repository.create_archive.assert_not_called()
else:
run_periods.sort()
name = 'scheduled: {periods}: {datetime}'.format(
periods=', '.join(run_periods),
datetime=repo_datetime.datetime.now().astimezone().replace(
microsecond=0).isoformat())
app_ids = ['test-app1', 'test-app3']
archive_comment = json.dumps({
'type': 'scheduled',
'periods': run_periods
}).replace('{', '{{').replace('}', '}}')
repository.create_archive.assert_has_calls(
[call(name, app_ids, archive_comment=archive_comment)])
if not cleanups:
repository.delete_archive.assert_not_called()
else:
calls = [call(name) for name in cleanups]
repository.delete_archive.assert_has_calls(calls)
|
