1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
|
# SPDX-License-Identifier: AGPL-3.0-or-later
"""
Test module for custom middleware.
"""
from unittest.mock import MagicMock, Mock, call, patch
import pytest
from django.contrib.auth.models import AnonymousUser, Group, User
from django.core.exceptions import PermissionDenied
from django.db.utils import OperationalError
from django.http import (Http404, HttpResponse, HttpResponseNotAllowed,
HttpResponseRedirect)
from django.test.client import RequestFactory
from django.urls import resolve
from stronghold.decorators import public
from plinth import app as app_module
from plinth.middleware import (AdminRequiredMiddleware, CommonErrorMiddleware,
SetupMiddleware)
@pytest.fixture(name='kwargs')
def fixture_kwargs():
"""Fixture for returning kwargs for creating middleware."""
return {
'view_func': HttpResponse,
'view_args': [],
'view_kwargs': {},
}
@pytest.fixture(name='app')
def fixture_app():
"""Fixture for returning a test app."""
class AppTest(app_module.App):
"""Test app."""
app_id = 'mockapp'
def __init__(self):
"""Add info component."""
super().__init__()
self.add(app_module.Info('mockapp', version=1))
def get_setup_state(self):
return app_module.App.SetupState.NEEDS_SETUP
app_module.App._all_apps = {}
return AppTest()
class TestSetupMiddleware:
"""Test cases for setup middleware."""
@staticmethod
@pytest.fixture(name='middleware')
def fixture_middleware(load_cfg):
"""Fixture for returning middleware."""
return SetupMiddleware(True)
@staticmethod
@patch('django.urls.reverse', return_value='users:login')
def test_404_urls(reverse, middleware, kwargs):
"""Test how middleware deals with 404 URLs."""
request = RequestFactory().get('/plinth/non-existing-url')
response = middleware.process_view(request, **kwargs)
assert response is None
@staticmethod
@patch('django.urls.reverse', return_value='users:login')
def test_url_not_an_application(reverse, middleware, kwargs):
"""Test that none is returned for URLs that are not applications."""
request = RequestFactory().get('/plinth/')
response = middleware.process_view(request, **kwargs)
assert response is None
@staticmethod
@patch('django.urls.resolve')
@patch('django.urls.reverse', return_value='users:login')
def test_module_is_up_to_date(_reverse, resolve, app, middleware, kwargs):
"""Test that none is returned when module is up-to-date."""
resolve.return_value.namespaces = ['mockapp']
app.get_setup_state = lambda: app_module.App.SetupState.UP_TO_DATE
request = RequestFactory().get('/plinth/mockapp')
request.user = AnonymousUser()
response = middleware.process_view(request, **kwargs)
assert response is None
@staticmethod
@patch('plinth.views.SetupView')
@patch('django.urls.resolve')
@patch('django.urls.reverse', return_value='users:login')
@pytest.mark.django_db
def test_module_view(_reverse, resolve, setup_view, app, middleware,
kwargs):
"""Test that only registered users can access the setup view."""
resolve.return_value.namespaces = ['mockapp']
view = Mock()
setup_view.as_view.return_value = view
request = RequestFactory().get('/plinth/mockapp')
request.session = MagicMock()
# Verify that anonymous users cannot access the setup page
request.user = AnonymousUser()
with pytest.raises(PermissionDenied):
middleware.process_view(request, **kwargs)
setup_view.as_view.assert_not_called()
view.assert_not_called()
# Verify that non-admin logged-in users can't access the setup page
user = User(username='johndoe')
user.save()
request.user = user
with pytest.raises(PermissionDenied):
middleware.process_view(request, **kwargs)
setup_view.as_view.assert_not_called()
view.assert_not_called()
# Verify that admin logged-in users can access the setup page
user = User(username='adminuser')
user.save()
group = Group(name='admin')
group.save()
user.groups.add(group)
user.save()
request.user = user
middleware.process_view(request, **kwargs)
setup_view.as_view.assert_called_once_with()
view.assert_called_once_with(request, app_id='mockapp')
@staticmethod
@patch('plinth.operation.manager')
@patch('django.contrib.messages.error')
@patch('django.contrib.messages.success')
@patch('django.urls.resolve')
@patch('django.urls.reverse', return_value='users:login')
@pytest.mark.django_db
def test_install_result_collection(reverse, resolve, messages_success,
messages_error, operation_manager, app,
middleware, kwargs):
"""Test that module installation result is collected properly."""
resolve.return_value.namespaces = ['mockapp']
operation_manager.collect_results.return_value = [
Mock(translated_message='message1', exception=None),
Mock(translated_message='message2',
exception=RuntimeError('x-exception'))
]
app.get_setup_state = lambda: app_module.App.SetupState.UP_TO_DATE
# Admin user can collect result
request = RequestFactory().get('/plinth/mockapp')
request.resolver_match = Mock()
user = User(username='adminuser')
user.save()
group = Group(name='admin')
group.save()
user.groups.add(group)
user.save()
request.user = user
request.session = MagicMock()
response = middleware.process_view(request, **kwargs)
assert response is None
messages_success.assert_has_calls([call(request, 'message1')])
messages_error.assert_called_once()
assert messages_error.call_args.args[0] == request
assert messages_error.call_args.args[1].startswith('message2')
operation_manager.collect_results.assert_has_calls([call('mockapp')])
# Non-admin user can't collect result
messages_success.reset_mock()
messages_error.reset_mock()
operation_manager.collect_results.reset_mock()
request = RequestFactory().get('/plinth/mockapp')
user = User(username='johndoe')
user.save()
request.user = user
request.session = MagicMock()
response = middleware.process_view(request, **kwargs)
assert response is None
assert not messages_success.called
assert not messages_error.called
operation_manager.collect_results.assert_not_called()
class TestAdminMiddleware:
"""Test cases for admin middleware."""
@staticmethod
@pytest.fixture(name='middleware')
def fixture_middleware(load_cfg):
"""Fixture for returning middleware."""
return AdminRequiredMiddleware(True)
@staticmethod
@pytest.fixture(name='web_request')
def fixture_web_request():
"""Fixture for returning kwargs."""
web_request = RequestFactory().get('/plinth/mockapp')
web_request.user = Mock()
return web_request
@staticmethod
def test_that_admin_view_is_denied_for_usual_user(web_request, middleware,
kwargs):
"""Test that normal user is denied for an admin view"""
web_request.user.groups.filter().exists = Mock(return_value=False)
web_request.session = MagicMock()
with pytest.raises(PermissionDenied):
middleware.process_view(web_request, **kwargs)
@staticmethod
def test_group_view_is_denied_for_non_group_user(web_request, middleware,
kwargs):
"""Test that group view is allowed for an admin user."""
web_request.user.groups.filter().exists = Mock(return_value=False)
web_request.session = MagicMock()
with patch(
'plinth.middleware.AdminRequiredMiddleware.check_user_group',
lambda x, y: False):
with pytest.raises(PermissionDenied):
middleware.process_view(web_request, **kwargs)
@staticmethod
def test_group_view_is_allowed_for_group_user(web_request, middleware,
kwargs):
"""Test that group view is allowed for an admin user."""
web_request.user.groups.filter().exists = Mock(return_value=False)
web_request.session = MagicMock()
with patch(
'plinth.middleware.AdminRequiredMiddleware.check_user_group',
lambda x, y: True):
response = middleware.process_view(web_request, **kwargs)
assert response is None
@staticmethod
def test_that_admin_view_is_allowed_for_admin_user(web_request, middleware,
kwargs):
"""Test that admin user is allowed for an admin view"""
web_request.user.groups.filter().exists = Mock(return_value=True)
web_request.session = MagicMock()
response = middleware.process_view(web_request, **kwargs)
assert response is None
@staticmethod
def test_that_public_view_is_allowed_for_normal_user(
web_request, middleware, kwargs):
"""Test that normal user is allowed for an public view"""
kwargs = dict(kwargs)
kwargs['view_func'] = public(HttpResponse)
response = middleware.process_view(web_request, **kwargs)
assert response is None
class TestCommonErrorMiddleware:
"""Test cases for common error middleware."""
@staticmethod
@pytest.fixture(name='middleware')
def fixture_middleware(load_cfg):
"""Fixture for returning middleware."""
return CommonErrorMiddleware(True)
@staticmethod
@pytest.fixture(name='web_request')
def fixture_web_request():
"""Fixture for returning web request."""
web_request = RequestFactory().get('/apps/testapp/')
web_request.resolver_match = resolve('/apps/testapp/')
web_request.user = Mock()
return web_request
@staticmethod
@pytest.fixture(name='operational_error')
def fixture_operational_error():
"""Fixture for returning an OperationalError."""
return OperationalError()
@staticmethod
@pytest.fixture(name='other_error')
def fixture_other_error():
"""Fixture for returning a different type of error."""
return IndexError()
@staticmethod
def test_operational_error(middleware, web_request, operational_error):
response = middleware.process_exception(web_request, operational_error)
assert response.template_name == 'error.html'
assert 'message' in response.context_data
@staticmethod
@patch('django.contrib.messages.error')
def test_404_error_get(messages_error, middleware, web_request, test_menu):
"""Test that 404 page not found errors are handled."""
response = middleware.process_exception(web_request, Http404())
assert isinstance(response, HttpResponseRedirect)
assert response.url == '/apps/'
messages_error.assert_called_once()
assert messages_error.call_args.args[0] == web_request
assert messages_error.call_args.args[1].startswith(
'Page not found: /apps/testapp/')
@staticmethod
@patch('django.contrib.messages.error')
def test_other_error_get(messages_error, middleware, web_request,
other_error, test_menu):
response = middleware.process_exception(web_request, other_error)
assert isinstance(response, HttpResponseRedirect)
assert response.url == '/apps/'
messages_error.assert_called_once()
assert messages_error.call_args.args[0] == web_request
assert messages_error.call_args.args[1].startswith(
'Error loading page.')
@staticmethod
@patch('django.contrib.messages.error')
def test_other_error_post(messages_error, middleware, web_request,
other_error, test_menu):
web_request.method = 'POST'
response = middleware.process_exception(web_request, other_error)
assert isinstance(response, HttpResponseRedirect)
assert response.url == '/apps/testapp/'
messages_error.assert_called_once()
assert messages_error.call_args.args[0] == web_request
assert messages_error.call_args.args[1].startswith(
'Error running operation.')
@staticmethod
@patch('django.contrib.messages.error')
def test_other_error_index(messages_error, middleware, web_request,
other_error, test_menu):
web_request.path = '/'
web_request.resolver_match = resolve('/')
response = middleware.process_exception(web_request, other_error)
assert not response
messages_error.assert_not_called()
@staticmethod
@patch('django.contrib.messages.error')
def test_405_error(messages_error, middleware, web_request, test_menu):
"""Test that method not allowed errors are handled."""
response = middleware.process_response(
web_request, HttpResponseNotAllowed(['POST']))
assert isinstance(response, HttpResponseRedirect)
assert response.url == '/apps/'
messages_error.assert_not_called()
|