File: keyring_test.go

package info (click to toggle)
fscrypt 0.3.5-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 1,064 kB
  • sloc: sh: 970; makefile: 159; ansic: 84
file content (330 lines) | stat: -rw-r--r-- 10,851 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
/*
 * keyring_test.go - tests for the keyring package
 *
 * Copyright 2017 Google Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not
 * use this file except in compliance with the License. You may obtain a copy of
 * the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations under
 * the License.
 */

package keyring

import (
	"os/user"
	"strconv"
	"testing"

	"github.com/google/fscrypt/crypto"
	"github.com/google/fscrypt/filesystem"
	"github.com/google/fscrypt/metadata"
	"github.com/google/fscrypt/util"
)

// Reader that always returns the same byte
type ConstReader byte

func (r ConstReader) Read(b []byte) (n int, err error) {
	for i := range b {
		b[i] = byte(r)
	}
	return len(b), nil
}

// Makes a key of the same repeating byte
func makeKey(b byte, n int) (*crypto.Key, error) {
	return crypto.NewFixedLengthKeyFromReader(ConstReader(b), n)
}

var (
	testUser, _             = util.EffectiveUser()
	fakeValidPolicyKey, _   = makeKey(42, metadata.PolicyKeyLen)
	fakeInvalidPolicyKey, _ = makeKey(42, metadata.PolicyKeyLen-1)
	fakeV1Descriptor        = "0123456789abcdef"
	fakeV2Descriptor, _     = crypto.ComputeKeyDescriptor(fakeValidPolicyKey, 2)
)

func assertKeyStatus(t *testing.T, descriptor string, options *Options,
	expectedStatus KeyStatus) {
	status, err := GetEncryptionKeyStatus(descriptor, options)
	if err != nil {
		t.Error(err)
	}
	if status != expectedStatus {
		t.Errorf("Expected key status %v but got key status %v", expectedStatus, status)
	}
}

// getTestMount retrieves the Mount for a test filesystem, or skips the test if
// no test filesystem is available.
func getTestMount(t *testing.T) *filesystem.Mount {
	root, err := util.TestRoot()
	if err != nil {
		t.Skip(err)
	}
	mount, err := filesystem.GetMount(root)
	if err != nil {
		t.Skip(err)
	}
	return mount
}

// getTestMountV2 is like getTestMount, but it also checks that the
// filesystem keyring and v2 encryption policies are supported.
func getTestMountV2(t *testing.T) *filesystem.Mount {
	mount := getTestMount(t)
	if !IsFsKeyringSupported(mount) {
		t.Skip("No support for fs keyring, skipping test.")
	}
	return mount
}

func requireRoot(t *testing.T) {
	if !util.IsUserRoot() {
		t.Skip("Not root, skipping test.")
	}
}

// getNonRootUsers checks for root permission, then returns the users for uids
// 1000...1000+count-1.  If this fails, the test is skipped.
func getNonRootUsers(t *testing.T, count int) []*user.User {
	requireRoot(t)
	users := make([]*user.User, count)
	for i := 0; i < count; i++ {
		uid := 1000 + i
		user, err := user.LookupId(strconv.Itoa(uid))
		if err != nil {
			t.Skip(err)
		}
		users[i] = user
	}
	return users
}

func getOptionsForFsKeyringUsers(t *testing.T, numNonRootUsers int) (rootOptions *Options, userOptions []*Options) {
	mount := getTestMountV2(t)
	nonRootUsers := getNonRootUsers(t, numNonRootUsers)
	rootOptions = &Options{
		Mount: mount,
		User:  testUser,
	}
	userOptions = make([]*Options, numNonRootUsers)
	for i := 0; i < numNonRootUsers; i++ {
		userOptions[i] = &Options{
			Mount: mount,
			User:  nonRootUsers[i],
		}
	}
	return
}

// testAddAndRemoveKey does the common tests for adding+removing keys that are
// run in multiple configurations (v1 policies with user keyring, v1 policies
// with fs keyring, and v2 policies with fs keyring).
func testAddAndRemoveKey(t *testing.T, descriptor string, options *Options) {

	// Basic add, get status, and remove
	if err := AddEncryptionKey(fakeValidPolicyKey, descriptor, options); err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, descriptor, options, KeyPresent)
	if err := RemoveEncryptionKey(descriptor, options, false); err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, descriptor, options, KeyAbsent)
	err := RemoveEncryptionKey(descriptor, options, false)
	if err != ErrKeyNotPresent {
		t.Error(err)
	}

	// Adding a key twice should succeed
	if err := AddEncryptionKey(fakeValidPolicyKey, descriptor, options); err != nil {
		t.Error(err)
	}
	if err := AddEncryptionKey(fakeValidPolicyKey, descriptor, options); err != nil {
		t.Error("AddEncryptionKey should not fail if key already exists")
	}
	RemoveEncryptionKey(descriptor, options, false)
	assertKeyStatus(t, descriptor, options, KeyAbsent)

	// Adding a key with wrong length should fail
	if err := AddEncryptionKey(fakeInvalidPolicyKey, descriptor, options); err == nil {
		RemoveEncryptionKey(descriptor, options, false)
		t.Error("AddEncryptionKey should fail with wrong-length key")
	}
	assertKeyStatus(t, descriptor, options, KeyAbsent)
}

func TestUserKeyring(t *testing.T) {
	mount := getTestMount(t)
	options := &Options{
		Mount:                     mount,
		User:                      testUser,
		UseFsKeyringForV1Policies: false,
	}
	testAddAndRemoveKey(t, fakeV1Descriptor, options)
}

func TestFsKeyringV1PolicyKey(t *testing.T) {
	requireRoot(t)
	mount := getTestMountV2(t)
	options := &Options{
		Mount:                     mount,
		User:                      testUser,
		UseFsKeyringForV1Policies: true,
	}
	testAddAndRemoveKey(t, fakeV1Descriptor, options)
}

func TestV2PolicyKey(t *testing.T) {
	mount := getTestMountV2(t)
	options := &Options{
		Mount: mount,
		User:  testUser,
	}
	testAddAndRemoveKey(t, fakeV2Descriptor, options)
}

func TestV2PolicyKeyCannotBeRemovedByAnotherUser(t *testing.T) {
	rootOptions, userOptions := getOptionsForFsKeyringUsers(t, 2)
	user1Options := userOptions[0]
	user2Options := userOptions[1]

	// Add key as non-root user.
	if err := AddEncryptionKey(fakeValidPolicyKey, fakeV2Descriptor, user1Options); err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyPresentButOnlyOtherUsers)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyPresentButOnlyOtherUsers)

	// Key shouldn't be removable by another user, even root.
	err := RemoveEncryptionKey(fakeV2Descriptor, user2Options, false)
	if err != ErrKeyAddedByOtherUsers {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyPresentButOnlyOtherUsers)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyPresentButOnlyOtherUsers)
	err = RemoveEncryptionKey(fakeV2Descriptor, rootOptions, false)
	if err != ErrKeyAddedByOtherUsers {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyPresentButOnlyOtherUsers)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyPresentButOnlyOtherUsers)

	if err := RemoveEncryptionKey(fakeV2Descriptor, user1Options, false); err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyAbsent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyAbsent)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyAbsent)
}

func TestV2PolicyKeyMultipleUsers(t *testing.T) {
	rootOptions, userOptions := getOptionsForFsKeyringUsers(t, 2)
	user1Options := userOptions[0]
	user2Options := userOptions[1]

	// Add key as two non-root users.
	if err := AddEncryptionKey(fakeValidPolicyKey, fakeV2Descriptor, user1Options); err != nil {
		t.Error(err)
	}
	if err := AddEncryptionKey(fakeValidPolicyKey, fakeV2Descriptor, user2Options); err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyPresentButOnlyOtherUsers)

	// Remove key as one user.
	err := RemoveEncryptionKey(fakeV2Descriptor, user1Options, false)
	if err != ErrKeyAddedByOtherUsers {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyPresentButOnlyOtherUsers)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyPresentButOnlyOtherUsers)

	// Remove key as the other user.
	err = RemoveEncryptionKey(fakeV2Descriptor, user2Options, false)
	if err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyAbsent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyAbsent)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyAbsent)
}

func TestV2PolicyKeyWrongDescriptor(t *testing.T) {
	mount := getTestMountV2(t)
	options := &Options{
		Mount: mount,
		User:  testUser,
	}
	// one wrong but valid hex, and one not valid hex
	wrongV2Descriptors := []string{"abcdabcdabcdabcdabcdabcdabcdabcd", "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"}

	for _, desc := range wrongV2Descriptors {
		if err := AddEncryptionKey(fakeValidPolicyKey, desc, options); err == nil {
			RemoveEncryptionKey(desc, options, false)
			t.Error("For v2 policy keys, AddEncryptionKey should fail if the descriptor is wrong")
		}
	}
}

func TestV2PolicyKeyBadMount(t *testing.T) {
	options := &Options{
		Mount: &filesystem.Mount{Path: "/NONEXISTENT_MOUNT"},
		User:  testUser,
	}
	if err := AddEncryptionKey(fakeValidPolicyKey, fakeV2Descriptor, options); err == nil {
		RemoveEncryptionKey(fakeV2Descriptor, options, false)
		t.Error("AddEncryptionKey should have failed with bad mount!")
	}
	if err := RemoveEncryptionKey(fakeV2Descriptor, options, false); err == nil {
		t.Error("RemoveEncryptionKey should have failed with bad mount!")
	}
	status, err := GetEncryptionKeyStatus(fakeV2Descriptor, options)
	if err == nil {
		t.Error("GetEncryptionKeyStatus should have failed with bad mount!")
	}
	if status != KeyStatusUnknown {
		t.Error("GetEncryptionKeyStatus should have returned unknown status!")
	}
}

func TestV2PolicyKeyRemoveForAllUsers(t *testing.T) {
	rootOptions, userOptions := getOptionsForFsKeyringUsers(t, 2)
	user1Options := userOptions[0]
	user2Options := userOptions[1]

	// Add key as two non-root users.
	if err := AddEncryptionKey(fakeValidPolicyKey, fakeV2Descriptor, user1Options); err != nil {
		t.Error(err)
	}
	if err := AddEncryptionKey(fakeValidPolicyKey, fakeV2Descriptor, user2Options); err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyPresent)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyPresentButOnlyOtherUsers)

	// Remove key for all users as root.
	err := RemoveEncryptionKey(fakeV2Descriptor, rootOptions, true)
	if err != nil {
		t.Error(err)
	}
	assertKeyStatus(t, fakeV2Descriptor, user1Options, KeyAbsent)
	assertKeyStatus(t, fakeV2Descriptor, user2Options, KeyAbsent)
	assertKeyStatus(t, fakeV2Descriptor, rootOptions, KeyAbsent)
}