1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
|
###############################################
################### NOTES #####################
###############################################
1) logging
1.1) ff_log() and ff_vlog() must check if log subsystem is not initialized, and in case initialize it.
removes the need to manually call ff_log_init()
1.2) ff_log(err) must distinguish between unreported (not yet logged) and reported (already logged) errors.
the former have normal sign (EINVAL, ENOMEM...) and are reported normally,
the latter have opposite sign (-EINVAL, -ENOMEM...) and are reported as " (caused by previous error: %s)"
1.2.1) ff_log() and ff_vlog() always return errors as reported (-EINVAL, -ENOMEM...)
1.2.2) ft_remap.main() and other high-level *.main() methods
must check for unreported errors and log them them with message
"failed with unreported error"
1.3) configurable log format:
FC_FMT_MSG, // message only
FC_FMT_LEVEL_MSG, // level + message
FC_FMT_DATETIME_LEVEL_MSG, // datetime + level + message
FC_FMT_DATETIME_LEVEL_CALLER_MSG, // datetime + level + [file.func(line)] + message
1.4.1) -v enables FC_FMT_LEVEL_MSG also for stdout/stderr
1.4.2) -vv enables FC_FMT_DATETIME_LEVEL_MSG also for stdout/stderr
1.4.3) instead fsremap.log always uses FC_FMT_DATETIME_LEVEL_CALLER_MSG
1.5) more log(DEBUG) in io_posix.read_extents()
2) io.copy() and io.flush() queueing is managed by io, not its subclasses,
Overflow checks must be performed by the queueing methods in io.
3) -n, --dry-run options to run everything normally (including which I/O to use),
except that extents relocation does not read/write on disk
problem: still create secondary storage? yes, but create it sparse
4) mlock(primary_storage). without it we get a lot of disk thrashing,
but even with it disk I/O is not fully sequential.
An alternative would be not to mmap() at all primary_storage,
and maybe neither secondary_storage
5) fsremap must correctly handle the case where device_len and/or loop_file_len
are not multiples of effective block size
and file-system in loop_file uses a smaller block size than file-system in device
PARTIALLY implemented: fstransform creates a loop_file that is always multiple
of device block size. In this way, fsremap will not have problems.
6) some ioctl(FIEMAP) implementations are strange (buggy?) and refuse
to return more than a certain number of extents (approx. 1300)
in a single call.
if this case happens, fsremap MUST detect that the returned extents
are incomplete, log the problem, and work around it
- currently, fsremap switches to ioctl(FIBMAP) if it happens.
7) fsmove MUST preemptively check for DISK ALMOST FULL conditions
on {source-device} and {target-device}
Checking for I/O errors during the copy is NOT enough: Linux loop devices
created on top of sparse files (the case we exploit) do NOT report ANY error
when writing to the backing sparse file fails because of disk full,
but only write the I/O error to kernel messages (dmesg).
###############################################
################### TO DO #####################
###############################################
* bug? primary storage sometimes too small
|
