1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596
|
/* Self tests for enum-flags for GDB, the GNU debugger.
Copyright (C) 2016-2023 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "gdbsupport/enum-flags.h"
#include "gdbsupport/valid-expr.h"
#include "gdbsupport/selftest.h"
namespace selftests {
namespace enum_flags_tests {
/* The (real) enum types used in CHECK_VALID. Their names match the
template parameter names of the templates defined by CHECK_VALID to
make it simpler to use. They could be named differently. */
/* A "real enum". */
enum RE
{
RE_FLAG1 = 1 << 1,
RE_FLAG2 = 1 << 2,
};
/* Another "real enum". */
enum RE2
{
RE2_FLAG1 = 1 << 1,
RE2_FLAG2 = 1 << 2,
};
/* An unsigned "real enum". */
enum URE : unsigned
{
URE_FLAG1 = 1 << 1,
URE_FLAG2 = 1 << 2,
URE_FLAG3 = 0xffffffff,
};
/* A non-flags enum. */
enum NF
{
NF_FLAG1 = 1 << 1,
NF_FLAG2 = 1 << 2,
};
/* The corresponding "enum flags" types. */
DEF_ENUM_FLAGS_TYPE (RE, EF);
DEF_ENUM_FLAGS_TYPE (RE2, EF2);
DEF_ENUM_FLAGS_TYPE (URE, UEF);
#if HAVE_IS_TRIVIALLY_COPYABLE
/* So that std::vectors of types that have enum_flags fields can
reallocate efficiently memcpy. */
gdb_static_assert (std::is_trivially_copyable<EF>::value);
#endif
/* A couple globals used as lvalues in the CHECK_VALID expressions
below. Their names (and types) match the uppercase type names
exposed by CHECK_VALID just to make the expressions easier to
follow. */
static RE re ATTRIBUTE_UNUSED;
static EF ef ATTRIBUTE_UNUSED;
/* First, compile-time tests that:
- make sure that incorrect operations with mismatching enum types
are caught at compile time.
- make sure that the same operations but involving the right enum
types do compile and that they return the correct type.
*/
#define CHECK_VALID(VALID, EXPR_TYPE, EXPR) \
CHECK_VALID_EXPR_6 (EF, RE, EF2, RE2, UEF, URE, VALID, EXPR_TYPE, EXPR)
typedef std::underlying_type<RE>::type und;
/* Test construction / conversion from/to different types. */
/* RE/EF -> underlying (explicit) */
CHECK_VALID (true, und, und (RE ()))
CHECK_VALID (true, und, und (EF ()))
/* RE/EF -> int (explicit) */
CHECK_VALID (true, int, int (RE ()))
CHECK_VALID (true, int, int (EF ()))
/* other -> RE */
/* You can construct a raw enum value from an int explicitly to punch
a hole in the type system if need to. */
CHECK_VALID (true, RE, RE (1))
CHECK_VALID (true, RE, RE (RE2 ()))
CHECK_VALID (false, void, RE (EF2 ()))
CHECK_VALID (true, RE, RE (RE ()))
CHECK_VALID (false, void, RE (EF ()))
/* other -> EF. */
/* As expected, enum-flags is a stronger type than the backing raw
enum. Unlike with raw enums, you can't construct an enum flags
from an integer nor from an unrelated enum type explicitly. Add an
intermediate conversion via the raw enum if you really need it. */
CHECK_VALID (false, void, EF (1))
CHECK_VALID (false, void, EF (1u))
CHECK_VALID (false, void, EF (RE2 ()))
CHECK_VALID (false, void, EF (EF2 ()))
CHECK_VALID (true, EF, EF (RE ()))
CHECK_VALID (true, EF, EF (EF ()))
/* Test operators. */
/* operator OP (raw_enum, int) */
CHECK_VALID (false, void, RE () | 1)
CHECK_VALID (false, void, RE () & 1)
CHECK_VALID (false, void, RE () ^ 1)
/* operator OP (int, raw_enum) */
CHECK_VALID (false, void, 1 | RE ())
CHECK_VALID (false, void, 1 & RE ())
CHECK_VALID (false, void, 1 ^ RE ())
/* operator OP (enum_flags, int) */
CHECK_VALID (false, void, EF () | 1)
CHECK_VALID (false, void, EF () & 1)
CHECK_VALID (false, void, EF () ^ 1)
/* operator OP (int, enum_flags) */
CHECK_VALID (false, void, 1 | EF ())
CHECK_VALID (false, void, 1 & EF ())
CHECK_VALID (false, void, 1 ^ EF ())
/* operator OP (raw_enum, raw_enum) */
CHECK_VALID (false, void, RE () | RE2 ())
CHECK_VALID (false, void, RE () & RE2 ())
CHECK_VALID (false, void, RE () ^ RE2 ())
CHECK_VALID (true, RE, RE () | RE ())
CHECK_VALID (true, RE, RE () & RE ())
CHECK_VALID (true, RE, RE () ^ RE ())
/* operator OP (enum_flags, raw_enum) */
CHECK_VALID (false, void, EF () | RE2 ())
CHECK_VALID (false, void, EF () & RE2 ())
CHECK_VALID (false, void, EF () ^ RE2 ())
CHECK_VALID (true, EF, EF () | RE ())
CHECK_VALID (true, EF, EF () & RE ())
CHECK_VALID (true, EF, EF () ^ RE ())
/* operator OP= (raw_enum, raw_enum), rvalue ref on the lhs. */
CHECK_VALID (false, void, RE () |= RE2 ())
CHECK_VALID (false, void, RE () &= RE2 ())
CHECK_VALID (false, void, RE () ^= RE2 ())
CHECK_VALID (false, void, RE () |= RE ())
CHECK_VALID (false, void, RE () &= RE ())
CHECK_VALID (false, void, RE () ^= RE ())
/* operator OP= (raw_enum, raw_enum), lvalue ref on the lhs. */
CHECK_VALID (false, void, re |= RE2 ())
CHECK_VALID (false, void, re &= RE2 ())
CHECK_VALID (false, void, re ^= RE2 ())
CHECK_VALID (true, RE&, re |= RE ())
CHECK_VALID (true, RE&, re &= RE ())
CHECK_VALID (true, RE&, re ^= RE ())
/* operator OP= (enum_flags, raw_enum), rvalue ref on the lhs. */
CHECK_VALID (false, void, EF () |= RE2 ())
CHECK_VALID (false, void, EF () &= RE2 ())
CHECK_VALID (false, void, EF () ^= RE2 ())
CHECK_VALID (false, void, EF () |= RE ())
CHECK_VALID (false, void, EF () &= RE ())
CHECK_VALID (false, void, EF () ^= RE ())
/* operator OP= (enum_flags, raw_enum), lvalue ref on the lhs. */
CHECK_VALID (false, void, ef |= RE2 ())
CHECK_VALID (false, void, ef &= RE2 ())
CHECK_VALID (false, void, ef ^= RE2 ())
CHECK_VALID (true, EF&, ef |= EF ())
CHECK_VALID (true, EF&, ef &= EF ())
CHECK_VALID (true, EF&, ef ^= EF ())
/* operator OP= (enum_flags, enum_flags), rvalue ref on the lhs. */
CHECK_VALID (false, void, EF () |= EF2 ())
CHECK_VALID (false, void, EF () &= EF2 ())
CHECK_VALID (false, void, EF () ^= EF2 ())
CHECK_VALID (false, void, EF () |= EF ())
CHECK_VALID (false, void, EF () &= EF ())
CHECK_VALID (false, void, EF () ^= EF ())
/* operator OP= (enum_flags, enum_flags), lvalue ref on the lhs. */
CHECK_VALID (false, void, ef |= EF2 ())
CHECK_VALID (false, void, ef &= EF2 ())
CHECK_VALID (false, void, ef ^= EF2 ())
CHECK_VALID (true, EF&, ef |= EF ())
CHECK_VALID (true, EF&, ef &= EF ())
CHECK_VALID (true, EF&, ef ^= EF ())
/* operator~ (raw_enum) */
CHECK_VALID (false, void, ~RE ())
CHECK_VALID (true, URE, ~URE ())
/* operator~ (enum_flags) */
CHECK_VALID (false, void, ~EF ())
CHECK_VALID (true, UEF, ~UEF ())
/* Check ternary operator. This exercises implicit conversions. */
CHECK_VALID (true, EF, true ? EF () : RE ())
CHECK_VALID (true, EF, true ? RE () : EF ())
/* These are valid, but it's not a big deal since you won't be able to
assign the resulting integer to an enum or an enum_flags without a
cast.
The latter two tests are disabled on older GCCs because they
incorrectly fail with gcc 4.8 and 4.9 at least. Running the test
outside a SFINAE context shows:
invalid user-defined conversion from ‘EF’ to ‘RE2’
They've been confirmed to compile/pass with gcc 5.3, gcc 7.1 and
clang 3.7. */
CHECK_VALID (true, int, true ? EF () : EF2 ())
CHECK_VALID (true, int, true ? EF2 () : EF ())
#if GCC_VERSION >= 5003 || defined __clang__
CHECK_VALID (true, int, true ? EF () : RE2 ())
CHECK_VALID (true, int, true ? RE2 () : EF ())
#endif
/* Same, but with an unsigned enum. */
typedef unsigned int uns;
CHECK_VALID (true, uns, true ? EF () : UEF ())
CHECK_VALID (true, uns, true ? UEF () : EF ())
#if GCC_VERSION >= 5003 || defined __clang__
CHECK_VALID (true, uns, true ? EF () : URE ())
CHECK_VALID (true, uns, true ? URE () : EF ())
#endif
/* Unfortunately this can't work due to the way C++ computes the
return type of the ternary conditional operator. int isn't
implicitly convertible to the raw enum type, so the type of the
expression is int. And then int is not implicitly convertible to
enum_flags.
GCC 4.8 fails to compile this test with:
error: operands to ?: have different types ‘enum_flags<RE>’ and ‘int’
Confirmed to work with gcc 4.9, 5.3 and clang 3.7.
*/
#if GCC_VERSION >= 4009 || defined __clang__
CHECK_VALID (false, void, true ? EF () : 0)
CHECK_VALID (false, void, true ? 0 : EF ())
#endif
/* Check that the ++/--/<</>>/<<=/>>= operators are deleted. */
CHECK_VALID (false, void, RE ()++)
CHECK_VALID (false, void, ++RE ())
CHECK_VALID (false, void, --RE ())
CHECK_VALID (false, void, RE ()--)
CHECK_VALID (false, void, RE () << 1)
CHECK_VALID (false, void, RE () >> 1)
CHECK_VALID (false, void, EF () << 1)
CHECK_VALID (false, void, EF () >> 1)
CHECK_VALID (false, void, RE () <<= 1)
CHECK_VALID (false, void, RE () >>= 1)
CHECK_VALID (false, void, EF () <<= 1)
CHECK_VALID (false, void, EF () >>= 1)
/* Test comparison operators. */
CHECK_VALID (false, void, EF () == EF2 ())
CHECK_VALID (false, void, EF () == RE2 ())
CHECK_VALID (false, void, RE () == EF2 ())
CHECK_VALID (true, bool, EF (RE (1)) == EF (RE (1)))
CHECK_VALID (true, bool, EF (RE (1)) == RE (1))
CHECK_VALID (true, bool, RE (1) == EF (RE (1)))
CHECK_VALID (false, void, EF () != EF2 ())
CHECK_VALID (false, void, EF () != RE2 ())
CHECK_VALID (false, void, RE () != EF2 ())
/* Disable -Wenum-compare due to:
Clang:
"error: comparison of two values with different enumeration types
[-Werror,-Wenum-compare]"
GCC:
"error: comparison between ‘enum selftests::enum_flags_tests::RE’
and ‘enum selftests::enum_flags_tests::RE2’
[-Werror=enum-compare]"
Not a big deal since misuses like these in GDB will be caught by
-Werror anyway. This check is here mainly for completeness. */
#if defined __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wenum-compare"
#endif
CHECK_VALID (true, bool, RE () == RE2 ())
CHECK_VALID (true, bool, RE () != RE2 ())
#if defined __GNUC__
# pragma GCC diagnostic pop
#endif
CHECK_VALID (true, bool, EF (RE (1)) != EF (RE (2)))
CHECK_VALID (true, bool, EF (RE (1)) != RE (2))
CHECK_VALID (true, bool, RE (1) != EF (RE (2)))
CHECK_VALID (true, bool, EF () == 0)
/* Check we didn't disable/delete comparison between non-flags enums
and unrelated types by mistake. */
CHECK_VALID (true, bool, NF (1) == NF (1))
CHECK_VALID (true, bool, NF (1) == int (1))
CHECK_VALID (true, bool, NF (1) == char (1))
/* -------------------------------------------------------------------- */
/* Follows misc tests that exercise the API. Some are compile time,
when possible, others are run time. */
enum test_flag
{
FLAG1 = 1 << 1,
FLAG2 = 1 << 2,
FLAG3 = 1 << 3,
};
enum test_uflag : unsigned
{
UFLAG1 = 1 << 1,
UFLAG2 = 1 << 2,
UFLAG3 = 1 << 3,
};
DEF_ENUM_FLAGS_TYPE (test_flag, test_flags);
DEF_ENUM_FLAGS_TYPE (test_uflag, test_uflags);
static void
self_test ()
{
/* Check that default construction works. */
{
constexpr test_flags f;
gdb_static_assert (f == 0);
}
/* Check that assignment from zero works. */
{
test_flags f (FLAG1);
SELF_CHECK (f == FLAG1);
f = 0;
SELF_CHECK (f == 0);
}
/* Check that construction from zero works. */
{
constexpr test_flags zero1 = 0;
constexpr test_flags zero2 (0);
constexpr test_flags zero3 {0};
constexpr test_flags zero4 = {0};
gdb_static_assert (zero1 == 0);
gdb_static_assert (zero2 == 0);
gdb_static_assert (zero3 == 0);
gdb_static_assert (zero4 == 0);
}
/* Check construction from enum value. */
{
gdb_static_assert (test_flags (FLAG1) == FLAG1);
gdb_static_assert (test_flags (FLAG2) != FLAG1);
}
/* Check copy/assignment. */
{
constexpr test_flags src = FLAG1;
constexpr test_flags f1 = src;
constexpr test_flags f2 (src);
constexpr test_flags f3 {src};
constexpr test_flags f4 = {src};
gdb_static_assert (f1 == FLAG1);
gdb_static_assert (f2 == FLAG1);
gdb_static_assert (f3 == FLAG1);
gdb_static_assert (f4 == FLAG1);
}
/* Check moving. */
{
test_flags src = FLAG1;
test_flags dst = 0;
dst = std::move (src);
SELF_CHECK (dst == FLAG1);
}
/* Check construction from an 'or' of multiple bits. For this to
work, operator| must be overridden to return an enum type. The
builtin version would return int instead and then the conversion
to test_flags would fail. */
{
constexpr test_flags f = FLAG1 | FLAG2;
gdb_static_assert (f == (FLAG1 | FLAG2));
}
/* Similarly, check that "FLAG1 | FLAG2" on the rhs of an assignment
operator works. */
{
test_flags f = 0;
f |= FLAG1 | FLAG2;
SELF_CHECK (f == (FLAG1 | FLAG2));
f &= FLAG1 | FLAG2;
SELF_CHECK (f == (FLAG1 | FLAG2));
f ^= FLAG1 | FLAG2;
SELF_CHECK (f == 0);
}
/* Check explicit conversion to int works. */
{
constexpr int some_bits (FLAG1 | FLAG2);
/* And comparison with int works too. */
gdb_static_assert (some_bits == (FLAG1 | FLAG2));
gdb_static_assert (some_bits == test_flags (FLAG1 | FLAG2));
}
/* Check operator| and operator|=. Particularly interesting is
making sure that putting the enum value on the lhs side of the
expression works (FLAG | f). */
{
test_flags f = FLAG1;
f |= FLAG2;
SELF_CHECK (f == (FLAG1 | FLAG2));
}
{
test_flags f = FLAG1;
f = f | FLAG2;
SELF_CHECK (f == (FLAG1 | FLAG2));
}
{
test_flags f = FLAG1;
f = FLAG2 | f;
SELF_CHECK (f == (FLAG1 | FLAG2));
}
/* Check the &/&= operators. */
{
test_flags f = FLAG1 & FLAG2;
SELF_CHECK (f == 0);
f = FLAG1 | FLAG2;
f &= FLAG2;
SELF_CHECK (f == FLAG2);
f = FLAG1 | FLAG2;
f = f & FLAG2;
SELF_CHECK (f == FLAG2);
f = FLAG1 | FLAG2;
f = FLAG2 & f;
SELF_CHECK (f == FLAG2);
}
/* Check the ^/^= operators. */
{
constexpr test_flags f = FLAG1 ^ FLAG2;
gdb_static_assert (f == (FLAG1 ^ FLAG2));
}
{
test_flags f = FLAG1 ^ FLAG2;
f ^= FLAG3;
SELF_CHECK (f == (FLAG1 | FLAG2 | FLAG3));
f = f ^ FLAG3;
SELF_CHECK (f == (FLAG1 | FLAG2));
f = FLAG3 ^ f;
SELF_CHECK (f == (FLAG1 | FLAG2 | FLAG3));
}
/* Check operator~. Note this only compiles with unsigned
flags. */
{
constexpr test_uflags f1 = ~UFLAG1;
constexpr test_uflags f2 = ~f1;
gdb_static_assert (f2 == UFLAG1);
}
/* Check the ternary operator. */
{
/* raw enum, raw enum */
constexpr test_flags f1 = true ? FLAG1 : FLAG2;
gdb_static_assert (f1 == FLAG1);
constexpr test_flags f2 = false ? FLAG1 : FLAG2;
gdb_static_assert (f2 == FLAG2);
}
{
/* enum flags, raw enum */
constexpr test_flags src = FLAG1;
constexpr test_flags f1 = true ? src : FLAG2;
gdb_static_assert (f1 == FLAG1);
constexpr test_flags f2 = false ? src : FLAG2;
gdb_static_assert (f2 == FLAG2);
}
{
/* enum flags, enum flags */
constexpr test_flags src1 = FLAG1;
constexpr test_flags src2 = FLAG2;
constexpr test_flags f1 = true ? src1 : src2;
gdb_static_assert (f1 == src1);
constexpr test_flags f2 = false ? src1 : src2;
gdb_static_assert (f2 == src2);
}
/* Check that we can use flags in switch expressions (requires
unambiguous conversion to integer). Also check that we can use
operator| in switch cases, where only constants are allowed.
This should work because operator| is constexpr. */
{
test_flags f = FLAG1 | FLAG2;
bool ok = false;
switch (f)
{
case FLAG1:
break;
case FLAG2:
break;
case FLAG1 | FLAG2:
ok = true;
break;
}
SELF_CHECK (ok);
}
}
} /* namespace enum_flags_tests */
} /* namespace selftests */
void _initialize_enum_flags_selftests ();
void
_initialize_enum_flags_selftests ()
{
selftests::register_test ("enum-flags",
selftests::enum_flags_tests::self_test);
}
|