1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767
|
package timefilter
import (
"testing"
"time"
)
func TestParseSince(t *testing.T) {
// Use America/Vancouver timezone for testing (UTC-7 or UTC-8 depending on DST)
loc, err := time.LoadLocation("America/Vancouver")
if err != nil {
t.Fatalf("Failed to load timezone: %v", err)
}
tests := []struct {
name string
input string
expectError bool
expectType string // "instant", "dateOnly", or "empty"
}{
{
name: "empty string",
input: "",
expectError: false,
expectType: "empty",
},
{
name: "RFC3339 with timezone",
input: "2025-08-11T01:00:00-07:00",
expectError: false,
expectType: "instant",
},
{
name: "RFC3339 UTC",
input: "2025-08-11T08:00:00Z",
expectError: false,
expectType: "instant",
},
{
name: "RFC3339 with nanoseconds",
input: "2025-08-11T01:00:00.123456789-07:00",
expectError: false,
expectType: "instant",
},
{
name: "date only YYYY-MM-DD",
input: "2025-08-11",
expectError: false,
expectType: "dateOnly",
},
{
name: "invalid format",
input: "2025/08/11",
expectError: true,
expectType: "",
},
{
name: "invalid date",
input: "2025-13-01",
expectError: true,
expectType: "",
},
{
name: "too short date",
input: "2025-8-1",
expectError: true,
expectType: "",
},
{
name: "too long date",
input: "2025-08-011",
expectError: true,
expectType: "",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result, err := parseTimeValue(tt.input, loc)
if tt.expectError {
if err == nil {
t.Errorf("Expected error but got none")
}
return
}
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
switch tt.expectType {
case "empty":
if !result.IsEmpty() {
t.Errorf("Expected empty result")
}
case "instant":
if result.instant == nil {
t.Errorf("Expected instant to be set")
}
if result.dateOnly != nil {
t.Errorf("Expected dateOnly to be nil")
}
case "dateOnly":
if result.dateOnly == nil {
t.Errorf("Expected dateOnly to be set")
}
if result.instant != nil {
t.Errorf("Expected instant to be nil")
}
}
})
}
}
func TestIncludeBySince(t *testing.T) {
// Use America/Vancouver timezone for testing (UTC-7 or UTC-8 depending on DST)
loc, err := time.LoadLocation("America/Vancouver")
if err != nil {
t.Fatalf("Failed to load timezone: %v", err)
}
// Test cases from the MVP document
tests := []struct {
name string
fileMtime string // local time
sinceArg string
expectInclude bool
}{
{
name: "file before date boundary",
fileMtime: "2025-08-10T23:59:00-07:00",
sinceArg: "2025-08-11",
expectInclude: false,
},
{
name: "file at start of date",
fileMtime: "2025-08-11T00:00:00-07:00",
sinceArg: "2025-08-11",
expectInclude: true,
},
{
name: "file during date",
fileMtime: "2025-08-11T01:00:00-07:00",
sinceArg: "2025-08-11",
expectInclude: true,
},
{
name: "file at end of date",
fileMtime: "2025-08-11T23:59:00-07:00",
sinceArg: "2025-08-11",
expectInclude: true,
},
{
name: "file after date",
fileMtime: "2025-08-12T00:00:00-07:00",
sinceArg: "2025-08-11",
expectInclude: true,
},
{
name: "instant mode - file before",
fileMtime: "2025-08-11T01:00:00-07:00",
sinceArg: "2025-08-11T02:00:00-07:00",
expectInclude: false,
},
{
name: "instant mode - file after",
fileMtime: "2025-08-11T03:00:00-07:00",
sinceArg: "2025-08-11T02:00:00-07:00",
expectInclude: true,
},
{
name: "instant mode - file exactly at boundary",
fileMtime: "2025-08-11T02:00:00-07:00",
sinceArg: "2025-08-11T02:00:00-07:00",
expectInclude: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Parse file mtime
fileMtime, err := time.Parse(time.RFC3339, tt.fileMtime)
if err != nil {
t.Fatalf("Failed to parse file mtime: %v", err)
}
// Parse since bound
sinceBound, err := parseTimeValue(tt.sinceArg, loc)
if err != nil {
t.Fatalf("Failed to parse since arg: %v", err)
}
// Test inclusion
result := includeByTimeBound(fileMtime, sinceBound, loc, false)
if result != tt.expectInclude {
t.Errorf("Expected include=%v, got include=%v", tt.expectInclude, result)
}
})
}
}
func TestIncludeBySinceEmpty(t *testing.T) {
loc, err := time.LoadLocation("America/Vancouver")
if err != nil {
t.Fatalf("Failed to load timezone: %v", err)
}
// Test with empty since bound (no filter)
emptySince := TimeBound{}
testTime := time.Now()
result := includeByTimeBound(testTime, emptySince, loc, false)
if !result {
t.Errorf("Expected true for empty since bound, got false")
}
}
func TestTimeBoundIsEmpty(t *testing.T) {
tests := []struct {
name string
bound TimeBound
expected bool
}{
{
name: "empty bound",
bound: TimeBound{},
expected: true,
},
{
name: "instant bound",
bound: TimeBound{instant: &time.Time{}},
expected: false,
},
{
name: "dateOnly bound",
bound: TimeBound{dateOnly: &time.Time{}},
expected: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := tt.bound.IsEmpty()
if result != tt.expected {
t.Errorf("Expected %v, got %v", tt.expected, result)
}
})
}
}
func TestParseDuration(t *testing.T) {
tests := []struct {
name string
input string
expected time.Duration
expectError bool
}{
{
name: "empty string",
input: "",
expectError: true,
},
{
name: "seconds",
input: "30s",
expected: 30 * time.Second,
},
{
name: "minutes",
input: "45m",
expected: 45 * time.Minute,
},
{
name: "hours",
input: "2h",
expected: 2 * time.Hour,
},
{
name: "days",
input: "7d",
expected: 7 * 24 * time.Hour,
},
{
name: "weeks",
input: "2w",
expected: 2 * 7 * 24 * time.Hour,
},
{
name: "months",
input: "3mo",
expected: 3 * 30 * 24 * time.Hour,
},
{
name: "years",
input: "1y",
expected: 365 * 24 * time.Hour,
},
{
name: "combined hours and minutes",
input: "2h30m",
expected: 2*time.Hour + 30*time.Minute,
},
{
name: "combined with spaces",
input: "2 h 30 m",
expected: 2*time.Hour + 30*time.Minute,
},
{
name: "complex combination",
input: "1y2mo3w4d5h6m7s",
expected: 365*24*time.Hour + 2*30*24*time.Hour + 3*7*24*time.Hour + 4*24*time.Hour + 5*time.Hour + 6*time.Minute + 7*time.Second,
},
{
name: "uppercase",
input: "2H30M",
expected: 2*time.Hour + 30*time.Minute,
},
{
name: "invalid format",
input: "2x",
expectError: true,
},
{
name: "no number",
input: "h",
expectError: true,
},
{
name: "partial match",
input: "2h30",
expectError: true,
},
{
name: "invalid number",
input: "abch",
expectError: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result, err := parseDuration(tt.input)
if tt.expectError {
if err == nil {
t.Errorf("Expected error but got none")
}
return
}
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
if result != tt.expected {
t.Errorf("Expected %v, got %v", tt.expected, result)
}
})
}
}
func TestNewTimeFilter(t *testing.T) {
loc, err := time.LoadLocation("America/Vancouver")
if err != nil {
t.Fatalf("Failed to load timezone: %v", err)
}
now := time.Date(2025, 8, 11, 12, 0, 0, 0, loc)
tests := []struct {
name string
since string
until string
maxAge string
minAge string
expectError bool
expectEmpty bool
}{
{
name: "empty filter",
expectEmpty: true,
},
{
name: "since only",
since: "2025-08-10",
},
{
name: "until only",
until: "2025-08-12",
},
{
name: "max-age only",
maxAge: "7d",
},
{
name: "min-age only",
minAge: "30d",
},
{
name: "since and until",
since: "2025-08-01",
until: "2025-08-15",
},
{
name: "max-age and min-age",
maxAge: "7d",
minAge: "1d",
},
{
name: "all filters",
since: "2025-08-01",
until: "2025-08-15",
maxAge: "30d",
minAge: "1d",
},
{
name: "invalid since",
since: "invalid",
expectError: true,
},
{
name: "invalid until",
until: "invalid",
expectError: true,
},
{
name: "invalid max-age",
maxAge: "invalid",
expectError: true,
},
{
name: "invalid min-age",
minAge: "invalid",
expectError: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
filter, err := NewTimeFilter(tt.since, tt.until, tt.maxAge, tt.minAge, now, loc)
if tt.expectError {
if err == nil {
t.Errorf("Expected error but got none")
}
return
}
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
if tt.expectEmpty {
if !filter.IsEmpty() {
t.Errorf("Expected empty filter")
}
} else {
if filter.IsEmpty() {
t.Errorf("Expected non-empty filter")
}
}
})
}
}
func TestTimeFilterIncludeByTimeFilter(t *testing.T) {
loc, err := time.LoadLocation("America/Vancouver")
if err != nil {
t.Fatalf("Failed to load timezone: %v", err)
}
now := time.Date(2025, 8, 11, 12, 0, 0, 0, loc)
tests := []struct {
name string
since string
until string
maxAge string
minAge string
fileMtime string
expectInclude bool
}{
{
name: "since filter - file after",
since: "2025-08-10",
fileMtime: "2025-08-11T10:00:00-07:00",
expectInclude: true,
},
{
name: "since filter - file before",
since: "2025-08-10",
fileMtime: "2025-08-09T10:00:00-07:00",
expectInclude: false,
},
{
name: "until filter - file before",
until: "2025-08-12",
fileMtime: "2025-08-11T10:00:00-07:00",
expectInclude: true,
},
{
name: "until filter - file after",
until: "2025-08-12",
fileMtime: "2025-08-13T10:00:00-07:00",
expectInclude: false,
},
{
name: "max-age filter - file recent",
maxAge: "7d",
fileMtime: "2025-08-10T12:00:00-07:00", // 1 day ago
expectInclude: true,
},
{
name: "max-age filter - file old",
maxAge: "7d",
fileMtime: "2025-08-01T12:00:00-07:00", // 10 days ago
expectInclude: false,
},
{
name: "min-age filter - file old",
minAge: "7d",
fileMtime: "2025-08-01T12:00:00-07:00", // 10 days ago
expectInclude: true,
},
{
name: "min-age filter - file recent",
minAge: "7d",
fileMtime: "2025-08-10T12:00:00-07:00", // 1 day ago
expectInclude: false,
},
{
name: "combined filters - all pass",
since: "2025-08-01",
until: "2025-08-15",
maxAge: "30d",
minAge: "1d",
fileMtime: "2025-08-05T12:00:00-07:00", // 6 days ago
expectInclude: true,
},
{
name: "combined filters - since fails",
since: "2025-08-10",
until: "2025-08-15",
maxAge: "30d",
minAge: "1d",
fileMtime: "2025-08-05T12:00:00-07:00", // 6 days ago
expectInclude: false,
},
{
name: "combined filters - until fails",
since: "2025-08-01",
until: "2025-08-10",
maxAge: "30d",
minAge: "1d",
fileMtime: "2025-08-12T12:00:00-07:00", // future
expectInclude: false,
},
{
name: "combined filters - max-age fails",
since: "2025-08-01",
until: "2025-08-15",
maxAge: "5d",
minAge: "1d",
fileMtime: "2025-08-01T12:00:00-07:00", // 10 days ago
expectInclude: false,
},
{
name: "combined filters - min-age fails",
since: "2025-08-01",
until: "2025-08-15",
maxAge: "30d",
minAge: "5d",
fileMtime: "2025-08-10T12:00:00-07:00", // 1 day ago
expectInclude: false,
},
{
name: "date-only since and max-age - fail",
since: "2025-08-10",
maxAge: "3d",
fileMtime: "2025-08-09T12:00:00-07:00", // 2 days old, but before since date
expectInclude: false,
},
{
name: "date-only since and max-age - pass",
since: "2025-08-10",
maxAge: "3d",
fileMtime: "2025-08-10T12:00:00-07:00", // 1 day old, and on since date
expectInclude: true,
},
{
name: "date-only until and min-age - fail",
until: "2025-08-10",
minAge: "1d",
fileMtime: "2025-08-10T12:00:00-07:00", // 1 day old, but not old enough to be excluded by until
expectInclude: true,
},
{
name: "date-only until and min-age - pass",
until: "2025-08-10",
minAge: "2d",
fileMtime: "2025-08-08T12:00:00-07:00", // 3 days old, and before until date
expectInclude: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Parse file mtime
fileMtime, err := time.Parse(time.RFC3339, tt.fileMtime)
if err != nil {
t.Fatalf("Failed to parse file mtime: %v", err)
}
// Create time filter
filter, err := NewTimeFilter(tt.since, tt.until, tt.maxAge, tt.minAge, now, loc)
if err != nil {
t.Fatalf("Failed to create time filter: %v", err)
}
// Test inclusion
result := filter.IncludeByTimeFilter(fileMtime, loc)
if result != tt.expectInclude {
t.Errorf("Expected include=%v, got include=%v", tt.expectInclude, result)
}
})
}
}
func TestIncludeByTimeBound(t *testing.T) {
loc, err := time.LoadLocation("America/Vancouver")
if err != nil {
t.Fatalf("Failed to load timezone: %v", err)
}
tests := []struct {
name string
boundArg string
fileMtime string
isUntil bool
expectInclude bool
}{
{
name: "since instant - file after",
boundArg: "2025-08-11T10:00:00-07:00",
fileMtime: "2025-08-11T11:00:00-07:00",
isUntil: false,
expectInclude: true,
},
{
name: "since instant - file before",
boundArg: "2025-08-11T10:00:00-07:00",
fileMtime: "2025-08-11T09:00:00-07:00",
isUntil: false,
expectInclude: false,
},
{
name: "since instant - file exactly at boundary",
boundArg: "2025-08-11T10:00:00-07:00",
fileMtime: "2025-08-11T10:00:00-07:00",
isUntil: false,
expectInclude: true,
},
{
name: "until instant - file before",
boundArg: "2025-08-11T10:00:00-07:00",
fileMtime: "2025-08-11T09:00:00-07:00",
isUntil: true,
expectInclude: true,
},
{
name: "until instant - file after",
boundArg: "2025-08-11T10:00:00-07:00",
fileMtime: "2025-08-11T11:00:00-07:00",
isUntil: true,
expectInclude: false,
},
{
name: "until instant - file exactly at boundary",
boundArg: "2025-08-11T10:00:00-07:00",
fileMtime: "2025-08-11T10:00:00-07:00",
isUntil: true,
expectInclude: true,
},
{
name: "since date - file just before day",
boundArg: "2025-08-11",
fileMtime: "2025-08-10T23:59:59-07:00",
isUntil: false,
expectInclude: false,
},
{
name: "since date - file at start of day",
boundArg: "2025-08-11",
fileMtime: "2025-08-11T00:00:00-07:00",
isUntil: false,
expectInclude: true,
},
{
name: "since date - file at end of day",
boundArg: "2025-08-11",
fileMtime: "2025-08-11T23:59:59-07:00",
isUntil: false,
expectInclude: true,
},
{
name: "since date - file on next day",
boundArg: "2025-08-11",
fileMtime: "2025-08-12T00:00:00-07:00",
isUntil: false,
expectInclude: true,
},
{
name: "until date - file on previous day",
boundArg: "2025-08-11",
fileMtime: "2025-08-10T23:59:59-07:00",
isUntil: true,
expectInclude: true,
},
{
name: "until date - file at start of day",
boundArg: "2025-08-11",
fileMtime: "2025-08-11T00:00:00-07:00",
isUntil: true,
expectInclude: true,
},
{
name: "until date - file at end of day",
boundArg: "2025-08-11",
fileMtime: "2025-08-11T23:59:59-07:00",
isUntil: true,
expectInclude: true,
},
{
name: "until date - file just after day",
boundArg: "2025-08-11",
fileMtime: "2025-08-12T00:00:00-07:00",
isUntil: true,
expectInclude: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Parse time bound
bound, err := parseTimeValue(tt.boundArg, loc)
if err != nil {
t.Fatalf("Failed to parse time bound: %v", err)
}
// Parse file mtime
fileMtime, err := time.Parse(time.RFC3339, tt.fileMtime)
if err != nil {
t.Fatalf("Failed to parse file mtime: %v", err)
}
// Test inclusion
result := includeByTimeBound(fileMtime, bound, loc, tt.isUntil)
if result != tt.expectInclude {
t.Errorf("Expected include=%v, got include=%v", tt.expectInclude, result)
}
})
}
}
|