1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
|
/**********************************************************************
* $Id: ConnectedInteriorTester.cpp 1820 2006-09-06 16:54:23Z mloskot $
*
* GEOS - Geometry Engine Open Source
* http://geos.refractions.net
*
* Copyright (C) 2005-2006 Refractions Research Inc.
* Copyright (C) 2001-2002 Vivid Solutions Inc.
*
* This is free software; you can redistribute and/or modify it under
* the terms of the GNU Lesser General Public Licence as published
* by the Free Software Foundation.
* See the COPYING file for more information.
*
**********************************************************************
*
* Last port: operation/valid/ConnectedInteriorTester.java rev. 1.14
*
**********************************************************************
*
* TODO:
*
* - Remove heap allocation of GeometryFactory (might use a singleton)
* - Track MaximalEdgeRing references: we might be deleting them
* leaving dangling refs around.
*
**********************************************************************/
#include <geos/operation/valid/ConnectedInteriorTester.h>
#include <geos/operation/overlay/MaximalEdgeRing.h>
#include <geos/operation/overlay/MinimalEdgeRing.h>
#include <geos/operation/overlay/OverlayNodeFactory.h>
#include <geos/geom/GeometryFactory.h>
#include <geos/geom/CoordinateSequence.h>
#include <geos/geom/Coordinate.h>
#include <geos/geom/Location.h>
#include <geos/geom/Polygon.h>
#include <geos/geom/MultiPolygon.h>
#include <geos/geom/MultiPolygon.h>
#include <geos/geom/LineString.h>
#include <geos/geomgraph/GeometryGraph.h>
#include <geos/geomgraph/PlanarGraph.h>
#include <geos/geomgraph/EdgeRing.h>
#include <geos/geomgraph/DirectedEdge.h>
#include <geos/geomgraph/Position.h>
#include <geos/geomgraph/Label.h>
#include <vector>
#include <cassert>
#include <typeinfo>
#ifndef GEOS_DEBUG
#define GEOS_DEBUG 0
#endif
#if GEOS_DEBUG
#include <iostream>
#endif
using namespace std;
using namespace geos::geom;
using namespace geos::geomgraph;
using namespace geos::operation::overlay;
namespace geos {
namespace operation { // geos.operation
namespace valid { // geos.operation.valid
ConnectedInteriorTester::ConnectedInteriorTester(GeometryGraph &newGeomGraph):
geometryFactory(new GeometryFactory()),
geomGraph(newGeomGraph),
disconnectedRingcoord()
{
}
ConnectedInteriorTester::~ConnectedInteriorTester()
{
delete geometryFactory;
}
Coordinate&
ConnectedInteriorTester::getCoordinate()
{
return disconnectedRingcoord;
}
const Coordinate&
ConnectedInteriorTester::findDifferentPoint(const CoordinateSequence *coord,
const Coordinate& pt)
{
assert(coord);
size_t npts=coord->getSize();
for(size_t i=0; i<npts; ++i)
{
if(!(coord->getAt(i)==pt))
return coord->getAt(i);
}
return Coordinate::getNull();
}
/*public*/
bool
ConnectedInteriorTester::isInteriorsConnected()
{
// node the edges, in case holes touch the shell
std::vector<Edge*> splitEdges;
geomGraph.computeSplitEdges(&splitEdges);
// form the edges into rings
PlanarGraph graph(operation::overlay::OverlayNodeFactory::instance());
graph.addEdges(splitEdges);
setInteriorEdgesInResult(graph);
graph.linkResultDirectedEdges();
// Someone has to delete the returned vector and its contents
std::vector<EdgeRing*>* edgeRings=buildEdgeRings(graph.getEdgeEnds());
assert(edgeRings);
#if GEOS_DEBUG
cerr << "buildEdgeRings constructed " << edgeRings->size() << " edgeRings." << endl;
#endif
/*
* Mark all the edges for the edgeRings corresponding to the shells
* of the input polygons.
*
* Only ONE ring gets marked for each shell - if there are others
* which remain unmarked this indicates a disconnected interior.
*/
visitShellInteriors(geomGraph.getGeometry(), graph);
#if GEOS_DEBUG
cerr << "after visitShellInteriors edgeRings are " << edgeRings->size() << " edgeRings." << endl;
#endif
/*
* If there are any unvisited shell edges
* (i.e. a ring which is not a hole and which has the interior
* of the parent area on the RHS)
* this means that one or more holes must have split the interior of the
* polygon into at least two pieces. The polygon is thus invalid.
*/
bool res=!hasUnvisitedShellEdge(edgeRings);
assert(edgeRings);
#if GEOS_DEBUG
cerr << "releasing " << edgeRings->size() << " edgeRings." << endl;
#endif
// Release memory allocated by buildEdgeRings
for(size_t i=0, n=edgeRings->size(); i<n; ++i)
{
EdgeRing* er = (*edgeRings)[i];
#if GEOS_DEBUG
cerr<<*er<<endl;
#endif
assert(er);
delete er;
#if GEOS_DEBUG
cerr << "releasing edgeRing at " << er << endl;
#endif
}
delete edgeRings;
// Release memory allocated by MaximalEdgeRings
// There should be no more references to this object
// how to check this ? boost::shared_ptr<> comes to mind.
//
for (size_t i=0, n=maximalEdgeRings.size(); i<n; i++)
{
delete maximalEdgeRings[i];
}
maximalEdgeRings.clear();
return res;
}
void
ConnectedInteriorTester::setInteriorEdgesInResult(PlanarGraph &graph)
{
std::vector<EdgeEnd*> *ee=graph.getEdgeEnds();
for(size_t i=0, n=ee->size(); i<n; ++i)
{
// Unexpected non DirectedEdge in graphEdgeEnds
assert(dynamic_cast<DirectedEdge*>((*ee)[i]));
DirectedEdge *de=static_cast<DirectedEdge*>((*ee)[i]);
if ( de->getLabel()->getLocation(0, Position::RIGHT) == Location::INTERIOR)
{
de->setInResult(true);
}
}
}
/*private*/
std::vector<EdgeRing*>*
ConnectedInteriorTester::buildEdgeRings(std::vector<EdgeEnd*> *dirEdges)
{
#if GEOS_DEBUG
cerr << __FUNCTION__ << " got " << dirEdges->size() << " EdgeEnd vector" << endl;
#endif
std::vector<MinimalEdgeRing*> minEdgeRings;
for(size_t i=0, n=dirEdges->size(); i<n; ++i)
{
assert(dynamic_cast<DirectedEdge*>((*dirEdges)[i]));
DirectedEdge *de=static_cast<DirectedEdge*>((*dirEdges)[i]);
#if GEOS_DEBUG
cerr << "DirectedEdge " << i << ": " << de->print() << endl;
#endif
// if this edge has not yet been processed
if(de->isInResult() && de->getEdgeRing()==NULL)
{
//EdgeRing *er=new MaximalEdgeRing(de,geometryFactory);
//edgeRings->push_back(er);
MaximalEdgeRing* er=new MaximalEdgeRing(de, geometryFactory);
// We track MaximalEdgeRings allocations
// using the private maximalEdgeRings vector
maximalEdgeRings.push_back(er);
er->linkDirectedEdgesForMinimalEdgeRings();
er->buildMinimalRings(minEdgeRings);
}
}
std::vector<EdgeRing*> *edgeRings=new std::vector<EdgeRing*>();
edgeRings->assign(minEdgeRings.begin(), minEdgeRings.end());
return edgeRings;
}
/**
* Mark all the edges for the edgeRings corresponding to the shells
* of the input polygons. Note only ONE ring gets marked for each shell.
*/
void
ConnectedInteriorTester::visitShellInteriors(const Geometry *g, PlanarGraph &graph)
{
if (const Polygon* p=dynamic_cast<const Polygon*>(g))
{
visitInteriorRing(p->getExteriorRing(), graph);
}
if (const MultiPolygon* mp=dynamic_cast<const MultiPolygon*>(g))
{
for (size_t i=0, n=mp->getNumGeometries(); i<n; i++) {
const Polygon *p=static_cast<const Polygon*>(mp->getGeometryN(i));
visitInteriorRing(p->getExteriorRing(), graph);
}
}
}
void
ConnectedInteriorTester::visitInteriorRing(const LineString *ring, PlanarGraph &graph)
{
const CoordinateSequence *pts=ring->getCoordinatesRO();
const Coordinate& pt0=pts->getAt(0);
/**
* Find first point in coord list different to initial point.
* Need special check since the first point may be repeated.
*/
const Coordinate& pt1=findDifferentPoint(pts, pt0);
Edge *e=graph.findEdgeInSameDirection(pt0, pt1);
DirectedEdge *de=static_cast<DirectedEdge*>(graph.findEdgeEnd(e));
DirectedEdge *intDe=NULL;
if (de->getLabel()->getLocation(0,Position::RIGHT)==Location::INTERIOR) {
intDe=de;
} else if (de->getSym()->getLabel()->getLocation(0,Position::RIGHT)==Location::INTERIOR) {
intDe=de->getSym();
}
assert(intDe!=NULL); // unable to find dirEdge with Interior on RHS
visitLinkedDirectedEdges(intDe);
}
void
ConnectedInteriorTester::visitLinkedDirectedEdges(DirectedEdge *start)
{
DirectedEdge *startDe=start;
DirectedEdge *de=start;
//Debug.println(de);
do {
// found null Directed Edge
assert(de!=NULL);
de->setVisited(true);
de=de->getNext();
//Debug.println(de);
} while (de!=startDe);
}
/*private*/
bool
ConnectedInteriorTester::hasUnvisitedShellEdge(std::vector<EdgeRing*> *edgeRings)
{
#if GEOS_DEBUG
cerr << "hasUnvisitedShellEdge called with " << edgeRings->size() << " edgeRings." << endl;
#endif
for(std::vector<EdgeRing*>::iterator
it=edgeRings->begin(), itEnd=edgeRings->end();
it != itEnd;
++it)
{
EdgeRing *er=*it;
assert(er);
// don't check hole rings
if (er->isHole()) continue;
std::vector<DirectedEdge*>& edges=er->getEdges();
DirectedEdge *de=edges[0];
assert(de);
// don't check CW rings which are holes
// (MD - this check may now be irrelevant - 2006-03-09)
assert(de->getLabel());
if (de->getLabel()->getLocation(0, Position::RIGHT) != Location::INTERIOR) continue;
/*
* the edgeRing is CW ring which surrounds the INT
* of the area, so check all edges have been visited.
* If any are unvisited, this is a disconnected part
* of the interior
*/
for(std::vector<DirectedEdge*>::iterator
jt=edges.begin(), jtEnd=edges.end();
jt != jtEnd;
++jt)
{
de=*jt;
assert(de);
//Debug.print("visted? "); Debug.println(de);
if (!de->isVisited()) {
//Debug.print("not visited "); Debug.println(de);
disconnectedRingcoord=de->getCoordinate();
return true;
}
}
}
return false;
}
} // namespace geos.operation.valid
} // namespace geos.operation
} // namespace geos
/**********************************************************************
* $Log$
* Revision 1.29 2006/06/12 11:29:24 strk
* unsigned int => size_t
*
* Revision 1.28 2006/04/06 12:45:28 strk
* Delayed deletion of newly allocated MaximalEdgeRings.
* Existing 'valid' operation tests don't should instability with
* this patch.
*
* Revision 1.27 2006/03/29 13:53:59 strk
* EdgeRing equipped with Invariant testing function and lots of exceptional assertions. Removed useless heap allocations, and pointers usages.
*
* Revision 1.26 2006/03/27 16:02:34 strk
* Added INL file for MinimalEdgeRing, added many debugging blocks,
* fixed memory leak in ConnectedInteriorTester (bug #59)
*
* Revision 1.25 2006/03/27 14:20:46 strk
* Added paranoid assertion checking and a note in header about responsibility of return from buildMaximalEdgeRings()
*
* Revision 1.24 2006/03/20 16:57:44 strk
* spatialindex.h and opValid.h headers split
*
* Revision 1.23 2006/03/17 16:48:55 strk
* LineIntersector and PointLocator made complete components of RelateComputer
* (were statics const pointers before). Reduced inclusions from opRelate.h
* and opValid.h, updated .cpp files to allow build.
*
**********************************************************************/
|