1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058
|
{-
(c) The GRASP/AQUA Project, Glasgow University, 1993-1998
\section[WorkWrap]{Worker/wrapper-generating back-end of strictness analyser}
-}
module GHC.Core.Opt.WorkWrap
( WwOpts (..)
, wwTopBinds
)
where
import GHC.Prelude
import GHC.Core
import GHC.Core.Unfold.Make
import GHC.Core.Utils ( exprType, exprIsHNF )
import GHC.Core.Type
import GHC.Core.Opt.WorkWrap.Utils
import GHC.Core.SimpleOpt
import GHC.Types.Var
import GHC.Types.Id
import GHC.Types.Id.Info
import GHC.Types.Unique.Supply
import GHC.Types.Basic
import GHC.Types.Demand
import GHC.Types.Cpr
import GHC.Types.SourceText
import GHC.Types.Unique
import GHC.Utils.Misc
import GHC.Utils.Outputable
import GHC.Utils.Panic
import GHC.Utils.Panic.Plain
import GHC.Utils.Monad
import GHC.Core.DataCon
{-
We take Core bindings whose binders have:
\begin{enumerate}
\item Strictness attached (by the front-end of the strictness
analyser), and / or
\item Constructed Product Result information attached by the CPR
analysis pass.
\end{enumerate}
and we return some ``plain'' bindings which have been
worker/wrapper-ified, meaning:
\begin{enumerate}
\item Functions have been split into workers and wrappers where
appropriate. If a function has both strictness and CPR properties
then only one worker/wrapper doing both transformations is produced;
\item Binders' @IdInfos@ have been updated to reflect the existence of
these workers/wrappers (this is where we get STRICTNESS and CPR pragma
info for exported values).
\end{enumerate}
-}
wwTopBinds :: WwOpts -> UniqSupply -> CoreProgram -> CoreProgram
wwTopBinds ww_opts us top_binds
= initUs_ us $ do
top_binds' <- mapM (wwBind ww_opts) top_binds
return (concat top_binds')
{-
************************************************************************
* *
\subsection[wwBind-wwExpr]{@wwBind@ and @wwExpr@}
* *
************************************************************************
@wwBind@ works on a binding, trying each \tr{(binder, expr)} pair in
turn. Non-recursive case first, then recursive...
-}
wwBind :: WwOpts
-> CoreBind
-> UniqSM [CoreBind] -- returns a WwBinding intermediate form;
-- the caller will convert to Expr/Binding,
-- as appropriate.
wwBind ww_opts (NonRec binder rhs) = do
new_rhs <- wwExpr ww_opts rhs
new_pairs <- tryWW ww_opts NonRecursive binder new_rhs
return [NonRec b e | (b,e) <- new_pairs]
-- Generated bindings must be non-recursive
-- because the original binding was.
wwBind ww_opts (Rec pairs)
= return . Rec <$> concatMapM do_one pairs
where
do_one (binder, rhs) = do new_rhs <- wwExpr ww_opts rhs
tryWW ww_opts Recursive binder new_rhs
{-
@wwExpr@ basically just walks the tree, looking for appropriate
annotations that can be used. Remember it is @wwBind@ that does the
matching by looking for strict arguments of the correct type.
@wwExpr@ is a version that just returns the ``Plain'' Tree.
-}
wwExpr :: WwOpts -> CoreExpr -> UniqSM CoreExpr
wwExpr _ e@(Type {}) = return e
wwExpr _ e@(Coercion {}) = return e
wwExpr _ e@(Lit {}) = return e
wwExpr _ e@(Var {}) = return e
wwExpr ww_opts (Lam binder expr)
= Lam new_binder <$> wwExpr ww_opts expr
where new_binder | isId binder = zapIdUsedOnceInfo binder
| otherwise = binder
-- See Note [Zapping Used Once info in WorkWrap]
wwExpr ww_opts (App f a)
= App <$> wwExpr ww_opts f <*> wwExpr ww_opts a
wwExpr ww_opts (Tick note expr)
= Tick note <$> wwExpr ww_opts expr
wwExpr ww_opts (Cast expr co) = do
new_expr <- wwExpr ww_opts expr
return (Cast new_expr co)
wwExpr ww_opts (Let bind expr)
= mkLets <$> wwBind ww_opts bind <*> wwExpr ww_opts expr
wwExpr ww_opts (Case expr binder ty alts) = do
new_expr <- wwExpr ww_opts expr
new_alts <- mapM ww_alt alts
let new_binder = zapIdUsedOnceInfo binder
-- See Note [Zapping Used Once info in WorkWrap]
return (Case new_expr new_binder ty new_alts)
where
ww_alt (Alt con binders rhs) = do
new_rhs <- wwExpr ww_opts rhs
let new_binders = [ if isId b then zapIdUsedOnceInfo b else b
| b <- binders ]
-- See Note [Zapping Used Once info in WorkWrap]
return (Alt con new_binders new_rhs)
{-
************************************************************************
* *
\subsection[tryWW]{@tryWW@: attempt a worker/wrapper pair}
* *
************************************************************************
@tryWW@ just accumulates arguments, converts strictness info from the
front-end into the proper form, then calls @mkWwBodies@ to do
the business.
The only reason this is monadised is for the unique supply.
Note [Don't w/w INLINE things]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It's very important to refrain from w/w-ing an INLINE function (ie one
with a stable unfolding) because the wrapper will then overwrite the
old stable unfolding with the wrapper code.
Furthermore, if the programmer has marked something as INLINE,
we may lose by w/w'ing it.
If the strictness analyser is run twice, this test also prevents
wrappers (which are INLINEd) from being re-done. (You can end up with
several liked-named Ids bouncing around at the same time---absolute
mischief.)
Notice that we refrain from w/w'ing an INLINE function even if it is
in a recursive group. It might not be the loop breaker. (We could
test for loop-breaker-hood, but I'm not sure that ever matters.)
Note [Worker/wrapper for INLINABLE functions]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
If we have
{-# INLINABLE f #-}
f :: Ord a => [a] -> Int -> a
f x y = ....f....
where f is strict in y, we might get a more efficient loop by w/w'ing
f. But that would make a new unfolding which would overwrite the old
one! So the function would no longer be INLINABLE, and in particular
will not be specialised at call sites in other modules.
This comes up in practice (#6056).
Solution:
* Do the w/w for strictness analysis, even for INLINABLE functions
* Transfer the Stable unfolding to the *worker*. How do we "transfer
the unfolding"? Easy: by using the old one, wrapped in work_fn! See
GHC.Core.Unfold.Make.mkWorkerUnfolding.
* We use the /original, user-specified/ function's InlineSpec pragma
for both the wrapper and the worker (see `mkStrWrapperInlinePrag`).
So if f is INLINEABLE, both worker and wrapper will get an InlineSpec
of (Inlinable "blah").
It's important that both get this, because the specialiser uses
the existence of a /user-specified/ INLINE/INLINABLE pragma to
drive specialisation of imported functions. See GHC.Core.Opt.Specialise
Note [Specialising imported functions]
* Remember, the subsequent inlining behaviour of the wrapper is expressed by
(a) the stable unfolding
(b) the unfolding guidance of UnfWhen
(c) the inl_act activation (see Note [Wrapper activation]
For our {-# INLINEABLE f #-} example above, we will get something a
bit like like this:
{-# Has stable unfolding, active in phase 2;
plus InlineSpec = INLINEABLE #-}
f :: Ord a => [a] -> Int -> a
f d x y = case y of I# y' -> fw d x y'
{-# Has stable unfolding, plus InlineSpec = INLINEABLE #-}
fw :: Ord a => [a] -> Int# -> a
fw d x y' = let y = I# y' in ...f...
(Historical note: we used to always give the wrapper an INLINE pragma,
but CSE will not happen if there is a user-specified pragma, but
should happen for w/w’ed things (#14186). But now we simply propagate
any user-defined pragma info, so we'll defeat CSE (rightly) only when
there is a user-supplied INLINE/INLINEABLE pragma.)
Note [No worker/wrapper for record selectors]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
We sometimes generate a lot of record selectors, and generally the
don't benefit from worker/wrapper. Yes, mkWwBodies would find a w/w split,
but it is then suppressed by the certainlyWillInline test in splitFun.
The wasted effort in mkWwBodies makes a measurable difference in
compile time (see MR !2873), so although it's a terribly ad-hoc test,
we just check here for record selectors, and do a no-op in that case.
I did look for a generalisation, so that it's not just record
selectors that benefit. But you'd need a cheap test for "this
function will definitely get a w/w split" and that's hard to predict
in advance...the logic in mkWwBodies is complex. So I've left the
super-simple test, with this Note to explain.
NB: record selectors are ordinary functions, inlined iff GHC wants to,
so won't be caught by the preceding isInlineUnfolding test in tryWW.
Note [Worker/wrapper for NOINLINE functions]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
We used to disable worker/wrapper for NOINLINE things, but it turns out
this can cause unnecessary reboxing of values. Consider
{-# NOINLINE f #-}
f :: Int -> a
f x = error (show x)
g :: Bool -> Bool -> Int -> Int
g True True p = f p
g False True p = p + 1
g b False p = g b True p
the strictness analysis will discover f and g are strict, but because f
has no wrapper, the worker for g will rebox p. So we get
$wg x y p# =
let p = I# p# in -- Yikes! Reboxing!
case x of
False ->
case y of
False -> $wg False True p#
True -> +# p# 1#
True ->
case y of
False -> $wg True True p#
True -> case f p of { }
g x y p = case p of (I# p#) -> $wg x y p#
Now, in this case the reboxing will float into the True branch, and so
the allocation will only happen on the error path. But it won't float
inwards if there are multiple branches that call (f p), so the reboxing
will happen on every call of g. Disaster.
Solution: do worker/wrapper even on NOINLINE things; but move the
NOINLINE pragma to the worker.
(See #13143 for a real-world example.)
It is crucial that we do this for *all* NOINLINE functions. #10069
demonstrates what happens when we promise to w/w a (NOINLINE) leaf
function, but fail to deliver:
data C = C Int# Int#
{-# NOINLINE c1 #-}
c1 :: C -> Int#
c1 (C _ n) = n
{-# NOINLINE fc #-}
fc :: C -> Int#
fc c = 2 *# c1 c
Failing to w/w `c1`, but still w/wing `fc` leads to the following code:
c1 :: C -> Int#
c1 (C _ n) = n
$wfc :: Int# -> Int#
$wfc n = let c = C 0# n in 2 #* c1 c
fc :: C -> Int#
fc (C _ n) = $wfc n
Yikes! The reboxed `C` in `$wfc` can't cancel out, so we are in a bad place.
This generalises to any function that derives its strictness signature from
its callees, so we have to make sure that when a function announces particular
strictness properties, we have to w/w them accordingly, even if it means
splitting a NOINLINE function.
Note [Worker activation]
~~~~~~~~~~~~~~~~~~~~~~~~
Follows on from Note [Worker/wrapper for INLINABLE functions]
It is *vital* that if the worker gets an INLINABLE pragma (from the
original function), then the worker has the same phase activation as
the wrapper (or later). That is necessary to allow the wrapper to
inline into the worker's unfolding: see GHC.Core.Opt.Simplify.Utils
Note [Simplifying inside stable unfoldings].
If the original is NOINLINE, it's important that the worker inherits the
original activation. Consider
{-# NOINLINE expensive #-}
expensive x = x + 1
f y = let z = expensive y in ...
If expensive's worker inherits the wrapper's activation,
we'll get this (because of the compromise in point (2) of
Note [Wrapper activation])
{-# NOINLINE[Final] $wexpensive #-}
$wexpensive x = x + 1
{-# INLINE[Final] expensive #-}
expensive x = $wexpensive x
f y = let z = expensive y in ...
and $wexpensive will be immediately inlined into expensive, followed by
expensive into f. This effectively removes the original NOINLINE!
Otherwise, nothing is lost by giving the worker the same activation as the
wrapper, because the worker won't have any chance of inlining until the
wrapper does; there's no point in giving it an earlier activation.
Note [Don't w/w inline small non-loop-breaker things]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In general, we refrain from w/w-ing *small* functions, which are not
loop breakers, because they'll inline anyway. But we must take care:
it may look small now, but get to be big later after other inlining
has happened. So we take the precaution of adding a StableUnfolding
for any such functions.
I made this change when I observed a big function at the end of
compilation with a useful strictness signature but no w-w. (It was
small during demand analysis, we refrained from w/w, and then got big
when something was inlined in its rhs.) When I measured it on nofib,
it didn't make much difference; just a few percent improved allocation
on one benchmark (bspt/Euclid.space). But nothing got worse.
There is an infelicity though. We may get something like
f = g val
==>
g x = case gw x of r -> I# r
f {- InlineStable, Template = g val -}
f = case gw x of r -> I# r
The code for f duplicates that for g, without any real benefit. It
won't really be executed, because calls to f will go via the inlining.
Note [Don't w/w join points for CPR]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There's no point in exploiting CPR info on a join point. If the whole function
is getting CPR'd, then the case expression around the worker function will get
pushed into the join point by the simplifier, which will have the same effect
that w/w'ing for CPR would have - the result will be returned in an unboxed
tuple.
f z = let join j x y = (x+1, y+1)
in case z of A -> j 1 2
B -> j 2 3
=>
f z = case $wf z of (# a, b #) -> (a, b)
$wf z = case (let join j x y = (x+1, y+1)
in case z of A -> j 1 2
B -> j 2 3) of (a, b) -> (# a, b #)
=>
f z = case $wf z of (# a, b #) -> (a, b)
$wf z = let join j x y = (# x+1, y+1 #)
in case z of A -> j 1 2
B -> j 2 3
Note that we still want to give `j` the CPR property, so that `f` has it. So
CPR *analyse* join points as regular functions, but don't *transform* them.
We could retain the CPR /signature/ on the worker after W/W, but it would
become outright wrong if the Simplifier pushes a non-trivial continuation
into it. For example:
case (let $j x = (x,x) in ...) of alts
==>
let $j x = case (x,x) of alts in case ... of alts
Before pushing the case in, `$j` has the CPR property, but not afterwards.
So we simply zap the CPR signature for join pints as part of the W/W pass.
The signature served its purpose during CPR analysis in propagating the
CPR property of `$j`.
Doing W/W for returned products on a join point would be tricky anyway, as the
worker could not be a join point because it would not be tail-called. However,
doing the *argument* part of W/W still works for join points, since the wrapper
body will make a tail call:
f z = let join j x y = x + y
in ...
=>
f z = let join $wj x# y# = x# +# y#
j x y = case x of I# x# ->
case y of I# y# ->
$wj x# y#
in ...
Note [Wrapper activation]
~~~~~~~~~~~~~~~~~~~~~~~~~
When should the wrapper inlining be active?
1. It must not be active earlier than the current Activation of the Id,
because we must give rewrite rules mentioning the wrapper and
specialisation a chance to fire.
See Note [Worker/wrapper for INLINABLE functions]
and Note [Worker activation]
2. It should be active at some point, despite (1) because of
Note [Worker/wrapper for NOINLINE functions]
3. For ordinary functions with no pragmas we want to inline the
wrapper as early as possible (#15056). Suppose another module
defines f !x xs = ... foldr k z xs ...
and suppose we have the usual foldr/build RULE. Then if we have
a call `f x [1..x]`, we'd expect to inline f and the RULE will fire.
But if f is w/w'd (which it might be), we want the inlining to
occur just as if it hadn't been.
(This only matters if f's RHS is big enough to w/w, but small
enough to inline given the call site, but that can happen.)
4. We do not want to inline the wrapper before specialisation.
module Foo where
f :: Num a => a -> Int -> a
f n 0 = n -- Strict in the Int, hence wrapper
f n x = f (n+n) (x-1)
g :: Int -> Int
g x = f x x -- Provokes a specialisation for f
module Bar where
import Foo
h :: Int -> Int
h x = f 3 x
In module Bar we want to give specialisations a chance to fire
before inlining f's wrapper.
(Historical note: At one stage I tried making the wrapper inlining
always-active, and that had a very bad effect on nofib/imaginary/x2n1;
a wrapper was inlined before the specialisation fired.)
4a. If we have
{-# SPECIALISE foo :: (Int,Int) -> Bool -> Int #-}
{-# NOINLINE [n] foo #-}
then specialisation will generate a SPEC rule active from Phase n.
See Note [Auto-specialisation and RULES] in GHC.Core.Opt.Specialise
This SPEC specialisation rule will compete with inlining, but we don't
mind that, because if inlining succeeds, it should be better.
Now, if we w/w foo, we must ensure that the wrapper (which is very
keen to inline) has a phase /after/ 'n', else it'll always "win" over
the SPEC rule -- disaster (#20709).
Conclusion: the activation for the wrapper should be the /later/ of
(a) the current activation of the function, or FinalPhase if it is NOINLINE
(b) one phase /after/ the activation of any rules
This is implemented by mkStrWrapperInlinePrag.
Reminder: Note [Don't w/w INLINE things], so we don't need to worry
about INLINE things here.
What if `foo` has no specialisations, is worker/wrappered (with the
wrapper inlining very early), and exported; and then in an importing
module we have {-# SPECIALISE foo : ... #-}?
Well then, we'll specialise foo's wrapper, which will expose a
specialisation for foo's worker, which we will do too. That seems
fine. (To work reliably, `foo` would need an INLINABLE pragma,
in which case we don't unpack dictionaries for the worker; see
see Note [Do not unbox class dictionaries].)
Note [Drop absent bindings]
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Consider (#19824):
let t = ...big...
in ...(f t x)...
were `f` ignores its first argument. With luck f's wrapper will inline
thereby dropping `t`, but maybe not: the arguments to f all look boring.
So we pre-empt the problem by replacing t's RHS with an absent filler.
Simple and effective.
-}
tryWW :: WwOpts
-> RecFlag
-> Id -- The fn binder
-> CoreExpr -- The bound rhs; its innards
-- are already ww'd
-> UniqSM [(Id, CoreExpr)] -- either *one* or *two* pairs;
-- if one, then no worker (only
-- the orig "wrapper" lives on);
-- if two, then a worker and a
-- wrapper.
tryWW ww_opts is_rec fn_id rhs
-- See Note [Drop absent bindings]
| isAbsDmd (demandInfo fn_info)
, not (isJoinId fn_id)
, Just filler <- mkAbsentFiller ww_opts fn_id NotMarkedStrict
= return [(new_fn_id, filler)]
-- See Note [Don't w/w INLINE things]
| hasInlineUnfolding fn_info
= return [(new_fn_id, rhs)]
-- See Note [No worker/wrapper for record selectors]
| isRecordSelector fn_id
= return [ (new_fn_id, rhs ) ]
-- Don't w/w OPAQUE things
-- See Note [OPAQUE pragma]
--
-- Whilst this check might seem superfluous, since we strip boxity
-- information in GHC.Core.Opt.DmdAnal.finaliseArgBoxities and
-- CPR information in GHC.Core.Opt.CprAnal.cprAnalBind, it actually
-- isn't. That is because we would still perform w/w when:
--
-- - An argument is used strictly, and -fworker-wrapper-cbv is
-- enabled, or,
-- - When demand analysis marks an argument as absent.
--
-- In a debug build we do assert that boxity and CPR information
-- are actually stripped, since we want to prevent callers of OPAQUE
-- things to do reboxing. See:
-- - Note [The OPAQUE pragma and avoiding the reboxing of arguments]
-- - Note [The OPAQUE pragma and avoiding the reboxing of results]
| isOpaquePragma (inlinePragInfo fn_info)
= assertPpr (onlyBoxedArguments (dmdSigInfo fn_info) &&
isTopCprSig (cprSigInfo fn_info))
(text "OPAQUE fun with boxity" $$
ppr new_fn_id $$
ppr (dmdSigInfo fn_info) $$
ppr (cprSigInfo fn_info) $$
ppr rhs) $
return [ (new_fn_id, rhs) ]
-- Do this even if there is a NOINLINE pragma
-- See Note [Worker/wrapper for NOINLINE functions]
| is_fun
= splitFun ww_opts new_fn_id rhs
-- See Note [Thunk splitting]
| isNonRec is_rec, is_thunk
= splitThunk ww_opts is_rec new_fn_id rhs
| otherwise
= return [ (new_fn_id, rhs) ]
where
fn_info = idInfo fn_id
(wrap_dmds, _) = splitDmdSig (dmdSigInfo fn_info)
new_fn_id = zap_join_cpr $ zap_usage fn_id
zap_usage = zapIdUsedOnceInfo . zapIdUsageEnvInfo
-- See Note [Zapping DmdEnv after Demand Analyzer] and
-- See Note [Zapping Used Once info in WorkWrap]
zap_join_cpr id
| isJoinId id = id `setIdCprSig` topCprSig
| otherwise = id
-- See Note [Don't w/w join points for CPR]
is_fun = notNull wrap_dmds || isJoinId fn_id
is_thunk = not is_fun && not (exprIsHNF rhs) && not (isJoinId fn_id)
&& not (isUnliftedType (idType fn_id))
{-
Note [Zapping DmdEnv after Demand Analyzer]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In the worker-wrapper pass we zap the DmdEnv. Why?
(a) it is never used again
(b) it wastes space
(c) it becomes incorrect as things are cloned, because
we don't push the substitution into it
Why here?
* Because we don’t want to do it in the Demand Analyzer, as we never know
there when we are doing the last pass.
* We want them to be still there at the end of DmdAnal, so that
-ddump-str-anal contains them.
* We don’t want a second pass just for that.
* WorkWrap looks at all bindings anyway.
We also need to do it in TidyCore.tidyLetBndr to clean up after the
final, worker/wrapper-less run of the demand analyser (see
Note [Final Demand Analyser run] in GHC.Core.Opt.DmdAnal).
Note [Zapping Used Once info in WorkWrap]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
During the work/wrap pass, using zapIdUsedOnceInfo, we zap the "used once" info
* on every binder (let binders, case binders, lambda binders)
* in both demands and in strictness signatures
* recursively
Why?
* The simplifier may happen to transform code in a way that invalidates the
data (see #11731 for an example).
* It is not used in later passes, up to code generation.
At first it's hard to see how the simplifier might invalidate it (and
indeed for a while I thought it couldn't: #19482), but it's not quite
as simple as I thought. Consider this:
{-# STRICTNESS SIG <SP(M,A)> #-}
f p = let v = case p of (a,b) -> a
in p `seq` (v,v)
I think we'll give `f` the strictness signature `<SP(M,A)>`, where the
`M` says that we'll evaluate the first component of the pair at most
once. Why? Because the RHS of the thunk `v` is evaluated at most
once.
But now let's worker/wrapper f:
{-# STRICTNESS SIG <M> #-}
$wf p1 = let p2 = absentError "urk" in
let p = (p1,p2) in
let v = case p of (a,b) -> a
in p `seq` (v,v)
where I've gotten the demand on `p1` by decomposing the P(M,A) argument demand.
This rapidly simplifies to
{-# STRICTNESS SIG <M> #-}
$wf p1 = let v = p1 in
(v,v)
and thence to `(p1,p1)` by inlining the trivial let. Now the demand on `p1` should
not be at most once!!
Conclusion: used-once info is fragile to simplification, because of
the non-monotonic behaviour of let's, which turn used-many into
used-once. So indeed we should zap this info in worker/wrapper.
Conclusion: kill it during worker/wrapper, using `zapUsedOnceInfo`.
Both the *demand signature* of the binder, and the *demand-info* of
the binder. Moreover, do so recursively.
You might wonder: why do we generate used-once info if we then throw
it away. The main reason is that we do a final run of the demand analyser,
immediately before CoreTidy, which is /not/ followed by worker/wrapper; it
is there only to generate used-once info for single-entry thunks.
Note [Don't eta expand in w/w]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
A binding where the manifestArity of the RHS is less than idArity of
the binder means GHC.Core.Opt.Arity didn't eta expand that binding
When this happens, it does so for a reason (see Note [Arity invariants for bindings]
in GHC.Core.Opt.Arity) and we probably have a PAP, cast or trivial expression
as RHS.
Below is a historical account of what happened when w/w still did eta expansion.
Nowadays, it doesn't do that, but will simply w/w for the wrong arity, unleashing
a demand signature meant for e.g. 2 args to be unleashed for e.g. 1 arg
(manifest arity). That's at least as terrible as doing eta expansion, so don't
do it.
---
When worker/wrapper did eta expansion, it implictly eta expanded the binding to
idArity, overriding GHC.Core.Opt.Arity's decision. Other than playing fast and loose with
divergence, it's also broken for newtypes:
f = (\xy.blah) |> co
where
co :: (Int -> Int -> Char) ~ T
Then idArity is 2 (despite the type T), and it can have a DmdSig based on a
threshold of 2. But we can't w/w it without a type error.
The situation is less grave for PAPs, but the implicit eta expansion caused a
compiler allocation regression in T15164, where huge recursive instance method
groups, mostly consisting of PAPs, got w/w'd. This caused great churn in the
simplifier, when simply waiting for the PAPs to inline arrived at the same
output program.
Note there is the worry here that such PAPs and trivial RHSs might not *always*
be inlined. That would lead to reboxing, because the analysis tacitly assumes
that we W/W'd for idArity and will propagate analysis information under that
assumption. So far, this doesn't seem to matter in practice.
See https://gitlab.haskell.org/ghc/ghc/merge_requests/312#note_192064.
Note [Inline pragma for certainlyWillInline]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Consider this (#19824 comment on 15 May 21):
f _ (x,y) = ...big...
v = ...big...
g x = f v x + 1
So `f` will generate a worker/wrapper split; and `g` (since it is small)
will trigger the certainlyWillInline case of splitFun. The danger is that
we end up with
g {- StableUnfolding = \x -> f v x + 1 -}
= ...blah...
Since (a) that unfolding for g is AlwaysActive
(b) the unfolding for f's wrapper is ActiveAfterInitial
the call of f will never inline in g's stable unfolding, thereby
keeping `v` alive.
I thought of changing g's unfolding to be ActiveAfterInitial, but that
too is bad: it delays g's inlining into other modules, which makes fewer
specialisations happen. Example in perf/should_run/DeriveNull.
So I decided to live with the problem. In fact v's RHS will be replaced
by LitRubbish (see Note [Drop absent bindings]) so there is no great harm.
-}
---------------------
splitFun :: WwOpts -> Id -> CoreExpr -> UniqSM [(Id, CoreExpr)]
splitFun ww_opts fn_id rhs
| Just (arg_vars, body) <- collectNValBinders_maybe (length wrap_dmds) rhs
= warnPprTrace (not (wrap_dmds `lengthIs` (arityInfo fn_info)))
"splitFun"
(ppr fn_id <+> (ppr wrap_dmds $$ ppr cpr)) $
do { mb_stuff <- mkWwBodies ww_opts fn_id arg_vars (exprType body) wrap_dmds cpr
; case mb_stuff of
Nothing -> -- No useful wrapper; leave the binding alone
return [(fn_id, rhs)]
Just stuff
| let opt_wwd_rhs = simpleOptExpr (wo_simple_opts ww_opts) rhs
-- We need to stabilise the WW'd (and optimised) RHS below
, Just stable_unf <- certainlyWillInline uf_opts fn_info opt_wwd_rhs
-- We could make a w/w split, but in fact the RHS is small
-- See Note [Don't w/w inline small non-loop-breaker things]
, let id_w_unf = fn_id `setIdUnfolding` stable_unf
-- See Note [Inline pragma for certainlyWillInline]
-> return [ (id_w_unf, rhs) ]
| otherwise
-> do { work_uniq <- getUniqueM
; return (mkWWBindPair ww_opts fn_id fn_info arg_vars body
work_uniq div stuff) } }
| otherwise -- See Note [Don't eta expand in w/w]
= return [(fn_id, rhs)]
where
uf_opts = so_uf_opts (wo_simple_opts ww_opts)
fn_info = idInfo fn_id
(wrap_dmds, div) = splitDmdSig (dmdSigInfo fn_info)
cpr_ty = getCprSig (cprSigInfo fn_info)
-- Arity of the CPR sig should match idArity when it's not a join point.
-- See Note [Arity trimming for CPR signatures] in GHC.Core.Opt.CprAnal
cpr = assertPpr (isJoinId fn_id || cpr_ty == topCprType || ct_arty cpr_ty == arityInfo fn_info)
(ppr fn_id <> colon <+> text "ct_arty:" <+> int (ct_arty cpr_ty)
<+> text "arityInfo:" <+> ppr (arityInfo fn_info)) $
ct_cpr cpr_ty
mkWWBindPair :: WwOpts -> Id -> IdInfo
-> [Var] -> CoreExpr -> Unique -> Divergence
-> ([Demand],JoinArity, Id -> CoreExpr, Expr CoreBndr -> CoreExpr)
-> [(Id, CoreExpr)]
mkWWBindPair ww_opts fn_id fn_info fn_args fn_body work_uniq div
(work_demands, join_arity, wrap_fn, work_fn)
= -- pprTrace "mkWWBindPair" (ppr fn_id <+> ppr wrap_id <+> ppr work_id $$ ppr wrap_rhs) $
[(work_id, work_rhs), (wrap_id, wrap_rhs)]
-- Worker first, because wrapper mentions it
where
arity = arityInfo fn_info
-- The arity is set by the simplifier using exprEtaExpandArity
-- So it may be more than the number of top-level-visible lambdas
simpl_opts = wo_simple_opts ww_opts
work_rhs = work_fn (mkLams fn_args fn_body)
work_act = case fn_inline_spec of -- See Note [Worker activation]
NoInline _ -> inl_act fn_inl_prag
_ -> inl_act wrap_prag
work_prag = InlinePragma { inl_src = SourceText "{-# INLINE"
, inl_inline = fn_inline_spec
, inl_sat = Nothing
, inl_act = work_act
, inl_rule = FunLike }
-- inl_inline: copy from fn_id; see Note [Worker/wrapper for INLINABLE functions]
-- inl_act: see Note [Worker activation]
-- inl_rule: it does not make sense for workers to be constructorlike.
work_join_arity | isJoinId fn_id = Just join_arity
| otherwise = Nothing
-- worker is join point iff wrapper is join point
-- (see Note [Don't w/w join points for CPR])
work_id = asWorkerLikeId $
mkWorkerId work_uniq fn_id (exprType work_rhs)
`setIdOccInfo` occInfo fn_info
-- Copy over occurrence info from parent
-- Notably whether it's a loop breaker
-- Doesn't matter much, since we will simplify next, but
-- seems right-er to do so
`setInlinePragma` work_prag
`setIdUnfolding` mkWorkerUnfolding simpl_opts work_fn fn_unfolding
-- See Note [Worker/wrapper for INLINABLE functions]
`setIdDmdSig` mkClosedDmdSig work_demands div
-- Even though we may not be at top level,
-- it's ok to give it an empty DmdEnv
`setIdCprSig` topCprSig
`setIdDemandInfo` worker_demand
`setIdArity` work_arity
-- Set the arity so that the Core Lint check that the
-- arity is consistent with the demand type goes
-- through
`asJoinId_maybe` work_join_arity
work_arity = length work_demands :: Int
-- See Note [Demand on the worker]
single_call = saturatedByOneShots arity (demandInfo fn_info)
worker_demand | single_call = mkWorkerDemand work_arity
| otherwise = topDmd
wrap_rhs = wrap_fn work_id
wrap_prag = mkStrWrapperInlinePrag fn_inl_prag fn_rules
wrap_unf = mkWrapperUnfolding simpl_opts wrap_rhs arity
wrap_id = fn_id `setIdUnfolding` wrap_unf
`setInlinePragma` wrap_prag
`setIdOccInfo` noOccInfo
-- Zap any loop-breaker-ness, to avoid bleating from Lint
-- about a loop breaker with an INLINE rule
fn_inl_prag = inlinePragInfo fn_info
fn_inline_spec = inl_inline fn_inl_prag
fn_unfolding = realUnfoldingInfo fn_info
fn_rules = ruleInfoRules (ruleInfo fn_info)
mkStrWrapperInlinePrag :: InlinePragma -> [CoreRule] -> InlinePragma
mkStrWrapperInlinePrag (InlinePragma { inl_inline = fn_inl
, inl_act = fn_act
, inl_rule = rule_info }) rules
= InlinePragma { inl_src = SourceText "{-# INLINE"
, inl_sat = Nothing
, inl_inline = fn_inl
-- See Note [Worker/wrapper for INLINABLE functions]
, inl_act = activeAfter wrapper_phase
-- See Note [Wrapper activation]
, inl_rule = rule_info } -- RuleMatchInfo is (and must be) unaffected
where
-- See Note [Wrapper activation]
wrapper_phase = foldr (laterPhase . get_rule_phase) earliest_inline_phase rules
earliest_inline_phase = beginPhase fn_act `laterPhase` nextPhase InitialPhase
-- laterPhase (nextPhase InitialPhase) is a temporary hack
-- to inline no earlier than phase 2. I got regressions in
-- 'mate', due to changes in full laziness due to Note [Case
-- MFEs], when I did earlier inlining.
get_rule_phase :: CoreRule -> CompilerPhase
-- The phase /after/ the rule is first active
get_rule_phase rule = nextPhase (beginPhase (ruleActivation rule))
{-
Note [Demand on the worker]
~~~~~~~~~~~~~~~~~~~~~~~~~~~
If the original function is called once, according to its demand info, then
so is the worker. This is important so that the occurrence analyser can
attach OneShot annotations to the worker’s lambda binders.
Example:
-- Original function
f [Demand=<L,1*C(1,U)>] :: (a,a) -> a
f = \p -> ...
-- Wrapper
f [Demand=<L,1*C(1,U)>] :: a -> a -> a
f = \p -> case p of (a,b) -> $wf a b
-- Worker
$wf [Demand=<L,1*C(1,C(1,U))>] :: Int -> Int
$wf = \a b -> ...
We need to check whether the original function is called once, with
sufficiently many arguments. This is done using saturatedByOneShots, which
takes the arity of the original function (resp. the wrapper) and the demand on
the original function.
The demand on the worker is then calculated using mkWorkerDemand, and always of
the form [Demand=<L,1*(C(1,...(C(1,U))))>]
Note [Thunk splitting]
~~~~~~~~~~~~~~~~~~~~~~
Suppose x is used strictly; never mind whether it has the CPR
property. I'll use a '*' to mean "x* is demanded strictly".
let
x* = x-rhs
in body
splitThunk transforms like this:
let
x* = let x = x-rhs in
case x of { I# a -> I# a }
in body
This is a little strange: we are re-using the same `x` in the RHS; and
the RHS takes `x` apart and reboxes it. But because the outer 'let' is
strict, and the inner let mentions `x` only once, the simplifier
transform it to
case x-rhs of
I# a -> let x* = I# a
in body
That is good: in `body` we know the form of `x`, which
* gives the CPR property, and
* allows case-of-case to happen on x
Notes
* I tried transforming like this:
let
x* = let x = x-rhs in
case x of { I# a -> x }
in body
where I return `x` itself, rather than reboxing it. But this
turned out to cause some regressions, which I never fully
investigated.
* Suppose x-rhs is itself a case:
x-rhs = case e of { T -> I# e1; F -> I# e2 }
Then we'll get
join j a = let x* = I# a in body
in case e of { T -> j e1; F -> j e2 }
which is good (no boxing). But in the original, unsplit program
we would transform
let x* = case e of ... in body
==> join j2 x = body
in case e of { T -> j2 (I# e1); F -> j (I# e2) }
which is not good (boxing).
* In fact, splitThunk uses the function argument w/w splitting
function, mkWWstr_one, so that if x's demand is deeper (say U(U(L,L),L))
then the splitting will go deeper too.
* For recursive thunks, the Simplifier is unable to float `x-rhs` out of
`x*`'s RHS, because `x*` occurs freely in `x-rhs`, and will just change it
back to the original definition, so we just split non-recursive thunks.
Note [Thunk splitting for top-level binders]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Top-level bindings are never strict. Yet they can be absent, as T14270 shows:
module T14270 (mkTrApp) where
mkTrApp x y
| Just ... <- ... typeRepKind x ...
= undefined
| otherwise
= undefined
typeRepKind = Tick scc undefined
(T19180 is a profiling-free test case for this)
Note that `typeRepKind` is not exported and its only use site in
`mkTrApp` guards a bottoming expression. Thus, demand analysis
figures out that `typeRepKind` is absent and splits the thunk to
typeRepKind =
let typeRepKind = Tick scc undefined in
let typeRepKind = absentError in
typeRepKind
But now we have a local binding with an External Name
(See Note [About the NameSorts]). That will trigger a CoreLint error, which we
get around by localising the Id for the auxiliary bindings in 'splitThunk'.
-}
-- | See Note [Thunk splitting].
--
-- splitThunk converts the *non-recursive* binding
-- x = e
-- into
-- x = let x' = e in
-- case x' of I# y -> let x' = I# y in x'
-- See comments above. Is it not beautifully short?
-- Moreover, it works just as well when there are
-- several binders, and if the binders are lifted
-- E.g. x = e
-- --> x = let x' = e in
-- case x' of (a,b) -> let x' = (a,b) in x'
-- Here, x' is a localised version of x, in case x is a
-- top-level Id with an External Name, because Lint rejects local binders with
-- External Names; see Note [About the NameSorts] in GHC.Types.Name.
--
-- How can we do thunk-splitting on a top-level binder? See
-- Note [Thunk splitting for top-level binders].
splitThunk :: WwOpts -> RecFlag -> Var -> Expr Var -> UniqSM [(Var, Expr Var)]
splitThunk ww_opts is_rec x rhs
= assert (not (isJoinId x)) $
do { let x' = localiseId x -- See comment above
; (useful,_args, wrap_fn, fn_arg)
<- mkWWstr_one ww_opts x' NotMarkedStrict
; let res = [ (x, Let (NonRec x' rhs) (wrap_fn fn_arg)) ]
; if useful then assertPpr (isNonRec is_rec) (ppr x) -- The thunk must be non-recursive
return res
else return [(x, rhs)] }
|