1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
|
Subject: FTBFS with -Werror=format-security
Author: Thibaut Paumard <paumard@users.sourceforge.net>
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=643387
Forwarded: https://bugzilla.gnome.org/show_bug.cgi?id=660250
Last-Update: 2011-09-27
Debian started building with -Werror=format-security by default. This
causes FTBFS (on purpose) on calls such as "printf(msg)". This patch
corrects such calls to "printf("%s", msg)".
--- a/gap/gap_arr_dialog.c
+++ b/gap/gap_arr_dialog.c
@@ -1859,7 +1859,7 @@
if(run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message (msg);
+ g_message ("%s", msg);
}
}
}
--- a/gap/gap_split.c
+++ b/gap/gap_split.c
@@ -347,7 +347,7 @@
errMsg = g_strdup_printf(_("failed to overwrite %s (check permissions ?)")
, l_sav_name);
- g_message(errMsg);
+ g_message("%s", errMsg);
g_free(errMsg);
writePermission = FALSE;
}
--- a/gap/gap_fmac_base.c
+++ b/gap/gap_fmac_base.c
@@ -96,7 +96,7 @@
{
if(run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message(msg);
+ g_message("%s", msg);
}
printf("%s\n", msg);
g_free(msg);
--- a/gap/gap_fmac_main.c
+++ b/gap/gap_fmac_main.c
@@ -365,7 +365,7 @@
{
if(run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message(msg);
+ g_message("%s", msg);
}
printf("%s\n", msg);
g_free(msg);
--- a/gap/gap_morph_exec.c
+++ b/gap/gap_morph_exec.c
@@ -204,7 +204,7 @@
if(run_mode != GIMP_RUN_NONINTERACTIVE)
{
- g_message(l_msg);
+ g_message("%s", l_msg);
}
g_free(l_msg);
--- a/gap/gap_vex_dialog.c
+++ b/gap/gap_vex_dialog.c
@@ -912,7 +912,7 @@
break;
}
g_snprintf(gpp->val.preferred_decoder, sizeof(gpp->val.preferred_decoder)
- , preferred_decoder
+ , "%s", preferred_decoder
);
entry = GTK_ENTRY(gpp->mw__entry_preferred_decoder);
if(entry)
--- a/libgapvidutil/gap_gve_sox.c
+++ b/libgapvidutil/gap_gve_sox.c
@@ -153,7 +153,7 @@
, cval->tmp_audfile);
if(cval->run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message(l_msg);
+ g_message("%s", l_msg);
}
return -1;
}
@@ -175,7 +175,7 @@
);
if(cval->run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message(l_msg);
+ g_message("%s", l_msg);
}
g_free(l_msg);
return -1;
--- a/vid_common/gap_cme_gui.c
+++ b/vid_common/gap_cme_gui.c
@@ -2035,7 +2035,7 @@
, (int)(gpp->val.vid_width / 16) * 16
, (int)(gpp->val.vid_height / 16) * 16
);
- g_message(l_msg);
+ g_message("%s", l_msg);
g_free(l_msg);
return (FALSE);
}
@@ -2058,7 +2058,7 @@
, (int)bits
, gpp->val.audioname1
);
- g_message(l_msg);
+ g_message("%s", l_msg);
g_free(l_msg);
return (FALSE);
}
@@ -2077,7 +2077,7 @@
"file: %s\n")
, gpp->val.audioname1
);
- g_message(l_msg);
+ g_message("%s", l_msg);
g_free(l_msg);
return (FALSE);
}
@@ -2101,7 +2101,7 @@
"supported rates: \n"
" 22050, 24000, 32000, 44100, 48000")
, (int)gpp->val.samplerate);
- g_message(l_msg);
+ g_message("%s", l_msg);
g_free(l_msg);
return (FALSE);
break;
@@ -2129,7 +2129,7 @@
"supported rates:\n"
" 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000")
, (int)gpp->val.samplerate);
- g_message(l_msg);
+ g_message("%s", l_msg);
g_free(l_msg);
return (FALSE);
break;
@@ -3929,7 +3929,7 @@
l_msg = g_strdup_printf(_("Required Plugin %s not available"), gpp->val.ecp_sel.vid_enc_plugin);
if(gpp->val.run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message(l_msg);
+ g_message("%s", l_msg);
}
g_free(l_msg);
return -1;
@@ -3981,7 +3981,7 @@
l_msg = g_strdup_printf(_("Call of Required Plugin %s failed"), gpp->val.ecp_sel.vid_enc_plugin);
if(gpp->val.run_mode == GIMP_RUN_INTERACTIVE)
{
- g_message(l_msg);
+ g_message("%s", l_msg);
}
g_free(l_msg);
}
|