1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385
|
/** @file exam_paranoia.cpp
*
* This set of tests checks for some of GiNaC's oopses which showed up during
* development. Things were evaluated wrongly and so. Such a sick behaviour
* shouldn't occur any more. But we are paranoic and we want to exclude these
* these oopses for good, so we run those stupid tests... */
/*
* GiNaC Copyright (C) 1999-2002 Johannes Gutenberg University Mainz, Germany
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
#include "exams.h"
// The very first pair of historic problems had its roots in power.cpp and was
// finally resolved on April 27th 1999. (Fixing the first on April 23rd
// actually introduced the second.)
static unsigned exam_paranoia1(void)
{
unsigned result = 0;
symbol x("x"), y("y"), z("z");
ex e, f, g;
e = x * y * z;
f = y * z;
g = e / f;
// In the first one expand did not do any job at all:
if (!g.expand().is_equal(x)) {
clog << "e = x*y*z; f = y*z; expand(e/f) erroneously returned "
<< g.expand() << endl;
++result;
}
// This one somehow used to return 0:
e = pow(x + 1, -1);
if (!e.expand().is_equal(e)) {
clog << "expand(pow(x + 1, -1)) erroneously returned "
<< e.expand() << endl;
++result;
}
return result;
}
// And here the second oops which showed up until May 17th 1999. It had to do
// with lexicographic canonicalization and thus showed up only if the variables
// had the names as given here:
static unsigned exam_paranoia2(void)
{
unsigned result = 0;
symbol x("x"), y("y"), z("z");
ex e, f, g;
e = x + z*x;
f = e*y;
g = f - e*y;
// After .expand(), g should be zero:
if (!g.expand().is_zero()) {
clog << "e = (x + z*x); f = e*y; expand(f - e*y) erroneously returned "
<< g.expand() << endl;
++result;
}
// After .eval(), g should be zero:
if (!g.eval().is_zero()) {
clog << "e = (x + z*x); f = e*y; eval(f - e*y) erroneously returned "
<< g.eval() << endl;
++result;
}
// This actually worked already back in April 1999.
// But we are *very* paranoic!
if (!g.expand().eval().is_zero()) {
clog << "e = (x + z*x); f = e*y; eval(expand(f - e*y)) erroneously returned "
<< g.expand().eval() << endl;
++result;
}
return result;
}
// The third bug was introduced on May 18th 1999, discovered on May 19 and
// fixed that same day. It worked when x was substituted by 1 but not with
// other numbers:
static unsigned exam_paranoia3(void)
{
unsigned result = 0;
symbol x("x"), y("y");
ex e, f;
e = x*y - y;
f = e.subs(x == 2);
if (!f.is_equal(y)) {
clog << "e = x*y - y; f = e.subs(x == 2) erroneously returned "
<< f << endl;
++result;
}
if (!f.eval().is_equal(y)) {
clog << "e = x*y - y; eval(e.subs(x == 2)) erroneously returned "
<< f.eval() << endl;
++result;
}
if (!f.expand().is_equal(y)) {
clog << "e = x*y - y; expand(e.subs(x == 2)) erroneously returned "
<< f.expand() << endl;
++result;
}
return result;
}
// The fourth bug was also discovered on May 19th 1999 and fixed immediately:
static unsigned exam_paranoia4(void)
{
unsigned result = 0;
symbol x("x");
ex e, f, g;
e = pow(x, 2) + x + 1;
f = pow(x, 2) + x + 1;
g = e - f;
if (!g.is_zero()) {
clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g erroneously returned "
<< g << endl;
++result;
}
if (!g.is_zero()) {
clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g.eval() erroneously returned "
<< g.eval() << endl;
++result;
}
return result;
}
// The fifth oops was discovered on May 20th 1999 and fixed a day later:
static unsigned exam_paranoia5(void)
{
unsigned result = 0;
symbol x("x"), y("y");
ex e, f;
e = pow(x*y + 1, 2);
f = pow(x, 2) * pow(y, 2) + 2*x*y + 1;
if (!(e-f).expand().is_zero()) {
clog << "e = pow(x*y+1,2); f = pow(x,2)*pow(y,2) + 2*x*y + 1; (e-f).expand() erroneously returned "
<< (e-f).expand() << endl;
++result;
}
return result;
}
// This one was discovered on Jun 1st 1999 and fixed the same day:
static unsigned exam_paranoia6(void)
{
unsigned result = 0;
symbol x("x");
ex e, f;
e = pow(x, -5);
f = e.denom();
if (!f.is_equal(pow(x, 5))) {
clog << "e = pow(x, -5); f = e.denom(); f was " << f << " (should be x^5)" << endl;
++result;
}
return result;
}
// This one was introduced on June 1st 1999 by some aggressive manual
// optimization. Discovered and fixed on June 2nd.
static unsigned exam_paranoia7(void)
{
unsigned result = 0;
symbol x("x"), y("y");
ex e = y + y*x + 2;
ex f = expand(pow(e, 2) - (e*y*(x + 1)));
if (f.nops() > 3) {
clog << "e=y+y*x+2; f=expand(pow(e,2)-(e*y*(x+1))) has "
<< f.nops() << " arguments instead of 3 ( f=="
<< f << " )" << endl;
++result;
}
return result;
}
// This one was a result of the rewrite of mul::max_coefficient when we
// introduced the overall_coefficient field in expairseq objects on Oct 1st
// 1999. Fixed on Oct 4th.
static unsigned exam_paranoia8(void)
{
unsigned result = 0;
symbol x("x");
ex e = -x / (x+1);
ex f;
try {
f = e.normal();
if (!f.is_equal(e)) {
clog << "normal(-x/(x+1)) returns " << f << " instead of -x/(x+1)\n";
++result;
}
} catch (const exception &err) {
clog << "normal(-x/(x+1) throws " << err.what() << endl;
++result;
}
return result;
}
// This one was a result of a modification to frac_cancel() & Co. to avoid
// expanding the numerator and denominator when bringing them from Q[X] to
// Z[X]. multiply_lcm() forgot to multiply the x-linear term with the LCM of
// the coefficient's denominators (2 in this case). Introduced on Jan 25th
// 2000 and fixed on Jan 31th.
static unsigned exam_paranoia9(void)
{
unsigned result = 0;
symbol x("x");
ex e = (exp(-x)-2*x*exp(-x)+pow(x,2)/2*exp(-x))/exp(-x);
ex f = e.normal();
if (!f.is_equal(1-2*x+pow(x,2)/2)) {
clog << "normal(" << e << ") returns " << f << " instead of 1-2*x+1/2*x^2\n";
++result;
}
return result;
}
// I have no idea when this broke. It has been working long ago, before 0.4.0
// and on Feb 13th 2000 I found out that things like 2^(3/2) throw an exception
// "power::eval(): pow(0,0) is undefined" instead of simplifying to 2*2^(1/2).
// It was fixed that same day.
static unsigned exam_paranoia10(void)
{
unsigned result = 0;
ex b = numeric(2);
ex e = numeric(3,2);
ex r;
try {
r = pow(b,e).eval();
if (!(r-2*sqrt(ex(2))).is_zero()) {
clog << "2^(3/2) erroneously returned " << r << " instead of 2*sqrt(2)" << endl;
++result;
}
} catch (const exception &err) {
clog << "2^(3/2) throws " << err.what() << endl;
++result;
}
return result;
}
// After the rewriting of basic::normal() & Co. to return {num, den} lists,
// add::normal() forgot to multiply the denominator of the overall_coeff of
// its expanded and normalized children with the denominator of the expanded
// child (did you get this? Well, never mind...). Fixed on Feb 21th 2000.
static unsigned exam_paranoia11(void)
{
unsigned result = 0;
symbol x("x");
ex e = ((-5-2*x)-((2-5*x)/(-2+x))*(3+2*x))/(5-4*x);
ex f = e.normal();
ex d = (4+10*x+8*pow(x,2))/(x-2)/(5-4*x);
if (!(f - d).expand().is_zero()) {
clog << "normal(" << e << ") returns " << f << " instead of " << d << endl;
++result;
}
return result;
}
// This one returned 0 because add::normal() incorrectly assumed that if the
// common denominator is 1, all the denominators would be 1 (they can in fact
// be +/-1). Fixed on Aug 2nd 2000.
static unsigned exam_paranoia12(void)
{
unsigned result = 0;
symbol x("x");
ex e = 2-2*(1+x)/(-1-x);
ex f = e.normal();
ex d = 4;
if (!(f - d).expand().is_zero()) {
clog << "normal(" << e << ") returns " << f
<< " instead of " << d << endl;
++result;
}
return result;
}
// This one caused a division by 0 because heur_gcd() didn't check its
// input polynomials against 0. Fixed on Aug 4th 2000.
static unsigned exam_paranoia13(void)
{
unsigned result = 0;
symbol a("a"), b("b"), c("c");
ex e = (b*a-c*a)/(4-a);
ex d = (c*a-b*a)/(a-4);
try {
ex f = e.normal();
if (!(f - d).expand().is_zero()) {
clog << "normal(" << e << ") returns " << f
<< " instead of " << d << endl;
++result;
}
} catch (const exception &err) {
clog << "normal(" << e << ") throws " << err.what() << endl;
++result;
}
return result;
}
// A bug introduced on July 19, 2001. quo() and rem() would sometimes call
// vector::reserve() with a negative argument. Fixed on Dec 20, 2001.
static unsigned exam_paranoia14(void)
{
unsigned result = 0;
symbol x("x");
ex q = quo(1, pow(x, 3), x);
if (!q.is_zero()) {
clog << "quo(1,x^3,x) erroneously returned " << q << " instead of 0\n";
++result;
}
return result;
}
unsigned exam_paranoia(void)
{
unsigned result = 0;
cout << "examining several historic failures just out of paranoia" << flush;
clog << "----------several historic failures:" << endl;
result += exam_paranoia1(); cout << '.' << flush;
result += exam_paranoia2(); cout << '.' << flush;
result += exam_paranoia3(); cout << '.' << flush;
result += exam_paranoia4(); cout << '.' << flush;
result += exam_paranoia5(); cout << '.' << flush;
result += exam_paranoia6(); cout << '.' << flush;
result += exam_paranoia7(); cout << '.' << flush;
result += exam_paranoia8(); cout << '.' << flush;
result += exam_paranoia9(); cout << '.' << flush;
result += exam_paranoia10(); cout << '.' << flush;
result += exam_paranoia11(); cout << '.' << flush;
result += exam_paranoia12(); cout << '.' << flush;
result += exam_paranoia13(); cout << '.' << flush;
result += exam_paranoia14(); cout << '.' << flush;
if (!result) {
cout << " passed " << endl;
clog << "(no output)" << endl;
} else {
cout << " failed " << endl;
}
return result;
}
|