1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242
|
/** @file parser_bugs.cpp
*
* Check for some silly bugs in the parser. */
/*
* GiNaC Copyright (C) 1999-2025 Johannes Gutenberg University Mainz, Germany
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include "ginac.h"
using namespace GiNaC;
#include <iostream>
#include <sstream>
#include <stdexcept>
#include <string>
using namespace std;
// - a - b was misparsed as -a + b due to a bug in parser::parse_unary_expr()
static int check1(ostream& err_str)
{
const string srep("-a-b");
parser reader;
ex e = reader(srep);
ex a = reader.get_syms()["a"];
ex b = reader.get_syms()["b"];
ex g = - a - b;
ex d = (e - g).expand();
if (!d.is_zero()) {
err_str << "\"" << srep << "\" was misparsed as \""
<< e << "\"" << endl;
return 1;
}
return 0;
}
/// Parser was rejecting the valid expression '5 - (3*x)/10'.
static int check2(ostream& err_str)
{
const string srep("5-(3*x)/10");
parser reader;
ex e = reader(srep);
ex x = reader.get_syms()["x"];
ex g = 5 - (3*x)/10;
ex d = (e - g).expand();
if (!d.is_zero()) {
err_str << "\"" << srep << "\" was misparsed as \""
<< e << "\"" << endl;
return 1;
}
return 0;
}
/// parse_literal_expr forget to consume the token, so parser get
/// very confused.
static int check3(ostream& err_str)
{
const string srep("5-(2*I)/3");
parser reader;
ex e = reader(srep);
ex g = numeric(5) - (numeric(2)*I)/3;
ex d = (e - g).expand();
if (!d.is_zero()) {
err_str << "\"" << srep << "\" was misparsed as \""
<< e << "\"" << endl;
return 1;
}
return 0;
}
/// parser happily accepted various junk like 'x^2()+1'
static int check4(ostream& err_str)
{
const string junk("x^2()+1");
parser reader;
ex e;
try {
e = reader(junk);
err_str << "parser accepts junk: \"" << junk << "\"" << endl;
return 1;
} catch (parse_error& err) {
// Ok, parser rejects the nonsense.
return 0;
}
}
// Check that two strings parse to equal expressions.
static int check_eq(ostream &err_str, parser &reader, const char *expr1, const char *expr2)
{
const string srep1(expr1);
const string srep2(expr2);
ex e1, e2;
try{ e1 = reader(srep1); } catch (const exception &e) {
err_str << "\"" << srep1 << "\" failed to parse: "
<< e.what() << endl;
return 1;
}
try{ e2 = reader(srep2); } catch (const exception &e) {
err_str << "\"" << srep2 << "\" failed to parse: "
<< e.what() << endl;
return 1;
}
if (!(e1-e2).expand().is_zero()) {
err_str << "\"" << srep1 << "\" was misparsed as \""
<< e1 << "\"" << endl;
return 1;
}
return 0;
}
// Tests for the interaction of the '^' operator with
// the unary '+' and the unary '-' operators
static int check5(ostream& err_str)
{
parser reader;
return
+check_eq(err_str, reader, "3^2+1", "10")
+check_eq(err_str, reader, "3^+2-1", "8")
+check_eq(err_str, reader, "3^-2+1", "10/9")
+check_eq(err_str, reader, "3^-2/5", "1/45")
+check_eq(err_str, reader, "3^-2*5", "5/9")
+check_eq(err_str, reader, "3^-2-5", "-44/9")
+check_eq(err_str, reader, "3^(-2)+1", "10/9")
+check_eq(err_str, reader, "(3)^(-2)+1", "10/9")
+check_eq(err_str, reader, "+3^2+1", "10")
+check_eq(err_str, reader, "+3^+2+1", "10")
+check_eq(err_str, reader, "+3^-2+1", "10/9")
+check_eq(err_str, reader, "+3^-2/5", "1/45")
+check_eq(err_str, reader, "+3^-2*5", "5/9")
+check_eq(err_str, reader, "+3^-2-5", "-44/9")
+check_eq(err_str, reader, "-3^2+1", "-8")
+check_eq(err_str, reader, "-3^+2+1", "-8")
+check_eq(err_str, reader, "-3^-2+1", "8/9")
+check_eq(err_str, reader, "-3^-2/3", "-1/27")
+check_eq(err_str, reader, "1+2^3^4", "1+(2^81)")
+check_eq(err_str, reader, "2^3^4+1", "1+(2^81)")
+check_eq(err_str, reader, "2^+3^4+1", "1+(2^81)")
+check_eq(err_str, reader, "2^3^+4+1", "1+(2^81)");
}
// Tests for the interaction of the '*' operator with
// the unary '+' and the unary '-' operators
static int check6(ostream& err_str)
{
parser reader;
return
+check_eq(err_str, reader, "3*+2-1", "5")
+check_eq(err_str, reader, "3*2+1", "7")
+check_eq(err_str, reader, "3*+2+1", "7")
+check_eq(err_str, reader, "3*-2+1", "-5")
+check_eq(err_str, reader, "3*-2/5", "-6/5")
+check_eq(err_str, reader, "3*-2*5", "-30")
+check_eq(err_str, reader, "3*-2-5", "-11")
+check_eq(err_str, reader, "3*(-2)+1", "-5")
+check_eq(err_str, reader, "(3)*(-2)+1", "-5")
+check_eq(err_str, reader, "+3*2+1", "7")
+check_eq(err_str, reader, "+3*+2+1", "7")
+check_eq(err_str, reader, "+3*-2+1", "-5")
+check_eq(err_str, reader, "+3*-2/5", "-6/5")
+check_eq(err_str, reader, "+3*-2*5", "-30")
+check_eq(err_str, reader, "+3*-2-5", "-11")
+check_eq(err_str, reader, "-3*2+1", "-5")
+check_eq(err_str, reader, "-3*+2+1", "-5")
+check_eq(err_str, reader, "-3*-2+1", "7")
+check_eq(err_str, reader, "-3*-2/3", "2")
+check_eq(err_str, reader, "1+2*3*4", "25")
+check_eq(err_str, reader, "2*3*4+1", "25")
+check_eq(err_str, reader, "2*+3*4+1", "25")
+check_eq(err_str, reader, "2*3*+4+1", "25");
}
// Tests for nested unary + and unary -
static int check7(ostream& err_str)
{
parser reader;
return
+check_eq(err_str, reader, "+1", "1")
+check_eq(err_str, reader, "++1", "1")
+check_eq(err_str, reader, "+-+1", "-1")
+check_eq(err_str, reader, "+-+-1", "1")
+check_eq(err_str, reader, "+-+-+1", "1")
+check_eq(err_str, reader, "100++--+1+10", "111");
}
// Tests involving functions and constants (including their evaluation)
static int check8(ostream& err_str)
{
parser reader;
return
+check_eq(err_str, reader, "sqrt(x)+sqrt(x)", "2*sqrt(x)")
+check_eq(err_str, reader, "sqrt(x)-sqrt(x)", "0")
+check_eq(err_str, reader, "sqrt(x)+sqrt(y)", "sqrt(x)+sqrt(y)")
+check_eq(err_str, reader, "sqrt(x)^2", "x")
+check_eq(err_str, reader, "sqrt(x^2)", "sqrt(x^2)")
+check_eq(err_str, reader, "pow(x^2,2)", "pow(x,4)")
+check_eq(err_str, reader, "pow(x^(1/2),2)", "x")
+check_eq(err_str, reader, "pow(z^1/2,2)", "(z^2)/4")
+check_eq(err_str, reader, "log(x)+log(x)", "2*log(x)")
+check_eq(err_str, reader, "log(x)-log(x)", "0")
+check_eq(err_str, reader, "exp(log(x))", "x")
+check_eq(err_str, reader, "log(exp(x))", "log(exp(x))")
+check_eq(err_str, reader, "sin(asin(x))", "x")
+check_eq(err_str, reader, "asin(sin(x))", "asin(sin(x))")
+check_eq(err_str, reader, "cos(acos(x))", "x")
+check_eq(err_str, reader, "cos(acos(asin(sin(tan(atan(x))))))", "asin(sin(x))")
+check_eq(err_str, reader, "cos(Pi)+sin(Pi/2)", "0")
+check_eq(err_str, reader, "Pi-I-2+Euler", "Euler+Pi-I-2");
}
int main(int argc, char** argv)
{
cout << "examining parser" << flush;
ostringstream err_str;
int errors = 0;
errors += check1(err_str); cout << '.' << flush;
errors += check2(err_str); cout << '.' << flush;
errors += check3(err_str); cout << '.' << flush;
errors += check4(err_str); cout << '.' << flush;
errors += check5(err_str); cout << '.' << flush;
errors += check6(err_str); cout << '.' << flush;
errors += check7(err_str); cout << '.' << flush;
errors += check8(err_str); cout << '.' << flush;
if (errors) {
clog << "Yes, unfortunately: " << endl;
clog << err_str.str();
}
return errors;
}
|