File: comment_7_edb649d0019a061ef7bf6534a444429d._comment

package info (click to toggle)
git-annex 5.20141125
  • links: PTS
  • area: main
  • in suites: jessie, jessie-kfreebsd
  • size: 37,828 kB
  • ctags: 583
  • sloc: haskell: 42,582; sh: 1,080; ansic: 498; makefile: 316; perl: 125
file content (16 lines) | stat: -rw-r--r-- 805 bytes parent folder | download | duplicates (11) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
 
[[!comment format=mdwn
 username="https://www.google.com/accounts/o8/id?id=AItOawmkBwMWvNKZZCge_YqobCSILPMeK6xbFw8"
 nickname="TobiasTheViking"
 subject="comment 7"
 date="2013-12-31T18:20:32Z"
 content="""
I think the hook running anything in shell, to interact with git annex, is a mistake.

I see a lot more potential pitfalls and mistakes(especially crossplatform). 

It should be the existing git annex plumbing (preferred content) as you say. I just really think it should be configurable in the protocol, instead of a having to run a shell command. 

Since you have made this advanced protocol i really see it as a mistake to do anything between the hook and git-annex outside of the protocol, it makes much more sense to have all their interactions happen within the protocol.

IMO anyways.
"""]]