File: day_94__leaks.mdwn

package info (click to toggle)
git-annex 6.20170101-1%2Bdeb9u2
  • links: PTS
  • area: main
  • in suites: stretch
  • size: 50,088 kB
  • sloc: haskell: 53,116; sh: 1,582; ansic: 341; makefile: 292; perl: 144
file content (12 lines) | stat: -rw-r--r-- 658 bytes parent folder | download | duplicates (11)
1
2
3
4
5
6
7
8
9
10
11
12
Spent ages tracking down a memory leak in the assistant that showed up when
a lot of files were added. Turned out to be a standard haskell laziness
induced problem, fixed by adding strictness annotations. Actually there
were several of them, that leaked at different rates. Eventually, I seem to
have gotten them all fixed:

Before: [[bugs/import_memleak_from_the_assistant/leakbefore.png]]
After: [[bugs/import_memleak_from_the_assistant/leakafter.png]]

Also fixed a bug in `git annex add` when the disk was completely full.
In that situation, it could sometimes move the file from the work tree to
.git/annex/objects and fail to put the symlink in place.