1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
|
package git
import (
"bytes"
"io"
"testing"
"github.com/git-lfs/pktline"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestFilterProcessScannerInitializesWithCorrectSupportedValues(t *testing.T) {
var from, to bytes.Buffer
pl := pktline.NewPktline(nil, &from)
if err := pl.WritePacketText("git-filter-client"); err != nil {
t.Fatalf("expected... %v", err.Error())
}
require.Nil(t, pl.WritePacketText("git-filter-client"))
require.Nil(t, pl.WritePacketList([]string{"version=2"}))
fps := NewFilterProcessScanner(&from, &to)
err := fps.Init()
assert.Nil(t, err)
out, err := pktline.NewPktline(&to, nil).ReadPacketList()
assert.Nil(t, err)
assert.Equal(t, []string{"git-filter-server", "version=2"}, out)
}
func TestFilterProcessScannerRejectsUnrecognizedInitializationMessages(t *testing.T) {
var from, to bytes.Buffer
pl := pktline.NewPktline(nil, &from)
require.Nil(t, pl.WritePacketText("git-filter-client-unknown"))
require.Nil(t, pl.WriteFlush())
fps := NewFilterProcessScanner(&from, &to)
err := fps.Init()
require.NotNil(t, err)
assert.Equal(t, "invalid filter-process pkt-line welcome message: git-filter-client-unknown", err.Error())
assert.Empty(t, to.Bytes())
}
func TestFilterProcessScannerRejectsUnsupportedFilters(t *testing.T) {
var from, to bytes.Buffer
pl := pktline.NewPktline(nil, &from)
require.Nil(t, pl.WritePacketText("git-filter-client"))
// Write an unsupported version
require.Nil(t, pl.WritePacketList([]string{"version=0"}))
fps := NewFilterProcessScanner(&from, &to)
err := fps.Init()
require.NotNil(t, err)
assert.Equal(t, "filter 'version=2' not supported (your Git supports: [version=0])", err.Error())
assert.Empty(t, to.Bytes())
}
func TestFilterProcessScannerNegotitatesSupportedCapabilities(t *testing.T) {
var from, to bytes.Buffer
pl := pktline.NewPktline(nil, &from)
require.Nil(t, pl.WritePacketList([]string{
"capability=clean", "capability=smudge", "capability=not-invented-yet",
}))
fps := NewFilterProcessScanner(&from, &to)
caps, err := fps.NegotiateCapabilities()
assert.Contains(t, caps, "capability=clean")
assert.Contains(t, caps, "capability=smudge")
assert.Nil(t, err)
out, err := pktline.NewPktline(&to, nil).ReadPacketList()
assert.Nil(t, err)
assert.Equal(t, []string{"capability=clean", "capability=smudge"}, out)
}
func TestFilterProcessScannerDoesNotNegotitatesUnsupportedCapabilities(t *testing.T) {
var from, to bytes.Buffer
pl := pktline.NewPktline(nil, &from)
// Write an unsupported capability
require.Nil(t, pl.WritePacketList([]string{
"capability=unsupported",
}))
fps := NewFilterProcessScanner(&from, &to)
caps, err := fps.NegotiateCapabilities()
require.NotNil(t, err)
assert.Empty(t, caps)
assert.Equal(t, "filter 'capability=clean' not supported (your Git supports: [capability=unsupported])", err.Error())
assert.Empty(t, to.Bytes())
}
func TestFilterProcessScannerReadsRequestHeadersAndPayload(t *testing.T) {
var from, to bytes.Buffer
pl := pktline.NewPktline(nil, &from)
// Headers
require.Nil(t, pl.WritePacketList([]string{
"foo=bar", "other=woot", "crazy='sq',\\$x=.bin",
}))
// Multi-line packet
require.Nil(t, pl.WritePacketText("first"))
require.Nil(t, pl.WritePacketText("second"))
require.Nil(t, pl.WriteFlush())
req, err := readRequest(NewFilterProcessScanner(&from, &to))
assert.Nil(t, err)
assert.Equal(t, req.Header["foo"], "bar")
assert.Equal(t, req.Header["other"], "woot")
assert.Equal(t, req.Header["crazy"], "'sq',\\$x=.bin")
payload, err := io.ReadAll(req.Payload)
assert.Nil(t, err)
assert.Equal(t, []byte("first\nsecond\n"), payload)
}
func TestFilterProcessScannerRejectsInvalidHeaderPackets(t *testing.T) {
from := bytes.NewBuffer([]byte{
0x30, 0x30, 0x30, 0x33, // 0003 (invalid packet length)
})
req, err := readRequest(NewFilterProcessScanner(from, nil))
require.NotNil(t, err)
assert.Equal(t, "Invalid packet length.", err.Error())
assert.Nil(t, req)
}
func TestFilterProcessScannerWritesLists(t *testing.T) {
var to bytes.Buffer
fps := NewFilterProcessScanner(nil, &to)
err := fps.WriteList([]string{"hello", "goodbye"})
assert.NoError(t, err)
assert.Equal(t, "000ahello\n000cgoodbye\n0000", to.String())
}
// readRequest performs a single scan operation on the given
// `*FilterProcessScanner`, "s", and returns: an error if there was one, or a
// request if there was one. If neither, it returns (nil, nil).
func readRequest(s *FilterProcessScanner) (*Request, error) {
s.Scan()
if err := s.Err(); err != nil {
return nil, err
}
return s.Request(), nil
}
|
