1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
|
package main
import (
"bytes"
"errors"
"fmt"
"github.com/git-lfs/git-lfs/v3/tools"
"github.com/git-lfs/git-lfs/v3/tq"
)
// "upload" - all missing
func uploadAllMissing(manifest tq.Manifest, oidsExist, oidsMissing []TestObject) error {
retobjs, err := callBatchApi(manifest, tq.Upload, oidsMissing)
if err != nil {
return err
}
if len(retobjs) != len(oidsMissing) {
return fmt.Errorf("incorrect number of returned objects, expected %d, got %d", len(oidsMissing), len(retobjs))
}
var errbuf bytes.Buffer
for _, o := range retobjs {
rel, _ := o.Rel("upload")
if rel == nil {
errbuf.WriteString(fmt.Sprintf("Missing upload link for %s\n", o.Oid))
}
// verify link is optional so don't check
}
if errbuf.Len() > 0 {
return errors.New(errbuf.String())
}
return nil
}
// "upload" - all present
func uploadAllExists(manifest tq.Manifest, oidsExist, oidsMissing []TestObject) error {
retobjs, err := callBatchApi(manifest, tq.Upload, oidsExist)
if err != nil {
return err
}
if len(retobjs) != len(oidsExist) {
return fmt.Errorf("incorrect number of returned objects, expected %d, got %d", len(oidsExist), len(retobjs))
}
var errbuf bytes.Buffer
for _, o := range retobjs {
link, _ := o.Rel("upload")
if link != nil {
errbuf.WriteString(fmt.Sprintf("Upload link should not exist for %s, was %+v\n", o.Oid, link))
}
}
if errbuf.Len() > 0 {
return errors.New(errbuf.String())
}
return nil
}
// "upload" - mix of missing & present
func uploadMixed(manifest tq.Manifest, oidsExist, oidsMissing []TestObject) error {
existSet := tools.NewStringSetWithCapacity(len(oidsExist))
for _, o := range oidsExist {
existSet.Add(o.Oid)
}
missingSet := tools.NewStringSetWithCapacity(len(oidsMissing))
for _, o := range oidsMissing {
missingSet.Add(o.Oid)
}
calloids := interleaveTestData(oidsExist, oidsMissing)
retobjs, err := callBatchApi(manifest, tq.Upload, calloids)
if err != nil {
return err
}
count := len(oidsExist) + len(oidsMissing)
if len(retobjs) != count {
return fmt.Errorf("incorrect number of returned objects, expected %d, got %d", count, len(retobjs))
}
var errbuf bytes.Buffer
for _, o := range retobjs {
link, _ := o.Rel("upload")
if existSet.Contains(o.Oid) {
if link != nil {
errbuf.WriteString(fmt.Sprintf("Upload link should not exist for %s, was %+v\n", o.Oid, link))
}
}
if missingSet.Contains(o.Oid) && link == nil {
errbuf.WriteString(fmt.Sprintf("Missing upload link for %s\n", o.Oid))
}
}
if errbuf.Len() > 0 {
return errors.New(errbuf.String())
}
return nil
}
func uploadEdgeCases(manifest tq.Manifest, oidsExist, oidsMissing []TestObject) error {
errorCases := make([]TestObject, 0, 5)
errorCodeMap := make(map[string]int, 5)
errorReasonMap := make(map[string]string, 5)
validCases := make([]TestObject, 0, 1)
validReasonMap := make(map[string]string, 5)
// Invalid SHAs - code 422
// Too short
sha := "a345cde"
errorCases = append(errorCases, TestObject{Oid: sha, Size: 99})
errorCodeMap[sha] = 422
errorReasonMap[sha] = "SHA is too short"
// Too long
sha = "1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
errorCases = append(errorCases, TestObject{Oid: sha, Size: 99})
errorCodeMap[sha] = 422
errorReasonMap[sha] = "SHA is too long"
// Invalid characters -----!---------------------------------!
sha = "bf3e3e2af9366a3b704ax0c31de5afa64193ebabffde2091936ad2G7510bc03a"
errorCases = append(errorCases, TestObject{Oid: sha, Size: 99})
errorCodeMap[sha] = 422
errorReasonMap[sha] = "SHA contains invalid characters"
// Invalid size - code 422
sha = "e3bf3e2af9366a3b704af0c31de5afa64193ebabffde2091936ad237510bc03a"
errorCases = append(errorCases, TestObject{Oid: sha, Size: -1})
errorCodeMap[sha] = 422
errorReasonMap[sha] = "Negative size"
sha = "d2983e2af9366a3b704af0c31de5afa64193ebabffde2091936ad237510bc03a"
errorCases = append(errorCases, TestObject{Oid: sha, Size: -125})
errorCodeMap[sha] = 422
errorReasonMap[sha] = "Negative size"
// Zero size - should be allowed
sha = "159f6ac723b9023b704af0c31de5afa64193ebabffde2091936ad237510bc03a"
validCases = append(validCases, TestObject{Oid: sha, Size: 0})
validReasonMap[sha] = "Zero size should be allowed"
calloids := interleaveTestData(errorCases, validCases)
retobjs, err := callBatchApi(manifest, tq.Upload, calloids)
if err != nil {
return err
}
count := len(errorCases) + len(validCases)
if len(retobjs) != count {
return fmt.Errorf("incorrect number of returned objects, expected %d, got %d", count, len(retobjs))
}
var errbuf bytes.Buffer
for _, o := range retobjs {
link, _ := o.Rel("upload")
if code, iserror := errorCodeMap[o.Oid]; iserror {
reason, _ := errorReasonMap[o.Oid]
if link != nil {
errbuf.WriteString(fmt.Sprintf("Upload link should not exist for %s, was %+v, reason %s\n", o.Oid, link, reason))
}
if o.Error == nil {
errbuf.WriteString(fmt.Sprintf("Upload should include an error for invalid object %s, reason %s", o.Oid, reason))
} else if o.Error.Code != code {
errbuf.WriteString(fmt.Sprintf("Upload error code for missing object %s should be %d, got %d, reason %s\n", o.Oid, code, o.Error.Code, reason))
}
}
if reason, reasonok := validReasonMap[o.Oid]; reasonok {
if link == nil {
errbuf.WriteString(fmt.Sprintf("Missing upload link for %s, should be present because %s\n", o.Oid, reason))
}
}
}
if errbuf.Len() > 0 {
return errors.New(errbuf.String())
}
return nil
}
func init() {
addTest("Test upload: all missing", uploadAllMissing)
addTest("Test upload: all present", uploadAllExists)
addTest("Test upload: mixed", uploadMixed)
addTest("Test upload: edge cases", uploadEdgeCases)
}
|
