1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
|
import unittest
from click.testing import CliRunner as CLIRunner
from click import utils as click_utils
import mock
from git_pw import series
@mock.patch('git_pw.api.detail')
@mock.patch('git_pw.api.download')
@mock.patch('git_pw.utils.git_am')
class ApplyTestCase(unittest.TestCase):
def test_apply_without_args(self, mock_git_am, mock_download, mock_detail):
"""Validate calling with no arguments."""
rsp = {'mbox': 'http://example.com/api/patches/123/mbox/'}
mock_detail.return_value = rsp
mock_download.return_value = 'test.patch'
runner = CLIRunner()
result = runner.invoke(series.apply_cmd, ['123'])
assert result.exit_code == 0, result
mock_detail.assert_called_once_with('series', 123)
mock_download.assert_called_once_with(rsp['mbox'])
mock_git_am.assert_called_once_with(mock_download.return_value, ())
def test_apply_with_args(self, mock_git_am, mock_download, mock_detail):
"""Validate passthrough of arbitrary arguments to git-am."""
rsp = {'mbox': 'http://example.com/api/patches/123/mbox/'}
mock_detail.return_value = rsp
mock_download.return_value = 'test.patch'
runner = CLIRunner()
result = runner.invoke(series.apply_cmd, ['123', '-3'])
assert result.exit_code == 0, result
mock_detail.assert_called_once_with('series', 123)
mock_download.assert_called_once_with(rsp['mbox'])
mock_git_am.assert_called_once_with(mock_download.return_value,
('-3',))
@mock.patch('git_pw.api.detail')
@mock.patch('git_pw.api.download')
class DownloadTestCase(unittest.TestCase):
def test_download(self, mock_download, mock_detail):
"""Validate standard behavior."""
rsp = {'mbox': 'http://example.com/api/patches/123/mbox/'}
mock_detail.return_value = rsp
runner = CLIRunner()
result = runner.invoke(series.download_cmd, ['123'])
assert result.exit_code == 0, result
mock_detail.assert_called_once_with('series', 123)
mock_download.assert_called_once_with(rsp['mbox'], output=None)
def test_download_to_file(self, mock_download, mock_detail):
"""Validate downloading to a file."""
rsp = {'mbox': 'http://example.com/api/patches/123/mbox/'}
mock_detail.return_value = rsp
runner = CLIRunner()
result = runner.invoke(series.download_cmd, ['123', 'test.patch'])
assert result.exit_code == 0, result
mock_detail.assert_called_once_with('series', 123)
mock_download.assert_called_once_with(rsp['mbox'], output=mock.ANY)
assert isinstance(
mock_download.call_args[1]['output'], click_utils.LazyFile,
)
class ShowTestCase(unittest.TestCase):
@staticmethod
def _get_series(**kwargs):
rsp = {
'id': 123,
'date': '2017-01-01 00:00:00',
'name': 'Sample series',
'submitter': {
'name': 'foo',
'email': 'foo@bar.com',
},
'project': {
'name': 'bar',
},
'version': '1',
'total': 2,
'received_total': 2,
'received_all': True,
'cover_letter': None,
'patches': [],
}
rsp.update(**kwargs)
return rsp
@mock.patch('git_pw.api.detail')
def test_show(self, mock_detail):
"""Validate standard behavior."""
rsp = self._get_series()
mock_detail.return_value = rsp
runner = CLIRunner()
result = runner.invoke(series.show_cmd, ['123'])
assert result.exit_code == 0, result
mock_detail.assert_called_once_with('series', 123)
@mock.patch('git_pw.api.version', return_value=(1, 0))
@mock.patch('git_pw.api.index')
@mock.patch('git_pw.utils.echo_via_pager')
class ListTestCase(unittest.TestCase):
@staticmethod
def _get_series(**kwargs):
return ShowTestCase._get_series(**kwargs)
@staticmethod
def _get_people(**kwargs):
rsp = {
'id': 1,
'name': 'John Doe',
'email': 'john@example.com',
}
rsp.update(**kwargs)
return rsp
def test_list(self, mock_echo, mock_index, mock_version):
"""Validate standard behavior."""
rsp = [self._get_series()]
mock_index.return_value = rsp
runner = CLIRunner()
result = runner.invoke(series.list_cmd, [])
assert result.exit_code == 0, result
mock_index.assert_called_once_with('series', [
('q', None), ('page', None), ('per_page', None),
('order', '-date')])
def test_list_with_formatting(self, mock_echo, mock_index, mock_version):
"""Validate behavior with formatting applied."""
rsp = [self._get_series()]
mock_index.return_value = rsp
runner = CLIRunner()
result = runner.invoke(series.list_cmd, [
'--format', 'simple', '--column', 'ID', '--column', 'Name'])
assert result.exit_code == 0, result
mock_echo.assert_called_once_with(mock.ANY, ('ID', 'Name'),
fmt='simple')
def test_list_with_filters(self, mock_echo, mock_index, mock_version):
"""Validate behavior with filters applied.
Apply all filters, including those for pagination.
"""
people_rsp = [self._get_people()]
series_rsp = [self._get_series()]
mock_index.side_effect = [people_rsp, series_rsp]
runner = CLIRunner()
result = runner.invoke(series.list_cmd, [
'--submitter', 'john@example.com', '--submitter', '2',
'--limit', 1, '--page', 1, '--sort', '-name', 'test'])
assert result.exit_code == 0, result
calls = [
mock.call('people', [('q', 'john@example.com')]),
mock.call('series', [
('submitter', 1), ('submitter', '2'), ('q', 'test'),
('page', 1), ('per_page', 1), ('order', '-name')])]
mock_index.assert_has_calls(calls)
@mock.patch('git_pw.api.LOG')
def test_list_with_wildcard_filters(self, mock_log, mock_echo, mock_index,
mock_version):
"""Validate behavior with a "wildcard" filter.
Patchwork API v1.0 did not support multiple filters correctly. Ensure
the user is warned as necessary if a filter has multiple matches.
"""
people_rsp = [self._get_people(), self._get_people()]
series_rsp = [self._get_series()]
mock_index.side_effect = [people_rsp, series_rsp]
runner = CLIRunner()
runner.invoke(series.list_cmd, ['--submitter', 'john@example.com'])
assert mock_log.warning.called
@mock.patch('git_pw.api.LOG')
def test_list_with_multiple_filters(self, mock_log, mock_echo, mock_index,
mock_version):
"""Validate behavior with use of multiple filters.
Patchwork API v1.0 did not support multiple filters correctly. Ensure
the user is warned as necessary if they specify multiple filters.
"""
people_rsp = [self._get_people()]
series_rsp = [self._get_series()]
mock_index.side_effect = [people_rsp, people_rsp, series_rsp]
runner = CLIRunner()
result = runner.invoke(series.list_cmd, [
'--submitter', 'john@example.com',
'--submitter', 'jimmy@example.com'])
assert result.exit_code == 0, result
assert mock_log.warning.called
@mock.patch('git_pw.api.LOG')
def test_list_api_v1_1(self, mock_log, mock_echo, mock_index,
mock_version):
"""Validate behavior with API v1.1."""
mock_version.return_value = (1, 1)
people_rsp = [self._get_people()]
series_rsp = [self._get_series()]
mock_index.side_effect = [people_rsp, series_rsp]
runner = CLIRunner()
result = runner.invoke(series.list_cmd, [
'--submitter', 'jimmy@example.com',
'--submitter', 'John Doe'])
assert result.exit_code == 0, result
# We should have only made a single call to '/people' since API v1.1
# supports filtering with emails natively
calls = [
mock.call('people', [('q', 'John Doe')]),
mock.call('series', [
('submitter', 'jimmy@example.com'), ('submitter', 1),
('q', None), ('page', None), ('per_page', None),
('order', '-date')])]
mock_index.assert_has_calls(calls)
# We shouldn't see a warning about multiple versions either
assert not mock_log.warning.called
|
