File: test_unit.py

package info (click to toggle)
git-review 2.4.0-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 468 kB
  • sloc: python: 2,722; makefile: 150
file content (471 lines) | stat: -rw-r--r-- 17,601 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
# -*- coding: utf-8 -*-

# Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
# implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import argparse
import functools
import io
import os
import sys
import textwrap
from unittest import mock

import fixtures
import testtools

from git_review import cmd
from git_review.tests import IsoEnvDir
from git_review.tests import utils


class ConfigTestCase(testtools.TestCase):
    """Class testing config behavior."""

    @mock.patch('git_review.cmd.LOCAL_MODE',
                mock.PropertyMock(return_value=True))
    @mock.patch('git_review.cmd.git_directories', return_value=['', 'fake'])
    @mock.patch('git_review.cmd.run_command_exc')
    def test_git_local_mode(self, run_mock, dir_mock):
        cmd.git_config_get_value('abc', 'def')
        run_mock.assert_called_once_with(
            cmd.GitConfigException,
            'git', 'config', '-f', 'fake/config', '--get', 'abc.def')

    @mock.patch('git_review.cmd.LOCAL_MODE',
                mock.PropertyMock(return_value=True))
    @mock.patch('os.path.exists', return_value=False)
    def test_gitreview_local_mode(self, exists_mock):
        cmd.Config()
        self.assertFalse(exists_mock.called)


class GitReviewConsole(testtools.TestCase, fixtures.TestWithFixtures):
    """Class for testing the console output of git-review."""

    reviews = [
        {
            'number': '1010101',
            'branch': 'master',
            'subject': 'A simple short subject',
            'topic': 'simple-topic'
        }, {
            'number': 9877,  # Starting with 2.14, numbers are sent as int
            'branch': 'stable/codeword',
            'subject': 'A longer and slightly more wordy subject'
        }, {
            'number': '12345',
            'branch': 'master',
            'subject': 'A ridiculously long subject that can exceed the '
                       'normal console width, just need to ensure the '
                       'max width is short enough'
        }]

    def setUp(self):
        # will set up isolated env dir
        super(GitReviewConsole, self).setUp()

        # ensure all tests get a separate git dir to work in to avoid
        # local git config from interfering
        iso_env = self.useFixture(IsoEnvDir())

        self._run_git = functools.partial(utils.run_git,
                                          chdir=iso_env.work_dir)

        self.run_cmd_patcher = mock.patch('git_review.cmd.run_command_status')
        run_cmd_partial = functools.partial(
            cmd.run_command_status, GIT_WORK_TREE=iso_env.work_dir,
            GIT_DIR=os.path.join(iso_env.work_dir, '.git'))
        self.run_cmd_mock = self.run_cmd_patcher.start()
        self.run_cmd_mock.side_effect = run_cmd_partial

        self._run_git('init')
        self._run_git('commit', '--allow-empty', '-m "initial commit"')
        self._run_git('commit', '--allow-empty', '-m "2nd commit"')

    def tearDown(self):
        self.run_cmd_patcher.stop()
        super(GitReviewConsole, self).tearDown()

    @mock.patch('git_review.cmd.get_version',
                side_effect=cmd.GitReviewException(u"simple-toπ㌀c"))
    def test_print_exception_with_unicode(self, exists_mock):

        try:
            with mock.patch('sys.argv', ['git-review', '--version']):
                with self.assertRaisesRegex(SystemExit, '1'):
                    cmd.main()
        except Exception as e:
            self.fail('Exception not expected: %s' % e)

    @mock.patch('git_review.cmd.query_reviews')
    @mock.patch('git_review.cmd.get_remote_url', mock.MagicMock)
    @mock.patch('git_review.cmd._has_color', False)
    def test_list_reviews_output(self, mock_query):

        mock_query.return_value = self.reviews
        with mock.patch('sys.stdout', new_callable=io.StringIO) as output:
            cmd.list_reviews(None, None)
            console_output = output.getvalue().split('\n')

        self.assertEqual(
            ['1010101           master  A simple short subject',
             '   9877  stable/codeword  A longer and slightly more wordy '
             'subject'],
            console_output[:2])

    @mock.patch('git_review.cmd.query_reviews')
    @mock.patch('git_review.cmd.get_remote_url', mock.MagicMock)
    @mock.patch('git_review.cmd._has_color', False)
    def test_list_reviews_output_with_topic(self, mock_query):

        mock_query.return_value = self.reviews
        with mock.patch('sys.stdout', new_callable=io.StringIO) as output:
            cmd.list_reviews(None, None, with_topic=True)
            console_output = output.getvalue().split('\n')

        self.assertEqual(
            ['1010101           master  simple-topic  A simple short subject',
             '   9877  stable/codeword             -  A longer and slightly '
             'more wordy subject'],
            console_output[:2])

    @mock.patch('git_review.cmd.query_reviews')
    @mock.patch('git_review.cmd.get_remote_url', mock.MagicMock)
    @mock.patch('git_review.cmd._has_color', False)
    def test_list_reviews_no_blanks(self, mock_query):

        mock_query.return_value = self.reviews
        with mock.patch('sys.stdout', new_callable=io.StringIO) as output:
            cmd.list_reviews(None, None)
            console_output = output.getvalue().split('\n')

        wrapper = textwrap.TextWrapper(replace_whitespace=False,
                                       drop_whitespace=False)
        for text in console_output:
            for line in wrapper.wrap(text):
                self.assertEqual(line.isspace(), False,
                                 "Extra blank lines appearing between reviews"
                                 "in console output")

    @mock.patch('git_review.cmd._use_color', None)
    def test_color_output_disabled(self):
        """Test disabling of colour output color.ui defaults to enabled
        """

        # git versions < 1.8.4 default to 'color.ui' being false
        # so must be set to auto to correctly test
        self._run_git("config", "color.ui", "auto")

        self._run_git("config", "color.review", "never")
        self.assertFalse(cmd.check_use_color_output(),
                         "Failed to detect color output disabled")

    @mock.patch('git_review.cmd._use_color', None)
    def test_color_output_forced(self):
        """Test force enable of colour output when color.ui
        is defaulted to false
        """

        self._run_git("config", "color.ui", "never")

        self._run_git("config", "color.review", "always")
        self.assertTrue(cmd.check_use_color_output(),
                        "Failed to detect color output forcefully "
                        "enabled")

    @mock.patch('git_review.cmd._use_color', None)
    def test_color_output_fallback(self):
        """Test fallback to using color.ui when color.review is not
        set
        """

        self._run_git("config", "color.ui", "always")
        self.assertTrue(cmd.check_use_color_output(),
                        "Failed to use fallback to color.ui when "
                        "color.review not present")


class FakeResponse(object):

    def __init__(self, code, text=""):
        self.status_code = code
        self.text = text


class FakeException(Exception):

    def __init__(self, code, *args, **kwargs):
        super(FakeException, self).__init__(*args, **kwargs)
        self.code = code


FAKE_GIT_CREDENTIAL_FILL = """\
protocol=http
host=gerrit.example.com
username=user
password=pass
"""


class ResolveTrackingUnitTest(testtools.TestCase):
    """Class for testing resolve_tracking."""
    def setUp(self):
        testtools.TestCase.setUp(self)
        patcher = mock.patch('git_review.cmd.run_command_exc')
        self.addCleanup(patcher.stop)
        self.run_command_exc = patcher.start()

    def test_track_local_branch(self):
        'Test that local tracked branch is not followed.'
        self.run_command_exc.side_effect = [
            '',
            'refs/heads/other/branch',
        ]
        self.assertEqual(cmd.resolve_tracking(u'remote', u'rbranch'),
                         (u'remote', u'rbranch'))

    def test_track_untracked_branch(self):
        'Test that local untracked branch is not followed.'
        self.run_command_exc.side_effect = [
            '',
            '',
        ]
        self.assertEqual(cmd.resolve_tracking(u'remote', u'rbranch'),
                         (u'remote', u'rbranch'))

    def test_track_remote_branch(self):
        'Test that remote tracked branch is followed.'
        self.run_command_exc.side_effect = [
            '',
            'refs/remotes/other/branch',
        ]
        self.assertEqual(cmd.resolve_tracking(u'remote', u'rbranch'),
                         (u'other', u'branch'))

    def test_track_git_error(self):
        'Test that local tracked branch is not followed.'
        self.run_command_exc.side_effect = [cmd.CommandFailed(1, '', [], {})]
        self.assertRaises(cmd.CommandFailed,
                          cmd.resolve_tracking, u'remote', u'rbranch')


class GitReviewUnitTest(testtools.TestCase):
    """Class for misc unit tests."""

    @mock.patch('requests.get', return_value=FakeResponse(404))
    def test_run_http_exc_raise_http_error(self, mock_get):
        url = 'http://gerrit.example.com'
        try:
            cmd.run_http_exc(FakeException, url)
            self.fails('Exception expected')
        except FakeException as err:
            self.assertEqual(cmd.http_code_2_return_code(404), err.code)
            mock_get.assert_called_once_with(url)

    @mock.patch('requests.get', side_effect=Exception())
    def test_run_http_exc_raise_unknown_error(self, mock_get):
        url = 'http://gerrit.example.com'
        try:
            cmd.run_http_exc(FakeException, url)
            self.fails('Exception expected')
        except FakeException as err:
            self.assertEqual(255, err.code)
            mock_get.assert_called_once_with(url)

    @mock.patch('git_review.cmd.run_command_status')
    @mock.patch('requests.get', return_value=FakeResponse(200))
    def test_run_http_exc_without_auth(self, mock_get, mock_run):
        url = 'http://user@gerrit.example.com'

        cmd.run_http_exc(FakeException, url)
        self.assertFalse(mock_run.called)
        mock_get.assert_called_once_with(url)

    @mock.patch('git_review.cmd.run_command_status',
                return_value=(0, FAKE_GIT_CREDENTIAL_FILL))
    @mock.patch('requests.get',
                side_effect=[FakeResponse(401), FakeResponse(200)])
    def test_run_http_exc_with_auth(self, mock_get, mock_run):
        url = 'http://user@gerrit.example.com'

        cmd.run_http_exc(FakeException, url)
        # This gets encoded to utf8 which means the type passed down
        # is bytes.
        mock_run.assert_called_once_with('git', 'credential', 'fill',
                                         stdin='url=%s' % url)
        calls = [mock.call(url), mock.call(url, auth=('user', 'pass'))]
        mock_get.assert_has_calls(calls)

    @mock.patch('git_review.cmd.run_command_status',
                return_value=(0, FAKE_GIT_CREDENTIAL_FILL))
    @mock.patch('requests.get', return_value=FakeResponse(401))
    def test_run_http_exc_with_failing_auth(self, mock_get, mock_run):
        url = 'http://user@gerrit.example.com'

        try:
            cmd.run_http_exc(FakeException, url)
            self.fails('Exception expected')
        except FakeException as err:
            self.assertEqual(cmd.http_code_2_return_code(401), err.code)
        # This gets encoded to utf8 which means the type passed down
        # is bytes.
        mock_run.assert_called_once_with('git', 'credential', 'fill',
                                         stdin='url=%s' % url)
        calls = [mock.call(url), mock.call(url, auth=('user', 'pass'))]
        mock_get.assert_has_calls(calls)

    @mock.patch('git_review.cmd.run_command_status',
                return_value=(1, ''))
    @mock.patch('requests.get', return_value=FakeResponse(401))
    def test_run_http_exc_with_failing_git_creds(self, mock_get, mock_run):
        url = 'http://user@gerrit.example.com'

        try:
            cmd.run_http_exc(FakeException, url)
            self.fails('Exception expected')
        except FakeException as err:
            self.assertEqual(cmd.http_code_2_return_code(401), err.code)
        # This gets encoded to utf8 which means the type passed down
        # is bytes.
        mock_run.assert_called_once_with('git', 'credential', 'fill',
                                         stdin='url=%s' % url)
        mock_get.assert_called_once_with(url)

    @mock.patch('sys.argv', ['argv0', '--track', 'branch'])
    @mock.patch('git_review.cmd.check_remote')
    @mock.patch('git_review.cmd.resolve_tracking')
    def test_command_line_no_track(self, resolve_tracking, check_remote):
        check_remote.side_effect = Exception()
        self.assertRaises(Exception, cmd._main)
        self.assertFalse(resolve_tracking.called)

    @mock.patch('sys.argv', ['argv0', '--track'])
    @mock.patch('git_review.cmd.check_remote')
    @mock.patch('git_review.cmd.resolve_tracking')
    def test_track(self, resolve_tracking, check_remote):
        check_remote.side_effect = Exception()
        self.assertRaises(Exception, cmd._main)
        self.assertTrue(resolve_tracking.called)

    @mock.patch('sys.argv', ['argv0', '-n', '--notify', 'OWNER'])
    @mock.patch('git_review.cmd.check_remote')
    @mock.patch('git_review.cmd.rebase_changes')
    @mock.patch('git_review.cmd.set_hooks_commit_msg')
    @mock.patch('git_review.cmd.assert_one_change')
    @mock.patch('sys.stdout', io.StringIO())
    @mock.patch('sys.exit')
    def test_notify(self, check_remote, rebase, set_hooks, assert_one, exit):
        cmd._main()
        sys.stdout.seek(0)
        stdout = sys.stdout.read()
        self.assertIn("notify=OWNER", stdout)


class DownloadFlagUnitTest(testtools.TestCase):

    def setUp(self):
        super(DownloadFlagUnitTest, self).setUp()
        self.parser = argparse.ArgumentParser()
        self.parser.add_argument(
            '-d',
            action=cmd._DownloadFlag,
            const='download',
            dest='cid',
        )

    def test_store_id(self):
        args = self.parser.parse_args(['-d', '12345'])
        self.assertEqual('12345', args.cid)

    def test_parse_url(self):
        args = self.parser.parse_args(
            ['-d',
             'https://review.opendev.org/12345']
        )
        self.assertEqual('12345', args.cid)

    def test_parse_url_trailing_slash(self):
        args = self.parser.parse_args(
            ['-d',
             'https://review.opendev.org/12345/']
        )
        self.assertEqual('12345', args.cid)

    def test_parse_url_with_update(self):
        args = self.parser.parse_args(
            ['-d',
             'https://review.opendev.org/12345/2']
        )
        self.assertEqual('12345,2', args.cid)

    def test_parse_url_with_hash(self):
        args = self.parser.parse_args(
            ['-d',
             'https://review.opendev.org/#/c/12345']
        )
        self.assertEqual('12345', args.cid)

    def test_parse_url_with_hash_and_update(self):
        args = self.parser.parse_args(
            ['-d',
             'https://review.opendev.org/#/c/12345/1']
        )
        self.assertEqual('12345,1', args.cid)

    def test_parse_polygerrit_url(self):
        args = self.parser.parse_args(
            ['-d',
             'https://review.opendev.org/c/org/project/+/12345']
        )
        self.assertEqual('12345', args.cid)


class RepoUrlParsingTest(testtools.TestCase):
    """Test Git URL parsing"""

    def test_ssh_opendev(self):
        self.assertEqual(
            cmd.parse_gerrit_ssh_params_from_git_url(
                'ssh://someone@review.opendev.org:29418/x/y'),
            ('review.opendev.org', 'someone', '29418',
             'x/y'))

    def test_ssh_no_user_no_port(self):
        self.assertEqual(
            cmd.parse_gerrit_ssh_params_from_git_url(
                'ssh://review.opendev.org/opendev/git-review'),
            ('review.opendev.org', None, None, 'opendev/git-review'))

    def test_ssh_at_sign(self):
        self.assertEqual(
            cmd.parse_gerrit_ssh_params_from_git_url(
                'ssh://someone@example.org@review.opendev.org:29418/x/y'),
            ('review.opendev.org', 'someone@example.org', '29418',
             'x/y'))

    def test_ssh_at_signs_excessive(self):
        self.assertEqual(
            cmd.parse_gerrit_ssh_params_from_git_url(
                'ssh://x@y@example.org@review.opendev.org:29418/x/y'),
            ('review.opendev.org', 'x@y@example.org', '29418',
             'x/y'))

    def test_ssh_at_sign_escaped(self):
        self.assertEqual(
            cmd.parse_gerrit_ssh_params_from_git_url(
                r'ssh://someone%40example.org@review.opendev.org:29418/x/y'),
            ('review.opendev.org', r'someone%40example.org', '29418',
             'x/y'))