1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
|
#!/bin/sh
test_description='Test reffiles backend consistency check'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
GIT_TEST_DEFAULT_REF_FORMAT=files
export GIT_TEST_DEFAULT_REF_FORMAT
. ./test-lib.sh
test_expect_success 'ref name should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
tag_dir_prefix=.git/refs/tags &&
(
cd repo &&
git commit --allow-empty -m initial &&
git checkout -b default-branch &&
git tag default-tag &&
git tag multi_hierarchy/default-tag &&
cp $branch_dir_prefix/default-branch $branch_dir_prefix/@ &&
git refs verify 2>err &&
test_must_be_empty err &&
rm $branch_dir_prefix/@ &&
cp $tag_dir_prefix/default-tag $tag_dir_prefix/tag-1.lock &&
git refs verify 2>err &&
rm $tag_dir_prefix/tag-1.lock &&
test_must_be_empty err &&
cp $tag_dir_prefix/default-tag $tag_dir_prefix/.lock &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/tags/.lock: badRefName: invalid refname format
EOF
rm $tag_dir_prefix/.lock &&
test_cmp expect err &&
for refname in ".refname-starts-with-dot" "~refname-has-stride"
do
cp $branch_dir_prefix/default-branch "$branch_dir_prefix/$refname" &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/$refname: badRefName: invalid refname format
EOF
rm "$branch_dir_prefix/$refname" &&
test_cmp expect err || return 1
done &&
for refname in ".refname-starts-with-dot" "~refname-has-stride"
do
cp $tag_dir_prefix/default-tag "$tag_dir_prefix/$refname" &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/tags/$refname: badRefName: invalid refname format
EOF
rm "$tag_dir_prefix/$refname" &&
test_cmp expect err || return 1
done &&
for refname in ".refname-starts-with-dot" "~refname-has-stride"
do
cp $tag_dir_prefix/multi_hierarchy/default-tag "$tag_dir_prefix/multi_hierarchy/$refname" &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/tags/multi_hierarchy/$refname: badRefName: invalid refname format
EOF
rm "$tag_dir_prefix/multi_hierarchy/$refname" &&
test_cmp expect err || return 1
done &&
for refname in ".refname-starts-with-dot" "~refname-has-stride"
do
mkdir "$branch_dir_prefix/$refname" &&
cp $branch_dir_prefix/default-branch "$branch_dir_prefix/$refname/default-branch" &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/$refname/default-branch: badRefName: invalid refname format
EOF
rm -r "$branch_dir_prefix/$refname" &&
test_cmp expect err || return 1
done
)
'
test_expect_success 'ref name check should be adapted into fsck messages' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
(
cd repo &&
git commit --allow-empty -m initial &&
git checkout -b branch-1 &&
cp $branch_dir_prefix/branch-1 $branch_dir_prefix/.branch-1 &&
git -c fsck.badRefName=warn refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/.branch-1: badRefName: invalid refname format
EOF
rm $branch_dir_prefix/.branch-1 &&
test_cmp expect err &&
cp $branch_dir_prefix/branch-1 $branch_dir_prefix/.branch-1 &&
git -c fsck.badRefName=ignore refs verify 2>err &&
test_must_be_empty err
)
'
test_expect_success 'no refs directory of worktree should not cause problems' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
git worktree add --detach ./worktree &&
(
cd worktree &&
worktree_refdir="$(git rev-parse --git-dir)/refs" &&
# Simulate old directory layout
rmdir "$worktree_refdir" &&
git refs verify 2>err &&
test_must_be_empty err
)
)
'
test_expect_success 'ref name check should work for multiple worktrees' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
git checkout -b branch-1 &&
test_commit second &&
git checkout -b branch-2 &&
test_commit third &&
git checkout -b branch-3 &&
git worktree add ./worktree-1 branch-1 &&
git worktree add ./worktree-2 branch-2 &&
worktree1_refdir_prefix=.git/worktrees/worktree-1/refs/worktree &&
worktree2_refdir_prefix=.git/worktrees/worktree-2/refs/worktree &&
(
cd worktree-1 &&
git update-ref refs/worktree/branch-4 refs/heads/branch-3
) &&
(
cd worktree-2 &&
git update-ref refs/worktree/branch-4 refs/heads/branch-3
) &&
cp $worktree1_refdir_prefix/branch-4 $worktree1_refdir_prefix/'\'' branch-5'\'' &&
cp $worktree2_refdir_prefix/branch-4 $worktree2_refdir_prefix/'\''~branch-6'\'' &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: worktrees/worktree-1/refs/worktree/ branch-5: badRefName: invalid refname format
error: worktrees/worktree-2/refs/worktree/~branch-6: badRefName: invalid refname format
EOF
sort err >sorted_err &&
test_cmp expect sorted_err &&
for worktree in "worktree-1" "worktree-2"
do
(
cd $worktree &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: worktrees/worktree-1/refs/worktree/ branch-5: badRefName: invalid refname format
error: worktrees/worktree-2/refs/worktree/~branch-6: badRefName: invalid refname format
EOF
sort err >sorted_err &&
test_cmp expect sorted_err || return 1
)
done
)
'
test_expect_success 'regular ref content should be checked (individual)' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
(
cd repo &&
test_commit default &&
mkdir -p "$branch_dir_prefix/a/b" &&
git refs verify 2>err &&
test_must_be_empty err &&
for bad_content in "$(git rev-parse main)x" "xfsazqfxcadas" "Xfsazqfxcadas"
do
printf "%s" $bad_content >$branch_dir_prefix/branch-bad &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/branch-bad: badRefContent: $bad_content
EOF
rm $branch_dir_prefix/branch-bad &&
test_cmp expect err || return 1
done &&
for bad_content in "$(git rev-parse main)x" "xfsazqfxcadas" "Xfsazqfxcadas"
do
printf "%s" $bad_content >$branch_dir_prefix/a/b/branch-bad &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/a/b/branch-bad: badRefContent: $bad_content
EOF
rm $branch_dir_prefix/a/b/branch-bad &&
test_cmp expect err || return 1
done &&
printf "%s" "$(git rev-parse main)" >$branch_dir_prefix/branch-no-newline &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-no-newline: refMissingNewline: misses LF at the end
EOF
rm $branch_dir_prefix/branch-no-newline &&
test_cmp expect err &&
for trailing_content in " garbage" " more garbage"
do
printf "%s" "$(git rev-parse main)$trailing_content" >$branch_dir_prefix/branch-garbage &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-garbage: trailingRefContent: has trailing garbage: '\''$trailing_content'\''
EOF
rm $branch_dir_prefix/branch-garbage &&
test_cmp expect err || return 1
done &&
printf "%s\n\n\n" "$(git rev-parse main)" >$branch_dir_prefix/branch-garbage-special &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-garbage-special: trailingRefContent: has trailing garbage: '\''
'\''
EOF
rm $branch_dir_prefix/branch-garbage-special &&
test_cmp expect err &&
printf "%s\n\n\n garbage" "$(git rev-parse main)" >$branch_dir_prefix/branch-garbage-special &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-garbage-special: trailingRefContent: has trailing garbage: '\''
garbage'\''
EOF
rm $branch_dir_prefix/branch-garbage-special &&
test_cmp expect err
)
'
test_expect_success 'regular ref content should be checked (aggregate)' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
tag_dir_prefix=.git/refs/tags &&
(
cd repo &&
test_commit default &&
mkdir -p "$branch_dir_prefix/a/b" &&
bad_content_1=$(git rev-parse main)x &&
bad_content_2=xfsazqfxcadas &&
bad_content_3=Xfsazqfxcadas &&
printf "%s" $bad_content_1 >$tag_dir_prefix/tag-bad-1 &&
printf "%s" $bad_content_2 >$tag_dir_prefix/tag-bad-2 &&
printf "%s" $bad_content_3 >$branch_dir_prefix/a/b/branch-bad &&
printf "%s" "$(git rev-parse main)" >$branch_dir_prefix/branch-no-newline &&
printf "%s garbage" "$(git rev-parse main)" >$branch_dir_prefix/branch-garbage &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/a/b/branch-bad: badRefContent: $bad_content_3
error: refs/tags/tag-bad-1: badRefContent: $bad_content_1
error: refs/tags/tag-bad-2: badRefContent: $bad_content_2
warning: refs/heads/branch-garbage: trailingRefContent: has trailing garbage: '\'' garbage'\''
warning: refs/heads/branch-no-newline: refMissingNewline: misses LF at the end
EOF
sort err >sorted_err &&
test_cmp expect sorted_err
)
'
test_expect_success 'textual symref content should be checked (individual)' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
(
cd repo &&
test_commit default &&
mkdir -p "$branch_dir_prefix/a/b" &&
for good_referent in "refs/heads/branch" "HEAD"
do
printf "ref: %s\n" $good_referent >$branch_dir_prefix/branch-good &&
git refs verify 2>err &&
rm $branch_dir_prefix/branch-good &&
test_must_be_empty err || return 1
done &&
for bad_referent in "refs/heads/.branch" "refs/heads/~branch" "refs/heads/?branch"
do
printf "ref: %s\n" $bad_referent >$branch_dir_prefix/branch-bad &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/branch-bad: badReferentName: points to invalid refname '\''$bad_referent'\''
EOF
rm $branch_dir_prefix/branch-bad &&
test_cmp expect err || return 1
done &&
printf "ref: refs/heads/branch" >$branch_dir_prefix/branch-no-newline &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-no-newline: refMissingNewline: misses LF at the end
EOF
rm $branch_dir_prefix/branch-no-newline &&
test_cmp expect err &&
printf "ref: refs/heads/branch " >$branch_dir_prefix/a/b/branch-trailing-1 &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/a/b/branch-trailing-1: refMissingNewline: misses LF at the end
warning: refs/heads/a/b/branch-trailing-1: trailingRefContent: has trailing whitespaces or newlines
EOF
rm $branch_dir_prefix/a/b/branch-trailing-1 &&
test_cmp expect err &&
printf "ref: refs/heads/branch\n\n" >$branch_dir_prefix/a/b/branch-trailing-2 &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/a/b/branch-trailing-2: trailingRefContent: has trailing whitespaces or newlines
EOF
rm $branch_dir_prefix/a/b/branch-trailing-2 &&
test_cmp expect err &&
printf "ref: refs/heads/branch \n" >$branch_dir_prefix/a/b/branch-trailing-3 &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/a/b/branch-trailing-3: trailingRefContent: has trailing whitespaces or newlines
EOF
rm $branch_dir_prefix/a/b/branch-trailing-3 &&
test_cmp expect err &&
printf "ref: refs/heads/branch \n " >$branch_dir_prefix/a/b/branch-complicated &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/a/b/branch-complicated: refMissingNewline: misses LF at the end
warning: refs/heads/a/b/branch-complicated: trailingRefContent: has trailing whitespaces or newlines
EOF
rm $branch_dir_prefix/a/b/branch-complicated &&
test_cmp expect err
)
'
test_expect_success 'textual symref content should be checked (aggregate)' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
tag_dir_prefix=.git/refs/tags &&
(
cd repo &&
test_commit default &&
mkdir -p "$branch_dir_prefix/a/b" &&
printf "ref: refs/heads/branch\n" >$branch_dir_prefix/branch-good &&
printf "ref: HEAD\n" >$branch_dir_prefix/branch-head &&
printf "ref: refs/heads/branch" >$branch_dir_prefix/branch-no-newline-1 &&
printf "ref: refs/heads/branch " >$branch_dir_prefix/a/b/branch-trailing-1 &&
printf "ref: refs/heads/branch\n\n" >$branch_dir_prefix/a/b/branch-trailing-2 &&
printf "ref: refs/heads/branch \n" >$branch_dir_prefix/a/b/branch-trailing-3 &&
printf "ref: refs/heads/branch \n " >$branch_dir_prefix/a/b/branch-complicated &&
printf "ref: refs/heads/.branch\n" >$branch_dir_prefix/branch-bad-1 &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: refs/heads/branch-bad-1: badReferentName: points to invalid refname '\''refs/heads/.branch'\''
warning: refs/heads/a/b/branch-complicated: refMissingNewline: misses LF at the end
warning: refs/heads/a/b/branch-complicated: trailingRefContent: has trailing whitespaces or newlines
warning: refs/heads/a/b/branch-trailing-1: refMissingNewline: misses LF at the end
warning: refs/heads/a/b/branch-trailing-1: trailingRefContent: has trailing whitespaces or newlines
warning: refs/heads/a/b/branch-trailing-2: trailingRefContent: has trailing whitespaces or newlines
warning: refs/heads/a/b/branch-trailing-3: trailingRefContent: has trailing whitespaces or newlines
warning: refs/heads/branch-no-newline-1: refMissingNewline: misses LF at the end
EOF
sort err >sorted_err &&
test_cmp expect sorted_err
)
'
test_expect_success 'the target of the textual symref should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
tag_dir_prefix=.git/refs/tags &&
(
cd repo &&
test_commit default &&
mkdir -p "$branch_dir_prefix/a/b" &&
for good_referent in "refs/heads/branch" "HEAD" "refs/tags/tag"
do
printf "ref: %s\n" $good_referent >$branch_dir_prefix/branch-good &&
git refs verify 2>err &&
rm $branch_dir_prefix/branch-good &&
test_must_be_empty err || return 1
done &&
for nonref_referent in "refs-back/heads/branch" "refs-back/tags/tag" "reflogs/refs/heads/branch"
do
printf "ref: %s\n" $nonref_referent >$branch_dir_prefix/branch-bad-1 &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-bad-1: symrefTargetIsNotARef: points to non-ref target '\''$nonref_referent'\''
EOF
rm $branch_dir_prefix/branch-bad-1 &&
test_cmp expect err || return 1
done
)
'
test_expect_success SYMLINKS 'symlink symref content should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
tag_dir_prefix=.git/refs/tags &&
(
cd repo &&
test_commit default &&
mkdir -p "$branch_dir_prefix/a/b" &&
ln -sf ./main $branch_dir_prefix/branch-symbolic-good &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-symbolic-good: symlinkRef: use deprecated symbolic link for symref
EOF
rm $branch_dir_prefix/branch-symbolic-good &&
test_cmp expect err &&
ln -sf ../../logs/branch-escape $branch_dir_prefix/branch-symbolic &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-symbolic: symlinkRef: use deprecated symbolic link for symref
warning: refs/heads/branch-symbolic: symrefTargetIsNotARef: points to non-ref target '\''logs/branch-escape'\''
EOF
rm $branch_dir_prefix/branch-symbolic &&
test_cmp expect err &&
ln -sf ./"branch " $branch_dir_prefix/branch-symbolic-bad &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-symbolic-bad: symlinkRef: use deprecated symbolic link for symref
error: refs/heads/branch-symbolic-bad: badReferentName: points to invalid refname '\''refs/heads/branch '\''
EOF
rm $branch_dir_prefix/branch-symbolic-bad &&
test_cmp expect err &&
ln -sf ./".tag" $tag_dir_prefix/tag-symbolic-1 &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/tags/tag-symbolic-1: symlinkRef: use deprecated symbolic link for symref
error: refs/tags/tag-symbolic-1: badReferentName: points to invalid refname '\''refs/tags/.tag'\''
EOF
rm $tag_dir_prefix/tag-symbolic-1 &&
test_cmp expect err
)
'
test_expect_success SYMLINKS 'symlink symref content should be checked (worktree)' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git branch branch-1 &&
git branch branch-2 &&
git branch branch-3 &&
git worktree add ./worktree-1 branch-2 &&
git worktree add ./worktree-2 branch-3 &&
main_worktree_refdir_prefix=.git/refs/heads &&
worktree1_refdir_prefix=.git/worktrees/worktree-1/refs/worktree &&
worktree2_refdir_prefix=.git/worktrees/worktree-2/refs/worktree &&
(
cd worktree-1 &&
git update-ref refs/worktree/branch-4 refs/heads/branch-1
) &&
(
cd worktree-2 &&
git update-ref refs/worktree/branch-4 refs/heads/branch-1
) &&
ln -sf ../../../../refs/heads/good-branch $worktree1_refdir_prefix/branch-symbolic-good &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-1/refs/worktree/branch-symbolic-good: symlinkRef: use deprecated symbolic link for symref
EOF
rm $worktree1_refdir_prefix/branch-symbolic-good &&
test_cmp expect err &&
ln -sf ../../../../worktrees/worktree-1/good-branch $worktree2_refdir_prefix/branch-symbolic-good &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-2/refs/worktree/branch-symbolic-good: symlinkRef: use deprecated symbolic link for symref
EOF
rm $worktree2_refdir_prefix/branch-symbolic-good &&
test_cmp expect err &&
ln -sf ../../worktrees/worktree-2/good-branch $main_worktree_refdir_prefix/branch-symbolic-good &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-symbolic-good: symlinkRef: use deprecated symbolic link for symref
EOF
rm $main_worktree_refdir_prefix/branch-symbolic-good &&
test_cmp expect err &&
ln -sf ../../../../logs/branch-escape $worktree1_refdir_prefix/branch-symbolic &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-1/refs/worktree/branch-symbolic: symlinkRef: use deprecated symbolic link for symref
warning: worktrees/worktree-1/refs/worktree/branch-symbolic: symrefTargetIsNotARef: points to non-ref target '\''logs/branch-escape'\''
EOF
rm $worktree1_refdir_prefix/branch-symbolic &&
test_cmp expect err &&
for bad_referent_name in ".tag" "branch "
do
ln -sf ./"$bad_referent_name" $worktree1_refdir_prefix/bad-symbolic &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-1/refs/worktree/bad-symbolic: symlinkRef: use deprecated symbolic link for symref
error: worktrees/worktree-1/refs/worktree/bad-symbolic: badReferentName: points to invalid refname '\''worktrees/worktree-1/refs/worktree/$bad_referent_name'\''
EOF
rm $worktree1_refdir_prefix/bad-symbolic &&
test_cmp expect err &&
ln -sf ../../../../refs/heads/"$bad_referent_name" $worktree1_refdir_prefix/bad-symbolic &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-1/refs/worktree/bad-symbolic: symlinkRef: use deprecated symbolic link for symref
error: worktrees/worktree-1/refs/worktree/bad-symbolic: badReferentName: points to invalid refname '\''refs/heads/$bad_referent_name'\''
EOF
rm $worktree1_refdir_prefix/bad-symbolic &&
test_cmp expect err &&
ln -sf ./"$bad_referent_name" $worktree2_refdir_prefix/bad-symbolic &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-2/refs/worktree/bad-symbolic: symlinkRef: use deprecated symbolic link for symref
error: worktrees/worktree-2/refs/worktree/bad-symbolic: badReferentName: points to invalid refname '\''worktrees/worktree-2/refs/worktree/$bad_referent_name'\''
EOF
rm $worktree2_refdir_prefix/bad-symbolic &&
test_cmp expect err &&
ln -sf ../../../../refs/heads/"$bad_referent_name" $worktree2_refdir_prefix/bad-symbolic &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-2/refs/worktree/bad-symbolic: symlinkRef: use deprecated symbolic link for symref
error: worktrees/worktree-2/refs/worktree/bad-symbolic: badReferentName: points to invalid refname '\''refs/heads/$bad_referent_name'\''
EOF
rm $worktree2_refdir_prefix/bad-symbolic &&
test_cmp expect err || return 1
done
)
'
test_expect_success 'ref content checks should work with worktrees' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git branch branch-1 &&
git branch branch-2 &&
git branch branch-3 &&
git worktree add ./worktree-1 branch-2 &&
git worktree add ./worktree-2 branch-3 &&
worktree1_refdir_prefix=.git/worktrees/worktree-1/refs/worktree &&
worktree2_refdir_prefix=.git/worktrees/worktree-2/refs/worktree &&
(
cd worktree-1 &&
git update-ref refs/worktree/branch-4 refs/heads/branch-1
) &&
(
cd worktree-2 &&
git update-ref refs/worktree/branch-4 refs/heads/branch-1
) &&
for bad_content in "$(git rev-parse HEAD)x" "xfsazqfxcadas" "Xfsazqfxcadas"
do
printf "%s" $bad_content >$worktree1_refdir_prefix/bad-branch-1 &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: worktrees/worktree-1/refs/worktree/bad-branch-1: badRefContent: $bad_content
EOF
rm $worktree1_refdir_prefix/bad-branch-1 &&
test_cmp expect err || return 1
done &&
for bad_content in "$(git rev-parse HEAD)x" "xfsazqfxcadas" "Xfsazqfxcadas"
do
printf "%s" $bad_content >$worktree2_refdir_prefix/bad-branch-2 &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: worktrees/worktree-2/refs/worktree/bad-branch-2: badRefContent: $bad_content
EOF
rm $worktree2_refdir_prefix/bad-branch-2 &&
test_cmp expect err || return 1
done &&
printf "%s" "$(git rev-parse HEAD)" >$worktree1_refdir_prefix/branch-no-newline &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-1/refs/worktree/branch-no-newline: refMissingNewline: misses LF at the end
EOF
rm $worktree1_refdir_prefix/branch-no-newline &&
test_cmp expect err &&
printf "%s garbage" "$(git rev-parse HEAD)" >$worktree1_refdir_prefix/branch-garbage &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: worktrees/worktree-1/refs/worktree/branch-garbage: trailingRefContent: has trailing garbage: '\'' garbage'\''
EOF
rm $worktree1_refdir_prefix/branch-garbage &&
test_cmp expect err
)
'
test_expect_success SYMLINKS 'the filetype of packed-refs should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git branch branch-1 &&
git branch branch-2 &&
git branch branch-3 &&
git pack-refs --all &&
mv .git/packed-refs .git/packed-refs-back &&
ln -sf packed-refs-back .git/packed-refs &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: packed-refs: badRefFiletype: not a regular file but a symlink
EOF
rm .git/packed-refs &&
test_cmp expect err &&
mkdir .git/packed-refs &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: packed-refs: badRefFiletype: not a regular file
EOF
rm -r .git/packed-refs &&
test_cmp expect err
)
'
test_expect_success 'empty packed-refs should be reported' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
>.git/packed-refs &&
git refs verify 2>err &&
cat >expect <<-EOF &&
warning: packed-refs: emptyPackedRefsFile: file is empty
EOF
rm .git/packed-refs &&
test_cmp expect err
)
'
test_expect_success 'packed-refs header should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git refs verify 2>err &&
test_must_be_empty err &&
for bad_header in "# pack-refs wit: peeled fully-peeled sorted " \
"# pack-refs with traits: peeled fully-peeled sorted " \
"# pack-refs with a: peeled fully-peeled" \
"# pack-refs with:peeled fully-peeled sorted"
do
printf "%s\n" "$bad_header" >.git/packed-refs &&
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: packed-refs.header: badPackedRefHeader: '\''$bad_header'\'' does not start with '\''# pack-refs with: '\''
EOF
rm .git/packed-refs &&
test_cmp expect err || return 1
done
)
'
test_expect_success 'packed-refs missing header should not be reported' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
printf "$(git rev-parse HEAD) refs/heads/main\n" >.git/packed-refs &&
git refs verify 2>err &&
test_must_be_empty err
)
'
test_expect_success 'packed-refs unknown traits should not be reported' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
printf "# pack-refs with: peeled fully-peeled sorted foo\n" >.git/packed-refs &&
git refs verify 2>err &&
test_must_be_empty err
)
'
test_expect_success 'packed-refs content should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git branch branch-1 &&
git branch branch-2 &&
git tag -a annotated-tag-1 -m tag-1 &&
git tag -a annotated-tag-2 -m tag-2 &&
branch_1_oid=$(git rev-parse branch-1) &&
branch_2_oid=$(git rev-parse branch-2) &&
tag_1_oid=$(git rev-parse annotated-tag-1) &&
tag_2_oid=$(git rev-parse annotated-tag-2) &&
tag_1_peeled_oid=$(git rev-parse annotated-tag-1^{}) &&
tag_2_peeled_oid=$(git rev-parse annotated-tag-2^{}) &&
short_oid=$(printf "%s" $tag_1_peeled_oid | cut -c 1-4) &&
cat >.git/packed-refs <<-EOF &&
# pack-refs with: peeled fully-peeled sorted
$short_oid refs/heads/branch-1
${branch_1_oid}x
$branch_2_oid refs/heads/bad-branch
$branch_2_oid refs/heads/branch.
$tag_1_oid refs/tags/annotated-tag-3
^$short_oid
$tag_2_oid refs/tags/annotated-tag-4.
^$tag_2_peeled_oid garbage
EOF
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: packed-refs line 2: badPackedRefEntry: '\''$short_oid refs/heads/branch-1'\'' has invalid oid
error: packed-refs line 3: badPackedRefEntry: has no space after oid '\''$branch_1_oid'\'' but with '\''x'\''
error: packed-refs line 4: badRefName: has bad refname '\'' refs/heads/bad-branch'\''
error: packed-refs line 5: badRefName: has bad refname '\''refs/heads/branch.'\''
error: packed-refs line 7: badPackedRefEntry: '\''$short_oid'\'' has invalid peeled oid
error: packed-refs line 8: badRefName: has bad refname '\''refs/tags/annotated-tag-4.'\''
error: packed-refs line 9: badPackedRefEntry: has trailing garbage after peeled oid '\'' garbage'\''
EOF
test_cmp expect err
)
'
test_expect_success 'packed-ref with sorted trait should be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git branch branch-1 &&
git branch branch-2 &&
git tag -a annotated-tag-1 -m tag-1 &&
branch_1_oid=$(git rev-parse branch-1) &&
branch_2_oid=$(git rev-parse branch-2) &&
tag_1_oid=$(git rev-parse annotated-tag-1) &&
tag_1_peeled_oid=$(git rev-parse annotated-tag-1^{}) &&
refname1="refs/heads/main" &&
refname2="refs/heads/foo" &&
refname3="refs/tags/foo" &&
cat >.git/packed-refs <<-EOF &&
# pack-refs with: peeled fully-peeled sorted
EOF
git refs verify 2>err &&
rm .git/packed-refs &&
test_must_be_empty err &&
cat >.git/packed-refs <<-EOF &&
# pack-refs with: peeled fully-peeled sorted
$branch_2_oid $refname1
EOF
git refs verify 2>err &&
rm .git/packed-refs &&
test_must_be_empty err &&
cat >.git/packed-refs <<-EOF &&
# pack-refs with: peeled fully-peeled sorted
$branch_2_oid $refname1
$branch_1_oid $refname2
$tag_1_oid $refname3
EOF
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: packed-refs line 3: packedRefUnsorted: refname '\''$refname2'\'' is less than previous refname '\''$refname1'\''
EOF
rm .git/packed-refs &&
test_cmp expect err &&
cat >.git/packed-refs <<-EOF &&
# pack-refs with: peeled fully-peeled sorted
$tag_1_oid $refname3
^$tag_1_peeled_oid
$branch_2_oid $refname2
EOF
test_must_fail git refs verify 2>err &&
cat >expect <<-EOF &&
error: packed-refs line 4: packedRefUnsorted: refname '\''$refname2'\'' is less than previous refname '\''$refname3'\''
EOF
rm .git/packed-refs &&
test_cmp expect err
)
'
test_expect_success 'packed-ref without sorted trait should not be checked' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit default &&
git branch branch-1 &&
git branch branch-2 &&
git tag -a annotated-tag-1 -m tag-1 &&
branch_1_oid=$(git rev-parse branch-1) &&
branch_2_oid=$(git rev-parse branch-2) &&
tag_1_oid=$(git rev-parse annotated-tag-1) &&
tag_1_peeled_oid=$(git rev-parse annotated-tag-1^{}) &&
refname1="refs/heads/main" &&
refname2="refs/heads/foo" &&
refname3="refs/tags/foo" &&
cat >.git/packed-refs <<-EOF &&
# pack-refs with: peeled fully-peeled
$branch_2_oid $refname1
$branch_1_oid $refname2
EOF
git refs verify 2>err &&
test_must_be_empty err
)
'
test_expect_success '--[no-]references option should apply to fsck' '
test_when_finished "rm -rf repo" &&
git init repo &&
branch_dir_prefix=.git/refs/heads &&
(
cd repo &&
test_commit default &&
for trailing_content in " garbage" " more garbage"
do
printf "%s" "$(git rev-parse HEAD)$trailing_content" >$branch_dir_prefix/branch-garbage &&
git fsck 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-garbage: trailingRefContent: has trailing garbage: '\''$trailing_content'\''
EOF
rm $branch_dir_prefix/branch-garbage &&
test_cmp expect err || return 1
done &&
for trailing_content in " garbage" " more garbage"
do
printf "%s" "$(git rev-parse HEAD)$trailing_content" >$branch_dir_prefix/branch-garbage &&
git fsck --references 2>err &&
cat >expect <<-EOF &&
warning: refs/heads/branch-garbage: trailingRefContent: has trailing garbage: '\''$trailing_content'\''
EOF
rm $branch_dir_prefix/branch-garbage &&
test_cmp expect err || return 1
done &&
for trailing_content in " garbage" " more garbage"
do
printf "%s" "$(git rev-parse HEAD)$trailing_content" >$branch_dir_prefix/branch-garbage &&
git fsck --no-references 2>err &&
rm $branch_dir_prefix/branch-garbage &&
test_must_be_empty err || return 1
done
)
'
test_done
|
