1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
|
//golangcitest:args -Egocritic
//golangcitest:config_path testdata/configs/gocritic.yml
package testdata
import (
"flag"
"log"
"strings"
)
var _ = *flag.Bool("global1", false, "") // want `flagDeref: immediate deref in \*flag.Bool\(.global1., false, ..\) is most likely an error; consider using flag\.BoolVar`
type size1 struct {
a bool
}
type size2 struct {
size1
b bool
}
func gocriticRangeValCopySize1(ss []size1) {
for _, s := range ss {
log.Print(s)
}
}
func gocriticRangeValCopySize2(ss []size2) {
for _, s := range ss { // want "rangeValCopy: each iteration copies 2 bytes.*"
log.Print(s)
}
}
func gocriticStringSimplify() {
s := "Most of the time, travellers worry about their luggage."
s = strings.Replace(s, ",", "", -1) // want "ruleguard: this Replace call can be simplified.*"
log.Print(s)
}
func gocriticDup(x bool) {
if x && x { // want "ruleguard: suspicious identical LHS and RHS.*"
log.Print("x is true")
}
}
func gocriticRuleWrapperFunc() {
strings.Replace("abcabc", "a", "d", -1) // want "ruleguard: this Replace call can be simplified.*"
}
|
