1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
|
package agent
import (
"context"
"io"
"net/http"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v16/internal/module/kubernetes_api/rpc"
"gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v16/internal/module/modagent"
"k8s.io/client-go/rest"
"k8s.io/client-go/transport"
cmdtesting "k8s.io/kubectl/pkg/cmd/testing"
)
var (
_ modagent.Module = (*module)(nil)
_ modagent.Factory = (*Factory)(nil)
)
func TestClientImpersonation(t *testing.T) {
restImpConfig := rest.ImpersonationConfig{
UserName: "ruser1",
UID: "ruid1",
Groups: []string{"rg1", "rg2"},
Extra: map[string][]string{
"rx": {"rx1", "rx2"},
},
}
impConfig := &rpc.ImpersonationConfig{
Username: "iuser1",
Groups: []string{"ig1", "ig2"},
Uid: "iuid",
Extra: []*rpc.ExtraKeyVal{
{
Key: "ix",
Val: []string{"ix1", "ix2"},
},
},
}
requestHeader := http.Header{}
requestHeader.Set(transport.ImpersonateUserHeader, "huser1")
requestHeader.Set(transport.ImpersonateUIDHeader, "huid1")
requestHeader.Set(transport.ImpersonateGroupHeader, "hg1")
requestHeader.Add(transport.ImpersonateGroupHeader, "hg2")
requestHeader.Set(transport.ImpersonateUserExtraHeaderPrefix+"Hx", "hx1")
requestHeader.Add(transport.ImpersonateUserExtraHeaderPrefix+"Hx", "hx2")
tests := []struct {
name string
restImpConfig rest.ImpersonationConfig
impConfig *rpc.ImpersonationConfig
requestHeader http.Header
expectedRequestHeader http.Header
expectedErr string
}{
{
name: "no impersonation",
impConfig: &rpc.ImpersonationConfig{},
},
{
name: "rest config",
restImpConfig: restImpConfig,
impConfig: &rpc.ImpersonationConfig{},
expectedRequestHeader: http.Header{
transport.ImpersonateUserHeader: {"ruser1"},
transport.ImpersonateUIDHeader: {"ruid1"},
transport.ImpersonateGroupHeader: {"rg1", "rg2"},
transport.ImpersonateUserExtraHeaderPrefix + "Rx": {"rx1", "rx2"},
},
},
{
name: "rest config and impConfig",
restImpConfig: restImpConfig,
impConfig: impConfig,
expectedErr: "nested impersonation is not supported - agent is already configured to impersonate an identity",
},
{
name: "rest config and requestHeader",
restImpConfig: restImpConfig,
requestHeader: requestHeader,
expectedErr: "nested impersonation is not supported - agent is already configured to impersonate an identity",
},
{
name: "rest config and impConfig and requestHeader",
restImpConfig: restImpConfig,
impConfig: impConfig,
requestHeader: requestHeader,
expectedErr: "nested impersonation is not supported - agent is already configured to impersonate an identity",
},
{
name: "impConfig and requestHeader",
impConfig: impConfig,
requestHeader: requestHeader,
expectedErr: "nested impersonation is not supported - agent is already configured to impersonate an identity",
},
{
name: "requestHeader",
requestHeader: requestHeader,
expectedRequestHeader: http.Header{
transport.ImpersonateUserHeader: {"huser1"},
transport.ImpersonateUIDHeader: {"huid1"},
transport.ImpersonateGroupHeader: {"hg1", "hg2"},
transport.ImpersonateUserExtraHeaderPrefix + "Hx": {"hx1", "hx2"},
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
tf := cmdtesting.NewTestFactory()
defer tf.Cleanup()
config, err := tf.ToRESTConfig()
require.NoError(t, err)
config.Impersonate = tc.restImpConfig
rt := &testRoundTripper{
Response: &http.Response{
StatusCode: http.StatusOK,
Body: io.NopCloser(strings.NewReader("")),
},
}
config.Transport = rt
r, err := http.NewRequestWithContext(context.Background(), http.MethodGet, "/", nil)
require.NoError(t, err)
if tc.requestHeader != nil {
r.Header = tc.requestHeader
}
config, err = restImpersonationConfig(tc.impConfig, config, r)
if tc.expectedErr != "" {
require.EqualError(t, err, tc.expectedErr)
return
}
require.NoError(t, err)
wrappedRT, err := rest.HTTPWrappersForConfig(config, rt)
require.NoError(t, err)
resp, err := wrappedRT.RoundTrip(r)
require.NoError(t, err)
defer resp.Body.Close()
for k, v := range tc.expectedRequestHeader {
assert.Equal(t, v, rt.Request.Header[k], k)
}
})
}
}
type testRoundTripper struct {
Request *http.Request
Response *http.Response
Err error
}
func (rt *testRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
rt.Request = req
return rt.Response, rt.Err
}
|
