1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
|
package agent
import (
"context"
"testing"
"time"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/cluster-integration/gitlab-agent/v16/pkg/agentcfg"
"go.uber.org/zap/zaptest"
"k8s.io/apimachinery/pkg/util/wait"
)
type mockReconciler struct {
timesCalled uint32
}
func (r *mockReconciler) Stop() {
// do nothing
}
func (r *mockReconciler) Run(_ context.Context) error {
r.timesCalled += 1
return nil
}
func TestConfigChange(t *testing.T) {
tests := []struct {
description string
timesCalled uint32
configs []*agentcfg.AgentConfiguration
}{
{
description: "When remote dev is enabled in the config, does start reconciler",
timesCalled: 1,
configs: []*agentcfg.AgentConfiguration{
{
RemoteDevelopment: &agentcfg.RemoteCF{
Enabled: true,
},
},
},
},
{
description: "When the config is updated, restarts the reconciler",
timesCalled: 2,
configs: []*agentcfg.AgentConfiguration{
{
RemoteDevelopment: &agentcfg.RemoteCF{
Enabled: true,
DnsZone: "one",
},
},
{
RemoteDevelopment: &agentcfg.RemoteCF{
Enabled: true,
DnsZone: "two",
},
},
},
},
{
description: "When the config is published multiple times without any changes",
timesCalled: 1,
configs: []*agentcfg.AgentConfiguration{
{
RemoteDevelopment: &agentcfg.RemoteCF{
Enabled: true,
DnsZone: "one",
},
},
{
RemoteDevelopment: &agentcfg.RemoteCF{
Enabled: true,
DnsZone: "one",
},
},
},
},
}
for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
configChannel := make(chan *agentcfg.AgentConfiguration)
mock := &mockReconciler{}
mod := module{
log: zaptest.NewLogger(t),
api: newMockApi(t),
reconcilerFactory: func(ctx context.Context) (remoteDevReconciler, error) {
return mock, nil
},
}
ctx := context.Background()
wg := wait.Group{}
// publish configs asynchronously
wg.StartWithContext(ctx, func(ctx context.Context) {
publishInterval := 50 * time.Millisecond
if tt.configs != nil {
for _, cfg := range tt.configs {
// populate the test config with defaults if missing
// this must be explicitly done in tests where module's Run() is invoked directly
err := mod.DefaultAndValidateConfiguration(cfg)
require.NoError(t, err)
configChannel <- cfg
time.Sleep(publishInterval)
}
}
close(configChannel)
})
err := mod.Run(ctx, configChannel)
wg.Wait()
require.NoError(t, err)
require.Equal(t, tt.timesCalled, mock.timesCalled)
})
}
}
|