1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
//go:build integration
// +build integration
package helpers
import (
"context"
"fmt"
"io/fs"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/urfave/cli"
"gitlab.com/gitlab-org/gitlab-runner/commands/helpers/archive/fastzip"
"gitlab.com/gitlab-org/gitlab-runner/common"
"gitlab.com/gitlab-org/gitlab-runner/helpers"
"gitlab.com/gitlab-org/gitlab-runner/network"
)
func TestArchiveUploadRedirect(t *testing.T) {
finalRequestReceived := false
finalServer := httptest.NewServer(
assertRequestPathAndMethod(t, "final", finalServerHandler(t, &finalRequestReceived)),
)
defer finalServer.Close()
redirectingServer := httptest.NewServer(
assertRequestPathAndMethod(t, "redirection", redirectingServerHandler(finalServer.URL)),
)
defer redirectingServer.Close()
cmd := &ArtifactsUploaderCommand{
JobCredentials: common.JobCredentials{
ID: 12345,
Token: "token",
URL: redirectingServer.URL,
},
Name: "artifacts",
Format: common.ArtifactFormatZip,
CompressionLevel: "fastest",
network: network.NewGitLabClient(),
fileArchiver: fileArchiver{
Paths: []string{
filepath.Join(".", "testdata", "test-artifacts"),
},
},
}
defer helpers.MakeFatalToPanic()()
assert.NotPanics(t, func() {
cmd.Execute(&cli.Context{})
}, "expected command not to log fatal")
assert.True(t, finalRequestReceived)
}
func assertRequestPathAndMethod(t *testing.T, handlerName string, handler http.HandlerFunc) http.HandlerFunc {
return func(rw http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
assert.Equal(t, "/api/v4/jobs/12345/artifacts", r.URL.Path, "server handler: %s", handlerName)
assert.NotEqual(t, "/api/v4/jobs/12345/jobs/12345/artifacts", r.URL.Path, "server handler: %s", handlerName)
handler(rw, r)
}
}
func redirectingServerHandler(finalServerURL string) http.HandlerFunc {
return func(rw http.ResponseWriter, r *http.Request) {
rw.Header().Set("Location", fmt.Sprintf("%s%s", finalServerURL, r.RequestURI))
rw.WriteHeader(http.StatusTemporaryRedirect)
}
}
func finalServerHandler(t *testing.T, finalRequestReceived *bool) http.HandlerFunc {
return func(rw http.ResponseWriter, r *http.Request) {
dir, err := os.MkdirTemp("", "test-archive-upload-redirect-dir-")
require.NoError(t, err)
defer func() {
_ = os.RemoveAll(dir)
}()
receiveFile(t, r, dir)
err = filepath.Walk(dir, func(path string, info fs.FileInfo, err error) error {
if info.IsDir() {
return nil
}
fileName := info.Name()
fileContentBytes, err := os.ReadFile(path)
if err != nil {
return err
}
assert.Equal(t, fileName, strings.TrimSpace(string(fileContentBytes)))
return nil
})
assert.NoError(t, err)
*finalRequestReceived = true
rw.WriteHeader(http.StatusCreated)
}
}
func receiveFile(t *testing.T, r *http.Request, targetDir string) {
err := r.ParseMultipartForm(1024)
require.NoError(t, err)
formFiles := r.MultipartForm.File["file"]
require.Len(t, formFiles, 1)
formFile := formFiles[0]
assert.Equal(t, "artifacts.zip", formFile.Filename)
f, err := formFile.Open()
require.NoError(t, err)
defer func() {
_ = f.Close()
}()
extractor, err := fastzip.NewExtractor(f, formFile.Size, targetDir)
require.NoError(t, err)
err = extractor.Extract(context.Background())
require.NoError(t, err)
}
|
