1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809
|
package client
import (
"context"
"crypto/tls"
"fmt"
"io"
"net"
"os"
"path/filepath"
"strings"
"testing"
"github.com/miekg/dns"
"github.com/opentracing/opentracing-go"
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/uber/jaeger-client-go"
gitalyauth "gitlab.com/gitlab-org/gitaly/v16/auth"
internalclient "gitlab.com/gitlab-org/gitaly/v16/internal/grpc/client"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/internal/tracing"
gitalyx509 "gitlab.com/gitlab-org/gitaly/v16/internal/x509"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
"gitlab.com/gitlab-org/labkit/correlation"
grpccorrelation "gitlab.com/gitlab-org/labkit/correlation/grpc"
grpctracing "gitlab.com/gitlab-org/labkit/tracing/grpc"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/credentials/insecure"
healthpb "google.golang.org/grpc/health/grpc_health_v1"
"google.golang.org/grpc/interop/grpc_testing"
"google.golang.org/grpc/status"
)
var proxyEnvironmentKeys = []string{"http_proxy", "https_proxy", "no_proxy"}
func TestDial(t *testing.T) {
if emitProxyWarning() {
t.Log("WARNING. Proxy configuration detected from environment settings. This test failure may be related to proxy configuration. Please process with caution")
}
stop, connectionMap := startListeners(t, func(creds credentials.TransportCredentials) *grpc.Server {
srv := grpc.NewServer(grpc.Creds(creds))
healthpb.RegisterHealthServer(srv, &healthServer{})
return srv
})
defer stop()
unixSocketAbsPath := connectionMap["unix"]
tempDir := testhelper.TempDir(t)
unixSocketPath := filepath.Join(tempDir, "gitaly.socket")
require.NoError(t, os.Symlink(unixSocketAbsPath, unixSocketPath))
tests := []struct {
name string
rawAddress string
envSSLCertFile string
dialOpts []grpc.DialOption
expectDialFailure bool
expectHealthFailure bool
}{
{
name: "tcp localhost with prefix",
rawAddress: "tcp://localhost:" + connectionMap["tcp"], // "tcp://localhost:1234"
expectDialFailure: false,
expectHealthFailure: false,
},
{
name: "tls localhost",
rawAddress: "tls://localhost:" + connectionMap["tls"], // "tls://localhost:1234"
envSSLCertFile: "./testdata/gitalycert.pem",
expectDialFailure: false,
expectHealthFailure: false,
},
{
name: "unix absolute",
rawAddress: "unix:" + unixSocketAbsPath, // "unix:/tmp/temp-socket"
expectDialFailure: false,
expectHealthFailure: false,
},
{
name: "unix relative",
rawAddress: "unix:" + unixSocketPath, // "unix:../../tmp/temp-socket"
expectDialFailure: false,
expectHealthFailure: false,
},
{
name: "unix absolute does not exist",
rawAddress: "unix:" + unixSocketAbsPath + ".does_not_exist", // "unix:/tmp/temp-socket.does_not_exist"
expectDialFailure: false,
expectHealthFailure: true,
},
{
name: "unix relative does not exist",
rawAddress: "unix:" + unixSocketPath + ".does_not_exist", // "unix:../../tmp/temp-socket.does_not_exist"
expectDialFailure: false,
expectHealthFailure: true,
},
{
// Gitaly does not support connections that do not have a scheme.
name: "tcp localhost no prefix",
rawAddress: "localhost:" + connectionMap["tcp"], // "localhost:1234"
expectDialFailure: true,
},
{
name: "invalid",
rawAddress: ".",
expectDialFailure: true,
},
{
name: "empty",
rawAddress: "",
expectDialFailure: true,
},
{
name: "dial fail if there is no listener on address",
rawAddress: "tcp://invalid.address",
dialOpts: FailOnNonTempDialError(),
expectDialFailure: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if emitProxyWarning() {
t.Log("WARNING. Proxy configuration detected from environment settings. This test failure may be related to proxy configuration. Please process with caution")
}
if tt.envSSLCertFile != "" {
t.Setenv(gitalyx509.SSLCertFile, tt.envSSLCertFile)
}
ctx := testhelper.Context(t)
dialOpts := append(tt.dialOpts, WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()))
conn, err := Dial(tt.rawAddress, dialOpts)
if tt.expectDialFailure {
require.Error(t, err)
return
}
require.NoError(t, err)
defer testhelper.MustClose(t, conn)
_, err = healthpb.NewHealthClient(conn).Check(ctx, &healthpb.HealthCheckRequest{})
if tt.expectHealthFailure {
require.Error(t, err)
return
}
require.NoError(t, err)
})
}
}
func TestDialSidechannel(t *testing.T) {
if emitProxyWarning() {
t.Log("WARNING. Proxy configuration detected from environment settings. This test failure may be related to proxy configuration. Please process with caution")
}
stop, connectionMap := startListeners(t, func(creds credentials.TransportCredentials) *grpc.Server {
return grpc.NewServer(TestSidechannelServer(newLogger(t), creds, func(
_ interface{},
stream grpc.ServerStream,
sidechannelConn io.ReadWriteCloser,
) error {
if method, ok := grpc.Method(stream.Context()); !ok || method != "/grpc.health.v1.Health/Check" {
return fmt.Errorf("unexpected method: %s", method)
}
var req healthpb.HealthCheckRequest
if err := stream.RecvMsg(&req); err != nil {
return fmt.Errorf("recv msg: %w", err)
}
if _, err := io.Copy(sidechannelConn, sidechannelConn); err != nil {
return fmt.Errorf("copy: %w", err)
}
if err := stream.SendMsg(&healthpb.HealthCheckResponse{}); err != nil {
return fmt.Errorf("send msg: %w", err)
}
return nil
})...)
})
defer stop()
unixSocketAbsPath := connectionMap["unix"]
tempDir := testhelper.TempDir(t)
unixSocketPath := filepath.Join(tempDir, "gitaly.socket")
require.NoError(t, os.Symlink(unixSocketAbsPath, unixSocketPath))
registry := NewSidechannelRegistry(newLogger(t))
tests := []struct {
name string
rawAddress string
envSSLCertFile string
dialOpts []grpc.DialOption
}{
{
name: "tcp sidechannel",
rawAddress: "tcp://localhost:" + connectionMap["tcp"], // "tcp://localhost:1234"
},
{
name: "tls sidechannel",
rawAddress: "tls://localhost:" + connectionMap["tls"], // "tls://localhost:1234"
envSSLCertFile: "./testdata/gitalycert.pem",
},
{
name: "unix sidechannel",
rawAddress: "unix:" + unixSocketAbsPath, // "unix:/tmp/temp-socket"
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if tt.envSSLCertFile != "" {
t.Setenv(gitalyx509.SSLCertFile, tt.envSSLCertFile)
}
ctx := testhelper.Context(t)
dialOpts := append(tt.dialOpts, WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()))
conn, err := DialSidechannel(ctx, tt.rawAddress, registry, dialOpts)
require.NoError(t, err)
defer testhelper.MustClose(t, conn)
ctx, scw := registry.Register(ctx, func(conn SidechannelConn) error {
const message = "hello world"
if _, err := io.WriteString(conn, message); err != nil {
return err
}
if err := conn.CloseWrite(); err != nil {
return err
}
buf, err := io.ReadAll(conn)
if err != nil {
return err
}
if string(buf) != message {
return fmt.Errorf("expected %q, got %q", message, buf)
}
return nil
})
defer testhelper.MustClose(t, scw)
req := &healthpb.HealthCheckRequest{Service: "test sidechannel"}
_, err = healthpb.NewHealthClient(conn).Check(ctx, req)
require.NoError(t, err)
require.NoError(t, scw.Close())
})
}
}
type testSvc struct {
grpc_testing.UnimplementedTestServiceServer
unaryCall func(context.Context, *grpc_testing.SimpleRequest) (*grpc_testing.SimpleResponse, error)
fullDuplexCall func(stream grpc_testing.TestService_FullDuplexCallServer) error
}
func (ts *testSvc) UnaryCall(ctx context.Context, r *grpc_testing.SimpleRequest) (*grpc_testing.SimpleResponse, error) {
if ts.unaryCall != nil {
return ts.unaryCall(ctx, r)
}
return &grpc_testing.SimpleResponse{}, nil
}
func (ts *testSvc) FullDuplexCall(stream grpc_testing.TestService_FullDuplexCallServer) error {
if ts.fullDuplexCall != nil {
return ts.fullDuplexCall(stream)
}
return nil
}
func TestDial_Correlation(t *testing.T) {
t.Run("unary", func(t *testing.T) {
serverSocketPath := testhelper.GetTemporaryGitalySocketFileName(t)
listener, err := net.Listen("unix", serverSocketPath)
require.NoError(t, err)
grpcServer := grpc.NewServer(grpc.UnaryInterceptor(grpccorrelation.UnaryServerCorrelationInterceptor()))
svc := &testSvc{
unaryCall: func(ctx context.Context, r *grpc_testing.SimpleRequest) (*grpc_testing.SimpleResponse, error) {
cid := correlation.ExtractFromContext(ctx)
assert.Equal(t, "correlation-id-1", cid)
return &grpc_testing.SimpleResponse{}, nil
},
}
grpc_testing.RegisterTestServiceServer(grpcServer, svc)
go testhelper.MustServe(t, grpcServer, listener)
defer grpcServer.Stop()
ctx := testhelper.Context(t)
cc, err := DialContext(ctx, "unix://"+serverSocketPath, []grpc.DialOption{
internalclient.UnaryInterceptor(),
internalclient.StreamInterceptor(),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
})
require.NoError(t, err)
defer testhelper.MustClose(t, cc)
client := grpc_testing.NewTestServiceClient(cc)
ctx = correlation.ContextWithCorrelation(ctx, "correlation-id-1")
_, err = client.UnaryCall(ctx, &grpc_testing.SimpleRequest{})
require.NoError(t, err)
})
t.Run("stream", func(t *testing.T) {
serverSocketPath := testhelper.GetTemporaryGitalySocketFileName(t)
listener, err := net.Listen("unix", serverSocketPath)
require.NoError(t, err)
grpcServer := grpc.NewServer(grpc.StreamInterceptor(grpccorrelation.StreamServerCorrelationInterceptor()))
svc := &testSvc{
fullDuplexCall: func(stream grpc_testing.TestService_FullDuplexCallServer) error {
cid := correlation.ExtractFromContext(stream.Context())
assert.Equal(t, "correlation-id-1", cid)
_, err := stream.Recv()
assert.NoError(t, err)
return stream.Send(&grpc_testing.StreamingOutputCallResponse{})
},
}
grpc_testing.RegisterTestServiceServer(grpcServer, svc)
go testhelper.MustServe(t, grpcServer, listener)
defer grpcServer.Stop()
ctx := testhelper.Context(t)
cc, err := DialContext(ctx, "unix://"+serverSocketPath, []grpc.DialOption{
internalclient.UnaryInterceptor(),
internalclient.StreamInterceptor(),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
})
require.NoError(t, err)
defer testhelper.MustClose(t, cc)
client := grpc_testing.NewTestServiceClient(cc)
ctx = correlation.ContextWithCorrelation(ctx, "correlation-id-1")
stream, err := client.FullDuplexCall(ctx)
require.NoError(t, err)
require.NoError(t, stream.Send(&grpc_testing.StreamingOutputCallRequest{}))
require.NoError(t, stream.CloseSend())
_, err = stream.Recv()
require.NoError(t, err)
})
}
func TestDial_Tracing(t *testing.T) {
serverSocketPath := testhelper.GetTemporaryGitalySocketFileName(t)
listener, err := net.Listen("unix", serverSocketPath)
require.NoError(t, err)
clientSendClosed := make(chan struct{})
// This is our test service. All it does is to create additional spans
// which should in the end be visible when collecting all registered
// spans.
grpcServer := grpc.NewServer(
grpc.UnaryInterceptor(grpctracing.UnaryServerTracingInterceptor()),
grpc.StreamInterceptor(grpctracing.StreamServerTracingInterceptor()),
)
svc := &testSvc{
unaryCall: func(ctx context.Context, r *grpc_testing.SimpleRequest) (*grpc_testing.SimpleResponse, error) {
span, _ := tracing.StartSpan(ctx, "nested-span", nil)
defer span.Finish()
span.LogKV("was", "called")
return &grpc_testing.SimpleResponse{}, nil
},
fullDuplexCall: func(stream grpc_testing.TestService_FullDuplexCallServer) error {
// synchronize the client has returned from CloseSend as the client span finishing
// races with sending the stream close to the server
select {
case <-clientSendClosed:
case <-stream.Context().Done():
return stream.Context().Err()
}
span, _ := tracing.StartSpan(stream.Context(), "nested-span", nil)
defer span.Finish()
span.LogKV("was", "called")
return nil
},
}
grpc_testing.RegisterTestServiceServer(grpcServer, svc)
go testhelper.MustServe(t, grpcServer, listener)
defer grpcServer.Stop()
ctx := testhelper.Context(t)
t.Run("unary", func(t *testing.T) {
reporter := jaeger.NewInMemoryReporter()
tracer, tracerCloser := jaeger.NewTracer("", jaeger.NewConstSampler(true), reporter)
defer testhelper.MustClose(t, tracerCloser)
defer func(old opentracing.Tracer) { opentracing.SetGlobalTracer(old) }(opentracing.GlobalTracer())
opentracing.SetGlobalTracer(tracer)
// This needs to be run after setting up the global tracer as it will cause us to
// create the span when executing the RPC call further down below.
cc, err := DialContext(ctx, "unix://"+serverSocketPath, []grpc.DialOption{
internalclient.UnaryInterceptor(),
internalclient.StreamInterceptor(),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
})
require.NoError(t, err)
defer testhelper.MustClose(t, cc)
// We set up a "main" span here, which is going to be what the
// other spans inherit from. In order to check whether baggage
// works correctly, we also set up a "stub" baggage item which
// should be inherited to child contexts.
span := tracer.StartSpan("unary-check")
span = span.SetBaggageItem("service", "stub")
ctx := opentracing.ContextWithSpan(ctx, span)
// We're now invoking the unary RPC with the span injected into
// the context. This should create a span that's nested into
// the "stream-check" span.
_, err = grpc_testing.NewTestServiceClient(cc).UnaryCall(ctx, &grpc_testing.SimpleRequest{})
require.NoError(t, err)
span.Finish()
spans := reporter.GetSpans()
require.Len(t, spans, 3)
for i, expectedSpan := range []struct {
baggage string
operation string
}{
// This is the first span we expect, which is the
// "health" span which we've manually created inside of
// PingMethod.
{baggage: "", operation: "nested-span"},
// This span is the RPC call to TestService/Ping. It
// inherits the "unary-check" we set up and thus has
// baggage.
{baggage: "stub", operation: "/grpc.testing.TestService/UnaryCall"},
// And this finally is the outermost span which we
// manually set up before the RPC call.
{baggage: "stub", operation: "unary-check"},
} {
assert.IsType(t, spans[i], &jaeger.Span{})
span := spans[i].(*jaeger.Span)
assert.Equal(t, expectedSpan.baggage, span.BaggageItem("service"), "wrong baggage item for span %d", i)
assert.Equal(t, expectedSpan.operation, span.OperationName(), "wrong operation name for span %d", i)
}
})
t.Run("stream", func(t *testing.T) {
reporter := jaeger.NewInMemoryReporter()
tracer, tracerCloser := jaeger.NewTracer("", jaeger.NewConstSampler(true), reporter)
defer testhelper.MustClose(t, tracerCloser)
defer func(old opentracing.Tracer) { opentracing.SetGlobalTracer(old) }(opentracing.GlobalTracer())
opentracing.SetGlobalTracer(tracer)
// This needs to be run after setting up the global tracer as it will cause us to
// create the span when executing the RPC call further down below.
cc, err := DialContext(ctx, "unix://"+serverSocketPath, []grpc.DialOption{
internalclient.UnaryInterceptor(),
internalclient.StreamInterceptor(),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
})
require.NoError(t, err)
defer testhelper.MustClose(t, cc)
// We set up a "main" span here, which is going to be what the other spans inherit
// from. In order to check whether baggage works correctly, we also set up a "stub"
// baggage item which should be inherited to child contexts.
span := tracer.StartSpan("stream-check")
span = span.SetBaggageItem("service", "stub")
ctx := opentracing.ContextWithSpan(ctx, span)
// We're now invoking the streaming RPC with the span injected into the context.
// This should create a span that's nested into the "stream-check" span.
stream, err := grpc_testing.NewTestServiceClient(cc).FullDuplexCall(ctx)
require.NoError(t, err)
require.NoError(t, stream.CloseSend())
close(clientSendClosed)
// wait for the server to finish its spans and close the stream
resp, err := stream.Recv()
require.Equal(t, err, io.EOF)
require.Nil(t, resp)
span.Finish()
spans := reporter.GetSpans()
require.Len(t, spans, 3)
for i, expectedSpan := range []struct {
baggage string
operation string
}{
// This span is the RPC call to TestService/Ping.
{baggage: "stub", operation: "/grpc.testing.TestService/FullDuplexCall"},
// This is the second span we expect, which is the "nested-span" span which
// we've manually created inside of PingMethod. This is different than for
// unary RPCs: given that one can send multiple messages to the RPC, we may
// see multiple such "nested-span"s being created. And the PingStream span
// will only be finalized last.
{baggage: "", operation: "nested-span"},
// And this finally is the outermost span which we
// manually set up before the RPC call.
{baggage: "stub", operation: "stream-check"},
} {
if !assert.IsType(t, spans[i], &jaeger.Span{}) {
continue
}
span := spans[i].(*jaeger.Span)
assert.Equal(t, expectedSpan.baggage, span.BaggageItem("service"), "wrong baggage item for span %d", i)
assert.Equal(t, expectedSpan.operation, span.OperationName(), "wrong operation name for span %d", i)
}
})
}
// healthServer provide a basic GRPC health service endpoint for testing purposes
type healthServer struct {
healthpb.UnimplementedHealthServer
}
func (*healthServer) Check(context.Context, *healthpb.HealthCheckRequest) (*healthpb.HealthCheckResponse, error) {
return &healthpb.HealthCheckResponse{}, nil
}
// startTCPListener will start a insecure TCP listener on a random unused port
func startTCPListener(tb testing.TB, factory func(credentials.TransportCredentials) *grpc.Server) (func(), string) {
listener, err := net.Listen("tcp", "localhost:0")
require.NoError(tb, err)
tcpPort := listener.Addr().(*net.TCPAddr).Port
address := fmt.Sprintf("%d", tcpPort)
grpcServer := factory(insecure.NewCredentials())
go testhelper.MustServe(tb, grpcServer, listener)
return func() {
grpcServer.Stop()
}, address
}
// startUnixListener will start a unix socket listener using a temporary file
func startUnixListener(tb testing.TB, factory func(credentials.TransportCredentials) *grpc.Server) (func(), string) {
serverSocketPath := testhelper.GetTemporaryGitalySocketFileName(tb)
listener, err := net.Listen("unix", serverSocketPath)
require.NoError(tb, err)
grpcServer := factory(insecure.NewCredentials())
go testhelper.MustServe(tb, grpcServer, listener)
return func() {
grpcServer.Stop()
}, serverSocketPath
}
// startTLSListener will start a secure TLS listener on a random unused port
//
//go:generate openssl req -newkey rsa:4096 -new -nodes -x509 -days 3650 -out testdata/gitalycert.pem -keyout testdata/gitalykey.pem -subj "/C=US/ST=California/L=San Francisco/O=GitLab/OU=GitLab-Shell/CN=localhost" -addext "subjectAltName = IP:127.0.0.1, DNS:localhost"
func startTLSListener(tb testing.TB, factory func(credentials.TransportCredentials) *grpc.Server) (func(), string) {
listener, err := net.Listen("tcp", "localhost:0")
require.NoError(tb, err)
tcpPort := listener.Addr().(*net.TCPAddr).Port
address := fmt.Sprintf("%d", tcpPort)
cert, err := tls.LoadX509KeyPair("testdata/gitalycert.pem", "testdata/gitalykey.pem")
require.NoError(tb, err)
grpcServer := factory(
credentials.NewTLS(&tls.Config{
Certificates: []tls.Certificate{cert},
MinVersion: tls.VersionTLS12,
}),
)
go testhelper.MustServe(tb, grpcServer, listener)
return func() {
grpcServer.Stop()
}, address
}
var listeners = map[string]func(testing.TB, func(credentials.TransportCredentials) *grpc.Server) (func(), string){
"tcp": startTCPListener,
"unix": startUnixListener,
"tls": startTLSListener,
}
// startListeners will start all the different listeners used in this test
func startListeners(tb testing.TB, factory func(credentials.TransportCredentials) *grpc.Server) (func(), map[string]string) {
var closers []func()
connectionMap := map[string]string{}
for k, v := range listeners {
closer, address := v(tb, factory)
closers = append(closers, closer)
connectionMap[k] = address
}
return func() {
for _, v := range closers {
v()
}
}, connectionMap
}
func emitProxyWarning() bool {
for _, key := range proxyEnvironmentKeys {
value := os.Getenv(key)
if value != "" {
return true
}
value = os.Getenv(strings.ToUpper(key))
if value != "" {
return true
}
}
return false
}
func TestHealthCheckDialer(t *testing.T) {
_, addr, cleanup := runServer(t, "token")
defer cleanup()
ctx := testhelper.Context(t)
_, err := HealthCheckDialer(DialContext)(ctx, addr, nil)
testhelper.RequireGrpcError(t, status.Error(codes.Unauthenticated, "authentication required"), err)
cc, err := HealthCheckDialer(DialContext)(ctx, addr, []grpc.DialOption{
grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2("token")),
internalclient.UnaryInterceptor(),
internalclient.StreamInterceptor(),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
})
require.NoError(t, err)
require.NoError(t, cc.Close())
}
var dialFuncs = []struct {
name string
dial func(*testing.T, string, []grpc.DialOption) (*grpc.ClientConn, error)
}{
{
name: "Dial",
dial: func(t *testing.T, rawAddress string, connOpts []grpc.DialOption) (*grpc.ClientConn, error) {
return Dial(rawAddress, connOpts)
},
},
{
name: "DialContext",
dial: func(t *testing.T, rawAddress string, connOpts []grpc.DialOption) (*grpc.ClientConn, error) {
return DialContext(testhelper.Context(t), rawAddress, connOpts)
},
},
{
name: "DialSidechannel",
dial: func(t *testing.T, rawAddress string, connOpts []grpc.DialOption) (*grpc.ClientConn, error) {
sr := NewSidechannelRegistry(testhelper.NewDiscardingLogEntry(t))
return DialSidechannel(testhelper.Context(t), rawAddress, sr, connOpts)
},
},
}
func TestWithGitalyDNSResolver_resolvableDomain(t *testing.T) {
t.Parallel()
serverURL := startFakeGitalyServer(t)
serverHost, serverPort, err := net.SplitHostPort(serverURL)
require.NoError(t, err)
dnsServer := testhelper.NewFakeDNSServer(t).WithHandler(dns.TypeA, func(host string) []string {
if host == "grpc.test." {
return []string{serverHost}
}
return nil
}).Start()
// This scheme uses our DNS resolver
url := fmt.Sprintf("dns://%s/grpc.test:%s", dnsServer.Addr(), serverPort)
for _, dialFunc := range dialFuncs {
dialFunc := dialFunc
t.Run(fmt.Sprintf("dial via %s, url = %s", dialFunc.name, url), func(t *testing.T) {
t.Parallel()
verifyDNSConnection(t, dialFunc.dial, url)
})
}
}
func TestWithGitalyDNSResolver_loopbackAddresses(t *testing.T) {
t.Parallel()
serverURL := startFakeGitalyServer(t)
_, port, err := net.SplitHostPort(serverURL)
require.NoError(t, err)
urls := []string{
fmt.Sprintf("dns:///%s", serverURL),
fmt.Sprintf("dns:%s", serverURL),
fmt.Sprintf("dns:///localhost:%s", port),
fmt.Sprintf("dns:localhost:%s", port),
}
for _, url := range urls {
for _, dialFunc := range dialFuncs {
url := url
dialFunc := dialFunc
t.Run(fmt.Sprintf("dial via %s, url = %s", dialFunc.name, url), func(t *testing.T) {
t.Parallel()
verifyDNSConnection(t, dialFunc.dial, url)
})
}
}
}
func verifyDNSConnection(t *testing.T, dial func(*testing.T, string, []grpc.DialOption) (*grpc.ClientConn, error), target string) {
conn, err := dial(
t,
target,
[]grpc.DialOption{
grpc.WithTransportCredentials(insecure.NewCredentials()),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
},
)
require.NoError(t, err)
defer testhelper.MustClose(t, conn)
client := gitalypb.NewCommitServiceClient(conn)
for i := 0; i < 10; i++ {
_, err = client.FindCommit(testhelper.Context(t), &gitalypb.FindCommitRequest{})
require.NoError(t, err)
}
}
func TestWithGitalyDNSResolver_zeroAddresses(t *testing.T) {
t.Parallel()
for _, dialFunc := range dialFuncs {
dialFunc := dialFunc
t.Run(fmt.Sprintf("dial via %s", dialFunc.name), func(t *testing.T) {
t.Parallel()
dnsServer := testhelper.NewFakeDNSServer(t).WithHandler(dns.TypeA, func(host string) []string {
return nil
}).Start()
// This scheme uses our DNS resolver
target := fmt.Sprintf("dns://%s/grpc.test:50051", dnsServer.Addr())
conn, err := dialFunc.dial(
t,
target,
[]grpc.DialOption{
grpc.WithTransportCredentials(insecure.NewCredentials()),
WithGitalyDNSResolver(DefaultDNSResolverBuilderConfig()),
},
)
require.NoError(t, err)
defer testhelper.MustClose(t, conn)
client := gitalypb.NewCommitServiceClient(conn)
_, err = client.FindCommit(testhelper.Context(t), &gitalypb.FindCommitRequest{})
require.Equal(t, err, status.Error(codes.Unavailable, "last resolver error: produced zero addresses"))
})
}
}
type fakeCommitServer struct {
gitalypb.UnimplementedCommitServiceServer
}
func (s *fakeCommitServer) FindCommit(_ context.Context, _ *gitalypb.FindCommitRequest) (*gitalypb.FindCommitResponse, error) {
return &gitalypb.FindCommitResponse{}, nil
}
func startFakeGitalyServer(t *testing.T) string {
listener, err := net.Listen("tcp", "localhost:0")
require.NoError(t, err)
srv := grpc.NewServer(SidechannelServer(newLogger(t), insecure.NewCredentials()))
gitalypb.RegisterCommitServiceServer(srv, &fakeCommitServer{})
go testhelper.MustServe(t, srv, listener)
t.Cleanup(srv.Stop)
return listener.Addr().String()
}
func newLogger(tb testing.TB) *logrus.Entry {
return logrus.NewEntry(testhelper.NewDiscardingLogger(tb))
}
|