1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
|
package backup
import (
"context"
"fmt"
"sync/atomic"
"testing"
"time"
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/storage"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
)
func TestLoggingPipeline(t *testing.T) {
t.Parallel()
testPipeline(t, func() Pipeline {
return NewLoggingPipeline(logrus.StandardLogger())
})
}
func TestParallelPipeline(t *testing.T) {
t.Parallel()
testPipeline(t, func() Pipeline {
return NewParallelPipeline(NewLoggingPipeline(logrus.StandardLogger()), 2, 0)
})
t.Run("parallelism", func(t *testing.T) {
for _, tc := range []struct {
parallel int
parallelStorage int
expectedMaxParallel int64
}{
{
parallel: 2,
parallelStorage: 0,
expectedMaxParallel: 2,
},
{
parallel: 2,
parallelStorage: 3,
expectedMaxParallel: 2,
},
{
parallel: 0,
parallelStorage: 3,
expectedMaxParallel: 6, // 2 storages * 3 workers per storage
},
} {
t.Run(fmt.Sprintf("parallel:%d,parallelStorage:%d", tc.parallel, tc.parallelStorage), func(t *testing.T) {
var calls int64
strategy := MockStrategy{
CreateFunc: func(ctx context.Context, req *CreateRequest) error {
currentCalls := atomic.AddInt64(&calls, 1)
defer atomic.AddInt64(&calls, -1)
assert.LessOrEqual(t, currentCalls, tc.expectedMaxParallel)
time.Sleep(time.Millisecond)
return nil
},
}
var p Pipeline
p = NewLoggingPipeline(logrus.StandardLogger())
p = NewParallelPipeline(p, tc.parallel, tc.parallelStorage)
ctx := testhelper.Context(t)
for i := 0; i < 10; i++ {
p.Handle(ctx, NewCreateCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{StorageName: "storage1"}, false))
p.Handle(ctx, NewCreateCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{StorageName: "storage2"}, false))
}
require.NoError(t, p.Done())
})
}
})
t.Run("context done", func(t *testing.T) {
var strategy MockStrategy
var p Pipeline
p = NewLoggingPipeline(logrus.StandardLogger())
p = NewParallelPipeline(p, 0, 0) // make sure worker channels always block
ctx, cancel := context.WithCancel(testhelper.Context(t))
cancel()
<-ctx.Done()
p.Handle(ctx, NewCreateCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{StorageName: "default"}, false))
err := p.Done()
require.EqualError(t, err, "pipeline: context canceled")
})
}
type MockStrategy struct {
CreateFunc func(context.Context, *CreateRequest) error
RestoreFunc func(context.Context, *RestoreRequest) error
}
func (s MockStrategy) Create(ctx context.Context, req *CreateRequest) error {
if s.CreateFunc != nil {
return s.CreateFunc(ctx, req)
}
return nil
}
func (s MockStrategy) Restore(ctx context.Context, req *RestoreRequest) error {
if s.RestoreFunc != nil {
return s.RestoreFunc(ctx, req)
}
return nil
}
func testPipeline(t *testing.T, init func() Pipeline) {
t.Run("create command", func(t *testing.T) {
t.Parallel()
strategy := MockStrategy{
CreateFunc: func(_ context.Context, req *CreateRequest) error {
switch req.Repository.StorageName {
case "normal":
return nil
case "skip":
return ErrSkipped
case "error":
return assert.AnError
}
require.Failf(t, "unexpected call to Create", "StorageName = %q", req.Repository.StorageName)
return nil
},
}
p := init()
ctx := testhelper.Context(t)
commands := []Command{
NewCreateCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{RelativePath: "a.git", StorageName: "normal"}, false),
NewCreateCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{RelativePath: "b.git", StorageName: "skip"}, false),
NewCreateCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{RelativePath: "c.git", StorageName: "error"}, false),
}
for _, cmd := range commands {
p.Handle(ctx, cmd)
}
err := p.Done()
require.EqualError(t, err, "pipeline: 1 failures encountered:\n - c.git: assert.AnError general error for testing\n")
})
t.Run("restore command", func(t *testing.T) {
t.Parallel()
strategy := MockStrategy{
RestoreFunc: func(_ context.Context, req *RestoreRequest) error {
switch req.Repository.StorageName {
case "normal":
return nil
case "skip":
return ErrSkipped
case "error":
return assert.AnError
}
require.Failf(t, "unexpected call to Restore", "StorageName = %q", req.Repository.StorageName)
return nil
},
}
p := init()
ctx := testhelper.Context(t)
commands := []Command{
NewRestoreCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{RelativePath: "a.git", StorageName: "normal"}, false),
NewRestoreCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{RelativePath: "b.git", StorageName: "skip"}, false),
NewRestoreCommand(strategy, storage.ServerInfo{}, &gitalypb.Repository{RelativePath: "c.git", StorageName: "error"}, false),
}
for _, cmd := range commands {
p.Handle(ctx, cmd)
}
err := p.Done()
require.EqualError(t, err, "pipeline: 1 failures encountered:\n - c.git: assert.AnError general error for testing\n")
})
}
func TestPipelineError(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
name string
repos []*gitalypb.Repository
expectedError string
}{
{
name: "with gl_project_path",
repos: []*gitalypb.Repository{
{RelativePath: "1.git", GlProjectPath: "Projects/Apple"},
{RelativePath: "2.git", GlProjectPath: "Projects/Banana"},
{RelativePath: "3.git", GlProjectPath: "Projects/Carrot"},
},
expectedError: `3 failures encountered:
- 1.git (Projects/Apple): assert.AnError general error for testing
- 2.git (Projects/Banana): assert.AnError general error for testing
- 3.git (Projects/Carrot): assert.AnError general error for testing
`,
},
{
name: "without gl_project_path",
repos: []*gitalypb.Repository{
{RelativePath: "1.git"},
{RelativePath: "2.git"},
{RelativePath: "3.git"},
},
expectedError: `3 failures encountered:
- 1.git: assert.AnError general error for testing
- 2.git: assert.AnError general error for testing
- 3.git: assert.AnError general error for testing
`,
},
} {
t.Run(tc.name, func(t *testing.T) {
err := PipelineErrors{}
for _, repo := range tc.repos {
err.AddError(repo, assert.AnError)
}
require.EqualError(t, err, tc.expectedError)
})
}
}
|
