1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321
|
package cache
import (
"context"
"crypto/sha256"
"encoding/hex"
"errors"
"fmt"
"io/fs"
"os"
"path/filepath"
"sort"
"strings"
"time"
"github.com/google/uuid"
"github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus/ctxlogrus"
"gitlab.com/gitlab-org/gitaly/v16/internal/featureflag"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/storage"
"gitlab.com/gitlab-org/gitaly/v16/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v16/internal/safe"
"gitlab.com/gitlab-org/gitaly/v16/internal/version"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
"google.golang.org/grpc"
"google.golang.org/protobuf/proto"
)
var (
// ErrMissingLeaseFile indicates a lease file does not exist on the
// filesystem that the lease ender expected to be there
ErrMissingLeaseFile = errors.New("lease file unexpectedly missing")
// ErrInvalidUUID indicates an internal error with generating a UUID
ErrInvalidUUID = errors.New("unable to generate valid UUID")
// ErrCtxMethodMissing indicates the provided context does not contain the
// expected information about the current gRPC method
ErrCtxMethodMissing = errors.New("context does not contain gRPC method name")
// ErrPendingExists indicates that there is a critical zone for the current
// repository in the pending transition
ErrPendingExists = errors.New("one or more cache generations are pending transition for the current repository")
)
// leaseKeyer will try to return a key path for the current generation of
// the repo's cache. It uses a strategy that avoids file locks in favor of
// atomically created/renamed files. Read more about leaseKeyer's design:
// https://gitlab.com/gitlab-org/gitaly/issues/1745
type leaseKeyer struct {
locator storage.Locator
countErr func(error) error
}
// newLeaseKeyer initializes a new leaseKeyer
func newLeaseKeyer(locator storage.Locator, countErr func(error) error) leaseKeyer {
return leaseKeyer{
locator: locator,
countErr: countErr,
}
}
func (keyer leaseKeyer) updateLatest(ctx context.Context, repo *gitalypb.Repository) (_ string, returnedErr error) {
repoStatePath, err := keyer.getRepoStatePath(repo)
if err != nil {
return "", err
}
lPath := latestPath(repoStatePath)
if err := os.MkdirAll(filepath.Dir(lPath), perm.SharedDir); err != nil {
return "", err
}
latest, err := safe.NewFileWriter(lPath)
if err != nil {
return "", err
}
defer func() {
if err := latest.Close(); err != nil && returnedErr == nil {
if !errors.Is(err, safe.ErrAlreadyDone) {
returnedErr = err
}
}
}()
nextGenID := uuid.New().String()
if nextGenID == "" {
return "", ErrInvalidUUID
}
if _, err = latest.Write([]byte(nextGenID)); err != nil {
return "", err
}
if err := latest.Commit(); err != nil {
return "", err
}
ctxlogrus.Extract(ctx).
WithField("diskcache", nextGenID).
Infof("diskcache state change")
return nextGenID, nil
}
// staleAge is how old we consider a pending file to be stale before removal
const staleAge = time.Hour
// keyPath will attempt to return the unique keypath for a request in the
// specified repo for the current generation. The context must contain the gRPC
// method in its values.
func (keyer leaseKeyer) keyPath(ctx context.Context, repo *gitalypb.Repository, req proto.Message) (string, error) {
pending, err := keyer.currentLeases(repo)
if err != nil {
return "", err
}
repoStatePath, err := keyer.getRepoStatePath(repo)
if err != nil {
return "", err
}
pDir := pendingDir(repoStatePath)
anyValidPending := false
for _, p := range pending {
info, err := p.Info()
if err != nil {
// The lease may have been cleaned up already, so we just ignore it as we
// wanted to remove it anyway.
if errors.Is(err, fs.ErrNotExist) {
continue
}
return "", fmt.Errorf("statting lease: %w", err)
}
if time.Since(info.ModTime()) > staleAge {
pPath := filepath.Join(pDir, p.Name())
if err := os.Remove(pPath); err != nil && !os.IsNotExist(err) {
return "", err
}
continue
}
anyValidPending = true
}
if anyValidPending {
return "", keyer.countErr(ErrPendingExists)
}
genID, err := keyer.currentGenID(ctx, repo)
if err != nil {
return "", err
}
key, err := compositeKeyHashHex(ctx, genID, req)
if err != nil {
return "", err
}
cDir, err := keyer.cacheDir(repo)
if err != nil {
return "", err
}
return radixPath(cDir, key)
}
// radixPath is the same directory structure scheme used by git. This scheme
// allows for the objects to be randomly distributed across folders based on
// the first 2 hex chars of the key (i.e. 256 possible top level folders).
func radixPath(root, key string) (string, error) {
return filepath.Join(root, key[0:2], key[2:]), nil
}
func (keyer leaseKeyer) newPendingLease(repo *gitalypb.Repository) (string, error) {
repoStatePath, err := keyer.getRepoStatePath(repo)
if err != nil {
return "", err
}
lPath := latestPath(repoStatePath)
if err := os.Remove(lPath); err != nil && !os.IsNotExist(err) {
return "", err
}
pDir := pendingDir(repoStatePath)
if err := os.MkdirAll(pDir, perm.SharedDir); err != nil {
return "", err
}
f, err := os.CreateTemp(pDir, "")
if err != nil {
err = fmt.Errorf("creating pending lease failed: %w", err)
return "", err
}
if err := f.Close(); err != nil {
return "", err
}
return f.Name(), nil
}
// cacheDir is $STORAGE/+gitaly/cache
func (keyer leaseKeyer) cacheDir(repo *gitalypb.Repository) (string, error) {
cacheDir, err := keyer.locator.CacheDir(repo.StorageName)
if err != nil {
return "", fmt.Errorf("cache dir not found for %v", repo)
}
return cacheDir, nil
}
func (keyer leaseKeyer) getRepoStatePath(repo *gitalypb.Repository) (string, error) {
storagePath, err := keyer.locator.GetStorageByName(repo.StorageName)
if err != nil {
return "", fmt.Errorf("getRepoStatePath: storage not found for %v", repo)
}
stateDir, err := keyer.locator.StateDir(repo.StorageName)
if err != nil {
return "", fmt.Errorf("getRepoStatePath: state dir not found for %v", repo)
}
relativePath := repo.GetRelativePath()
if len(relativePath) == 0 {
return "", fmt.Errorf("getRepoStatePath: relative path missing from %+v", repo)
}
if _, err := storage.ValidateRelativePath(storagePath, relativePath); err != nil {
return "", fmt.Errorf("getRepoStatePath: %w", err)
}
return filepath.Join(stateDir, relativePath), nil
}
func (keyer leaseKeyer) currentLeases(repo *gitalypb.Repository) ([]fs.DirEntry, error) {
repoStatePath, err := keyer.getRepoStatePath(repo)
if err != nil {
return nil, err
}
pendings, err := os.ReadDir(pendingDir(repoStatePath))
switch {
case os.IsNotExist(err):
// pending files subdir don't exist yet, that's okay
break
case err == nil:
break
default:
return nil, err
}
return pendings, nil
}
func (keyer leaseKeyer) currentGenID(ctx context.Context, repo *gitalypb.Repository) (string, error) {
repoStatePath, err := keyer.getRepoStatePath(repo)
if err != nil {
return "", err
}
latestBytes, err := os.ReadFile(latestPath(repoStatePath))
switch {
case os.IsNotExist(err):
// latest file doesn't exist, so create one
return keyer.updateLatest(ctx, repo)
case err == nil:
return string(latestBytes), nil
default:
return "", err
}
}
// func stateDir(repoDir string) string { return filepath.Join(repoDir, "state") }
func pendingDir(repoStateDir string) string { return filepath.Join(repoStateDir, "pending") }
func latestPath(repoStateDir string) string { return filepath.Join(repoStateDir, "latest") }
// compositeKeyHashHex returns a hex encoded string that is a SHA256 hash sum of
// the composite key made up of the following properties: Gitaly version, gRPC
// method, repo cache current generation ID, protobuf request, and enabled
// feature flags.
func compositeKeyHashHex(ctx context.Context, genID string, req proto.Message) (string, error) {
method, ok := grpc.Method(ctx)
if !ok {
return "", ErrCtxMethodMissing
}
reqSum, err := proto.Marshal(req)
if err != nil {
return "", err
}
h := sha256.New()
var flagsWithValue []string
for flag, enabled := range featureflag.FromContext(ctx) {
flagsWithValue = append(flagsWithValue, flag.FormatWithValue(enabled))
}
sort.Strings(flagsWithValue)
for _, i := range []string{
version.GetVersion(),
method,
genID,
string(reqSum),
strings.Join(flagsWithValue, " "),
} {
_, err := h.Write(prefixLen(i))
if err != nil {
return "", err
}
}
return hex.EncodeToString(h.Sum(nil)), nil
}
// prefixLen reduces the risk of collisions due to different combinations of
// concatenated strings producing the same content.
// e.g. f+oobar and foo+bar concatenate to the same thing: foobar
func prefixLen(s string) []byte {
return []byte(fmt.Sprintf("%08x%s", len(s), s))
}
|