1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
package cache
import (
"os"
"os/exec"
"path/filepath"
"strings"
"testing"
"time"
promtest "github.com/prometheus/client_golang/prometheus/testutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/v16/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper/testcfg"
)
func TestDiskCacheObjectWalker(t *testing.T) {
cfg := testcfg.Build(t)
locator := config.NewLocator(cfg)
var shouldExist, shouldNotExist []string
for _, tt := range []struct {
name string
age time.Duration
expectRemoval bool
}{
{"0f/oldey", time.Hour, true},
{"90/n00b", time.Minute, false},
{"2b/ancient", 24 * time.Hour, true},
{"cd/baby", time.Second, false},
} {
cacheDir, err := locator.CacheDir(cfg.Storages[0].Name)
require.NoError(t, err)
path := filepath.Join(cacheDir, tt.name)
require.NoError(t, os.MkdirAll(filepath.Dir(path), perm.SharedDir))
f, err := os.Create(path)
require.NoError(t, err)
require.NoError(t, f.Close())
require.NoError(t, os.Chtimes(path, time.Now(), time.Now().Add(-1*tt.age)))
if tt.expectRemoval {
shouldNotExist = append(shouldNotExist, path)
} else {
shouldExist = append(shouldExist, path)
}
}
cache := New(cfg, locator, withDisabledMoveAndClear())
require.NoError(t, cache.StartWalkers())
defer cache.StopWalkers()
require.Eventually(t, func() bool {
count := int(promtest.ToFloat64(cache.walkerRemovalTotal))
return count == 4
}, time.Minute, time.Millisecond)
for _, p := range shouldExist {
assert.FileExists(t, p)
}
for _, p := range shouldNotExist {
require.NoFileExists(t, p)
}
}
func TestDiskCacheInitialClear(t *testing.T) {
cfg := testcfg.Build(t)
locator := config.NewLocator(cfg)
cacheDir, err := locator.CacheDir(cfg.Storages[0].Name)
require.NoError(t, err)
canary := filepath.Join(cacheDir, "canary.txt")
require.NoError(t, os.MkdirAll(filepath.Dir(canary), perm.SharedDir))
require.NoError(t, os.WriteFile(canary, []byte("chirp chirp"), perm.PublicFile))
cache := New(cfg, locator, withDisabledWalker())
require.NoError(t, cache.StartWalkers())
defer cache.StopWalkers()
require.NoFileExists(t, canary)
}
func TestCleanWalkDirNotExists(t *testing.T) {
cfg := testcfg.Build(t)
cache := New(cfg, config.NewLocator(cfg))
err := cache.cleanWalk("/path/that/does/not/exist")
assert.NoError(t, err, "cleanWalk returned an error for a non existing directory")
}
func TestCleanWalkEmptyDirs(t *testing.T) {
tmp := testhelper.TempDir(t)
for _, tt := range []struct {
path string
stale bool
}{
{path: "a/b/c/"},
{path: "a/b/c/1", stale: true},
{path: "a/b/c/2", stale: true},
{path: "a/b/d/"},
{path: "e/"},
{path: "e/1"},
{path: "f/"},
} {
p := filepath.Join(tmp, tt.path)
if strings.HasSuffix(tt.path, "/") {
require.NoError(t, os.MkdirAll(p, perm.SharedDir))
} else {
require.NoError(t, os.WriteFile(p, nil, perm.SharedFile))
if tt.stale {
require.NoError(t, os.Chtimes(p, time.Now(), time.Now().Add(-time.Hour)))
}
}
}
cfg := testcfg.Build(t)
cache := New(cfg, config.NewLocator(cfg))
require.NoError(t, cache.cleanWalk(tmp))
actual := findFiles(t, tmp)
expect := `.
./e
./e/1
`
require.Equal(t, expect, actual)
}
func findFiles(tb testing.TB, path string) string {
cmd := exec.Command("find", ".")
cmd.Dir = path
out, err := cmd.Output()
require.NoError(tb, err)
return string(out)
}
|
