1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
|
package objectpool
import (
"context"
"fmt"
"io"
"os"
"path/filepath"
"strings"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/transaction"
"gitlab.com/gitlab-org/gitaly/v16/internal/safe"
)
// Link will link the given repository to the object pool. This is done by writing the object pool's
// path relative to the repository into the repository's "alternates" file. This does not trigger
// deduplication, which is the responsibility of the caller.
func (o *ObjectPool) Link(ctx context.Context, repo *localrepo.Repo) (returnedErr error) {
altPath, err := repo.InfoAlternatesPath()
if err != nil {
return err
}
expectedRelPath, err := o.getRelativeObjectPath(repo)
if err != nil {
return err
}
linked, err := o.LinkedToRepository(repo)
if err != nil {
return err
}
if linked {
return nil
}
alternatesWriter, err := safe.NewLockingFileWriter(altPath)
if err != nil {
return fmt.Errorf("creating alternates writer: %w", err)
}
defer func() {
if err := alternatesWriter.Close(); err != nil && returnedErr == nil {
returnedErr = fmt.Errorf("closing alternates writer: %w", err)
}
}()
if _, err := io.WriteString(alternatesWriter, expectedRelPath); err != nil {
return fmt.Errorf("writing alternates: %w", err)
}
if err := transaction.CommitLockedFile(ctx, o.txManager, alternatesWriter); err != nil {
return fmt.Errorf("committing alternates: %w", err)
}
return o.removeMemberBitmaps(repo)
}
// removeMemberBitmaps removes packfile bitmaps from the member
// repository that just joined the pool. If Git finds two packfiles with
// bitmaps it will print a warning, which is visible to the end user
// during a Git clone. Our goal is to avoid that warning. In normal
// operation, the next 'git gc' or 'git repack -ad' on the member
// repository will remove its local bitmap file. In other words the
// situation we eventually converge to is that the pool may have a bitmap
// but none of its members will. With removeMemberBitmaps we try to
// change "eventually" to "immediately", so that users won't see the
// warning. https://gitlab.com/gitlab-org/gitaly/issues/1728
func (o *ObjectPool) removeMemberBitmaps(repo *localrepo.Repo) error {
poolPath, err := o.Repo.Path()
if err != nil {
return err
}
poolBitmaps, err := getBitmaps(poolPath)
if err != nil {
return err
}
if len(poolBitmaps) == 0 {
return nil
}
repoPath, err := repo.Path()
if err != nil {
return err
}
memberBitmaps, err := getBitmaps(repoPath)
if err != nil {
return err
}
if len(memberBitmaps) == 0 {
return nil
}
for _, bitmap := range memberBitmaps {
if err := os.Remove(bitmap); err != nil && !os.IsNotExist(err) {
return err
}
}
return nil
}
func getBitmaps(repoPath string) ([]string, error) {
packDir := filepath.Join(repoPath, "objects/pack")
entries, err := os.ReadDir(packDir)
if err != nil {
return nil, err
}
var bitmaps []string
for _, entry := range entries {
if name := entry.Name(); strings.HasSuffix(name, ".bitmap") && strings.HasPrefix(name, "pack-") {
bitmaps = append(bitmaps, filepath.Join(packDir, name))
}
}
return bitmaps, nil
}
func (o *ObjectPool) getRelativeObjectPath(repo *localrepo.Repo) (string, error) {
poolPath, err := o.Path()
if err != nil {
return "", fmt.Errorf("getting object pool path: %w", err)
}
repoPath, err := repo.Path()
if err != nil {
return "", fmt.Errorf("getting repository path: %w", err)
}
relPath, err := filepath.Rel(filepath.Join(repoPath, "objects"), poolPath)
if err != nil {
return "", err
}
return filepath.Join(relPath, "objects"), nil
}
// LinkedToRepository tests if a repository is linked to an object pool
func (o *ObjectPool) LinkedToRepository(repo *localrepo.Repo) (bool, error) {
poolPath, err := o.Path()
if err != nil {
return false, fmt.Errorf("getting object pool path: %w", err)
}
relPath, err := getAlternateObjectDir(repo)
if err != nil {
if err == ErrAlternateObjectDirNotExist {
return false, nil
}
return false, err
}
expectedRelPath, err := o.getRelativeObjectPath(repo)
if err != nil {
return false, err
}
if relPath == expectedRelPath {
return true, nil
}
if filepath.Clean(relPath) != filepath.Join(poolPath, "objects") {
return false, fmt.Errorf("unexpected alternates content: %q", relPath)
}
return false, nil
}
|
