1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
package git_test
import (
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/git"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper/testcfg"
)
func TestCheckRefFormat(t *testing.T) {
cfg := testcfg.Build(t)
ctx := testhelper.Context(t)
gitCmdFactory := gittest.NewCommandFactory(t, cfg)
for _, tc := range []struct {
desc string
tagName string
ok bool
}{
// Just trivial tests here, most of this is tested in
// internal/gitaly/service/operations/tags_test.go
{
desc: "unqualified name",
tagName: "my-name",
ok: false,
},
{
desc: "fully-qualified name",
tagName: "refs/heads/my-name",
ok: true,
},
{
desc: "basic tag",
tagName: "refs/tags/my-tag",
ok: true,
},
{
desc: "invalid tag",
tagName: "refs/tags/my tag",
ok: false,
},
} {
t.Run(tc.desc, func(t *testing.T) {
ok, err := git.CheckRefFormat(ctx, gitCmdFactory, tc.tagName)
require.NoError(t, err)
require.Equal(t, tc.ok, ok)
})
}
}
func TestReferenceName_NewReferenceNameFromBranchName(t *testing.T) {
for _, tc := range []struct {
desc string
reference string
expected string
}{
{
desc: "unqualified reference",
reference: "master",
expected: "refs/heads/master",
},
{
desc: "partly qualified reference",
reference: "heads/master",
expected: "refs/heads/heads/master",
},
{
desc: "fully qualified reference",
reference: "refs/heads/master",
expected: "refs/heads/refs/heads/master",
},
{
desc: "weird branch name",
reference: "refs/master",
expected: "refs/heads/refs/master",
},
{
desc: "tag is treated as a branch",
reference: "refs/tags/master",
expected: "refs/heads/refs/tags/master",
},
} {
t.Run(tc.desc, func(t *testing.T) {
ref := git.NewReferenceNameFromBranchName(tc.reference)
require.Equal(t, ref.String(), tc.expected)
})
}
}
func TestReferenceName_Branch(t *testing.T) {
for _, tc := range []struct {
desc string
reference string
expected string
}{
{
desc: "fully qualified reference",
reference: "refs/heads/master",
expected: "master",
},
{
desc: "nested branch",
reference: "refs/heads/foo/master",
expected: "foo/master",
},
{
desc: "unqualified branch is not a branch",
reference: "master",
expected: "",
},
{
desc: "tag is not a branch",
reference: "refs/tags/master",
expected: "",
},
} {
t.Run(tc.desc, func(t *testing.T) {
branch, ok := git.ReferenceName(tc.reference).Branch()
require.Equal(t, tc.expected, branch)
require.Equal(t, tc.expected != "", ok)
})
}
}
|
