1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Admin::RunnersController, feature_category: :fleet_visibility do
let_it_be(:runner) { create(:ci_runner) }
let_it_be(:user) { create(:admin) }
before do
sign_in(user)
end
describe '#index' do
render_views
before do
get :index
end
it 'renders index template' do
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:index)
end
end
describe '#show' do
render_views
it 'shows a runner show page' do
get :show, params: { id: runner.id }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:show)
end
end
describe '#new' do
it 'renders a :new template' do
get :new
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:new)
end
end
describe '#register' do
subject(:register) { get :register, params: { id: new_runner.id } }
context 'when runner can be registered after creation' do
let_it_be(:new_runner) { create(:ci_runner, registration_type: :authenticated_user) }
it 'renders a :register template' do
register
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:register)
end
end
context 'when runner cannot be registered after creation' do
let_it_be(:new_runner) { runner }
it 'returns :not_found' do
register
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe '#edit' do
render_views
let_it_be(:project) { create(:project) }
let_it_be(:project_two) { create(:project) }
it 'shows a runner edit page' do
get :edit, params: { id: runner.id }
expect(response).to have_gitlab_http_status(:ok)
end
it 'shows 404 for unknown runner' do
get :edit, params: { id: 0 }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'avoids N+1 queries', :request_store do
get :edit, params: { id: runner.id }
control = ActiveRecord::QueryRecorder.new { get :edit, params: { id: runner.id } }
# There is one additional query looking up subject.group in ProjectPolicy for the
# needs_new_sso_session permission
expect { get :edit, params: { id: runner.id } }.not_to exceed_query_limit(control).with_threshold(1)
expect(response).to have_gitlab_http_status(:ok)
end
end
describe '#update' do
let(:new_desc) { runner.description.swapcase }
let(:runner_params) { { id: runner.id, runner: { description: new_desc } } }
subject(:request) { post :update, params: runner_params }
context 'with update succeeding' do
it 'updates the runner and ticks the queue' do
expect_next_instance_of(Ci::Runners::UpdateRunnerService, user, runner) do |service|
expect(service).to receive(:execute).with(anything).and_call_original
end
expect { request }.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_gitlab_http_status(:found)
expect(runner.description).to eq(new_desc)
end
end
context 'with update failing' do
it 'does not update runner or tick the queue' do
expect_next_instance_of(Ci::Runners::UpdateRunnerService, user, runner) do |service|
expect(service).to receive(:execute).with(anything).and_return(ServiceResponse.error(message: 'failure'))
end
expect { request }.not_to change { runner.ensure_runner_queue_value }
expect { request }.not_to change { runner.reload.description }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:show)
end
end
end
describe 'GET #runner_setup_scripts' do
it 'renders the setup scripts' do
get :runner_setup_scripts, params: { os: 'linux', arch: 'amd64' }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to have_key("install")
expect(json_response).to have_key("register")
end
it 'renders errors if they occur' do
get :runner_setup_scripts, params: { os: 'foo', arch: 'bar' }
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response).to have_key("errors")
end
end
describe 'GET #tag_list' do
let_it_be(:linux_tag) { create(:ci_tag, name: 'linux') }
let_it_be(:oxs_tag) { create(:ci_tag, name: 'osx') }
it 'renders a list of tags matching the search' do
get :tag_list, params: { search: 'lin' }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to contain_exactly(a_hash_including({ 'id' => linux_tag.id }))
end
it 'applies the limit' do
stub_const("#{described_class.name}::TAGS_LIMIT", 1)
get :tag_list, params: {}
expect(response).to have_gitlab_http_status(:ok)
expect(json_response.size).to eq(1)
end
end
end
|
