1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Admin::TopicsController, :with_current_organization do
let_it_be(:namespace) { create :namespace, organization: current_organization }
let_it_be(:topic) { create(:topic, name: 'topic', organization: namespace.organization) }
let_it_be(:admin) { create(:admin, namespace: namespace) }
let_it_be(:user) { create(:user, namespace: namespace) }
before do
sign_in(admin)
end
describe 'GET #index' do
it 'renders the template' do
get :index
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('index')
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
get :index
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'GET #new' do
it 'renders the template' do
get :new
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('new')
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
get :new
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'GET #edit' do
it 'renders the template' do
get :edit, params: { id: topic.id }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('edit')
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
get :edit, params: { id: topic.id }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'POST #create' do
it 'creates topic' do
expect do
post :create, params: { projects_topic: { name: 'test', title: 'Test' } }
end.to change { Projects::Topic.for_organization(current_organization.id).count }.by(1)
end
it 'shows error message for invalid topic name' do
post :create, params: { projects_topic: { name: nil, title: 'Test' } }
errors = assigns[:topic].errors
expect(errors).to contain_exactly(errors.full_message(:name, I18n.t('errors.messages.blank')))
end
it 'shows error message if topic name not unique (case insensitive)' do
post :create, params: { projects_topic: { name: topic.name.upcase, title: topic.title } }
errors = assigns[:topic].errors
expect(errors).to contain_exactly(errors.full_message(:name, I18n.t('errors.messages.taken')))
end
it 'shows error message for invalid topic title' do
post :create, params: { projects_topic: { name: 'test', title: nil } }
errors = assigns[:topic].errors
expect(errors).to contain_exactly(errors.full_message(:title, I18n.t('errors.messages.blank')))
end
it 'redirects to the topics list' do
post :create, params: { projects_topic: { name: 'test-redirect', title: "Test redirect" } }
expect(response).to redirect_to(admin_topics_path)
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
post :create, params: { projects_topic: { name: 'test' } }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'PUT #update' do
it 'updates topic' do
put :update, params: { id: topic.id, projects_topic: { name: 'test' } }
expect(response).to redirect_to(edit_admin_topic_path(topic))
expect(topic.reload.name).to eq('test')
end
it 'shows error message for invalid topic' do
put :update, params: { id: topic.id, projects_topic: { name: nil } }
errors = assigns[:topic].errors
expect(errors).to contain_exactly(errors.full_message(:name, I18n.t('errors.messages.blank')))
end
it 'shows error message if topic not unique (case insensitive)' do
other_topic = create(:topic, name: 'other-topic', organization: current_organization)
put :update, params: { id: topic.id, projects_topic: { name: other_topic.name.upcase } }
errors = assigns[:topic].errors
expect(errors).to contain_exactly(errors.full_message(:name, I18n.t('errors.messages.taken')))
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
put :update, params: { id: topic.id, projects_topic: { name: 'test' } }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'DELETE #destroy' do
it 'removes topic' do
delete :destroy, params: { id: topic.id }
expect(response).to redirect_to(admin_topics_path)
expect { topic.reload }.to raise_error(ActiveRecord::RecordNotFound)
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
delete :destroy, params: { id: topic.id }
expect(response).to have_gitlab_http_status(:not_found)
expect { topic.reload }.not_to raise_error
end
end
end
describe 'POST #merge' do
let_it_be(:source_topic) { create(:topic, name: 'source_topic', organization: current_organization) }
let_it_be(:project) { create(:project, topic_list: source_topic.name, organization: current_organization) }
let_it_be(:new_organization) { create(:organization, name: 'New Organization') }
let_it_be(:new_organization_topic) { create(:topic, name: 'new_org_topic', organization: new_organization) }
it 'merges source topic into target topic' do
post :merge, params: { source_topic_id: source_topic.id, target_topic_id: topic.id }
expect(response).to redirect_to(admin_topics_path)
expect(topic.projects).to contain_exactly(project)
expect { source_topic.reload }.to raise_error(ActiveRecord::RecordNotFound)
end
it 'renders a 404 error for non-existing id' do
post :merge, params: { source_topic_id: non_existing_record_id, target_topic_id: topic.id }
expect(response).to have_gitlab_http_status(:not_found)
expect { topic.reload }.not_to raise_error
end
it 'renders a 400 error for identical topic ids' do
post :merge, params: { source_topic_id: topic.id, target_topic_id: topic.id }
expect(response).to have_gitlab_http_status(:bad_request)
expect { topic.reload }.not_to raise_error
end
it 'renders a 400 error when trying to merge topics from different organizations' do
post :merge, params: { source_topic_id: source_topic.id, target_topic_id: new_organization_topic.id }
expect(response).to have_gitlab_http_status(:bad_request)
expect { source_topic.reload }.not_to raise_error
expect { new_organization_topic.reload }.not_to raise_error
end
context 'as a normal user' do
before do
sign_in(user)
end
it 'renders a 404 error' do
post :merge, params: { source_topic_id: source_topic.id, target_topic_id: topic.id }
expect(response).to have_gitlab_http_status(:not_found)
expect { source_topic.reload }.not_to raise_error
end
end
end
end
|
