1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe RoutableActions do
controller(::ApplicationController) do
include RoutableActions
before_action :routable
def routable
@klass = params[:type].constantize
@routable = find_routable!(params[:type].constantize, params[:id], '/')
end
def show
head :ok
end
private
def build_canonical_path(routable)
routable.full_path
end
end
def get_routable(routable, id: routable.full_path)
get :show, params: { id: id, type: routable.class }
end
describe '#find_routable!' do
context 'when signed in' do
let(:user) { create(:user) }
before do
sign_in(user)
end
context 'with a project' do
let(:routable) { create(:project) }
context 'when authorized' do
before do
routable.add_guest(user)
end
it 'returns the project' do
get_routable(routable)
expect(assigns[:routable]).to be_a(Project)
end
it 'allows access' do
get_routable(routable)
expect(response).to have_gitlab_http_status(:ok)
end
context 'when old project path is used' do
let(:old_path) { 'old-path/of-the-project' }
before do
create(:redirect_route, source: routable, path: old_path)
end
it 'redirects to the new path' do
get_routable(routable, id: old_path)
expect(response).to have_gitlab_http_status(:redirect)
expect(response).to redirect_to(routable.full_path)
end
context 'when the canonical url generation fails' do
it 'returns 404 page' do
allow(controller).to receive(:build_canonical_path).and_raise(
ActionController::UrlGenerationError, 'error'
)
get_routable(routable, id: old_path)
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
it 'prevents access when not authorized' do
get_routable(routable)
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'with a group' do
let(:routable) { create(:group, :private) }
context 'when authorized' do
before do
routable.add_guest(user)
end
it 'returns the group' do
get_routable(routable)
expect(assigns[:routable]).to be_a(Group)
end
it 'allows access' do
get_routable(routable)
expect(response).to have_gitlab_http_status(:ok)
end
end
it 'prevents access when not authorized' do
get_routable(routable)
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'with a user' do
let(:routable) { user }
it 'allows access when authorized' do
get_routable(routable)
expect(response).to have_gitlab_http_status(:ok)
end
it 'prevents access when unauthorized' do
allow(subject).to receive(:can?).and_return(false)
get_routable(user)
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'when not signed in' do
it 'redirects to sign in for private resouces' do
routable = create(:project, :private)
get_routable(routable)
expect(response).to have_gitlab_http_status(:found)
expect(response.location).to end_with('/users/sign_in')
end
end
end
describe '#perform_not_found_actions' do
let(:routable) { create(:project) }
before do
sign_in(create(:user))
end
it 'performs multiple checks' do
last_check_called = false
checks = [proc {}, proc { last_check_called = true }]
allow(subject).to receive(:not_found_actions).and_return(checks)
get_routable(routable)
expect(last_check_called).to eq(true)
end
it 'performs checks in the context of the controller' do
check = ->(routable, path_info) { redirect_to routable }
allow(subject).to receive(:not_found_actions).and_return([check])
get_routable(routable)
expect(response.location).to end_with(routable.to_param)
end
it 'skips checks once one has resulted in a render/redirect' do
first_check = proc { render plain: 'first' }
second_check = proc { render plain: 'second' }
allow(subject).to receive(:not_found_actions).and_return([first_check, second_check])
get_routable(routable)
expect(response.body).to eq('first')
end
end
end
|
