1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe DashboardController, feature_category: :code_review_workflow do
context 'signed in' do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
before_all do
project.add_maintainer(user)
end
before do
sign_in(user)
end
describe 'GET issues' do
it_behaves_like 'issuables list meta-data', :issue, :issues
it_behaves_like 'issuables requiring filter', :issues
it 'includes tasks in issue list' do
task = create(:work_item, :task, project: project, author: user)
get :issues, params: { author_id: user.id }
expect(assigns[:issues].map(&:id)).to include(task.id)
end
end
describe 'GET merge requests' do
it_behaves_like 'issuables list meta-data', :merge_request, :merge_requests
it_behaves_like 'issuables requiring filter', :merge_requests
context 'when an ActiveRecord::QueryCanceled is raised' do
before do
allow_next_instance_of(Gitlab::IssuableMetadata) do |instance|
allow(instance).to receive(:data).and_raise(ActiveRecord::QueryCanceled)
end
end
it 'sets :search_timeout_occurred' do
get :merge_requests, params: { author_id: user.id }
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:search_timeout_occurred)).to eq(true)
end
context 'rendering views' do
render_views
it 'shows error message' do
get :merge_requests, params: { author_id: user.id }
expect(response.body).to have_content('Too many results to display. Edit your search or add a filter.')
end
it 'does not display MR counts in nav' do
get :merge_requests, params: { author_id: user.id }
expect(response.body).to have_content('Open Merged Closed All')
expect(response.body).not_to have_content('Open 0 Merged 0 Closed 0 All 0')
end
end
it 'logs the exception' do
expect(Gitlab::ErrorTracking).to receive(:track_exception).and_call_original
get :merge_requests, params: { author_id: user.id }
end
end
context 'when an ActiveRecord::QueryCanceled is not raised' do
it 'does not set :search_timeout_occurred' do
get :merge_requests, params: { author_id: user.id }
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:search_timeout_occurred)).to eq(nil)
end
context 'rendering views' do
render_views
it 'displays MR counts in nav' do
get :merge_requests, params: { author_id: user.id }
expect(response.body).to have_content('Open 0 Merged 0 Closed 0 All 0')
expect(response.body).not_to have_content('Open Merged Closed All')
end
end
end
end
describe 'GET merge requests search' do
it_behaves_like 'issuables requiring filter', :search_merge_requests
context 'when an ActiveRecord::QueryCanceled is raised' do
before do
allow_next_instance_of(Gitlab::IssuableMetadata) do |instance|
allow(instance).to receive(:data).and_raise(ActiveRecord::QueryCanceled)
end
end
it 'sets :search_timeout_occurred' do
get :search_merge_requests, params: { author_id: user.id }
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:search_timeout_occurred)).to eq(true)
end
context 'rendering views' do
render_views
it 'shows error message' do
get :search_merge_requests, params: { author_id: user.id }
expect(response.body).to have_content('Too many results to display. Edit your search or add a filter.')
end
it 'does not display MR counts in nav' do
get :search_merge_requests, params: { author_id: user.id }
expect(response.body).to have_content('Open Merged Closed All')
expect(response.body).not_to have_content('Open 0 Merged 0 Closed 0 All 0')
end
end
it 'logs the exception' do
expect(Gitlab::ErrorTracking).to receive(:track_exception).and_call_original
get :search_merge_requests, params: { author_id: user.id }
end
end
context 'when an ActiveRecord::QueryCanceled is not raised' do
it 'does not set :search_timeout_occurred' do
get :search_merge_requests, params: { author_id: user.id }
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:search_timeout_occurred)).to eq(nil)
end
context 'rendering views' do
render_views
it 'displays MR counts in nav' do
get :search_merge_requests, params: { author_id: user.id }
expect(response.body).to have_content('Open 0 Merged 0 Closed 0 All 0')
expect(response.body).not_to have_content('Open Merged Closed All')
end
end
end
end
end
describe "GET activity as JSON" do
include DesignManagementTestHelpers
render_views
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :public, issues_access_level: ProjectFeature::PRIVATE) }
let_it_be(:other_project) { create(:project, :public) }
before do
enable_design_management
create(:event, :created, project: project, target: create(:issue))
create(:wiki_page_event, :created, project: project)
create(:wiki_page_event, :updated, project: project)
create(:design_event, project: project)
create(:design_event, author: user, project: other_project)
sign_in(user)
request.cookies[:event_filter] = 'all'
end
context 'when user has permission to see the event' do
before do
project.add_developer(user)
other_project.add_developer(user)
end
context 'without filter param' do
it 'returns only events of the user' do
get :activity, params: { format: :json }
expect(json_response['count']).to eq(3)
end
end
context 'with "projects" filter' do
it 'returns events of the user\'s projects' do
get :activity, params: { format: :json, filter: :projects }
expect(json_response['count']).to eq(6)
end
end
context 'with "followed" filter' do
let_it_be(:followed_user) { create(:user) }
let_it_be(:followed_user_private_project) { create(:project, :private) }
let_it_be(:followed_user_public_project) { create(:project, :public) }
before do
followed_user_private_project.add_developer(followed_user)
followed_user_public_project.add_developer(followed_user)
user.follow(followed_user)
create(:event, :created, project: followed_user_private_project, target: create(:issue),
author: followed_user)
create(:event, :created, project: followed_user_public_project, target: create(:issue), author: followed_user)
end
it 'returns public events of the user\'s followed users' do
get :activity, params: { format: :json, filter: :followed }
expect(json_response['count']).to eq(1)
end
end
end
context 'when user has no permission to see the event' do
it 'filters out invisible event' do
get :activity, params: { format: :json, filter: :projects }
expect(json_response['html']).to include(_('No activities found'))
end
it 'filters out invisible event when calculating the count' do
get :activity, params: { format: :json, filter: :projects }
expect(json_response['count']).to eq(0)
end
end
end
describe "#check_filters_presence!" do
let(:user) { create(:user) }
before do
sign_in(user)
get :merge_requests, params: params
end
context "no filters" do
let(:params) { {} }
shared_examples_for 'no filters are set' do
it 'sets @no_filters_set to true' do
expect(assigns[:no_filters_set]).to eq(true)
end
end
it_behaves_like 'no filters are set'
context 'when key is present but value is not' do
let(:params) { { author_username: nil } }
it_behaves_like 'no filters are set'
end
context 'when in param is set but no search' do
let(:params) { { in: 'title' } }
it_behaves_like 'no filters are set'
end
end
shared_examples_for 'filters are set' do
it 'sets @no_filters_set to false' do
expect(assigns[:no_filters_set]).to eq(false)
end
end
context "scalar filters" do
let(:params) { { author_id: user.id } }
it_behaves_like 'filters are set'
end
context "array filters" do
let(:params) { { label_name: ['bug'] } }
it_behaves_like 'filters are set'
end
context 'search' do
let(:params) { { search: 'test' } }
it_behaves_like 'filters are set'
end
end
end
|
