1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe GraphqlController, feature_category: :integrations do
include GraphqlHelpers
# two days is enough to make timezones irrelevant
let_it_be(:last_activity_on) { 2.days.ago.to_date }
let(:app_context) { Gitlab::ApplicationContext.current }
describe 'rescue_from' do
let_it_be(:message) { 'green ideas sleep furiously' }
it 'handles ArgumentError' do
allow(subject).to receive(:execute) do
raise Gitlab::Graphql::Errors::ArgumentError, message
end
post :execute
expect(json_response).to include(
'errors' => include(a_hash_including('message' => message))
)
end
it 'handles a timeout nicely' do
allow(subject).to receive(:execute) do
raise ActiveRecord::QueryCanceled, '**taps wristwatch**'
end
post :execute
expect(json_response).to include(
'errors' => include(a_hash_including('message' => /Request timed out/))
)
end
it 'handles StandardError' do
allow(subject).to receive(:execute) do
raise StandardError, message
end
post :execute
expect(json_response).to include(
'errors' => include(
a_hash_including('message' => /Internal server error/, 'raisedAt' => /graphql_controller_spec.rb/)
)
)
end
it 'handles Gitlab::Auth::TooManyIps', :aggregate_failures do
allow(controller).to receive(:execute) do
raise Gitlab::Auth::TooManyIps.new(150, '123.123.123.123', 10)
end
expect(controller).to receive(:log_exception).and_call_original
post :execute
expect(json_response).to include(
'errors' => include(
a_hash_including('message' => 'User 150 from IP: 123.123.123.123 tried logging from too many ips: 10')
)
)
expect(response).to have_gitlab_http_status(:forbidden)
end
it 'handles Gitlab::Git::ResourceExhaustedError', :aggregate_failures do
allow(controller).to receive(:execute) do
raise Gitlab::Git::ResourceExhaustedError.new("Upstream Gitaly has been exhausted. Try again later", 50)
end
post :execute
expect(json_response).to include(
'errors' => include(
a_hash_including('message' => 'Upstream Gitaly has been exhausted. Try again later')
)
)
expect(response).to have_gitlab_http_status(:service_unavailable)
expect(response.headers['Retry-After']).to be(50)
end
end
describe 'POST #execute' do
context 'when user is logged in' do
let(:user) { create(:user, last_activity_on: last_activity_on) }
before do
sign_in(user)
end
it 'sets feature category in ApplicationContext from request' do
request.headers["HTTP_X_GITLAB_FEATURE_CATEGORY"] = "web_ide"
post :execute
expect(::Gitlab::ApplicationContext.current_context_attribute(:feature_category)).to eq('web_ide')
end
it 'returns 200 when user can access API' do
post :execute
expect(response).to have_gitlab_http_status(:ok)
end
it 'executes a simple query with no errors' do
post :execute, params: { query: '{ __typename }' }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq({ 'data' => { '__typename' => 'Query' } })
end
it 'executes a simple multiplexed query with no errors' do
multiplex = [{ query: '{ __typename }' }] * 2
post :execute, params: { _json: multiplex }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
[
{ 'data' => { '__typename' => 'Query' } },
{ 'data' => { '__typename' => 'Query' } }
])
end
it 'executes a multiplexed queries with variables with no errors' do
query = <<~GQL
mutation($a: String!, $b: String!) {
echoCreate(input: { messages: [$a, $b] }) { echoes }
}
GQL
multiplex = [
{ query: query, variables: { a: 'A', b: 'B' } },
{ query: query, variables: { a: 'a', b: 'b' } }
]
post :execute, params: { _json: multiplex }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
[
{ 'data' => { 'echoCreate' => { 'echoes' => %w[A B] } } },
{ 'data' => { 'echoCreate' => { 'echoes' => %w[a b] } } }
])
end
it 'does not allow string as _json parameter (a malformed multiplex query)' do
post :execute, params: { _json: 'bad' }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq({
"errors" => [
{
"message" => "Unexpected end of document",
"locations" => []
}
]
})
end
it 'sets a limit on the total query size' do
graphql_query = "{#{(['__typename'] * 1000).join(' ')}}"
post :execute, params: { query: graphql_query }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response).to eq({ 'errors' => [{ 'message' => 'Query too large' }] })
end
it 'sets a limit on the total query size for multiplex queries' do
graphql_query = "{#{(['__typename'] * 200).join(' ')}}"
multiplex = [{ query: graphql_query }] * 5
post :execute, params: { _json: multiplex }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response).to eq({ 'errors' => [{ 'message' => 'Query too large' }] })
end
it 'returns forbidden when user cannot access API' do
# User cannot access API in a couple of cases
# * When user is internal(like ghost users)
# * When user is blocked
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
expect(Ability).to receive(:allowed?).with(user, :access_api, :global).and_return(false)
post :execute
expect(response).to have_gitlab_http_status(:forbidden)
expect(json_response).to include(
'errors' => include(a_hash_including('message' => /API not accessible/))
)
end
it 'updates the users last_activity_on field' do
expect { post :execute }.to change { user.reload.last_activity_on }
end
it "sets context's sessionless value as false" do
post :execute
expect(assigns(:context)[:is_sessionless_user]).to be false
end
it 'calls the track api when trackable method' do
agent = 'vs-code-gitlab-workflow/3.11.1 VSCode/1.52.1 Node.js/12.14.1 (darwin; x64)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::VSCodeExtensionActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
it 'calls the track jetbrains api when trackable method' do
agent = 'gitlab-jetbrains-plugin/0.0.1 intellij-idea/2021.2.4 java/11.0.13 mac-os-x/aarch64/12.1'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::JetBrainsPluginActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
it 'calls the track jetbrains bundled third party api when trackable method' do
agent = 'IntelliJ-GitLab-Plugin PhpStorm/PS-232.6734.11 (JRE 17.0.7+7-b966.2; Linux 6.2.0-20-generic; amd64)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::JetBrainsBundledPluginActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
it 'calls the track visual studio extension api when trackable method' do
agent = 'code-completions-language-server-experiment (gl-visual-studio-extension:1.0.0.0; arch:X64;)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::VisualStudioExtensionActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
it 'calls the track neovim plugin api when trackable method' do
agent = 'code-completions-language-server-experiment (Neovim:0.9.0; gitlab.vim (v0.1.0); arch:amd64; os:darwin)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::NeovimPluginActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
context 'if using the GitLab CLI' do
it 'call trackable for the old UserAgent' do
agent = 'GLab - GitLab CLI'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::GitLabCliActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
it 'call trackable for the current UserAgent' do
agent = 'glab/v1.25.3-27-g7ec258fb (built 2023-02-16), darwin'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::GitLabCliActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
post :execute
end
end
it "assigns username in ApplicationContext" do
post :execute
expect(Gitlab::ApplicationContext.current).to include('meta.user' => user.username)
end
end
context 'when 2FA is required for the user' do
let(:user) { create(:user, last_activity_on: last_activity_on) }
before do
group = create(:group, require_two_factor_authentication: true)
group.add_developer(user)
sign_in(user)
end
it 'does not redirect if 2FA is enabled' do
expect(controller).not_to receive(:redirect_to)
post :execute
expect(response).to have_gitlab_http_status(:unauthorized)
expected_message = "Authentication error: " \
"enable 2FA in your profile settings to continue using GitLab: %{mfa_help_page}" %
{ mfa_help_page: controller.mfa_help_page_url }
expect(json_response).to eq({ 'errors' => [{ 'message' => expected_message }] })
end
end
context 'when user uses an API token' do
let(:user) { create(:user, last_activity_on: last_activity_on) }
let(:token) { create(:personal_access_token, user: user, scopes: [:api]) }
let(:query) { '{ __typename }' }
subject { post :execute, params: { query: query, access_token: token.token } }
shared_examples 'invalid token' do
it 'returns 401 with invalid token message' do
subject
expect(response).to have_gitlab_http_status(:unauthorized)
expect_graphql_errors_to_include('Invalid token')
end
end
context 'with an expired token' do
let(:token) { create(:personal_access_token, :expired, user: user, scopes: [:api]) }
it_behaves_like 'invalid token'
it 'registers token_expire in application context' do
subject
expect(app_context['meta.auth_fail_reason']).to eq('token_expired')
expect(app_context['meta.auth_fail_token_id']).to eq("PersonalAccessToken/#{token.id}")
end
end
context 'with a revoked token' do
let(:token) { create(:personal_access_token, :revoked, user: user, scopes: [:api]) }
it_behaves_like 'invalid token'
it 'registers token_expire in application context' do
subject
expect(app_context['meta.auth_fail_reason']).to eq('token_revoked')
expect(app_context['meta.auth_fail_token_id']).to eq("PersonalAccessToken/#{token.id}")
end
end
context 'with an invalid token' do
context 'with auth header' do
subject do
request.headers[header] = 'invalid'
post :execute, params: { query: query, user: nil }
end
context 'with private-token' do
let(:header) { 'Private-Token' }
it_behaves_like 'invalid token'
end
context 'with job-token' do
let(:header) { 'Job-Token' }
it_behaves_like 'invalid token'
end
context 'with deploy-token' do
let(:header) { 'Deploy-Token' }
it_behaves_like 'invalid token'
end
end
context 'with authorization bearer (oauth token)' do
subject do
request.headers['Authorization'] = 'Bearer invalid'
post :execute, params: { query: query, user: nil }
end
it_behaves_like 'invalid token'
end
context 'with auth param' do
subject { post :execute, params: { query: query, user: nil }.merge(header) }
context 'with private_token' do
let(:header) { { private_token: 'invalid' } }
it_behaves_like 'invalid token'
end
context 'with job_token' do
let(:header) { { job_token: 'invalid' } }
it_behaves_like 'invalid token'
end
context 'with token' do
let(:header) { { token: 'invalid' } }
it_behaves_like 'invalid token'
end
end
end
context 'when the user is a project bot' do
let(:user) { create(:user, :project_bot, last_activity_on: last_activity_on) }
it 'updates the users last_activity_on field' do
expect { subject }.to change { user.reload.last_activity_on }
end
it "sets context's sessionless value as true" do
subject
expect(assigns(:context)[:is_sessionless_user]).to be true
end
it 'executes a simple query with no errors' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq({ 'data' => { '__typename' => 'Query' } })
end
it 'can access resources the project_bot has access to' do
project_a, project_b = create_list(:project, 2, :private)
project_a.add_developer(user)
post :execute, params: { query: <<~GQL, access_token: token.token }
query {
a: project(fullPath: "#{project_a.full_path}") { name }
b: project(fullPath: "#{project_b.full_path}") { name }
}
GQL
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq({ 'data' => { 'a' => { 'name' => project_a.name }, 'b' => nil } })
end
end
it 'updates the users last_activity_on field' do
expect { subject }.to change { user.reload.last_activity_on }
end
it "sets context's sessionless value as true" do
subject
expect(assigns(:context)[:is_sessionless_user]).to be true
end
it "assigns username in ApplicationContext" do
subject
expect(app_context).to include('meta.user' => user.username)
expect(app_context.keys).not_to include('meta.auth_fail_reason', 'meta.auth_fail_token_id')
end
it 'calls the track api when trackable method' do
agent = 'vs-code-gitlab-workflow/3.11.1 VSCode/1.52.1 Node.js/12.14.1 (darwin; x64)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::VSCodeExtensionActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
subject
end
it 'calls the track jetbrains api when trackable method' do
agent = 'gitlab-jetbrains-plugin/0.0.1 intellij-idea/2021.2.4 java/11.0.13 mac-os-x/aarch64/12.1'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::JetBrainsPluginActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
subject
end
it 'calls the track jetbrains bundled third party api when trackable method' do
agent = 'IntelliJ-GitLab-Plugin PhpStorm/PS-232.6734.11 (JRE 17.0.7+7-b966.2; Linux 6.2.0-20-generic; amd64)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::JetBrainsBundledPluginActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
subject
end
it 'calls the track visual studio extension api when trackable method' do
agent = 'code-completions-language-server-experiment (gl-visual-studio-extension:1.0.0.0; arch:X64;)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::VisualStudioExtensionActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
subject
end
it 'calls the track neovim plugin api when trackable method' do
agent = 'code-completions-language-server-experiment (Neovim:0.9.0; gitlab.vim (v0.1.0); arch:amd64; os:darwin)'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::NeovimPluginActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
subject
end
it 'calls the track gitlab cli when trackable method' do
agent = 'GLab - GitLab CLI'
request.env['HTTP_USER_AGENT'] = agent
expect(Gitlab::UsageDataCounters::GitLabCliActivityUniqueCounter)
.to receive(:track_api_request_when_trackable).with(user_agent: agent, user: user)
subject
end
end
context 'when user is not logged in' do
it 'returns 200' do
post :execute
expect(response).to have_gitlab_http_status(:ok)
end
it "sets context's sessionless value as false" do
post :execute
expect(assigns(:context)[:is_sessionless_user]).to be false
end
it "does not assign a username in ApplicationContext" do
subject
expect(app_context.key?('meta.user')).to be false
expect(app_context.keys).not_to include('meta.auth_fail_reason', 'meta.auth_fail_token_id')
end
end
it 'includes request object in context' do
post :execute
expect(assigns(:context)[:request]).to eq request
end
it 'sets `context[:remove_deprecated]` to false by default' do
post :execute
expect(assigns(:context)[:remove_deprecated]).to be false
end
it 'sets `context[:remove_deprecated]` to true when `remove_deprecated` param is truthy' do
post :execute, params: { remove_deprecated: '1' }
expect(assigns(:context)[:remove_deprecated]).to be true
end
context 'when querying an IntrospectionQuery', :use_clean_rails_memory_store_caching do
let_it_be(:query) { CachedIntrospectionQuery.query_string }
context 'in dev or test env' do
before do
allow(Gitlab).to receive(:dev_or_test_env?).and_return(true)
end
it 'does not cache IntrospectionQuery' do
expect(GitlabSchema).to receive(:execute).exactly(:twice)
post :execute, params: { query: query }
post :execute, params: { query: query }
end
end
context 'in env different from dev or test' do
before do
allow(Gitlab).to receive(:dev_or_test_env?).and_return(false)
end
it 'caches IntrospectionQuery even when operationName is not given' do
expect(GitlabSchema).to receive(:execute).exactly(:once)
post :execute, params: { query: query }
post :execute, params: { query: query }
end
it 'caches the IntrospectionQuery' do
expect(GitlabSchema).to receive(:execute).exactly(:once)
post :execute, params: { query: query, operationName: 'IntrospectionQuery' }
post :execute, params: { query: query, operationName: 'IntrospectionQuery' }
end
it 'caches separately for both remove_deprecated set to true and false' do
expect(GitlabSchema).to receive(:execute).exactly(:twice)
post :execute, params: { query: query, operationName: 'IntrospectionQuery', remove_deprecated: true }
post :execute, params: { query: query, operationName: 'IntrospectionQuery', remove_deprecated: true }
# We clear this instance variable to reset remove_deprecated
subject.remove_instance_variable(:@context) if subject.instance_variable_defined?(:@context)
post :execute, params: { query: query, operationName: 'IntrospectionQuery', remove_deprecated: false }
post :execute, params: { query: query, operationName: 'IntrospectionQuery', remove_deprecated: false }
end
it 'has a different cache for each Gitlab.revision' do
expect(GitlabSchema).to receive(:execute).exactly(:twice)
post :execute, params: { query: query, operationName: 'IntrospectionQuery' }
allow(Gitlab).to receive(:revision).and_return('new random value')
post :execute, params: { query: query, operationName: 'IntrospectionQuery' }
end
context 'when there is an unknown introspection query' do
let(:query) { File.read(Rails.root.join('spec/fixtures/api/graphql/fake_introspection.graphql')) }
it 'does not cache an unknown introspection query' do
expect(GitlabSchema).to receive(:execute).exactly(:twice)
post :execute, params: { query: query, operationName: 'IntrospectionQuery' }
post :execute, params: { query: query, operationName: 'IntrospectionQuery' }
end
end
it 'hits the cache even if the whitespace in the query differs' do
query_1 = CachedIntrospectionQuery.query_string
query_2 = "#{query_1} " # add a couple of spaces to change the fingerprint
expect(GitlabSchema).to receive(:execute).exactly(:once)
post :execute, params: { query: query_1, operationName: 'IntrospectionQuery' }
post :execute, params: { query: query_2, operationName: 'IntrospectionQuery' }
end
end
context 'when performing a multiplex query as an IntrospectionQuery' do
let(:user) { create(:user) }
let_it_be(:query) do
<<~GQL
mutation IntrospectionQuery{createSnippet(input:{title:"test" description:"test" visibilityLevel:public blobActions:[{action:create previousPath:"test" filePath:"test" content:"test new file"}]}){errors clientMutationId snippet{webUrl}}}
GQL
end
before do
sign_in(user)
end
it 'does not perform a mutation' do
expect do
get :execute,
params: { query: query, operationName: 'IntrospectionQuery', _json: ["[query]=query {__typename}"] }
end.not_to change {
Snippet.count
}
end
it 'does not call GitlabSchema.execute' do
expect(GitlabSchema).not_to receive(:execute)
expect(GitlabSchema).to receive(:multiplex)
get :execute,
params: { query: query, operationName: 'IntrospectionQuery', _json: ["[query]=query {__typename}"] }
end
end
end
context 'when X_GITLAB_DISABLE_SQL_QUERY_LIMIT is set' do
let(:issue_url) { "http://some/issue/url" }
let(:limit) { 205 }
context 'and it specifies a new query limit' do
let(:header_value) { "#{limit},#{issue_url}" }
it 'respects the new query limit' do
expect(Gitlab::QueryLimiting).to receive(:disable!).with(issue_url, new_threshold: limit)
request.env['HTTP_X_GITLAB_DISABLE_SQL_QUERY_LIMIT'] = header_value
post :execute
end
end
context 'and it does not specify a new limit' do
let(:header_value) { issue_url }
it 'disables limit' do
expect(Gitlab::QueryLimiting).to receive(:disable!).with(issue_url)
request.env['HTTP_X_GITLAB_DISABLE_SQL_QUERY_LIMIT'] = header_value
post :execute
end
end
end
end
describe 'Admin Mode' do
let_it_be(:admin) { create(:admin) }
let_it_be(:project) { create(:project) }
let(:graphql_query) { graphql_query_for('project', { 'fullPath' => project.full_path }, %w[id name]) }
before do
sign_in(admin)
end
context 'when admin mode enabled' do
before do
Gitlab::Session.with_session(controller.session) do
controller.current_user_mode.request_admin_mode!
controller.current_user_mode.enable_admin_mode!(password: admin.password)
end
end
it 'can query project data' do
post :execute, params: { query: graphql_query }
expect(controller.current_user_mode.admin_mode?).to be(true)
expect(json_response['data']['project']['name']).to eq(project.name)
end
end
context 'when admin mode disabled' do
it 'cannot query project data' do
post :execute, params: { query: graphql_query }
expect(controller.current_user_mode.admin_mode?).to be(false)
expect(json_response['data']['project']).to be_nil
end
context 'when admin is member of the project' do
before do
project.add_developer(admin)
end
it 'can query project data' do
post :execute, params: { query: graphql_query }
expect(controller.current_user_mode.admin_mode?).to be(false)
expect(json_response['data']['project']['name']).to eq(project.name)
end
end
end
end
describe '#append_info_to_payload' do
let(:query_1) { { query: graphql_query_for('project', { 'fullPath' => 'foo' }, %w[id name], 'getProject_1') } }
let(:query_2) { { query: graphql_query_for('project', { 'fullPath' => 'bar' }, %w[id], 'getProject_2') } }
let(:graphql_queries) { [query_1, query_2] }
let(:log_payload) { {} }
let(:expected_logs) do
[
{
operation_name: 'getProject_1',
complexity: 3,
depth: 2,
used_deprecated_arguments: [],
used_deprecated_fields: [],
used_fields: ['Project.id', 'Project.name', 'Query.project'],
variables: '{}'
},
{
operation_name: 'getProject_2',
complexity: 2,
depth: 2,
used_deprecated_arguments: [],
used_deprecated_fields: [],
used_fields: ['Project.id', 'Query.project'],
variables: '{}'
}
]
end
before do
RequestStore.clear!
allow(controller).to receive(:append_info_to_payload).and_wrap_original do |method, *|
method.call(log_payload)
end
end
it 'appends metadata for logging' do
post :execute, params: { _json: graphql_queries }
expect(controller).to have_received(:append_info_to_payload)
expect(log_payload.dig(:metadata, :graphql)).to match_array(expected_logs)
end
it 'appends the exception in case of errors' do
exception = StandardError.new('boom')
expect(controller).to receive(:execute).and_raise(exception)
post :execute, params: { _json: graphql_queries }
expect(controller).to have_received(:append_info_to_payload)
expect(log_payload[:exception_object]).to eq(exception)
end
end
end
|