1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Groups::RunnersController, feature_category: :fleet_visibility do
let_it_be(:user) { create(:user) }
let_it_be(:namespace_settings) do
create(:namespace_settings, runner_registration_enabled: true, allow_runner_registration_token: true)
end
let_it_be(:group) { create(:group, namespace_settings: namespace_settings) }
let_it_be(:project) { create(:project, group: group) }
let_it_be(:runner) { create(:ci_runner, :group, groups: [group]) }
let!(:project_runner) { create(:ci_runner, :project, projects: [project]) }
let!(:instance_runner) { create(:ci_runner, :instance) }
let(:runner_registration_enabled) { true }
before do
namespace_settings.update!(runner_registration_enabled: runner_registration_enabled)
sign_in(user)
end
describe '#index', :snowplow do
let(:allow_runner_registration_token) { false }
subject(:execute_get_request) { get :index, params: { group_id: group } }
before do
stub_application_setting(allow_runner_registration_token: allow_runner_registration_token)
end
shared_examples 'can access the page' do
it 'renders index with 200 status code' do
execute_get_request
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:index)
end
it 'tracks the event' do
execute_get_request
expect_snowplow_event(category: described_class.name, action: 'index', user: user, namespace: group)
end
end
shared_examples 'cannot access the page' do
it 'renders 404' do
execute_get_request
expect(response).to have_gitlab_http_status(:not_found)
end
it 'does not track the event' do
execute_get_request
expect_no_snowplow_event
end
end
context 'when the user is a maintainer' do
before_all do
group.add_maintainer(user)
end
include_examples 'can access the page'
context 'when runner registration is allowed' do
let(:allow_runner_registration_token) { true }
it 'does not expose runner creation and registration variables' do
execute_get_request
expect(assigns(:group_runner_registration_token)).to be_nil
expect(assigns(:group_new_runner_path)).to be_nil
end
end
end
context 'when the user is an owner' do
before_all do
group.add_owner(user)
end
include_examples 'can access the page'
it 'does not expose runner registration variables' do
execute_get_request
expect(assigns(:group_runner_registration_token)).to be_nil
end
context 'when runner registration is allowed' do
let(:allow_runner_registration_token) { true }
it 'exposes runner creation and registration variables' do
execute_get_request
expect(assigns(:group_runner_registration_token)).not_to be_nil
expect(assigns(:group_new_runner_path)).to eq(new_group_runner_path(group))
end
context 'when runner registration is disabled' do
let(:runner_registration_enabled) { false }
it 'does not expose runner creation and registration variables' do
execute_get_request
expect(assigns(:group_runner_registration_token)).to be_nil
expect(assigns(:group_new_runner_path)).to be_nil
end
end
end
end
context 'when user is not maintainer' do
before_all do
group.add_developer(user)
end
include_examples 'cannot access the page'
end
end
describe '#new' do
context 'when user is owner' do
before_all do
group.add_owner(user)
end
it 'renders new with 200 status code' do
get :new, params: { group_id: group }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:new)
end
end
context 'when user is not owner' do
before_all do
group.add_maintainer(user)
end
it 'renders a 404' do
get :new, params: { group_id: group }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe '#register' do
subject(:register) { get :register, params: { group_id: group, id: new_runner } }
context 'when user is owner' do
before_all do
group.add_owner(user)
end
context 'when runner can be registered after creation' do
let_it_be(:new_runner) { create(:ci_runner, :group, groups: [group], registration_type: :authenticated_user) }
it 'renders a :register template' do
register
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:register)
end
end
context 'when runner cannot be registered after creation' do
let_it_be(:new_runner) { runner }
it 'returns :not_found' do
register
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'when user is not owner' do
before_all do
group.add_maintainer(user)
end
context 'when runner can be registered after creation' do
let_it_be(:new_runner) { create(:ci_runner, :group, groups: [group], registration_type: :authenticated_user) }
it 'returns :not_found' do
register
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
describe '#show' do
context 'when user is maintainer' do
before_all do
group.add_maintainer(user)
end
it 'renders show with 200 status code' do
get :show, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:show)
end
it 'renders show with 200 status code instance runner' do
get :show, params: { group_id: group, id: instance_runner }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:show)
end
it 'renders show with 200 status code project runner' do
get :show, params: { group_id: group, id: project_runner }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:show)
end
end
context 'when user is not maintainer' do
before_all do
group.add_developer(user)
end
it 'renders a 404' do
get :show, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders a 404 instance runner' do
get :show, params: { group_id: group, id: instance_runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders a 404 project runner' do
get :show, params: { group_id: group, id: project_runner }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe '#edit' do
context 'when user is owner' do
before_all do
group.add_owner(user)
end
it 'renders 200 for group runner' do
get :edit, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:edit)
end
it 'renders 404 for non-existing runner' do
get :edit, params: { group_id: group, id: non_existing_record_id }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 404 for instance runner' do
get :edit, params: { group_id: group, id: instance_runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 200 for project runner' do
get :edit, params: { group_id: group, id: project_runner }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:edit)
end
end
context 'when user is maintainer' do
before_all do
group.add_maintainer(user)
end
it 'renders 404 for group runner' do
get :edit, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 404 for instance runner' do
get :edit, params: { group_id: group, id: instance_runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 200 for project runner' do
get :edit, params: { group_id: group, id: project_runner }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:edit)
end
end
context 'when user is not maintainer' do
before_all do
group.add_developer(user)
end
it 'renders 404 for group runner' do
get :edit, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 404 for instance runner' do
get :edit, params: { group_id: group, id: instance_runner }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'renders 404 for project runner' do
get :edit, params: { group_id: group, id: project_runner }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe '#update' do
let!(:group_runner) { create(:ci_runner, :group, groups: [group]) }
shared_examples 'updates the runner' do
it 'updates the runner, ticks the queue, and redirects' do
new_desc = runner.description.swapcase
expect do
post :update, params: { group_id: group, id: runner, runner: { description: new_desc } }
runner.reload
end.to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(:found)
expect(runner.reload.description).to eq(new_desc)
end
end
shared_examples 'rejects the update' do
it 'does not update the runner' do
new_desc = runner.description.swapcase
expect do
post :update, params: { group_id: group, id: runner, runner: { description: new_desc } }
runner.reload
end.to not_change { runner.ensure_runner_queue_value }
.and not_change { runner.description }
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when user is owner' do
before_all do
group.add_owner(user)
end
context 'with group runner' do
let(:runner) { group_runner }
it_behaves_like 'updates the runner'
end
context 'with instance runner' do
let(:runner) { instance_runner }
it_behaves_like 'rejects the update'
end
context 'with project runner' do
let(:runner) { project_runner }
it_behaves_like 'updates the runner'
end
end
context 'when user is maintainer' do
before_all do
group.add_maintainer(user)
end
context 'with group runner' do
let(:runner) { group_runner }
it_behaves_like 'rejects the update'
end
context 'with instance runner' do
let(:runner) { instance_runner }
it_behaves_like 'rejects the update'
end
context 'with project runner' do
let(:runner) { project_runner }
it_behaves_like 'updates the runner'
end
end
context 'when user is not maintainer' do
before_all do
group.add_developer(user)
end
context 'with group runner' do
let(:runner) { group_runner }
it_behaves_like 'rejects the update'
end
context 'with instance runner' do
let(:runner) { instance_runner }
it_behaves_like 'rejects the update'
end
context 'with project runner' do
let(:runner) { project_runner }
it_behaves_like 'rejects the update'
end
end
end
end
|
