1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Groups::Settings::CiCdController, feature_category: :continuous_integration do
include ExternalAuthorizationServiceHelpers
let_it_be(:group) { create(:group) }
let_it_be(:user) { create(:user) }
before do
sign_in(user)
end
describe 'GET #show' do
context 'when user is owner' do
before do
group.add_owner(user)
end
it 'renders show with 200 status code' do
get :show, params: { group_id: group }
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:show)
end
end
context 'when user is not owner' do
before do
group.add_maintainer(user)
end
it 'renders a 404' do
get :show, params: { group_id: group }
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'external authorization' do
before do
enable_external_authorization_service_check
group.add_owner(user)
end
it 'renders show with 200 status code' do
get :show, params: { group_id: group }
expect(response).to have_gitlab_http_status(:ok)
end
end
end
describe 'PATCH #update_auto_devops' do
let(:auto_devops_param) { '1' }
subject do
patch :update_auto_devops, params: {
group_id: group,
group: { auto_devops_enabled: auto_devops_param }
}
end
context 'when user does not have enough permission' do
before do
group.add_maintainer(user)
end
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when user has enough privileges' do
before do
group.add_owner(user)
end
it { is_expected.to redirect_to(group_settings_ci_cd_path) }
context 'when service execution went wrong' do
before do
allow_any_instance_of(Groups::AutoDevopsService).to receive(:execute).and_return(false)
allow_any_instance_of(Group).to receive_message_chain(:errors, :full_messages)
.and_return(['Error 1'])
subject
end
it 'returns a flash alert' do
expect(controller).to set_flash[:alert]
.to eq("There was a problem updating Auto DevOps pipeline: [\"Error 1\"].")
end
end
context 'when service execution was successful' do
it 'returns a flash notice' do
subject
expect(controller).to set_flash[:notice]
.to eq('Auto DevOps pipeline was updated for the group')
end
end
context 'when changing auto devops value' do
before do
subject
group.reload
end
context 'when explicitly enabling auto devops' do
it 'updates group attribute' do
expect(group.auto_devops_enabled).to eq(true)
end
end
context 'when explicitly disabling auto devops' do
let(:auto_devops_param) { '0' }
it 'updates group attribute' do
expect(group.auto_devops_enabled).to eq(false)
end
end
end
end
end
describe 'PATCH #update' do
subject(:response) { perform_request }
def perform_request
patch :update, params: params
end
context 'when user is a group owner' do
before_all do
group.add_owner(user)
end
context 'when updating max_artifacts_size' do
let(:params) { { group_id: group, group: { max_artifacts_size: 10 } } }
it 'cannot update max_artifacts_size' do
expect { perform_request }.not_to change { group.reload.max_artifacts_size }
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when updating allow_runner_registration_token' do
let(:params) { { group_id: group, group: { allow_runner_registration_token: false } } }
it 'can update allow_runner_registration_token' do
expect { perform_request }.to change { group.reload.allow_runner_registration_token? }.from(true).to(false)
end
context 'when user is not a group owner' do
before_all do
group.add_maintainer(user)
end
it 'cannot update allow_runner_registration_token?' do
expect { perform_request }.not_to change { group.reload.allow_runner_registration_token? }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
context 'when user is a group maintainer' do
let_it_be(:user) { create(:user).tap { |user| group.add_maintainer(user) } }
context 'when updating allow_runner_registration_token' do
let(:params) { { group_id: group, group: { allow_runner_registration_token: false } } }
it 'cannot update allow_runner_registration_token?' do
expect { perform_request }.not_to change { group.reload.allow_runner_registration_token? }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'when user is an admin' do
let_it_be(:user) { create(:admin).tap { |user| group.add_owner(user) } }
context 'when admin mode is disabled' do
context 'when updating max_artifacts_size' do
let(:params) { { group_id: group, group: { max_artifacts_size: 10 } } }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when updating allow_runner_registration_token' do
let(:params) { { group_id: group, group: { allow_runner_registration_token: false } } }
it 'can update allow_runner_registration_token' do
expect { perform_request }.to change { group.reload.allow_runner_registration_token? }.from(true).to(false)
end
end
end
context 'when admin mode is enabled', :enable_admin_mode do
let(:params) { { group_id: group, group: { max_artifacts_size: 10 } } }
it { is_expected.to redirect_to(group_settings_ci_cd_path) }
context 'when service execution went wrong' do
let(:update_service) { double }
before do
allow(Groups::UpdateService).to receive(:new).and_return(update_service)
allow(update_service).to receive(:execute).and_return(false)
allow_any_instance_of(Group).to receive_message_chain(:errors, :full_messages)
.and_return(['Error 1'])
response
end
it 'returns a flash alert' do
expect(controller).to set_flash[:alert]
.to eq("There was a problem updating the group CI/CD settings: [\"Error 1\"].")
end
end
context 'when service execution was successful' do
it 'returns a flash notice' do
response
expect(controller).to set_flash[:notice]
.to eq('Group CI/CD settings were successfully updated.')
end
end
end
end
end
end
|
