1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::CommitsController, feature_category: :source_code_management do
let_it_be(:project) { create(:project, :repository) }
let_it_be(:repository) { project.repository }
let_it_be(:user) { create(:user) }
before do
project.add_maintainer(user)
end
context 'signed in' do
before do
sign_in(user)
end
describe "GET commits_root" do
context "no ref is provided" do
it 'redirects to the default branch of the project' do
get :commits_root, params: { namespace_id: project.namespace, project_id: project }
expect(response).to redirect_to project_commits_path(project)
end
end
end
describe "GET show" do
let(:params) { { namespace_id: project.namespace, project_id: project, id: id, ref_type: ref_type } }
let(:ref_type) { nil }
let(:request) do
get(:show, params: params)
end
render_views
context 'with file path' do
include_context 'with ambiguous refs for controllers'
before do
request
end
context 'when the ref is ambiguous' do
let(:ref) { 'ambiguous_ref' }
let(:ref_type) { 'tags' }
let(:path) { 'README.md' }
let(:id) { "#{ref}/#{path}" }
it_behaves_like '#set_is_ambiguous_ref when ref is ambiguous'
end
describe '#set_is_ambiguous_ref with no ambiguous ref' do
let(:id) { 'master/README.md' }
it_behaves_like '#set_is_ambiguous_ref when ref is not ambiguous'
end
context "valid branch, valid file" do
let(:id) { 'master/README.md' }
it { is_expected.to respond_with(:success) }
end
context "HEAD, valid file" do
let(:id) { 'HEAD/README.md' }
it { is_expected.to respond_with(:success) }
end
context "valid branch, invalid file" do
let(:id) { 'master/invalid-path.rb' }
it { is_expected.to redirect_to project_tree_path(project, 'master', '/') }
end
context "invalid branch, valid file" do
let(:id) { 'invalid-branch/README.md' }
it { is_expected.to respond_with(:not_found) }
end
context "branch with invalid format, valid file" do
let(:id) { 'branch with space/README.md' }
it { is_expected.to respond_with(:not_found) }
end
end
context "with an invalid limit" do
let(:id) { "master/README.md" }
it "uses the default limit" do
expect_any_instance_of(Repository).to receive(:commits).with(
"master",
path: "README.md",
limit: described_class::COMMITS_DEFAULT_LIMIT,
offset: 0
).and_call_original
get :show, params: { namespace_id: project.namespace, project_id: project, id: id, limit: "foo" }
expect(response).to be_successful
end
context 'when limit is a hash' do
it 'uses the default limit' do
expect_any_instance_of(Repository).to receive(:commits).with(
"master",
path: "README.md",
limit: described_class::COMMITS_DEFAULT_LIMIT,
offset: 0
).and_call_original
get :show, params: {
namespace_id: project.namespace,
project_id: project,
id: id,
limit: { 'broken' => 'value' }
}
expect(response).to be_successful
end
end
end
context 'date range' do
let(:id) { "master/README.md" }
let(:base_repository_params) do
{
path: "README.md",
limit: described_class::COMMITS_DEFAULT_LIMIT,
offset: 0
}
end
let(:base_request_params) do
{
namespace_id: project.namespace,
project_id: project,
id: id
}
end
shared_examples 'repository commits call' do
it 'passes the correct params' do
expect_any_instance_of(Repository).to receive(:commits).with(
"master",
repository_params
).and_call_original
get :show, params: request_params
expect(response).to be_successful
end
end
context 'when committed_before param' do
context 'is valid' do
let(:request_params) { base_request_params.merge(committed_before: '2020-01-01') }
let(:repository_params) { base_repository_params.merge(before: 1577836800) }
it_behaves_like 'repository commits call'
end
context 'is invalid' do
let(:request_params) { base_request_params.merge(committed_before: 'xxx') }
let(:repository_params) { base_repository_params }
it_behaves_like 'repository commits call'
end
context 'is not provided' do
let(:request_params) { base_request_params }
let(:repository_params) { base_repository_params }
it_behaves_like 'repository commits call'
end
end
context 'with committed_after param' do
context 'is valid' do
let(:request_params) { base_request_params.merge(committed_after: '2020-01-01') }
let(:repository_params) { base_repository_params.merge(after: 1577836800) }
it_behaves_like 'repository commits call'
end
context 'is invalid' do
let(:request_params) { base_request_params.merge(committed_after: 'xxx') }
let(:repository_params) { base_repository_params }
it_behaves_like 'repository commits call'
end
end
end
describe 'loading tags' do
it 'loads tags for commits' do
expect_next_instance_of(CommitCollection) do |collection|
expect(collection).to receive(:load_tags)
end
get :show, params: { namespace_id: project.namespace, project_id: project, id: 'master/README.md' }
expect(response).to have_gitlab_http_status(:ok)
end
end
context 'when tag has a non-ASCII encoding' do
before do
repository.add_tag(user, 'tést', 'master')
end
it 'does not raise an exception' do
get :show, params: { namespace_id: project.namespace, project_id: project, id: 'master' }
expect(response).to have_gitlab_http_status(:ok)
end
end
context "when the ref name ends in .atom" do
context "when the ref does not exist with the suffix" do
before do
get :show, params: { namespace_id: project.namespace, project_id: project, id: "master.atom" }
end
it "renders as atom" do
expect(response).to be_successful
expect(response.media_type).to eq('application/atom+xml')
end
it 'renders summary with type=html' do
expect(response.body).to include('<summary type="html">')
end
end
context "when the ref exists with the suffix" do
before do
commit = project.repository.commit('master')
allow_any_instance_of(Repository).to receive(:commit).and_call_original
allow_any_instance_of(Repository).to receive(:commit).with('master.atom').and_return(commit)
get :show, params: {
namespace_id: project.namespace,
project_id: project,
id: "master.atom"
}
end
it "renders as HTML" do
expect(response).to be_successful
expect(response.media_type).to eq('text/html')
end
end
context 'when the ref does not exist' do
before do
get(:show, params: {
namespace_id: project.namespace,
project_id: project,
id: 'unknown.atom'
})
end
it 'returns 404 page' do
expect(response).to be_not_found
end
end
end
context 'with markdown cache' do
it 'preloads markdown cache for commits' do
expect(Commit).to receive(:preload_markdown_cache!).and_call_original
get :show, params: { namespace_id: project.namespace, project_id: project, id: 'master/README.md' }
end
end
end
describe "GET /commits/:id/signatures" do
render_views
let(:send_request) do
get :signatures, params: {
namespace_id: project.namespace,
project_id: project,
id: id
}, format: :json
end
before do
expect(::Gitlab::GitalyClient).to receive(:allow_ref_name_caching).and_call_original unless id.include?(' ')
end
context "valid branch" do
let(:id) { 'master' }
it 'returns a successful response' do
send_request
is_expected.to respond_with(:success)
end
end
context "invalid branch format" do
let(:id) { 'some branch' }
it 'returns a not found response' do
send_request
is_expected.to respond_with(:not_found)
end
end
context 'with signature message' do
let(:id) { 'master' }
let(:commit) { repository.commit('5937ac0a7beb003549fc5fd26fc247adbce4a52e') }
let(:signature) { json_response['signatures'].find { |s| s['commit_sha'] == commit.id } }
it 'returns a signature message' do
send_request
expect(signature).to be_present
expect(signature['html']).to include('GPG Key ID')
expect(signature['html']).to include('This commit was signed with an unverified signature')
end
context 'when commit has an unsupported signature type' do
before do
allow(Gitlab::Gpg::Commit).to receive(:new).and_call_original
expect_next_instance_of(Gitlab::Gpg::Commit, commit) do |gpg_commit|
expect(gpg_commit).to receive(:signature).and_return(nil)
end
end
it 'returns a unsupported signature message' do
send_request
expect(signature).to be_present
expect(signature['html']).to include('Unsupported signature')
end
end
end
end
end
end
|