1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::EnvironmentsController, feature_category: :continuous_delivery do
include KubernetesHelpers
let_it_be(:project) { create(:project, :repository) }
let_it_be(:maintainer) { create(:user, name: 'main-dos', maintainer_of: project) }
let_it_be(:reporter) { create(:user, name: 'repo-dos', reporter_of: project) }
let(:user) { maintainer }
let!(:environment) { create(:environment, name: 'production', project: project) }
before do
sign_in(user)
end
describe 'GET index' do
context 'when a request for the HTML is made' do
it 'responds with status code 200' do
get :index, params: environment_params
expect(response).to have_gitlab_http_status(:ok)
end
it 'expires etag cache to force reload environments list' do
expect_any_instance_of(Gitlab::EtagCaching::Store)
.to receive(:touch).with(project_environments_path(project, format: :json))
get :index, params: environment_params
end
it_behaves_like 'tracking unique visits', :index do
let(:request_params) { environment_params }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
context 'when requesting JSON response for folders' do
before do
allow_any_instance_of(Environment).to receive(:has_terminals?).and_return(true)
allow_any_instance_of(Environment).to receive(:rollout_status).and_return(kube_deployment_rollout_status)
create(:environment, project: project, name: 'staging/review-1', state: :available)
create(:environment, project: project, name: 'staging/review-2', state: :available)
create(:environment, project: project, name: 'staging/review-3', state: :stopped)
end
let(:environments) { json_response['environments'] }
context 'with default parameters' do
subject { get :index, params: environment_params(format: :json) }
it 'responds with a flat payload describing available environments' do
subject
expect(environments.count).to eq 3
expect(environments.first).to include('name' => 'production', 'name_without_type' => 'production')
expect(environments.second).to include('name' => 'staging/review-1', 'name_without_type' => 'review-1')
expect(environments.third).to include('name' => 'staging/review-2', 'name_without_type' => 'review-2')
expect(json_response['available_count']).to eq 3
expect(json_response['stopped_count']).to eq 1
end
it 'handles search option properly' do
get :index, params: environment_params(format: :json, search: 'staging/r')
expect(environments.map { |env| env['name'] }).to contain_exactly('staging/review-1', 'staging/review-2')
expect(json_response['available_count']).to eq 2
expect(json_response['stopped_count']).to eq 1
end
it 'ignores search option if is shorter than a minimum' do
get :index, params: environment_params(format: :json, search: 'st')
expect(environments.map { |env| env['name'] }).to contain_exactly('production', 'staging/review-1', 'staging/review-2')
expect(json_response['available_count']).to eq 3
expect(json_response['stopped_count']).to eq 1
end
it 'supports search within environment folder name' do
create(:environment, project: project, name: 'review-app', state: :available)
get :index, params: environment_params(format: :json, search: 'review')
expect(environments.map { |env| env['name'] }).to contain_exactly('review-app', 'staging/review-1', 'staging/review-2')
expect(json_response['available_count']).to eq 3
expect(json_response['stopped_count']).to eq 1
end
context 'can access stop stale environments feature' do
it 'maintainers can access the feature' do
get :index, params: environment_params(format: :json)
expect(json_response['can_stop_stale_environments']).to be_truthy
end
context 'when user is a reporter' do
let(:user) { reporter }
it 'reporters cannot access the feature' do
get :index, params: environment_params(format: :json)
expect(json_response['can_stop_stale_environments']).to be_falsey
end
end
end
it 'sets the polling interval header' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Poll-Interval']).to eq("3000")
end
context 'validates latest deployment' do
let_it_be(:test_environment) do
create(:environment, project: project, name: 'staging/review-4', state: :available)
end
before do
create_list(:deployment, 2, :success, environment: test_environment, project: project)
end
it 'responds with the latest deployment for the environment' do
subject
environment = environments.find { |env| env['id'] == test_environment.id }
expect(environment['last_deployment']['id']).to eq(test_environment.deployments.last.id)
end
end
end
context 'when a folder-based nested structure is requested' do
before do
get :index, params: environment_params(format: :json, nested: true)
end
it 'responds with a payload containing the latest environment for each folder' do
expect(environments.count).to eq 2
expect(environments.first['name']).to eq 'production'
expect(environments.second['name']).to eq 'staging'
expect(environments.second['size']).to eq 2
expect(environments.second['latest']['name']).to eq 'staging/review-2'
end
end
context 'when requesting available environments scope' do
before do
get :index, params: environment_params(format: :json, nested: true, scope: :available)
end
it 'responds with a payload describing available environments' do
expect(environments.count).to eq 2
expect(environments.first['name']).to eq 'production'
expect(environments.first['latest']['rollout_status']).to be_present
expect(environments.second['name']).to eq 'staging'
expect(environments.second['size']).to eq 2
expect(environments.second['latest']['name']).to eq 'staging/review-2'
expect(environments.second['latest']['rollout_status']).to be_present
end
it 'contains values describing environment scopes sizes' do
expect(json_response['available_count']).to eq 3
expect(json_response['stopped_count']).to eq 1
end
end
context 'when requesting stopped environments scope' do
before do
get :index, params: environment_params(format: :json, nested: true, scope: :stopped)
end
it 'responds with a payload describing stopped environments' do
expect(environments.count).to eq 1
expect(environments.first['name']).to eq 'staging'
expect(environments.first['size']).to eq 1
expect(environments.first['latest']['name']).to eq 'staging/review-3'
end
it 'contains values describing environment scopes sizes' do
expect(json_response['available_count']).to eq 3
expect(json_response['stopped_count']).to eq 1
end
end
end
end
describe 'GET folder' do
context 'when using default format' do
it 'responds with HTML' do
get :folder, params: {
namespace_id: project.namespace,
project_id: project,
id: 'staging-1.0'
}
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template 'folder'
end
it_behaves_like 'tracking unique visits', :folder do
let(:request_params) do
{
namespace_id: project.namespace,
project_id: project,
id: 'staging-1.0'
}
end
let(:target_id) { 'users_visiting_environments_pages' }
end
end
context 'when using JSON format' do
before do
create(:environment, project: project, name: 'staging-1.0/review', state: :available)
create(:environment, project: project, name: 'staging-1.0/zzz', state: :available)
end
let(:environments) { json_response['environments'] }
it 'sorts the subfolders lexicographically' do
get :folder, params: {
namespace_id: project.namespace,
project_id: project,
id: 'staging-1.0'
}, format: :json
expect(response).to be_ok
expect(response).not_to render_template 'folder'
expect(json_response['environments'][0])
.to include('name' => 'staging-1.0/review', 'name_without_type' => 'review')
expect(json_response['environments'][1])
.to include('name' => 'staging-1.0/zzz', 'name_without_type' => 'zzz')
end
it 'handles search option properly' do
get(:folder, params: {
namespace_id: project.namespace,
project_id: project,
id: 'staging-1.0',
search: 'staging-1.0/z'
}, format: :json)
expect(environments.map { |env| env['name'] }).to eq(['staging-1.0/zzz'])
expect(json_response['available_count']).to eq 1
expect(json_response['stopped_count']).to eq 0
end
end
end
describe 'GET k8s' do
context 'with valid id' do
it 'responds with a status code 200' do
get :k8s, params: environment_params
expect(response).to be_ok
end
end
context 'with invalid id' do
it 'responds with a status code 404' do
params = environment_params
params[:id] = non_existing_record_id
get :k8s, params: params
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'GET show' do
context 'with valid id' do
it 'responds with a status code 200' do
get :show, params: environment_params
expect(response).to be_ok
end
it_behaves_like 'tracking unique visits', :show do
let(:request_params) { environment_params }
let(:target_id) { 'users_visiting_environments_pages' }
end
it 'sets the kas cookie if the request format is html' do
allow(::Gitlab::Kas::UserAccess).to receive(:enabled?).and_return(true)
get :show, params: environment_params
expect(
request.env['action_dispatch.cookies'][Gitlab::Kas::COOKIE_KEY]
).to be_present
end
it 'does not set the kas_cookie if the request format is not html' do
allow(::Gitlab::Kas::UserAccess).to receive(:enabled?).and_return(true)
get :show, params: environment_params(format: :json)
expect(
request.env['action_dispatch.cookies'][Gitlab::Kas::COOKIE_KEY]
).to be_nil
end
end
context 'with invalid id' do
it 'responds with a status code 404' do
params = environment_params
params[:id] = non_existing_record_id
get :show, params: params
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'GET new' do
it 'responds with a status code 200' do
get :new, params: environment_params
expect(response).to be_ok
end
it_behaves_like 'tracking unique visits', :new do
let(:request_params) { environment_params }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
describe 'GET edit' do
it 'responds with a status code 200' do
get :edit, params: environment_params
expect(response).to be_ok
end
it_behaves_like 'tracking unique visits', :edit do
let(:request_params) { environment_params }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
describe 'PATCH #update' do
subject { patch :update, params: params }
context "when environment params are valid" do
let(:params) { environment_params.merge(environment: { external_url: 'https://git.gitlab.com' }) }
it 'returns ok and the path to the newly created environment' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['path']).to eq("/#{project.full_path}/-/environments/#{environment.id}")
end
it_behaves_like 'tracking unique visits', :update do
let(:request_params) { params }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
context "when environment params are invalid" do
let(:params) { environment_params.merge(environment: { external_url: 'javascript:alert("hello")' }) }
it 'returns bad request' do
subject
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context 'when name is passed' do
let(:params) { environment_params.merge(environment: { name: "new name" }) }
it 'ignores name' do
expect do
subject
end.not_to change { environment.reload.name }
end
end
end
describe 'PATCH #stop' do
subject { patch :stop, params: environment_params(format: :json) }
context 'when env not available' do
it 'returns 404' do
allow_any_instance_of(Environment).to receive(:available?) { false }
subject
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when stop action' do
it 'returns job url for a stop action when job is build' do
action = create(:ci_build, :manual)
allow_next_instance_of(Environments::StopService) do |service|
response = ServiceResponse.success(payload: { environment: environment, actions: [action] })
allow(service).to receive(:execute).with(environment).and_return(response)
end
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
{ 'redirect_url' =>
project_job_url(project, action) })
end
it 'returns pipeline url for a stop action when job is bridge' do
action = create(:ci_bridge, :manual)
allow_next_instance_of(Environments::StopService) do |service|
response = ServiceResponse.success(payload: { environment: environment, actions: [action] })
allow(service).to receive(:execute).with(environment).and_return(response)
end
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
{ 'redirect_url' =>
project_job_url(project, action) })
end
it 'returns environment url for multiple stop actions' do
actions = create_list(:ci_build, 2, :manual)
allow_next_instance_of(Environments::StopService) do |service|
response = ServiceResponse.success(payload: { environment: environment, actions: actions })
allow(service).to receive(:execute).with(environment).and_return(response)
end
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
{ 'redirect_url' =>
project_environment_url(project, environment) })
end
it 'returns 403 if there was an error stopping the environment' do
allow_next_instance_of(Environments::StopService) do |service|
response = ServiceResponse.error(message: 'error message')
allow(service).to receive(:execute).with(environment).and_return(response)
end
subject
expect(response).to have_gitlab_http_status(:forbidden)
end
it_behaves_like 'tracking unique visits', :stop do
let(:request_params) { environment_params(format: :json) }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
context 'when no stop action' do
it 'returns env url' do
allow_next_instance_of(Environments::StopService) do |service|
response = ServiceResponse.success(payload: { environment: environment, actions: [] })
allow(service).to receive(:execute).with(environment).and_return(response)
end
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
{ 'redirect_url' =>
project_environment_url(project, environment) })
end
end
end
describe 'POST #cancel_auto_stop' do
subject { post :cancel_auto_stop, params: params }
let(:params) { environment_params }
context 'when environment is set as auto-stop' do
let(:environment) { create(:environment, :will_auto_stop, name: 'staging', project: project) }
it_behaves_like 'successful response for #cancel_auto_stop'
it_behaves_like 'tracking unique visits', :cancel_auto_stop do
let(:request_params) { environment_params }
let(:target_id) { 'users_visiting_environments_pages' }
end
context 'when user is reporter' do
let(:user) { reporter }
it 'shows NOT Found' do
subject
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'when environment is not set as auto-stop' do
let(:environment) { create(:environment, name: 'staging', project: project) }
it_behaves_like 'failed response for #cancel_auto_stop' do
let(:message) { 'the environment is not set as auto stop' }
end
end
end
describe 'GET #terminal' do
context 'with valid id' do
it 'responds with a status code 200' do
get :terminal, params: environment_params
expect(response).to have_gitlab_http_status(:ok)
end
it 'loads the terminals for the environment' do
# In EE we have to stub EE::Environment since it overwrites the
# "terminals" method.
expect_any_instance_of(Gitlab.ee? ? EE::Environment : Environment)
.to receive(:terminals)
get :terminal, params: environment_params
end
it_behaves_like 'tracking unique visits', :terminal do
let(:request_params) { environment_params }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
context 'with invalid id' do
it 'responds with a status code 404' do
get :terminal, params: environment_params(id: 666)
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
describe 'GET #terminal_websocket_authorize' do
context 'with valid workhorse signature' do
before do
allow(Gitlab::Workhorse).to receive(:verify_api_request!).and_return(nil)
end
context 'and valid id' do
it 'returns the first terminal for the environment' do
# In EE we have to stub EE::Environment since it overwrites the
# "terminals" method.
expect_any_instance_of(Gitlab.ee? ? EE::Environment : Environment)
.to receive(:terminals)
.and_return([:fake_terminal])
expect(Gitlab::Workhorse)
.to receive(:channel_websocket)
.with(:fake_terminal)
.and_return(workhorse: :response)
get :terminal_websocket_authorize, params: environment_params
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers["Content-Type"]).to eq(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
expect(response.body).to eq('{"workhorse":"response"}')
end
end
context 'and invalid id' do
it 'returns 404' do
get :terminal_websocket_authorize, params: environment_params(id: 666)
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'with invalid workhorse signature' do
it 'aborts with an exception' do
allow(Gitlab::Workhorse).to receive(:verify_api_request!).and_raise(JWT::DecodeError)
expect { get :terminal_websocket_authorize, params: environment_params }.to raise_error(JWT::DecodeError)
# controller tests don't set the response status correctly. It's enough
# to check that the action raised an exception
end
end
end
describe 'GET #search' do
before do
create(:environment, name: 'staging', project: project)
create(:environment, name: 'review/patch-1', project: project)
create(:environment, name: 'review/patch-2', project: project)
end
let(:query) { 'pro' }
it 'responds with status code 200' do
get :search, params: environment_params(format: :json, query: query)
expect(response).to have_gitlab_http_status(:ok)
end
it 'returns matched results' do
get :search, params: environment_params(format: :json, query: query)
expect(json_response).to contain_exactly('production')
end
context 'when query is review' do
let(:query) { 'review' }
it 'returns matched results' do
get :search, params: environment_params(format: :json, query: query)
expect(json_response).to contain_exactly('review/patch-1', 'review/patch-2')
end
end
context 'when query is empty' do
let(:query) { '' }
it 'returns matched results' do
get :search, params: environment_params(format: :json, query: query)
expect(json_response)
.to contain_exactly('production', 'staging', 'review/patch-1', 'review/patch-2')
end
end
context 'when query is review/patch-3' do
let(:query) { 'review/patch-3' }
it 'responds with status code 204' do
get :search, params: environment_params(format: :json, query: query)
expect(response).to have_gitlab_http_status(:no_content)
end
end
context 'when query is partially matched in the middle of environment name' do
let(:query) { 'patch' }
it 'responds with status code 204' do
get :search, params: environment_params(format: :json, query: query)
expect(response).to have_gitlab_http_status(:no_content)
end
end
context 'when query contains a wildcard character' do
let(:query) { 'review%' }
it 'prevents wildcard injection' do
get :search, params: environment_params(format: :json, query: query)
expect(response).to have_gitlab_http_status(:no_content)
end
end
context 'when query matches case insensitively' do
let(:query) { 'Prod' }
it 'returns matched results' do
get :search, params: environment_params(format: :json, query: query)
expect(json_response).to contain_exactly('production')
end
end
end
describe 'POST #create' do
subject { post :create, params: params }
context "when environment params are valid" do
let(:params) { { namespace_id: project.namespace, project_id: project, environment: { name: 'foo', external_url: 'https://foo.example.com' } } }
it 'returns ok and the path to the newly created environment' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['path']).to eq("/#{project.full_path}/-/environments/#{json_response['environment']['id']}")
end
it_behaves_like 'tracking unique visits', :create do
let(:request_params) { params }
let(:target_id) { 'users_visiting_environments_pages' }
end
end
context "when environment params are invalid" do
let(:params) { { namespace_id: project.namespace, project_id: project, environment: { name: 'foo/', external_url: '/foo.example.com' } } }
it 'returns bad request' do
subject
expect(response).to have_gitlab_http_status(:bad_request)
end
end
end
def environment_params(opts = {})
opts.reverse_merge(namespace_id: project.namespace, project_id: project, id: environment.id)
end
end
|