1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe SentNotificationsController, feature_category: :shared do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :public) }
let_it_be(:private_project) { create(:project, :private) }
let(:email) { 'email@example.com' }
let(:issue) do
create(:issue, project: target_project, external_author: email) do |issue|
issue.subscriptions.create!(user: user, project: target_project, subscribed: true)
issue.issue_email_participants.create!(email: email)
end
end
let(:confidential_issue) do
create(:issue, project: target_project, confidential: true) do |issue|
issue.subscriptions.create!(user: user, project: target_project, subscribed: true)
end
end
let(:merge_request) do
create(:merge_request, source_project: target_project, target_project: target_project) do |mr|
mr.subscriptions.create!(user: user, project: target_project, subscribed: true)
end
end
let(:noteable) { issue }
let(:target_project) { project }
let(:sent_notification) do
create(:sent_notification, project: target_project, noteable: noteable, recipient: user)
end
let(:id) { sent_notification.reply_key }
let(:perform_request) { unsubscribe }
def force_unsubscribe
get(:unsubscribe, params: { id: id, force: true })
end
def unsubscribe
get(:unsubscribe, params: { id: id })
end
def post_unsubscribe
post(:unsubscribe, params: { id: id })
end
shared_examples 'returns 404' do
it 'does not set the flash message' do
expect(controller).not_to set_flash[:notice]
end
it 'returns a 404' do
expect(response).to have_gitlab_http_status(:not_found)
end
end
shared_examples 'validates parameters and records' do
context 'when the ID passed does not exist' do
let(:id) { sent_notification.reply_key.reverse }
before do
perform_request
end
it_behaves_like 'returns 404'
end
context 'when the noteable associated to the notification has been deleted' do
before do
sent_notification.noteable.destroy!
perform_request
end
it_behaves_like 'returns 404'
end
end
shared_examples 'unsubscribes a user' do
before do
perform_request
end
it 'unsubscribes the user' do
expect(issue.subscribed?(user, project)).to be_falsey
end
it 'does not delete the issue email participant for non-service-desk issue' do
expect { force_unsubscribe }.not_to change { issue.issue_email_participants.count }
end
it 'sets the flash message' do
expect(controller).to set_flash[:notice].to(/unsubscribed/)
end
end
shared_examples 'unsubscribes an external participant' do
context 'when support bot is the notification recipient' do
let(:sent_notification) do
create(:sent_notification,
project: target_project, noteable: noteable, recipient: Users::Internal.support_bot)
end
it 'deletes the external author on the issue' do
expect { perform_request }.to change { issue.issue_email_participants.count }.by(-1)
end
context 'when sent_notification contains issue_email_participant' do
let!(:other_issue_email_participant) do
create(:issue_email_participant, issue: issue, email: 'other@example.com')
end
let(:sent_notification) do
create(:sent_notification,
project: target_project,
noteable: noteable,
recipient: Users::Internal.support_bot,
issue_email_participant: other_issue_email_participant
)
end
it 'deletes the connected issue email participant' do
expect { perform_request }.to change { issue.issue_email_participants.count }.by(-1)
# Ensure external author is still present
expect(issue.email_participants_emails).to contain_exactly(email)
end
end
context 'when noteable is not an issue' do
let(:noteable) { merge_request }
it 'does not delete the external author on the issue' do
expect { perform_request }.not_to change { issue.issue_email_participants.count }
end
end
end
end
describe 'GET unsubscribe' do
context 'when the user is not logged in' do
context 'when the force param is passed' do
let(:perform_request) { force_unsubscribe }
it_behaves_like 'unsubscribes a user'
it_behaves_like 'unsubscribes an external participant'
it 'redirects to the login page' do
force_unsubscribe
expect(response).to redirect_to(new_user_session_path)
end
end
context 'when the force param is not passed' do
render_views
before do
unsubscribe
end
shared_examples 'unsubscribing as anonymous' do |project_visibility|
it 'does not unsubscribe the user' do
expect(noteable.subscribed?(user, target_project)).to be_truthy
end
it 'does not set the flash message' do
expect(controller).not_to set_flash[:notice]
end
it 'renders unsubscribe page' do
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template :unsubscribe
end
if project_visibility == :private
it 'does not show project name or path' do
expect(response.body).not_to include(noteable.project.name)
expect(response.body).not_to include(noteable.project.full_name)
end
else
it 'shows project name or path' do
expect(response.body).to include(noteable.project.name)
expect(response.body).to include(noteable.project.full_name)
end
end
end
context 'when project is public' do
context 'when unsubscribing from issue' do
let(:noteable) { issue }
it 'shows issue title' do
expect(response.body).to include(issue.title)
end
it 'does not delete the issue email participant' do
expect { unsubscribe }.not_to change { issue.issue_email_participants.count }
end
it_behaves_like 'unsubscribing as anonymous', :public
end
context 'when unsubscribing from confidential issue' do
let(:noteable) { confidential_issue }
it 'does not show issue title' do
expect(response.body).not_to include(confidential_issue.title)
expect(response.body).to include(confidential_issue.to_reference)
end
it_behaves_like 'unsubscribing as anonymous', :public
end
context 'when unsubscribing from merge request' do
let(:noteable) { merge_request }
it 'shows merge request title' do
expect(response.body).to include(merge_request.title)
end
it 'shows project name or path' do
expect(response.body).to include(issue.project.name)
expect(response.body).to include(issue.project.full_name)
end
it_behaves_like 'unsubscribing as anonymous', :public
end
end
context 'when project is not public' do
let(:target_project) { private_project }
context 'when unsubscribing from issue' do
let(:noteable) { issue }
it 'does not show issue title' do
expect(response.body).not_to include(issue.title)
end
it_behaves_like 'unsubscribing as anonymous', :private
end
context 'when unsubscribing from confidential issue' do
let(:noteable) { confidential_issue }
it 'does not show issue title' do
expect(response.body).not_to include(confidential_issue.title)
expect(response.body).to include(confidential_issue.to_reference)
end
it_behaves_like 'unsubscribing as anonymous', :private
end
context 'when unsubscribing from merge request' do
let(:noteable) { merge_request }
it 'dos not show merge request title' do
expect(response.body).not_to include(merge_request.title)
end
it_behaves_like 'unsubscribing as anonymous', :private
end
end
end
it_behaves_like 'validates parameters and records'
end
context 'when the user is logged in' do
before do
sign_in(user)
end
it_behaves_like 'validates parameters and records'
it_behaves_like 'unsubscribes an external participant'
context 'when the force param is passed' do
let(:perform_request) { force_unsubscribe }
it_behaves_like 'unsubscribes a user'
it 'redirects to the issue page' do
force_unsubscribe
expect(response).to redirect_to(project_issue_path(project, issue))
end
end
context 'when the force param is not passed' do
let(:merge_request) do
create(:merge_request, source_project: project, author: user) do |merge_request|
merge_request.subscriptions.create!(user: user, project: project, subscribed: true)
end
end
let(:sent_notification) do
create(:sent_notification, project: project, noteable: merge_request, recipient: user)
end
before do
unsubscribe
end
it 'unsubscribes the user' do
expect(merge_request.subscribed?(user, project)).to be_falsey
end
it 'sets the flash message' do
expect(controller).to set_flash[:notice].to(/unsubscribed/)
end
it 'redirects to the merge request page' do
expect(response).to redirect_to(project_merge_request_path(project, merge_request))
end
context 'when unsubscribing from design' do
let(:design) do
create(:design, issue: issue) do |design|
design.subscriptions.create!(user: user, project: project, subscribed: true)
end
end
let(:sent_notification) do
create(:sent_notification, project: project, noteable: design, recipient: user)
end
before do
unsubscribe
end
it 'unsubscribes the user' do
expect(design.subscribed?(user, project)).to be_falsey
end
end
end
context 'when project is private' do
context 'and user does not have access' do
let(:noteable) { issue }
let(:target_project) { private_project }
before do
unsubscribe
end
it 'unsubscribes user and redirects to root path' do
expect(response).to redirect_to(root_path)
end
end
context 'and user has access' do
let(:noteable) { issue }
let(:target_project) { private_project }
before_all do
private_project.add_developer(user)
end
before do
unsubscribe
end
it 'unsubscribes user and redirects to issue path' do
expect(response).to redirect_to(project_issue_path(private_project, issue))
end
it 'does not delete the issue email participant for non-service-desk issue' do
expect { unsubscribe }.not_to change { issue.issue_email_participants.count }
end
end
end
end
end
describe 'POST unsubscribe' do
let(:perform_request) { post_unsubscribe }
# Ensure we don't verify CSRF token
around do |example|
ForgeryProtection.with_forgery_protection { example.run }
end
it_behaves_like 'validates parameters and records'
context 'when the user is not logged in' do
it_behaves_like 'unsubscribes a user'
it_behaves_like 'unsubscribes an external participant'
it 'redirects to the login page' do
post_unsubscribe
expect(response).to redirect_to(new_user_session_path)
end
end
context 'when the user is logged in' do
before do
sign_in(user)
end
it_behaves_like 'unsubscribes a user'
it 'redirects to the issue page' do
post_unsubscribe
expect(response).to redirect_to(project_issue_path(project, issue))
end
end
end
end
|