1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Edit group settings', feature_category: :groups_and_projects do
include Spec::Support::Helpers::ModalHelpers
let(:user) { create(:user) }
let(:group) { create(:group, path: 'foo') }
before do
group.add_owner(user)
sign_in(user)
end
describe 'when the group path is changed' do
let(:new_group_path) { 'bar' }
let(:old_group_full_path) { "/#{group.path}" }
let(:new_group_full_path) { "/#{new_group_path}" }
it 'the group is accessible via the new path' do
update_path(new_group_path)
visit new_group_full_path
expect(page).to have_current_path(new_group_full_path, ignore_query: true)
expect(find('h1.home-panel-title')).to have_content(group.name)
end
it 'the old group path redirects to the new path' do
update_path(new_group_path)
visit old_group_full_path
expect(page).to have_current_path(new_group_full_path, ignore_query: true)
expect(find('h1.home-panel-title')).to have_content(group.name)
end
context 'with a subgroup' do
let!(:subgroup) { create(:group, parent: group, path: 'subgroup') }
let(:old_subgroup_full_path) { "/#{group.path}/#{subgroup.path}" }
let(:new_subgroup_full_path) { "/#{new_group_path}/#{subgroup.path}" }
it 'the subgroup is accessible via the new path' do
update_path(new_group_path)
visit new_subgroup_full_path
expect(page).to have_current_path(new_subgroup_full_path, ignore_query: true)
expect(find('h1.home-panel-title')).to have_content(subgroup.name)
end
it 'the old subgroup path redirects to the new path' do
update_path(new_group_path)
visit old_subgroup_full_path
expect(page).to have_current_path(new_subgroup_full_path, ignore_query: true)
expect(find('h1.home-panel-title')).to have_content(subgroup.name)
end
end
context 'with a project', :js do
let!(:project) { create(:project, group: group) }
let(:old_project_full_path) { "/#{group.path}/#{project.path}" }
let(:new_project_full_path) { "/#{new_group_path}/#{project.path}" }
before(:context) do
TestEnv.clean_test_path
end
after do
TestEnv.clean_test_path
end
it 'the project is accessible via the new path' do
update_path(new_group_path)
visit new_project_full_path
expect(page).to have_current_path(new_project_full_path, ignore_query: true)
expect(find_by_testid('breadcrumb-links')).to have_content(project.name)
end
it 'the old project path redirects to the new path' do
update_path(new_group_path)
visit old_project_full_path
expect(page).to have_current_path(new_project_full_path, ignore_query: true)
expect(find_by_testid('breadcrumb-links')).to have_content(project.name)
end
end
end
describe 'project creation level menu' do
it 'shows the selection menu' do
visit edit_group_path(group)
expect(page).to have_content('Roles allowed to create projects')
end
end
describe 'subgroup creation level menu' do
it 'shows the selection menu' do
visit edit_group_path(group)
expect(page).to have_content('Roles allowed to create subgroups')
end
end
describe 'edit group avatar' do
before do
visit edit_group_path(group)
attach_file(:group_avatar, Rails.root.join('spec', 'fixtures', 'banana_sample.gif'))
expect { save_general_group }.to change { group.reload.avatar? }.to(true)
end
it 'uploads new group avatar' do
expect(group.avatar).to be_instance_of AvatarUploader
expect(group.avatar.url).to eq "/uploads/-/system/group/avatar/#{group.id}/banana_sample.gif"
expect(page).to have_link('Remove avatar')
end
it 'removes group avatar' do
expect { click_link 'Remove avatar' }.to change { group.reload.avatar? }.to(false)
expect(page).not_to have_link('Remove avatar')
end
end
describe 'edit group path' do
it 'has a root URL label for top-level group' do
visit edit_group_path(group)
expect(find(:css, '.group-root-path').text).to eq(root_url)
end
it 'has a parent group URL label for a subgroup group' do
subgroup = create(:group, parent: group)
visit edit_group_path(subgroup)
expect(find(:css, '.group-root-path').text).to eq(group_url(subgroup.parent) + '/')
end
end
describe 'transfer group', :js do
let(:namespace_select) { find_by_testid('transfer-group-namespace-select') }
let(:confirm_modal) { find_by_testid('confirm-danger-modal') }
shared_examples 'can transfer the group' do
before do
selected_group.add_owner(user)
end
it 'can successfully transfer the group' do
selected_group_path = selected_group.path
visit edit_group_path(selected_group)
within_testid('transfer-locations-dropdown') do
click_button _('Select parent group')
fill_in _('Search'), with: target_group&.name || ''
wait_for_requests
click_button(target_group&.name || 'No parent group')
end
click_button s_('GroupSettings|Transfer group')
page.within(confirm_modal) do
expect(page).to have_text "You are about to transfer #{selected_group.full_path} to another namespace. This action changes the group's path and can lead to data loss."
fill_in 'confirm_name_input', with: selected_group.full_path
click_button 'Transfer group'
end
within_testid('breadcrumb-links') do
expect(page).to have_content(target_group.name) if target_group
expect(page).to have_content(selected_group.name)
end
if target_group
expect(current_url).to include("#{target_group.path}/#{selected_group_path}")
else
expect(current_url).to include(selected_group_path)
end
end
end
context 'when transfering from a subgroup' do
let(:selected_group) { create(:group, path: 'foo-subgroup', parent: group) }
context 'when transfering to no parent group' do
let(:target_group) { nil }
it_behaves_like 'can transfer the group'
end
context 'when transfering to a parent group' do
let(:target_group) { create(:group, path: 'foo-parentgroup') }
before do
target_group.add_owner(user)
end
it_behaves_like 'can transfer the group'
end
end
context 'when transfering from a root group to a parent group' do
let(:selected_group) { create(:group, path: 'foo-rootgroup') }
let(:target_group) { group }
it_behaves_like 'can transfer the group'
end
end
context 'enable email notifications' do
it 'is visible' do
visit edit_group_path(group)
expect(page).to have_selector('#group_emails_enabled', visible: true)
end
it 'accepts the changed state' do
visit edit_group_path(group)
uncheck 'group_emails_enabled'
expect { save_permissions_group }.to change { updated_emails_enabled? }.to(false)
end
end
describe 'prevent sharing outside group hierarchy setting' do
it 'updates the setting' do
visit edit_group_path(group)
check 'group_prevent_sharing_groups_outside_hierarchy'
expect { save_permissions_group }.to change {
group.reload.prevent_sharing_groups_outside_hierarchy
}.to(true)
end
it 'is not present for a subgroup' do
subgroup = create(:group, parent: group)
visit edit_group_path(subgroup)
expect(page).to have_text "Permissions"
expect(page).not_to have_selector('#group_prevent_sharing_groups_outside_hierarchy')
end
end
describe 'group README', :js do
let_it_be(:group) { create(:group) }
context 'with gitlab-profile project and README.md' do
let_it_be(:project) { create(:project, :readme, namespace: group) }
it 'renders link to Group README and navigates to it on click' do
visit edit_group_path(group)
wait_for_requests
click_link('README')
wait_for_requests
expect(page).to have_current_path(project_blob_path(project, "#{project.default_branch}/README.md"))
expect(page).to have_text('README.md')
end
end
context 'with gitlab-profile project and no README.md' do
let_it_be(:project) { create(:project, path: 'gitlab-profile', namespace: group) }
it 'renders Add README button and allows user to create a README via the IDE' do
visit edit_group_path(group)
wait_for_requests
expect(page).not_to have_selector('.ide')
click_button('Add README')
accept_gl_confirm("This will create a README.md for project #{group.readme_project.present.path_with_namespace}.", button_text: 'Add README')
wait_for_requests
expect(page).to have_current_path("/-/ide/project/#{group.readme_project.present.path_with_namespace}/edit/main/-/README.md/")
page.within('.ide') do
expect(page).to have_text('README.md')
end
end
end
context 'with no gitlab-profile project and no README.md' do
it 'renders Add README button and allows user to create both the gitlab-profile project and README via the IDE' do
visit edit_group_path(group)
wait_for_requests
expect(page).not_to have_selector('.ide')
click_button('Add README')
accept_gl_confirm("This will create a project #{group.full_path}/gitlab-profile and add a README.md.", button_text: 'Create and add README')
wait_for_requests
expect(page).to have_current_path("/-/ide/project/#{group.full_path}/gitlab-profile/edit/main/-/README.md/")
page.within('.ide') do
expect(page).to have_text('README.md')
end
end
end
end
context 'Dormant members', :saas, :aggregate_failures, feature_category: :user_management do
before do
visit edit_group_path(group)
end
context "when feature flag is disabled" do
before do
stub_feature_flags(group_remove_dormant_members: false)
visit edit_group_path(group)
end
it 'does not expose the setting section' do
expect(page).not_to have_content('Dormant members')
expect(page).not_to have_field('Remove dormant members after a period of inactivity')
expect(page).not_to have_field('Days of inactivity before removal', disabled: true)
end
end
it 'exposes the setting section' do
expect(page).to have_content('Dormant members')
expect(page).to have_field('Remove dormant members after a period of inactivity')
expect(page).to have_field('Days of inactivity before removal', disabled: true)
end
it 'changes dormant members', :js do
expect(page).to have_unchecked_field(_('Remove dormant members after a period of inactivity'))
expect(group.namespace_settings.remove_dormant_members).to be_falsey
within_testid('permissions-settings') do
check _('Remove dormant members after a period of inactivity')
fill_in _('Days of inactivity before removal'), with: '90'
click_button _('Save changes')
end
expect(page).to have_content(
format(
_("Group '%{group_name}' was successfully updated."),
group_name: group.name
)
)
page.refresh
expect(page).to have_checked_field(_('Remove dormant members after a period of inactivity'))
expect(page).to have_field(_('Days of inactivity before removal'), disabled: false, with: '90')
end
it 'displays dormant members period field validation error', :js do
selector = '#group_remove_dormant_members_period_error'
expect(page).not_to have_selector(selector, visible: :visible)
within_testid('permissions-settings') do
check _('Remove dormant members after a period of inactivity')
fill_in _('Days of inactivity before removal'), with: '30'
click_button 'Save changes'
end
expect(page).to have_selector(selector, visible: :visible)
expect(page).to have_content _('Please enter a value of 90 days or more')
end
it 'auto disables dormant members period field depending on parent checkbox', :js do
uncheck _('Remove dormant members after a period of inactivity')
expect(page).to have_field(_('Days of inactivity before removal'), disabled: true)
check _('Remove dormant members after a period of inactivity')
expect(page).to have_field(_('Days of inactivity before removal'), disabled: false)
end
end
def update_path(new_group_path)
visit edit_group_path(group)
within_testid('advanced-settings-content') do
fill_in 'group_path', with: new_group_path
click_button 'Change group URL'
end
end
def save_general_group
within_testid('general-settings') do
click_button 'Save changes'
end
end
def save_permissions_group
within_testid('permissions-settings') do
click_button 'Save changes'
end
end
def updated_emails_enabled?
group.reload.clear_memoization(:emails_enabled_memoized)
group.emails_enabled?
end
end
|