1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'General settings visibility levels', :js, :aggregate_failures, feature_category: :groups_and_projects do
let_it_be(:group) { create(:group, :public) }
let_it_be(:user) { create(:user).tap { |user| group.add_owner(user) } }
before do
sign_in(user)
end
context 'with parent group internal' do
let_it_be(:parent_group) { create(:group, :internal) }
let_it_be(:group) { create(:group, :internal, parent: parent_group) }
let_it_be(:user) { create(:user).tap { |user| group.add_owner(user) } }
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_content('Visibility level')
expect(page).to have_field("Private", checked: false, disabled: false)
expect(page).to have_field("Internal", checked: true, disabled: false)
expect(page).to have_field("Public", checked: false, disabled: true)
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Private')
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Internal')
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Public',
popover_content: 'This visibility level is not allowed ' \
'because the parent group has a more restrictive visibility level.'
)
end
end
context 'with internal child project in group' do
let_it_be(:project) { create(:project, :internal, group: group) }
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_field("Private", checked: false, disabled: true)
expect(page).to have_field("Internal", checked: false, disabled: false)
expect(page).to have_field("Public", checked: true, disabled: false)
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Private',
popover_content: "This visibility level is not allowed " \
"because a child of #{group.name} has a less restrictive visibility level. Learn more."
)
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Internal')
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Public')
end
end
context 'without restricted visibility levels' do
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_content('Visibility level')
expect(page).to have_field("Private", checked: false, disabled: false)
expect(page).to have_field("Internal", checked: false, disabled: false)
expect(page).to have_field("Public", checked: true, disabled: false)
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Private')
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Internal')
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Public')
end
end
context 'with restricted visibility level public' do
before do
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
end
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_field("Private", checked: false, disabled: false)
expect(page).to have_field("Internal", checked: false, disabled: false)
expect(page).to have_field("Public", checked: true, disabled: true)
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Private')
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Internal')
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Public',
popover_content: 'This visibility level has been restricted by your administrator.'
)
end
context 'with private project in group' do
let_it_be(:project) { create(:project, :private, group: group) }
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_field("Private", checked: false, disabled: false)
expect(page).to have_field("Internal", checked: false, disabled: false)
expect(page).to have_field("Public", checked: true, disabled: true)
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Private')
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Internal')
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Public',
popover_content: 'This visibility level has been restricted by your administrator.'
)
end
end
context 'with public project in group' do
let_it_be(:project) { create(:project, :public, group: group) }
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_field("Private", checked: false, disabled: true)
expect(page).to have_field("Internal", checked: false, disabled: true)
expect(page).to have_field("Public", checked: true, disabled: true)
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Private',
popover_content: "This visibility level is not allowed " \
"because a child of #{group.name} has a less restrictive visibility level. Learn more."
)
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Internal',
popover_content: "This visibility level is not allowed " \
"because a child of #{group.name} has a less restrictive visibility level. Learn more."
)
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Public',
popover_content: 'This visibility level has been restricted by your administrator.'
)
end
end
end
context 'with multiple restricted visibility levels "Public" and "Private"' do
let_it_be(:project) { create(:project, :internal, group: group) }
before do
stub_application_setting(
restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::PRIVATE]
)
end
it 'shows each visibility level in correct field state' do
visit edit_group_path(group)
expect(page).to have_field("Private", checked: false, disabled: true)
expect(page).to have_field("Internal", checked: false, disabled: false)
expect(page).to have_field("Public", checked: true, disabled: true)
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Private',
popover_content: 'This visibility level has been restricted by your administrator.'
)
expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text: 'Internal')
expect_popover_for_disallowed_visibility_level(
visibility_level_label_text: 'Public',
popover_content: 'This visibility level has been restricted by your administrator.'
)
end
end
def expect_popover_for_disallowed_visibility_level(visibility_level_label_text:, popover_content:)
# Checking that a popover content is not visible before hovering
expect(page).not_to have_content(popover_content)
within('label', text: visibility_level_label_text) do
find('[data-testid=visibility-level-not-allowed-popover]').hover
end
page.within('.gl-popover') do
expect(page).to have_content('Visibility level not allowed')
expect(page).to have_content(popover_content)
end
# Move cursor to another element to hide the popover
find('label', text: visibility_level_label_text).hover
end
def expect_no_popover_for_disallowed_visibility_level(visibility_level_label_text:)
within('label', text: visibility_level_label_text) do
expect(page).not_to have_selector('[data-testid=visibility-level-not-allowed-popover]')
end
expect(page).not_to have_selector('.gl-popover')
end
end
|
